Re: [PATCH 0/2] Use PCD for Watchdog count

[Daniil Egranov <Daniil.Egranov@arm.com>]

Hi Leif,

I tested it on Juno R2. I see a one EFI SBSA watchdog test failure but I see the same failure without the patches so it's not a patch issue.

It looks good for me.

Thanks,
Daniil

-----Original Message-----
From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
Sent: Wednesday, September 20, 2017 11:22 AM
To: Evan Lloyd
Cc: edk2-devel@lists.01.org; Ard Biesheuvel; Matteo Carlini; nd; Arvind Chauhan; Daniil Egranov; Thomas Panakamattam Abraham
Subject: Re: [PATCH 0/2] Use PCD for Watchdog count

Arvind, Daniil, Thomas - any comments?

I have no objections to this changeset.

/
    Leif

On Mon, Sep 18, 2017 at 03:53:42PM +0100, evan.lloyd@arm.com wrote:
> From: EvanLloyd <evan.lloyd@arm.com>
>
> Paired patches for edk2 and edk2-platforms that add and use a PCD
> indicating the number of SBSA Watchdog timers present.  This makes
> things more configurable, and is consistent with other examples of
> platform characteristics. It may also help with debates over GTDT
> inclusion (or not) of secure timers.
>
> Sami Mujawar (1):
>   ArmPlatformPkg: Add PCD for SBSA Watchdog Count
>
>  ArmPlatformPkg/ArmPlatformPkg.dec               | 4 +++-
>  ArmPlatformPkg/ArmJunoPkg/Include/ArmPlatform.h | 4 ++--
>  2 files changed, 5 insertions(+), 3 deletions(-)
>
> Sami Mujawar (1):
>   Platforms/ARM: SBSA Watchdog PCD and build option
>
>  Platform/ARM/JunoPkg/ArmJuno.dsc                     |  7 ++++++-
>  Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc |  7 ++++++-
>  Platform/ARM/JunoPkg/AcpiTables/AcpiTables.inf       |  4 +++-
>  Platform/ARM/VExpressPkg/AcpiTables/AcpiTables.inf   |  4 +++-
>  Platform/ARM/JunoPkg/AcpiTables/Gtdt.aslc            |  6 +++++-
>  Platform/ARM/VExpressPkg/AcpiTables/Gtdt.aslc        | 14 +++++++++++---
>  6 files changed, 34 insertions(+), 8 deletions(-)
>
> --
> Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")
>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.