From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40074.outbound.protection.outlook.com [40.107.4.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 53A1220958BC8 for ; Fri, 1 Sep 2017 10:29:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ewvTQ4YTvS+gqNxoU1NsV67k74LYCHNhSxK+cldTxaI=; b=Ik5yojTK9gdYPPVl9W4UUvSCLhss16jDj1jQ04X7AXX72Cq5HJTTpRDX8OsU0qURXVNG25iUniEIncf6IvUMmRd97AaYlyjZCFzZwi/KwasO8TwtU3UC6wzsTxO0WOu7wosb6/N0IiFAGDFraKgEcG7hAsyFEbktccYLdPzvJ1k= Received: from DB6PR0802MB2295.eurprd08.prod.outlook.com (10.172.228.11) by DB6PR0802MB2246.eurprd08.prod.outlook.com (10.172.227.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10; Fri, 1 Sep 2017 17:32:27 +0000 Received: from DB6PR0802MB2295.eurprd08.prod.outlook.com ([fe80::2c99:efb4:b8fc:3650]) by DB6PR0802MB2295.eurprd08.prod.outlook.com ([fe80::2c99:efb4:b8fc:3650%14]) with mapi id 15.20.0013.014; Fri, 1 Sep 2017 17:32:25 +0000 From: Jeremy Linton To: Evan Lloyd , "edk2-devel@lists.01.org" CC: "ryan.harkin@linaro.org" , Leif Lindholm , Ard Biesheuvel Thread-Topic: [edk2] [PATCH] Platform/ARM/VExpressPkg:Fix Pcd broken in edk2 Thread-Index: AQHTI0ee58Mol7pxuk6WEeKqSoZuK6KgSbzg Date: Fri, 1 Sep 2017 17:32:24 +0000 Message-ID: References: <20170901172728.10480-1-evan.lloyd@arm.com> In-Reply-To: <20170901172728.10480-1-evan.lloyd@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Jeremy.Linton@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB6PR0802MB2246; 6:n/wUuMvSiCRe03GVHfSMy0oRgXPto/W872GsvknlrCkCCcyc8W19lH2qpvHMhxok8lXlY11l5Aqb/qT19LBIFs82ZJPtd3eyoCLQpJMSgkDKNyBgaCf1WkqMTCCqWnb8VSMKJfe6d3T3XHZmL9gv36fhNqe2VorIAhGeOHqRGhbGeRFczYtmYLor7NfaUsI0n+fy8mqg7wKKarTV+0rfeJOttp5hrxqUHF8rmzxQ0ktKmA9kol9n4eBwgoHQHdL8tAjILqAFJeStAihTlaICZnn0r46Q1G42gwTx0DzLUTRjoLZMtYQM5HPYiMuHnvFo5m7OBBedFhgI9dQNzw2b7Q==; 5:FQchFV5Z/djcg6L3GSanxYPhRPhiEzFeBuaOmFH0OY1BuqZF4ht1eFf6ETHyh7zvctyzKMONXRaMkytZhM2FR9N0YDaa1ncsiXQlxY7ZNwr0mZRapCQmjhC9wCq9SpxvXuxGZEw8Gvn3joLlloEMyg==; 24:MOssqgtock4CJk73zSChh3lkNP1fUZxhic2vZoPG2jIB1DbrKDxd9YT+tviDOuJSYWNa+mjtiExvj6BWLy3tv5jQrqGUnu8ov71C/EZjtDM=; 7:H0vM+YyH/vTeVH5PQtnu6Kyphk7Fn8UPd0jbDouqaU/K6ikZIIo82MeIroLc2xAM6tVfVHeCo3i1Vj/A+kP2sP9PKa96PJjaMWJvrMHP8WcMj2po0bgUtzUaf6EWquR7GcoijatxFo0CgcjjeI5bhjOJqQFvzgMre0Xeu/8wLoKSASYoEXcUgRWJJ54R9EnWlIj65gbnez9YX61PfrGLxWA1lPAGLH8oMvCEHUXC5yQ= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-office365-filtering-correlation-id: f782c3fa-dabd-4272-e25a-08d4f15f6939 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DB6PR0802MB2246; x-ms-traffictypediagnostic: DB6PR0802MB2246: x-exchange-antispam-report-test: UriScan:(180628864354917)(166708455590820)(162533806227266); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123555025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DB6PR0802MB2246; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DB6PR0802MB2246; x-forefront-prvs: 0417A3FFD2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(377454003)(199003)(189002)(13464003)(40434004)(101416001)(76176999)(54356999)(50986999)(33656002)(68736007)(189998001)(54906002)(2900100001)(8676002)(99286003)(55016002)(105586002)(2950100002)(74316002)(3660700001)(9686003)(81156014)(6246003)(6306002)(102836003)(3846002)(2906002)(53936002)(3280700002)(6116002)(106356001)(25786009)(5660300001)(7696004)(97736004)(4326008)(478600001)(72206003)(7736002)(66066001)(14454004)(305945005)(86362001)(81166006)(8936002)(2501003)(5890100001)(5250100002)(6506006)(6436002)(229853002)(19627235001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0802MB2246; H:DB6PR0802MB2295.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2017 17:32:25.4889 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2246 Subject: Re: [PATCH] Platform/ARM/VExpressPkg:Fix Pcd broken in edk2 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Sep 2017 17:29:44 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, It seems the FVP is build is broken too (and this appears to be part of the= solution). |-----Original Message----- |From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of |evan.lloyd@arm.com |Sent: Friday, September 01, 2017 12:27 PM |To: edk2-devel@lists.01.org |Cc: ryan.harkin@linaro.org; Leif Lindholm; Ard Biesheuvel |Subject: [edk2] [PATCH] Platform/ARM/VExpressPkg:Fix Pcd broken in edk2 | |From: EvanLloyd | |A recent change in edk2: | EmbeddedPkg/EmbeddedPkg.dsc: fix build for non-ARM architectures |actually broke the build for AARCH64 architectures (well Juno, really). |The PCD moved, PcdIsp1761BaseAddress, is used by |edk2\EmbeddedPkg\Drivers\Isp1761UsbDxe\Isp1761UsbDxe.inf, which was |included by Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | |This patch moves the Isp1761UsbDxe.inf to [Components.ARM] so that it |doesn't invoke the PCD for Juno. | |Contributed-under: TianoCore Contribution Agreement 1.0 |Signed-off-by: Evan Lloyd |--- | |Code may be examined at: |https://github.com/EvanLloyd/edk2- |platforms/blob/148_fix_juno_build_v1/Platform/ARM/VExpressPkg/ArmVEx |press.dsc.inc | | Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 9 ++++++--- | 1 file changed, 6 insertions(+), 3 deletions(-) | |diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc |b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc |index |770007d1c89300f11c130515244686db6f97c96b..f82df48a00b22967f9c9741526fc |0c1b75073fa0 100644 |--- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc |+++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc |@@ -471,9 +471,6 @@ [Components.common] | EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.inf | !endif | |- # ISP1761 USB OTG Controller |- EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.inf |- | # | # Android Fastboot | # |@@ -505,3 +502,9 @@ [Components.common] | PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf | |BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfg |CommandLib.inf | } |+ |+[Components.ARM] |+ |+ # ISP1761 USB OTG Controller |+ EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.inf |+ |-- |Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") | |_______________________________________________ |edk2-devel mailing list |edk2-devel@lists.01.org |https://lists.01.org/mailman/listinfo/edk2-devel IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.