public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Krzysztof Koch <Krzysztof.Koch@arm.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "michael.d.kinney@intel.com" <michael.d.kinney@intel.com>,
	"liming.gao@intel.com" <liming.gao@intel.com>,
	Matteo Carlini <Matteo.Carlini@arm.com>, nd <nd@arm.com>,
	Laura Moretta <Laura.Moretta@arm.com>
Subject: Re: [PATCH v1 1/1] MdePkg: Add PCCT table signature definition
Date: Thu, 30 Jan 2020 11:40:02 +0000	[thread overview]
Message-ID: <DB6PR0802MB23752403F0372418993FA9AD84040@DB6PR0802MB2375.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20200130111406.67564-1-krzysztof.koch@arm.com>

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

-----Original Message-----
From: Krzysztof Koch <krzysztof.koch@arm.com> 
Sent: 30 January 2020 11:14
To: devel@edk2.groups.io
Cc: michael.d.kinney@intel.com; liming.gao@intel.com; Matteo Carlini <Matteo.Carlini@arm.com>; Sami Mujawar <Sami.Mujawar@arm.com>; nd <nd@arm.com>
Subject: [PATCH v1 1/1] MdePkg: Add PCCT table signature definition

Acpi63.h contains definitions describing the Platform Communications Channel Table's (PCCT) structure. However, a macro for the table's signature is missing.

This patch adds the definition of Platform Communications Channel Table's signature.

References:
- ACPI 6.3, January 2019, Section 14.1

Signed-off-by: Krzysztof Koch <krzysztof.koch@arm.com>
---

Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/tree/617_add_pcct_signature_def_v1

Notes:
    v1:
    - Add definition of PCCT table signature [Krzysztof]

 MdePkg/Include/IndustryStandard/Acpi63.h | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/MdePkg/Include/IndustryStandard/Acpi63.h b/MdePkg/Include/IndustryStandard/Acpi63.h
index eca1f9357b70f10887e680ff13c97c0beab3600b..b281b30155e90eba5169dc39bde9a3379e3b7005 100644
--- a/MdePkg/Include/IndustryStandard/Acpi63.h
+++ b/MdePkg/Include/IndustryStandard/Acpi63.h
@@ -2,7 +2,7 @@
   ACPI 6.3 definitions from the ACPI Specification Revision 6.3 Jan, 2019.
 
   Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
-  Copyright (c) 2019, ARM Ltd. All rights reserved.<BR>
+  Copyright (c) 2019 - 2020, ARM Ltd. All rights reserved.<BR>
 
   SPDX-License-Identifier: BSD-2-Clause-Patent  **/ @@ -2880,6 +2880,11 @@ typedef struct {  ///  #define EFI_ACPI_6_3_DATA_MANAGEMENT_TABLE_SIGNATURE  SIGNATURE_32('M', 'S', 'D', 'M')
 
+///
+/// "PCCT" Platform Communications Channel Table /// #define 
+EFI_ACPI_6_3_PLATFORM_COMMUNICATIONS_CHANNEL_TABLE_SIGNATURE  
+SIGNATURE_32('P', 'C', 'C', 'T')
+
 ///
 /// "SDEI" Software Delegated Exceptions Interface Table  ///
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



  reply	other threads:[~2020-01-30 11:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-30 11:14 [PATCH v1 1/1] MdePkg: Add PCCT table signature definition Krzysztof Koch
2020-01-30 11:40 ` Sami Mujawar [this message]
2020-02-12 10:55   ` Krzysztof Koch
2020-02-12 13:58     ` Liming Gao
2020-02-12 14:01       ` Krzysztof Koch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB6PR0802MB23752403F0372418993FA9AD84040@DB6PR0802MB2375.eurprd08.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox