* [PATCH v1 1/1] MdePkg: Add PCCT table signature definition
@ 2020-01-30 11:14 Krzysztof Koch
2020-01-30 11:40 ` Sami Mujawar
0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Koch @ 2020-01-30 11:14 UTC (permalink / raw)
To: devel; +Cc: michael.d.kinney, liming.gao, Matteo.Carlini, Sami.Mujawar, nd
Acpi63.h contains definitions describing the Platform Communications
Channel Table's (PCCT) structure. However, a macro for the table's
signature is missing.
This patch adds the definition of Platform Communications Channel
Table's signature.
References:
- ACPI 6.3, January 2019, Section 14.1
Signed-off-by: Krzysztof Koch <krzysztof.koch@arm.com>
---
Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/tree/617_add_pcct_signature_def_v1
Notes:
v1:
- Add definition of PCCT table signature [Krzysztof]
MdePkg/Include/IndustryStandard/Acpi63.h | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/MdePkg/Include/IndustryStandard/Acpi63.h b/MdePkg/Include/IndustryStandard/Acpi63.h
index eca1f9357b70f10887e680ff13c97c0beab3600b..b281b30155e90eba5169dc39bde9a3379e3b7005 100644
--- a/MdePkg/Include/IndustryStandard/Acpi63.h
+++ b/MdePkg/Include/IndustryStandard/Acpi63.h
@@ -2,7 +2,7 @@
ACPI 6.3 definitions from the ACPI Specification Revision 6.3 Jan, 2019.
Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
- Copyright (c) 2019, ARM Ltd. All rights reserved.<BR>
+ Copyright (c) 2019 - 2020, ARM Ltd. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -2880,6 +2880,11 @@ typedef struct {
///
#define EFI_ACPI_6_3_DATA_MANAGEMENT_TABLE_SIGNATURE SIGNATURE_32('M', 'S', 'D', 'M')
+///
+/// "PCCT" Platform Communications Channel Table
+///
+#define EFI_ACPI_6_3_PLATFORM_COMMUNICATIONS_CHANNEL_TABLE_SIGNATURE SIGNATURE_32('P', 'C', 'C', 'T')
+
///
/// "SDEI" Software Delegated Exceptions Interface Table
///
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] MdePkg: Add PCCT table signature definition
2020-01-30 11:14 [PATCH v1 1/1] MdePkg: Add PCCT table signature definition Krzysztof Koch
@ 2020-01-30 11:40 ` Sami Mujawar
2020-02-12 10:55 ` Krzysztof Koch
0 siblings, 1 reply; 5+ messages in thread
From: Sami Mujawar @ 2020-01-30 11:40 UTC (permalink / raw)
To: Krzysztof Koch, devel@edk2.groups.io
Cc: michael.d.kinney@intel.com, liming.gao@intel.com, Matteo Carlini,
nd, Laura Moretta
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
-----Original Message-----
From: Krzysztof Koch <krzysztof.koch@arm.com>
Sent: 30 January 2020 11:14
To: devel@edk2.groups.io
Cc: michael.d.kinney@intel.com; liming.gao@intel.com; Matteo Carlini <Matteo.Carlini@arm.com>; Sami Mujawar <Sami.Mujawar@arm.com>; nd <nd@arm.com>
Subject: [PATCH v1 1/1] MdePkg: Add PCCT table signature definition
Acpi63.h contains definitions describing the Platform Communications Channel Table's (PCCT) structure. However, a macro for the table's signature is missing.
This patch adds the definition of Platform Communications Channel Table's signature.
References:
- ACPI 6.3, January 2019, Section 14.1
Signed-off-by: Krzysztof Koch <krzysztof.koch@arm.com>
---
Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/tree/617_add_pcct_signature_def_v1
Notes:
v1:
- Add definition of PCCT table signature [Krzysztof]
MdePkg/Include/IndustryStandard/Acpi63.h | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/MdePkg/Include/IndustryStandard/Acpi63.h b/MdePkg/Include/IndustryStandard/Acpi63.h
index eca1f9357b70f10887e680ff13c97c0beab3600b..b281b30155e90eba5169dc39bde9a3379e3b7005 100644
--- a/MdePkg/Include/IndustryStandard/Acpi63.h
+++ b/MdePkg/Include/IndustryStandard/Acpi63.h
@@ -2,7 +2,7 @@
ACPI 6.3 definitions from the ACPI Specification Revision 6.3 Jan, 2019.
Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
- Copyright (c) 2019, ARM Ltd. All rights reserved.<BR>
+ Copyright (c) 2019 - 2020, ARM Ltd. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -2880,6 +2880,11 @@ typedef struct { /// #define EFI_ACPI_6_3_DATA_MANAGEMENT_TABLE_SIGNATURE SIGNATURE_32('M', 'S', 'D', 'M')
+///
+/// "PCCT" Platform Communications Channel Table /// #define
+EFI_ACPI_6_3_PLATFORM_COMMUNICATIONS_CHANNEL_TABLE_SIGNATURE
+SIGNATURE_32('P', 'C', 'C', 'T')
+
///
/// "SDEI" Software Delegated Exceptions Interface Table ///
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] MdePkg: Add PCCT table signature definition
2020-01-30 11:40 ` Sami Mujawar
@ 2020-02-12 10:55 ` Krzysztof Koch
2020-02-12 13:58 ` Liming Gao
0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Koch @ 2020-02-12 10:55 UTC (permalink / raw)
To: devel@edk2.groups.io
Cc: michael.d.kinney@intel.com, liming.gao@intel.com, Matteo Carlini,
nd, Laura Moretta, Sami Mujawar
Hi All,
Is there something I can do to help get this patch merged?
Kind regards,
Krzysztof
-----Original Message-----
From: Sami Mujawar <Sami.Mujawar@arm.com>
Sent: Thursday, January 30, 2020 11:40
To: Krzysztof Koch <Krzysztof.Koch@arm.com>; devel@edk2.groups.io
Cc: michael.d.kinney@intel.com; liming.gao@intel.com; Matteo Carlini <Matteo.Carlini@arm.com>; nd <nd@arm.com>; Laura Moretta <Laura.Moretta@arm.com>
Subject: RE: [PATCH v1 1/1] MdePkg: Add PCCT table signature definition
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
-----Original Message-----
From: Krzysztof Koch <krzysztof.koch@arm.com>
Sent: 30 January 2020 11:14
To: devel@edk2.groups.io
Cc: michael.d.kinney@intel.com; liming.gao@intel.com; Matteo Carlini <Matteo.Carlini@arm.com>; Sami Mujawar <Sami.Mujawar@arm.com>; nd <nd@arm.com>
Subject: [PATCH v1 1/1] MdePkg: Add PCCT table signature definition
Acpi63.h contains definitions describing the Platform Communications Channel Table's (PCCT) structure. However, a macro for the table's signature is missing.
This patch adds the definition of Platform Communications Channel Table's signature.
References:
- ACPI 6.3, January 2019, Section 14.1
Signed-off-by: Krzysztof Koch <krzysztof.koch@arm.com>
---
Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/tree/617_add_pcct_signature_def_v1
Notes:
v1:
- Add definition of PCCT table signature [Krzysztof]
MdePkg/Include/IndustryStandard/Acpi63.h | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/MdePkg/Include/IndustryStandard/Acpi63.h b/MdePkg/Include/IndustryStandard/Acpi63.h
index eca1f9357b70f10887e680ff13c97c0beab3600b..b281b30155e90eba5169dc39bde9a3379e3b7005 100644
--- a/MdePkg/Include/IndustryStandard/Acpi63.h
+++ b/MdePkg/Include/IndustryStandard/Acpi63.h
@@ -2,7 +2,7 @@
ACPI 6.3 definitions from the ACPI Specification Revision 6.3 Jan, 2019.
Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
- Copyright (c) 2019, ARM Ltd. All rights reserved.<BR>
+ Copyright (c) 2019 - 2020, ARM Ltd. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -2880,6 +2880,11 @@ typedef struct { /// #define EFI_ACPI_6_3_DATA_MANAGEMENT_TABLE_SIGNATURE SIGNATURE_32('M', 'S', 'D', 'M')
+///
+/// "PCCT" Platform Communications Channel Table /// #define
+EFI_ACPI_6_3_PLATFORM_COMMUNICATIONS_CHANNEL_TABLE_SIGNATURE
+SIGNATURE_32('P', 'C', 'C', 'T')
+
///
/// "SDEI" Software Delegated Exceptions Interface Table ///
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] MdePkg: Add PCCT table signature definition
2020-02-12 10:55 ` Krzysztof Koch
@ 2020-02-12 13:58 ` Liming Gao
2020-02-12 14:01 ` Krzysztof Koch
0 siblings, 1 reply; 5+ messages in thread
From: Liming Gao @ 2020-02-12 13:58 UTC (permalink / raw)
To: Krzysztof Koch, devel@edk2.groups.io
Cc: Kinney, Michael D, Matteo Carlini, nd, Laura Moretta,
Sami Mujawar
Krzysztof：
Sorry to miss this patch. I see PCCT table is added since ACPI 5.0. So, I think its table signature definition should also be added into Acpi50.h, Acpi51.h, Acpi60.h, Acpi61.h and Acpi62.h.
Thanks
Liming
> -----Original Message-----
> From: Krzysztof Koch <Krzysztof.Koch@arm.com>
> Sent: Wednesday, February 12, 2020 6:55 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Matteo Carlini <Matteo.Carlini@arm.com>;
> nd <nd@arm.com>; Laura Moretta <Laura.Moretta@arm.com>; Sami Mujawar <Sami.Mujawar@arm.com>
> Subject: RE: [PATCH v1 1/1] MdePkg: Add PCCT table signature definition
>
> Hi All,
>
> Is there something I can do to help get this patch merged?
>
> Kind regards,
> Krzysztof
>
> -----Original Message-----
> From: Sami Mujawar <Sami.Mujawar@arm.com>
> Sent: Thursday, January 30, 2020 11:40
> To: Krzysztof Koch <Krzysztof.Koch@arm.com>; devel@edk2.groups.io
> Cc: michael.d.kinney@intel.com; liming.gao@intel.com; Matteo Carlini <Matteo.Carlini@arm.com>; nd <nd@arm.com>; Laura Moretta
> <Laura.Moretta@arm.com>
> Subject: RE: [PATCH v1 1/1] MdePkg: Add PCCT table signature definition
>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
>
> Regards,
>
> Sami Mujawar
>
> -----Original Message-----
> From: Krzysztof Koch <krzysztof.koch@arm.com>
> Sent: 30 January 2020 11:14
> To: devel@edk2.groups.io
> Cc: michael.d.kinney@intel.com; liming.gao@intel.com; Matteo Carlini <Matteo.Carlini@arm.com>; Sami Mujawar
> <Sami.Mujawar@arm.com>; nd <nd@arm.com>
> Subject: [PATCH v1 1/1] MdePkg: Add PCCT table signature definition
>
> Acpi63.h contains definitions describing the Platform Communications Channel Table's (PCCT) structure. However, a macro for the
> table's signature is missing.
>
> This patch adds the definition of Platform Communications Channel Table's signature.
>
> References:
> - ACPI 6.3, January 2019, Section 14.1
>
> Signed-off-by: Krzysztof Koch <krzysztof.koch@arm.com>
> ---
>
> Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/tree/617_add_pcct_signature_def_v1
>
> Notes:
> v1:
> - Add definition of PCCT table signature [Krzysztof]
>
> MdePkg/Include/IndustryStandard/Acpi63.h | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/MdePkg/Include/IndustryStandard/Acpi63.h b/MdePkg/Include/IndustryStandard/Acpi63.h
> index eca1f9357b70f10887e680ff13c97c0beab3600b..b281b30155e90eba5169dc39bde9a3379e3b7005 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi63.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi63.h
> @@ -2,7 +2,7 @@
> ACPI 6.3 definitions from the ACPI Specification Revision 6.3 Jan, 2019.
>
> Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> - Copyright (c) 2019, ARM Ltd. All rights reserved.<BR>
> + Copyright (c) 2019 - 2020, ARM Ltd. All rights reserved.<BR>
>
> SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -2880,6 +2880,11 @@ typedef struct { /// #define
> EFI_ACPI_6_3_DATA_MANAGEMENT_TABLE_SIGNATURE SIGNATURE_32('M', 'S', 'D', 'M')
>
> +///
> +/// "PCCT" Platform Communications Channel Table /// #define
> +EFI_ACPI_6_3_PLATFORM_COMMUNICATIONS_CHANNEL_TABLE_SIGNATURE
> +SIGNATURE_32('P', 'C', 'C', 'T')
> +
> ///
> /// "SDEI" Software Delegated Exceptions Interface Table ///
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] MdePkg: Add PCCT table signature definition
2020-02-12 13:58 ` Liming Gao
@ 2020-02-12 14:01 ` Krzysztof Koch
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Koch @ 2020-02-12 14:01 UTC (permalink / raw)
To: Gao, Liming, devel@edk2.groups.io
Cc: Kinney, Michael D, Matteo Carlini, nd, Laura Moretta,
Sami Mujawar
Hi Liming,
No problem, I will resubmit the patch updating the relevant ACPI spec header files.
Thanks,
Krzysztof
-----Original Message-----
From: Gao, Liming <liming.gao@intel.com>
Sent: Wednesday, February 12, 2020 13:59
To: Krzysztof Koch <Krzysztof.Koch@arm.com>; devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Matteo Carlini <Matteo.Carlini@arm.com>; nd <nd@arm.com>; Laura Moretta <Laura.Moretta@arm.com>; Sami Mujawar <Sami.Mujawar@arm.com>
Subject: RE: [PATCH v1 1/1] MdePkg: Add PCCT table signature definition
Krzysztof：
Sorry to miss this patch. I see PCCT table is added since ACPI 5.0. So, I think its table signature definition should also be added into Acpi50.h, Acpi51.h, Acpi60.h, Acpi61.h and Acpi62.h.
Thanks
Liming
> -----Original Message-----
> From: Krzysztof Koch <Krzysztof.Koch@arm.com>
> Sent: Wednesday, February 12, 2020 6:55 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Matteo Carlini <Matteo.Carlini@arm.com>; nd
> <nd@arm.com>; Laura Moretta <Laura.Moretta@arm.com>; Sami Mujawar
> <Sami.Mujawar@arm.com>
> Subject: RE: [PATCH v1 1/1] MdePkg: Add PCCT table signature
> definition
>
> Hi All,
>
> Is there something I can do to help get this patch merged?
>
> Kind regards,
> Krzysztof
>
> -----Original Message-----
> From: Sami Mujawar <Sami.Mujawar@arm.com>
> Sent: Thursday, January 30, 2020 11:40
> To: Krzysztof Koch <Krzysztof.Koch@arm.com>; devel@edk2.groups.io
> Cc: michael.d.kinney@intel.com; liming.gao@intel.com; Matteo Carlini
> <Matteo.Carlini@arm.com>; nd <nd@arm.com>; Laura Moretta
> <Laura.Moretta@arm.com>
> Subject: RE: [PATCH v1 1/1] MdePkg: Add PCCT table signature
> definition
>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
>
> Regards,
>
> Sami Mujawar
>
> -----Original Message-----
> From: Krzysztof Koch <krzysztof.koch@arm.com>
> Sent: 30 January 2020 11:14
> To: devel@edk2.groups.io
> Cc: michael.d.kinney@intel.com; liming.gao@intel.com; Matteo Carlini
> <Matteo.Carlini@arm.com>; Sami Mujawar <Sami.Mujawar@arm.com>; nd
> <nd@arm.com>
> Subject: [PATCH v1 1/1] MdePkg: Add PCCT table signature definition
>
> Acpi63.h contains definitions describing the Platform Communications
> Channel Table's (PCCT) structure. However, a macro for the table's signature is missing.
>
> This patch adds the definition of Platform Communications Channel Table's signature.
>
> References:
> - ACPI 6.3, January 2019, Section 14.1
>
> Signed-off-by: Krzysztof Koch <krzysztof.koch@arm.com>
> ---
>
> Changes can be seen at:
> https://github.com/KrzysztofKoch1/edk2/tree/617_add_pcct_signature_def
> _v1
>
> Notes:
> v1:
> - Add definition of PCCT table signature [Krzysztof]
>
> MdePkg/Include/IndustryStandard/Acpi63.h | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/MdePkg/Include/IndustryStandard/Acpi63.h
> b/MdePkg/Include/IndustryStandard/Acpi63.h
> index
> eca1f9357b70f10887e680ff13c97c0beab3600b..b281b30155e90eba5169dc39bde9
> a3379e3b7005 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi63.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi63.h
> @@ -2,7 +2,7 @@
> ACPI 6.3 definitions from the ACPI Specification Revision 6.3 Jan, 2019.
>
> Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> - Copyright (c) 2019, ARM Ltd. All rights reserved.<BR>
> + Copyright (c) 2019 - 2020, ARM Ltd. All rights reserved.<BR>
>
> SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -2880,6
> +2880,11 @@ typedef struct { /// #define
> EFI_ACPI_6_3_DATA_MANAGEMENT_TABLE_SIGNATURE SIGNATURE_32('M', 'S',
> 'D', 'M')
>
> +///
> +/// "PCCT" Platform Communications Channel Table /// #define
> +EFI_ACPI_6_3_PLATFORM_COMMUNICATIONS_CHANNEL_TABLE_SIGNATURE
> +SIGNATURE_32('P', 'C', 'C', 'T')
> +
> ///
> /// "SDEI" Software Delegated Exceptions Interface Table ///
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-02-12 14:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-30 11:14 [PATCH v1 1/1] MdePkg: Add PCCT table signature definition Krzysztof Koch
2020-01-30 11:40 ` Sami Mujawar
2020-02-12 10:55 ` Krzysztof Koch
2020-02-12 13:58 ` Liming Gao
2020-02-12 14:01 ` Krzysztof Koch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox