From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (EUR02-VE1-obe.outbound.protection.outlook.com [40.107.2.53]) by mx.groups.io with SMTP id smtpd.web09.2513.1574679834326504821 for ; Mon, 25 Nov 2019 03:03:55 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=W+kkb6lR; spf=pass (domain: arm.com, ip: 40.107.2.53, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3/ADoAILvMed8PWCsK8NgVUi+Ru9bK4Js3u8UaIHNuY=; b=W+kkb6lR6RF/8Fsfg7CRJMiPIHKO0+UEfkEHTxNZSMRvxvX4IP180wdHI2VDoufRkLkiSAdoWoAj3TZySSAUOPV6yq851FU+5A4Wl58iVRDyDPP0IXdVv76Mtukj2yxSnNpSHSAIpv67teI9+zmNbTvO8MyQAKAQtyCt3KIJVQY= Received: from DB6PR0802CA0025.eurprd08.prod.outlook.com (2603:10a6:4:a3::11) by AM6PR08MB3478.eurprd08.prod.outlook.com (2603:10a6:20b:4a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.19; Mon, 25 Nov 2019 11:03:51 +0000 Received: from AM5EUR03FT045.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::206) by DB6PR0802CA0025.outlook.office365.com (2603:10a6:4:a3::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.16 via Frontend Transport; Mon, 25 Nov 2019 11:03:51 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT045.mail.protection.outlook.com (10.152.17.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.17 via Frontend Transport; Mon, 25 Nov 2019 11:03:51 +0000 Received: ("Tessian outbound fee635499979:v33"); Mon, 25 Nov 2019 11:03:50 +0000 X-CR-MTA-TID: 64aa7808 Received: from 15fb0b69ea09.2 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.1.55]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id DC5F3B98-7C52-4E38-A59E-4829EE445DE0.1; Mon, 25 Nov 2019 11:03:45 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01lp2055.outbound.protection.outlook.com [104.47.1.55]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 15fb0b69ea09.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 25 Nov 2019 11:03:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hADl/k2HNnEcjJH0p5JBOErew0lrmCPatjN88M8mRPZFoiE9rG4GgdWW8n2tWHA7/kzh6K79Q++EMrL2fAn85qQqGoI9wAwEYHrtlJOgzHtnYRWz+5vIMLmjN38ZAdFQwQn6QQWIEA844f1WFLj94IUv+cjdLjrMpW+zRlo3Gm/AkALw8NHf7KFClue7/03Dqvrs8owMPbj4ux51tD0ZThwdmt9mosnOS0YWxWgQqAP06Q+uL3LdBYxyW6cmMwcsl5Sw5om4/TiWlvvt90ECxC/IinTiUIvjSru5o5YikmSXCphYu1kvevFA1QlgqhcI5c9Yyck6vvYNmldybr/+CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3/ADoAILvMed8PWCsK8NgVUi+Ru9bK4Js3u8UaIHNuY=; b=NS+ZfmiSZdKPxZo6xa9BXsA3uLYWR9Betk5KfjBXuLqojc9UsyhWN9CG4y3EfiL0xGOfcE/BUepqZ0/kV/wceiQl5bhUVl2aiMEaoE3NFuQpUcgchRKhabGIrui6zLvy2On+4ixYc+yIyMZsUoeqakNkWHqoAhrzidFbvawillgeYlWZuIIPktr2daN8FnO6po8nw6+J0OOt0VmwzY8k8Xc7icO5PAKmQqRaHFjix839QBbuvdyV+lc8U4nO3Kz9+82BzJvjOEjXhgkgug0D9eiReiRK+VrBtXvKKEC2lFXFe5LUEAASRuLU/vCjOIROYj/cuKOI+hWEICBPp+8OzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3/ADoAILvMed8PWCsK8NgVUi+Ru9bK4Js3u8UaIHNuY=; b=W+kkb6lR6RF/8Fsfg7CRJMiPIHKO0+UEfkEHTxNZSMRvxvX4IP180wdHI2VDoufRkLkiSAdoWoAj3TZySSAUOPV6yq851FU+5A4Wl58iVRDyDPP0IXdVv76Mtukj2yxSnNpSHSAIpv67teI9+zmNbTvO8MyQAKAQtyCt3KIJVQY= Received: from DB6PR0802MB2375.eurprd08.prod.outlook.com (10.172.228.142) by DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.227.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.22; Mon, 25 Nov 2019 11:03:40 +0000 Received: from DB6PR0802MB2375.eurprd08.prod.outlook.com ([fe80::a4fa:10cb:41f5:222f]) by DB6PR0802MB2375.eurprd08.prod.outlook.com ([fe80::a4fa:10cb:41f5:222f%12]) with mapi id 15.20.2474.023; Mon, 25 Nov 2019 11:03:40 +0000 From: "Sami Mujawar" To: =?iso-8859-1?Q?Philippe_Mathieu-Daud=E9?= , "devel@edk2.groups.io" CC: Achin Gupta , "jiewen.yao@intel.com" , Supreeth Venkatesh , Matteo Carlini , Laura Moretta , nd Subject: Re: [edk2-devel] [PATCH v2 1/1] StandaloneMmPkg: Fix 'missing header' warning Thread-Topic: [edk2-devel] [PATCH v2 1/1] StandaloneMmPkg: Fix 'missing header' warning Thread-Index: AQHVo3Jp6PJ7YhuYRU6DpcVb8HBmraebtLOAgAADiKA= Date: Mon, 25 Nov 2019 11:03:39 +0000 Message-ID: References: <20191125092609.15060-1-sami.mujawar@arm.com> <80c1b0c2-e85e-daa0-4ba1-ed5344e9f688@redhat.com> In-Reply-To: <80c1b0c2-e85e-daa0-4ba1-ed5344e9f688@redhat.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: a26e8e8f-888a-4dcb-a9f0-f492f9155543.1 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Sami.Mujawar@arm.com; x-originating-ip: [217.140.106.52] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 9325df13-a7bf-48dc-0af2-08d771972790 X-MS-TrafficTypeDiagnostic: DB6PR0802MB2133:|DB6PR0802MB2133:|AM6PR08MB3478: X-MS-Exchange-PUrlCount: 2 x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:257;OLM:257; x-forefront-prvs: 0232B30BBC X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(6029001)(4636009)(39860400002)(366004)(136003)(396003)(376002)(346002)(199004)(189003)(13464003)(6506007)(53546011)(76176011)(7696005)(2906002)(102836004)(52536014)(6246003)(6116002)(3846002)(99286004)(446003)(478600001)(2501003)(26005)(14444005)(256004)(5660300002)(25786009)(9686003)(76116006)(8936002)(8676002)(33656002)(6306002)(110136005)(66066001)(71200400001)(71190400001)(11346002)(305945005)(54906003)(229853002)(186003)(66556008)(66476007)(74316002)(66946007)(66446008)(64756008)(86362001)(4326008)(14454004)(6436002)(55016002)(81156014)(81166006)(316002)(7736002)(966005)(46800400005);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2133;H:DB6PR0802MB2375.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: IqaZfBqVG22jzu1ivzWWj/XrqJybGa6cBpPifGofRNViKk1cS1jyhdlidisK258sBJKKmfWnz2JCWNshqPZLVjEpKmcPFE5uAWl1USP7+Usrx7uJiw8OaKzxOq2cTOq9UnZbsxkCNBGtMQChbwQh7A6qD/zh7UOPhTLpU+4Qz7XGFDSf/cj0cTGKlXFzeTdBnpdxEn0L2sAx3Qvqqgh4dDIa28bOgiYQcjLj7HpMlisTfghzkFpHMVNG+oSNfexVk/uGHJ2CAMhbqTEnEK4xDkuges3N2WsrslH4gbKJsyGH8T9vNUsqlz/BbHRKJvQGicrnuSNAoQLpQNqcdGja5se4pddV2fuuwV/pkjQ1NHOF1NGiDciSVEC6fmw7i8b6TEfjuHt7GrMVum+XQ6Q1OOiCzs2cRi5ulOW117h9neDHDUd0hV1RD63Z28goOvmdFIORqZ2cgDGozAPQRsXwhAYzMqvDqC4xW34E88QJsvA= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2133 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Sami.Mujawar@arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT045.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(6029001)(4636009)(346002)(396003)(39860400002)(136003)(376002)(189003)(199004)(13464003)(81166006)(22756006)(14444005)(54906003)(36906005)(110136005)(2501003)(6246003)(7736002)(50466002)(7696005)(102836004)(6506007)(53546011)(86362001)(5660300002)(26005)(11346002)(106002)(446003)(99286004)(186003)(336012)(316002)(76176011)(305945005)(74316002)(26826003)(70586007)(14454004)(478600001)(966005)(76130400001)(70206006)(229853002)(52536014)(25786009)(9686003)(8676002)(6306002)(55016002)(2906002)(8936002)(8746002)(23756003)(356004)(6116002)(3846002)(47776003)(4326008)(66066001)(33656002)(81156014)(46800400005);DIR:OUT;SFP:1101;SCL:1;SRVR:AM6PR08MB3478;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:Pass;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;MX:1;A:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: e7f13b5f-6b79-46e7-9db4-08d7719720d1 NoDisclaimer: True X-Forefront-PRVS: 0232B30BBC X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: teBvbUlqASM57UJPoLQSiRPyh8po2IoYtg994+bP9mSdZy0JIelYJ53b9qVtoF5A71g207hsNFsu4CKjsyKH0LvVcLgCzKGHE6h5kdVR/ybTigGrbfYm6RUxzD8VGA7O9kzY4GRbunyBeNv6WKK7QRdOvljjhg942mejkpbmTuEZkjdabLMoUjTQhbjTa55EuSCQ/S2H0+kcUAj32yFpdYdhv/Z7sis7Th0Q+GkZm97LmrbdJP97g4ltHrMQccr+dER0dt0axyNtnr8586nd2a4a43KkCqn/X5XGDGPgtMhjxfrfOC315RZ3Kc2XQDsHK781fCmZXV8252LmQ1rtI4XI4enPY5NnAGLHK7eT2ypJMVJRlowUMr8UQmH/Q2DCV9piWCXQ69kmGpVPiZm0BRYXozikZujgf5CEza7CnjeKTWAkY4QOXGksT01Rr/P3mv5XsFDBlR77HHbGNNLAWRsG6uScF9t4p6xlhyD8+oI= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2019 11:03:51.3345 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9325df13-a7bf-48dc-0af2-08d771972790 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3478 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hi Philippe, Apologies, I missed #28 from Laszlo's guide. This patch has also received a r-b from: Reviewed-by: Jiewen.yao@intel.com Regards, Sami Mujawar -----Original Message----- From: Philippe Mathieu-Daud=E9 =20 Sent: 25 November 2019 10:48 AM To: devel@edk2.groups.io; Sami Mujawar Cc: Achin Gupta ; jiewen.yao@intel.com; Supreeth Venka= tesh ; Matteo Carlini ;= Laura Moretta ; nd Subject: Re: [edk2-devel] [PATCH v2 1/1] StandaloneMmPkg: Fix 'missing head= er' warning Hi Sami, On 11/25/19 10:26 AM, Sami Mujawar via Groups.Io wrote: > The Basetools scripts have been updated to report warnings if header=20 > files are not listed in the [Sources] section of the inf files. >=20 > Update StandaloneMmCpu.inf to include the header file=20 > StandaloneMmCpu.h to fix the warning. >=20 > Cc: Achin Gupta > Cc: Jiewen Yao > Cc: Supreeth Venkatesh > Signed-off-by: Sami Mujawar > --- >=20 > The changes can be seen at: > https://github.com/samimujawar/edk2/tree/696_stmm_fix_include_warning_ > v1 >=20 > Notes: > v2: > - Fixed patch check failure in commit message, [SAM= I] > changed 'CC' to 'Cc'. No code change. No code change, please keep the reviewer tags so we don't have to review th= e same patch again. I reviewed this one, see: https://www.mail-archive.com/devel@edk2.groups.io/msg11976.html Again: Reviewed-by: Philippe Mathieu-Daude > v1: > - Fix missing header warnings [SAM= I] >=20 > StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf | 3= ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git=20 > a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf=20 > b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf > index=20 > 5cc4915806db72e36da6cec85d5f690c0c958f16..e8f0c97f4513dec261800f49571e > 02c9e1e427ce 100644 > ---=20 > a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf > +++ b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu. > +++ inf > @@ -4,7 +4,7 @@ > # > # Copyright (c) 2009, Apple Inc. All rights reserved.
> # Copyright (c) 2016 HP Development Company, L.P. > -# Copyright (c) 2017 - 2018, ARM Limited. All rights reserved. > +# Copyright (c) 2017 - 2019, ARM Limited. All rights reserved. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -21,6 +21,7 @@ [Defines] > =20 > [Sources] > StandaloneMmCpu.c > + StandaloneMmCpu.h > EventHandle.c > =20 > [Packages] >=20