public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Sami Mujawar <Sami.Mujawar@arm.com>
To: Ashish Singhal <ashishsingha@nvidia.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>, nd <nd@arm.com>
Subject: Re: [PATCH 0/2] DynamicTablesPkg Updates
Date: Mon, 25 Feb 2019 13:38:17 +0000	[thread overview]
Message-ID: <DB6PR0802MB23753B89C191840D6A0EA812847A0@DB6PR0802MB2375.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <cover.1550773480.git.ashishsingha@nvidia.com>

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

-----Original Message-----
From: Ashish Singhal <ashishsingha@nvidia.com> 
Sent: 21 February 2019 06:39 PM
To: edk2-devel@lists.01.org
Cc: Sami Mujawar <Sami.Mujawar@arm.com>; Alexei Fedorov <Alexei.Fedorov@arm.com>; Ashish Singhal <ashishsingha@nvidia.com>
Subject: [PATCH 0/2] DynamicTablesPkg Updates

DynamicTablesPkg/DynamicTableManagerDxe: Update DEPEX

This patch adds appropriate dependencies to DynamicTableManagerDxe.
The initialization function fails if gEdkiiDynamicTableFactoryProtocolGuid
and gEdkiiConfigurationManagerProtocolGuid are not present already. Since we are not relying on a callback but locating these in initialization, we should add these dependencies. Towards the end of initialization function where we build and install ACPI tables, we locate gEfiAcpiTableProtocolGuid and return a failure is not present. We need to add approriate dependency for this as well. Adding these proper dependencies would make the code not rely on drivers forcefully dispatched in a particular order

DynamicTablesPkg/AcpiSpcrLibArm: Support 16550 UART.

This patch adds support for 16550 UART in ACPI SPCR table. HLOS support for this type of UART is already present.

Both the patches have been verified to work on hardware.

Ashish Singhal (2):
  DynamicTablesPkg/DynamicTableManagerDxe: Update DEPEX
  DynamicTablesPkg/AcpiSpcrLibArm: Support 16550 UART.

 .../Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf         | 4 +++-
 DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c      | 2 ++
 2 files changed, 5 insertions(+), 1 deletion(-)

--
2.7.4



  parent reply	other threads:[~2019-02-25 13:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-21 18:38 [PATCH 0/2] DynamicTablesPkg Updates Ashish Singhal
2019-02-21 18:38 ` [PATCH 1/2] DynamicTablesPkg/DynamicTableManagerDxe: Update DEPEX Ashish Singhal
2019-02-21 18:38 ` [PATCH 2/2] DynamicTablesPkg/AcpiSpcrLibArm: Support 16550 UART Ashish Singhal
2019-02-25 13:38 ` Sami Mujawar [this message]
2019-02-25 13:46   ` [PATCH 0/2] DynamicTablesPkg Updates Alexei Fedorov
2019-02-25 19:30 ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB6PR0802MB23753B89C191840D6A0EA812847A0@DB6PR0802MB2375.eurprd08.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox