[PATCH 0/2] DynamicTablesPkg Updates

[PATCH 0/2] DynamicTablesPkg Updates

[Ashish Singhal]

DynamicTablesPkg/DynamicTableManagerDxe: Update DEPEX

This patch adds appropriate dependencies to DynamicTableManagerDxe.
The initialization function fails if gEdkiiDynamicTableFactoryProtocolGuid
and gEdkiiConfigurationManagerProtocolGuid are not present already. Since
we are not relying on a callback but locating these in initialization, we
should add these dependencies. Towards the end of initialization function
where we build and install ACPI tables, we locate gEfiAcpiTableProtocolGuid
and return a failure is not present. We need to add approriate dependency
for this as well. Adding these proper dependencies would make the code not
rely on drivers forcefully dispatched in a particular order

DynamicTablesPkg/AcpiSpcrLibArm: Support 16550 UART.

This patch adds support for 16550 UART in ACPI SPCR table. HLOS support for
this type of UART is already present.

Both the patches have been verified to work on hardware.

Ashish Singhal (2):
  DynamicTablesPkg/DynamicTableManagerDxe: Update DEPEX
  DynamicTablesPkg/AcpiSpcrLibArm: Support 16550 UART.

 .../Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf         | 4 +++-
 DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c      | 2 ++
 2 files changed, 5 insertions(+), 1 deletion(-)

-- 
2.7.4

[PATCH 1/2] DynamicTablesPkg/DynamicTableManagerDxe: Update DEPEX

[Ashish Singhal]

DynamicTableManagerDxe initialization fails if
gEdkiiDynamicTableFactoryProtocolGuid,
gEdkiiConfigurationManagerProtocolGuid and
gEfiAcpiTableProtocolGuid are not already available.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com>
---
 .../Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf         | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf b/DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf
index 2aeaf15..fef8b20 100644
--- a/DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf
+++ b/DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf
@@ -46,5 +46,7 @@
   gEdkiiDynamicTableFactoryProtocolGuid
 
 [Depex]
-  gEdkiiConfigurationManagerProtocolGuid
+  gEfiAcpiTableProtocolGuid AND
+  gEdkiiConfigurationManagerProtocolGuid AND
+  gEdkiiDynamicTableFactoryProtocolGuid
 
-- 
2.7.4

[PATCH 2/2] DynamicTablesPkg/AcpiSpcrLibArm: Support 16550 UART.

[Ashish Singhal]

Add support for 16550 UART to ACPI SPCR table as it is a
supported UART type by HLOS.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com>
---
 DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c
index 23d3a50..a4654ac 100644
--- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c
+++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c
@@ -189,6 +189,8 @@ BuildSpcrTable (
       (SerialPortInfo->PortSubtype !=
       EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART) &&
       (SerialPortInfo->PortSubtype !=
+      EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_FULL_16550) &&
+      (SerialPortInfo->PortSubtype !=
       EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC)) {
     Status = EFI_INVALID_PARAMETER;
     DEBUG ((
-- 
2.7.4

Re: [PATCH 0/2] DynamicTablesPkg Updates

[Sami Mujawar]

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

-----Original Message-----
From: Ashish Singhal <ashishsingha@nvidia.com> 
Sent: 21 February 2019 06:39 PM
To: edk2-devel@lists.01.org
Cc: Sami Mujawar <Sami.Mujawar@arm.com>; Alexei Fedorov <Alexei.Fedorov@arm.com>; Ashish Singhal <ashishsingha@nvidia.com>
Subject: [PATCH 0/2] DynamicTablesPkg Updates

DynamicTablesPkg/DynamicTableManagerDxe: Update DEPEX

This patch adds appropriate dependencies to DynamicTableManagerDxe.
The initialization function fails if gEdkiiDynamicTableFactoryProtocolGuid
and gEdkiiConfigurationManagerProtocolGuid are not present already. Since we are not relying on a callback but locating these in initialization, we should add these dependencies. Towards the end of initialization function where we build and install ACPI tables, we locate gEfiAcpiTableProtocolGuid and return a failure is not present. We need to add approriate dependency for this as well. Adding these proper dependencies would make the code not rely on drivers forcefully dispatched in a particular order

DynamicTablesPkg/AcpiSpcrLibArm: Support 16550 UART.

This patch adds support for 16550 UART in ACPI SPCR table. HLOS support for this type of UART is already present.

Both the patches have been verified to work on hardware.

Ashish Singhal (2):
  DynamicTablesPkg/DynamicTableManagerDxe: Update DEPEX
  DynamicTablesPkg/AcpiSpcrLibArm: Support 16550 UART.

 .../Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf         | 4 +++-
 DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c      | 2 ++
 2 files changed, 5 insertions(+), 1 deletion(-)

--
2.7.4

Re: [PATCH 0/2] DynamicTablesPkg Updates

[Alexei Fedorov]

Reviewed-by: Alexei Fedorov <Alexei.Fedorov@arm.com>


Alexei

________________________________
From: Sami Mujawar
Sent: 25 February 2019 13:38:17
To: Ashish Singhal; edk2-devel@lists.01.org
Cc: Alexei Fedorov; nd
Subject: RE: [PATCH 0/2] DynamicTablesPkg Updates

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

-----Original Message-----
From: Ashish Singhal <ashishsingha@nvidia.com>
Sent: 21 February 2019 06:39 PM
To: edk2-devel@lists.01.org
Cc: Sami Mujawar <Sami.Mujawar@arm.com>; Alexei Fedorov <Alexei.Fedorov@arm.com>; Ashish Singhal <ashishsingha@nvidia.com>
Subject: [PATCH 0/2] DynamicTablesPkg Updates

DynamicTablesPkg/DynamicTableManagerDxe: Update DEPEX

This patch adds appropriate dependencies to DynamicTableManagerDxe.
The initialization function fails if gEdkiiDynamicTableFactoryProtocolGuid
and gEdkiiConfigurationManagerProtocolGuid are not present already. Since we are not relying on a callback but locating these in initialization, we should add these dependencies. Towards the end of initialization function where we build and install ACPI tables, we locate gEfiAcpiTableProtocolGuid and return a failure is not present. We need to add approriate dependency for this as well. Adding these proper dependencies would make the code not rely on drivers forcefully dispatched in a particular order

DynamicTablesPkg/AcpiSpcrLibArm: Support 16550 UART.

This patch adds support for 16550 UART in ACPI SPCR table. HLOS support for this type of UART is already present.

Both the patches have been verified to work on hardware.

Ashish Singhal (2):
  DynamicTablesPkg/DynamicTableManagerDxe: Update DEPEX
  DynamicTablesPkg/AcpiSpcrLibArm: Support 16550 UART.

 .../Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf         | 4 +++-
 DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c      | 2 ++
 2 files changed, 5 insertions(+), 1 deletion(-)

--
2.7.4

Re: [PATCH 0/2] DynamicTablesPkg Updates

[Laszlo Ersek]

On 02/21/19 19:38, Ashish Singhal wrote:
> DynamicTablesPkg/DynamicTableManagerDxe: Update DEPEX
> 
> This patch adds appropriate dependencies to DynamicTableManagerDxe.
> The initialization function fails if gEdkiiDynamicTableFactoryProtocolGuid
> and gEdkiiConfigurationManagerProtocolGuid are not present already. Since
> we are not relying on a callback but locating these in initialization, we
> should add these dependencies. Towards the end of initialization function
> where we build and install ACPI tables, we locate gEfiAcpiTableProtocolGuid
> and return a failure is not present. We need to add approriate dependency
> for this as well. Adding these proper dependencies would make the code not
> rely on drivers forcefully dispatched in a particular order
> 
> DynamicTablesPkg/AcpiSpcrLibArm: Support 16550 UART.
> 
> This patch adds support for 16550 UART in ACPI SPCR table. HLOS support for
> this type of UART is already present.
> 
> Both the patches have been verified to work on hardware.
> 
> Ashish Singhal (2):
>   DynamicTablesPkg/DynamicTableManagerDxe: Update DEPEX
>   DynamicTablesPkg/AcpiSpcrLibArm: Support 16550 UART.
> 
>  .../Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf         | 4 +++-
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c      | 2 ++
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 

I think the first patch in this series could be considered a bugfix, but
the second one can't. Therefore minimally commit 0692ef87594f
("DynamicTablesPkg/AcpiSpcrLibArm: Support 16550 UART.", 2019-02-25)
should be reverted.

Please see the explanation at
<https://lists.01.org/pipermail/edk2-devel/2019-February/037227.html>.
The patches were posted on the 21st, but only reviewed today (on the 25th).

Thanks
Laszlo