Re: [PATCH v5] ShellPkg: Add acpiview tool to dump ACPI tables

[Sami Mujawar <Sami.Mujawar@arm.com>]

Hi Jaben, Ray,

Is there anything more needed for integrating this patch in ShellPkg?

It has been:	
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Evan Lloyd <evan.lloyd@arm.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Tested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Regards,

Sami Mujawar

-----Original Message-----
From: Ard Biesheuvel <ard.biesheuvel@linaro.org> 
Sent: 21 March 2018 01:42 AM
To: Sami Mujawar <Sami.Mujawar@arm.com>
Cc: edk2-devel@lists.01.org; Ruiyu Ni <ruiyu.ni@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>; Stephanie Hughes-Fitt <Stephanie.Hughes-Fitt@arm.com>; Yao, Jiewen <jiewen.yao@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>; nd <nd@arm.com>
Subject: Re: [edk2] [PATCH v5] ShellPkg: Add acpiview tool to dump ACPI tables

On 9 March 2018 at 00:26, Sami Mujawar <sami.mujawar@arm.com> wrote:
> This program is provided to allow examination of ACPI table contents 
> from the UEFI Shell.  This can help with investigations, especially at 
> that stage where the tables are not enabling an OS to boot.
> The program is not exhaustive, and only encapsulates detailed 
> knowledge of a limited number of table types.
>
> Default behaviour is to display the content of all tables installed.
> 'Known' table types will be parsed and displayed with descriptions and 
> field values.  Where appropriate a degree of consistency checking is 
> done and errors may be reported in the output.
> Other table types will be displayed as an array of Hexadecimal bytes.
>
> To facilitate debugging, the -s and -d options can be used to generate 
> a binary file image of a table that can be copied elsewhere for 
> investigation using tools such as those provided by acpica.org.  This 
> is especially relevant for AML type tables like DSDT and SSDT.
>
> The inspiration for this is the existing smbiosview Debug1 Shell 
> command.
>
> Many tables are not explicitly handled, in part because no examples 
> are available for our testing.
>
> The program is designed to be extended to new tables with minimal 
> effort, and contributions are invited.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Evan Lloyd <evan.lloyd@arm.com>
> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

Tested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Thanks for contributing this, it is really very useful.

One nit: the MADT table is listed as 'APIC' which i think is incorrect, i.e,. we should refer to the tables by their official names rather than by the character sequences used as their signatures.