From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector1-arm-com header.b=ea0Yiy/w; spf=fail (domain: arm.com, ip: , mailfrom: sami.mujawar@arm.com) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (EUR02-VE1-obe.outbound.protection.outlook.com []) by groups.io with SMTP; Thu, 09 May 2019 06:36:59 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3hB9AcR+iirVg3CujPDSeOYObRCRwbaWtxdPDi3GWgM=; b=ea0Yiy/wUxjm0v4dkcESSI81R0zKNEFjyconZ2uQV2cR0XBTBA92MPKwiNp45eYCyU3GnWPVyXd+75e+VFsJ5vsET1tdR2Qq2YqvS7tAtEDest8RUN3XzTCLFBczYsf9IPBU8NCQXfbDYeHEYwRbGC4+I0haEFa0hegv+IAgFNo= Received: from DB6PR0802MB2375.eurprd08.prod.outlook.com (10.172.228.142) by DB6PR0802MB2278.eurprd08.prod.outlook.com (10.172.227.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1878.22; Thu, 9 May 2019 13:36:55 +0000 Received: from DB6PR0802MB2375.eurprd08.prod.outlook.com ([fe80::bca8:53e0:bf8a:3fa1]) by DB6PR0802MB2375.eurprd08.prod.outlook.com ([fe80::bca8:53e0:bf8a:3fa1%10]) with mapi id 15.20.1856.016; Thu, 9 May 2019 13:36:55 +0000 From: "Sami Mujawar" To: "devel@edk2.groups.io" CC: "jaben.carsey@intel.com" , "ray.ni@intel.com" , Krzysztof Koch , nd Subject: Re: [PATCH v1 1/1] ShellPkg: acpiview: Add GT Frame Number validation to GTDT parser Thread-Topic: [PATCH v1 1/1] ShellPkg: acpiview: Add GT Frame Number validation to GTDT parser Thread-Index: AQHVBaQmD3F4MuRkn0a78tmZNanT/qZiy91Q Date: Thu, 9 May 2019 13:36:54 +0000 Message-ID: References: <20190508134408.23096-1-krzysztof.koch@arm.com> In-Reply-To: <20190508134408.23096-1-krzysztof.koch@arm.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Sami.Mujawar@arm.com; x-originating-ip: [217.140.106.51] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 295c33dd-b9dc-4993-6d92-08d6d48366f5 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020);SRVR:DB6PR0802MB2278; x-ms-traffictypediagnostic: DB6PR0802MB2278: x-ms-exchange-purlcount: 1 nodisclaimer: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 003245E729 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(136003)(396003)(376002)(346002)(366004)(13464003)(199004)(189003)(5640700003)(6436002)(316002)(81166006)(4326008)(99286004)(8676002)(81156014)(1730700003)(8936002)(54906003)(9686003)(6306002)(55016002)(2501003)(25786009)(68736007)(7696005)(6246003)(11346002)(53936002)(446003)(476003)(486006)(76176011)(6506007)(53546011)(229853002)(102836004)(186003)(33656002)(2351001)(66066001)(26005)(6916009)(6116002)(3846002)(71190400001)(71200400001)(2906002)(5660300002)(52536014)(14444005)(256004)(72206003)(966005)(66446008)(14454004)(86362001)(478600001)(74316002)(7736002)(76116006)(73956011)(66946007)(66476007)(305945005)(64756008)(66556008);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2278;H:DB6PR0802MB2375.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: dup+tCAH0dfRO0MaXsvjeQ2eICLm/R3OLzd+cSvITvsiTv5I3q59GxvU+KY7/1TWkjj7rsT2vRz0JsN4kuhWXI3CH9aGw8IACXul0rF2syZV1B9viyttXO6cfXS+Gi4P+hbUCLaisxcA6/yk/uovZdzP7zBbetmzE0T0f6I/iw+pM+91hmillvY3JCrbENz1LR+9lDyd/NvPpMrjqnXXhNnDnHW9bHlQ6qDjoEOWTfDT03MfaWWotla+zqI5uABsiT+Urkj45G0y12RC6fAuMuUl2ZdqBA+i0qxqeyOthS+quH2DyRn4eC6XRepA9vo6N6LTxbKZK7cz7WvNp0M5Bf9hMvPPddNkEqc9CuRYvRtnesFkSAHJxly64+VZ10ICRj9DVppkthmhYnKSqPGWXZUHuV7Uf/QTfp1H4AOjR2o= MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 295c33dd-b9dc-4993-6d92-08d6d48366f5 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2019 13:36:54.5252 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2278 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sami Mujawar Regards, Sami Mujawar -----Original Message----- From: Krzysztof Koch =20 Sent: 08 May 2019 02:44 PM To: devel@edk2.groups.io Cc: jaben.carsey@intel.com; ray.ni@intel.com; Sami Mujawar ; Girish Pathak ; Pierre Gondois ; Matteo Carlini ; Stephanie Hughes-Fitt= ; nd Subject: [PATCH v1 1/1] ShellPkg: acpiview: Add GT Frame Number validation = to GTDT parser The ACPI 6.2 specification mandates that the Generic Timer (GT) Block Timer= Structures must have a frame number in the range 0-7. Update the GTDT parser to warn if this condition is violated. Signed-off-by: Krzysztof Koch --- The changes can be seen at: https://github.com/KrzysztofKoch1/edk2/tree/woa= _528_acpiview_gt_frame_validate_v1 Notes: v1: - Add GTDT Frame Number checks [Krzysztof] ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c | 4= 7 +++++++++++++++++++- 1 file changed, 45 insertions(+), 2 deletions(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/Gtdt= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtPa= rser.c index f31c4a2761751c58d4b1d3eb75084e24ec318e7f..572e52385c54932b14630481e85= a67d0b211966a 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.= c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtPars +++ er.c @@ -1,7 +1,7 @@ /** @file GTDT table parser =20 - Copyright (c) 2016 - 2018, ARM Limited. All rights reserved. + Copyright (c) 2016 - 2019, ARM Limited. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent =20 @par Reference(s): @@ -38,6 +38,21 @@ ValidateGtBlockTimerCount ( IN VOID* Context ); =20 +/** + This function validates the GT Frame Number. + + @param [in] Ptr Pointer to the start of the field data. + @param [in] Context Pointer to context specific information e.g. this + could be a pointer to the ACPI table header. +**/ +STATIC +VOID +EFIAPI +ValidateGtFrameNumber ( + IN UINT8* Ptr, + IN VOID* Context + ); + /** An ACPI_PARSER array describing the ACPI GTDT Table. **/ @@ -92,7 +107,7 @@ STATIC CONST ACPI_PARSER GtBlockParser[] =3D { An ACPI_PARSER array describing the GT Block timer. **/ STATIC CONST ACPI_PARSER GtBlockTimerParser[] =3D { - {L"Frame Number", 1, 0, L"%d", NULL, NULL, NULL, NULL}, + {L"Frame Number", 1, 0, L"%d", NULL, NULL, ValidateGtFrameNumber,=20 + NULL}, {L"Reserved", 3, 1, L"%x %x %x", Dump3Chars, NULL, NULL, NULL}, {L"Physical address (CntBaseX)", 8, 4, L"0x%lx", NULL, NULL, NULL, NULL}= , {L"Physical address (CntEL0BaseX)", 8, 12, L"0x%lx", NULL, NULL, NULL, @= @ -145,6 +160,34 @@ ValidateGtBlockTimerCount ( } } =20 +/** + This function validates the GT Frame Number. + + @param [in] Ptr Pointer to the start of the field data. + @param [in] Context Pointer to context specific information e.g. this + could be a pointer to the ACPI table header. +**/ +STATIC +VOID +EFIAPI +ValidateGtFrameNumber ( + IN UINT8* Ptr, + IN VOID* Context + ) +{ + UINT32 FrameNumber; + + FrameNumber =3D *(UINT8*)Ptr; + + if (FrameNumber > 7) { + IncrementErrorCount (); + Print ( + L"\nERROR: GT Frame Number =3D %d. GT Frame Number must be in range = 0-7.", + FrameNumber + ); + } +} + /** This function parses the Platform GT Block. =20 -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'