From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=hAYpeZzZ; spf=pass (domain: arm.com, ip: 40.107.2.68, mailfrom: sami.mujawar@arm.com) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (EUR02-VE1-obe.outbound.protection.outlook.com [40.107.2.68]) by groups.io with SMTP; Wed, 07 Aug 2019 01:46:49 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JoDvV/SwFXqZy025FblioRS+zTpZh5uVA3BpxBIODmw=; b=hAYpeZzZAcSdv9dWUIHeexj7R7CJCwvi5gT57qtHuhoketqCRCCc5ZjUF5ob4PlkbryXWvOeHEK5QwPN3lYh3V6fR6mh5lNyEE9GfHLgDX7pgObmM9k6d7Si099G5AbVeu8MWHWFF+ceIx01B+atPJhoa3jsHNov3VMgwk5kubU= Received: from VE1PR08CA0017.eurprd08.prod.outlook.com (2603:10a6:803:104::30) by HE1PR0801MB1851.eurprd08.prod.outlook.com (2603:10a6:3:7b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.17; Wed, 7 Aug 2019 08:46:44 +0000 Received: from VE1EUR03FT040.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::201) by VE1PR08CA0017.outlook.office365.com (2603:10a6:803:104::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2157.15 via Frontend Transport; Wed, 7 Aug 2019 08:46:43 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT040.mail.protection.outlook.com (10.152.18.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2052.18 via Frontend Transport; Wed, 7 Aug 2019 08:46:42 +0000 Received: ("Tessian outbound cc8a947d4660:v26"); Wed, 07 Aug 2019 08:46:38 +0000 X-CR-MTA-TID: 64aa7808 Received: from 0572722a95ea.3 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.6.58]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id BF0A340D-D65F-41DF-BEB8-EEE203B0E79C.1; Wed, 07 Aug 2019 08:46:33 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2058.outbound.protection.outlook.com [104.47.6.58]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0572722a95ea.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Aug 2019 08:46:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZhuA1LLUDoBRE+3p87y4Ym5I2+v8cKesoaQqpNWAhugzbo7LlqW9DSYmPv0JnNMCcZ5paF42Gzg4ayHthuYQ657E4U7/g0+qSU7AzUjnaTIBMQRXPm3Ezz5N5RvP8VjgGrHE8pG8f9+ocOtF2eL6aQh3OwFn94guDiS3eTDtcqYCZIuKacYFDmJEgeJOy/pSjFijgs+sLvrv9OW4qB5WpfyTQVhSLuHOxONpgmNvw1vwMZ4FE/XOsfu0RKvN+ChRbXNWc0YPn4C95TXZ2s90FoYGxH/Mm82HoCia7pNA0u8i3uVZe2dzzBgIAAhaGp88FTs3B9/oeii6d8t/BEKGDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JoDvV/SwFXqZy025FblioRS+zTpZh5uVA3BpxBIODmw=; b=MaAcc8qV9BoYhA7Z1K6PzZFnTgGA3+/SFCNRQsDs6GKIqy+Y/7ND8h+bJFfQNh7ZKyCCHwHEynBzhnDjyDKhPFEHYsuPW9AlYh9x+yH6TCuCPPUC/wmcPxTvp9M3LkQGpmUQTh1UuvZ5B4U4wHn6wSsVL2QRNJ6h/+4Rvn2UXbSeJW1j+UPDwCRb1IYaxcPJnUFEKzYMrI5a6bzfvKuKI+/DAFYEgs/5+Qw4UwTGHfwG5P/BviW6vUPPVcSqjsIxA/m6YHC0QiaHkMb7X7BUe/9brDGrvkCqakuoAYD5AVr86ksBVFOEl31EzRu3XSHA1PiTuZUCA8IKWokpa25gkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JoDvV/SwFXqZy025FblioRS+zTpZh5uVA3BpxBIODmw=; b=hAYpeZzZAcSdv9dWUIHeexj7R7CJCwvi5gT57qtHuhoketqCRCCc5ZjUF5ob4PlkbryXWvOeHEK5QwPN3lYh3V6fR6mh5lNyEE9GfHLgDX7pgObmM9k6d7Si099G5AbVeu8MWHWFF+ceIx01B+atPJhoa3jsHNov3VMgwk5kubU= Received: from DB6PR0802MB2375.eurprd08.prod.outlook.com (10.172.228.142) by DB6PR0802MB2166.eurprd08.prod.outlook.com (10.172.227.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2157.14; Wed, 7 Aug 2019 08:46:31 +0000 Received: from DB6PR0802MB2375.eurprd08.prod.outlook.com ([fe80::88a4:74c4:c4b7:aa1a]) by DB6PR0802MB2375.eurprd08.prod.outlook.com ([fe80::88a4:74c4:c4b7:aa1a%5]) with mapi id 15.20.2136.018; Wed, 7 Aug 2019 08:46:31 +0000 From: "Sami Mujawar" To: Krzysztof Koch , "devel@edk2.groups.io" CC: "jaben.carsey@intel.com" , "ray.ni@intel.com" , "zhichao.gao@intel.com" , "Matteo Carlini" , nd Subject: Re: [PATCH v1 0/6] Prevent buffer overruns in acpiview table parsers Thread-Topic: [PATCH v1 0/6] Prevent buffer overruns in acpiview table parsers Thread-Index: AQHVSEVeS7N2g9X61kCzIPj/d4smJ6bvaGRQ Date: Wed, 7 Aug 2019 08:46:31 +0000 Message-ID: References: <20190801084407.48712-1-krzysztof.koch@arm.com> In-Reply-To: <20190801084407.48712-1-krzysztof.koch@arm.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 38eb33b7-18b5-41ae-8a90-76735d512b86.1 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Sami.Mujawar@arm.com; x-originating-ip: [217.140.106.55] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: b6d63be7-937c-4b4b-215f-08d71b13c59c X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam-Untrusted: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:DB6PR0802MB2166; X-MS-TrafficTypeDiagnostic: DB6PR0802MB2166:|HE1PR0801MB1851: X-MS-Exchange-PUrlCount: 1 x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:4502;OLM:4502; x-forefront-prvs: 01221E3973 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(979002)(4636009)(39860400002)(136003)(366004)(396003)(346002)(376002)(189003)(199004)(13464003)(11346002)(229853002)(6436002)(33656002)(6506007)(102836004)(966005)(478600001)(486006)(2906002)(53546011)(26005)(186003)(76176011)(476003)(99286004)(7696005)(256004)(14444005)(14454004)(316002)(110136005)(54906003)(66066001)(81156014)(8936002)(68736007)(2501003)(446003)(6116002)(53936002)(3846002)(8676002)(25786009)(6246003)(71190400001)(71200400001)(81166006)(6306002)(55016002)(52536014)(66476007)(4326008)(64756008)(66446008)(66556008)(76116006)(9686003)(305945005)(86362001)(7736002)(5660300002)(74316002)(66946007)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2166;H:DB6PR0802MB2375.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: 6jPHR9qE91W0TDOyBM1hvTtsP8IF8oZyTp//sUsFk/KI5ICRgnALX4sRuHaTr02Jo2a6VZojG4uL3wGVlwNurtQ1C0Ay2CvVUKlzC/NELznrc00SbnDIidWBEI76bO+Wl5LSfypeUPE0MWwKulWwjcv35OSwFPnTlhyHMcSFOCEuGbDZZgqqEJnMFLoLYSemsPjqLrLWSJ5N4hEx2Idimtv10vYkW10Y6d9h9/Od5u1FRGVD8saJ4kEFDhzlNRHO3asPRUuqN3M9T7DE4xx4zaW9C3Ros476uxhJ7h8CYgDJLklHhPadQBGWq8uCUpu//QRT3AQbH+jEC/RxgqbYi2JBjtU35TB6XbOpum4Eiv8l1jRrEN3UkMlgoG8+XvixaGKkD8svaPmW50ZU89F5XiSK8YBzlWkJAVUDfC0eyV4= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2166 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Sami.Mujawar@arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT040.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(979002)(4636009)(376002)(136003)(346002)(39860400002)(396003)(2980300002)(189003)(199004)(13464003)(66066001)(25786009)(229853002)(6306002)(81156014)(8676002)(36906005)(2906002)(46406003)(9686003)(4326008)(55016002)(47776003)(81166006)(356004)(52536014)(76130400001)(63350400001)(476003)(14444005)(70586007)(486006)(336012)(11346002)(446003)(126002)(70206006)(63370400001)(2501003)(23726003)(22756006)(305945005)(316002)(7736002)(6246003)(6116002)(186003)(86362001)(14454004)(7696005)(6506007)(99286004)(50466002)(5660300002)(33656002)(97756001)(3846002)(102836004)(74316002)(26826003)(8746002)(26005)(478600001)(54906003)(110136005)(76176011)(966005)(53546011)(8936002)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR0801MB1851;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:TempError;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;MX:1;A:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 7c2e7761-9fe1-42c0-03d0-08d71b13beb9 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(710020)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:HE1PR0801MB1851; NoDisclaimer: True X-Forefront-PRVS: 01221E3973 X-Microsoft-Antispam-Message-Info: L/mkOoyKfZir9ePJM8gI8DJk+dd7vPbg/eRqVZSUCB03Sp/uGIQ/1Qrc9+eM4vnFc9NzSgD9D+8FyROU/z3fWlpRWY5vnDadbecT/nr1Bv3gzind2pbSME2Z5mU7wk8oVkf5f0zHwMtpNrBJ0EFPYa+/NRcvQjlnSk8U16PD2mkjbTXdp/jgWTEAN66Bu6ewm+tqMjck4sw59bZUQULScLNPq6+/IenpnrBAFmVNqOXc3B88HvpDBx8lXDpRuG1hInxIX5xC3IwWlnvlj99SdP9ubP2NpZlaY+Jez7A4/qhbp9bm2K5IAKoQLqcXIke/+rHscWMM2lNjaFXL3YDuIH3eykEpErS1cWNmCC5ejJMhsUt0JDo3VAi4jwEuwGi5UY7UW+z1ctTIRc8zICe6iqTbcb08ADZ5YJyEHXoT8nk= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2019 08:46:42.8625 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b6d63be7-937c-4b4b-215f-08d71b13c59c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1851 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable For this patch series. Reviewed-by: Sami Mujawar Regards, Sami Mujawar -----Original Message----- From: Krzysztof Koch =20 Sent: 01 August 2019 09:44 AM To: devel@edk2.groups.io Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com; Sami M= ujawar ; Matteo Carlini ; nd = Subject: [PATCH v1 0/6] Prevent buffer overruns in acpiview table parsers This patch series makes minor modifications to a number of ACPI table parse= rs with a goal to minimize the risk of buffer overruns. Some of these overr= uns can be caused by invalid ACPI table data. Changes can be seet at: https://github.com/KrzysztofKoch1/edk2/tree/612_pre= vent_buffer_overruns_v1 Krzysztof Koch (6): ShellPkg: acpiview: DBG2: Prevent buffer overruns ShellPkg: acpiview: GTDT: Prevent buffer overruns ShellPkg: acpiview: IORT: Prevent buffer overruns ShellPkg: acpiview: MADT: Prevent buffer overruns ShellPkg: acpiview: PPTT: Prevent buffer overruns ShellPkg: acpiview: SRAT: Prevent buffer overruns ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parser.c | 1= 41 ++++++++++----- ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gt= dt/GtdtParser.c | 147 +++++++-------- ShellPkg/Library/UefiShellAcpiViewCo= mmandLib/Parsers/Iort/IortParser.c | 191 +++++++++++--------- ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c | = 2 +- ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c | = 38 ++-- ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratPars= er.c | 14 +- 6 files changed, 314 insertions(+), 219 deletions(-) -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'