From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=AejH8zAa; spf=pass (domain: arm.com, ip: 40.107.2.49, mailfrom: sami.mujawar@arm.com) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (EUR02-VE1-obe.outbound.protection.outlook.com [40.107.2.49]) by groups.io with SMTP; Thu, 18 Jul 2019 04:18:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fuoSATXsbbb8RZguZQDTXGDLyLk1v4SqBwLppdkrVKMWKBwPLt7OJHVXqaLJB5lciycfVodmwzLoQH1Nmmaqu4zP50jtZ50K1s3o1UT30gSiX9VWSerh0Qn2H7s+v520Qa8Z/cXHTthzKkhkaGsw7IPKVqzzmd8uODIOiiFc+IOBesfmHa/sBC2PeVodNOrekkYg4ihbWiEnGfzLQtTd9YTe3Ep67UNW2HLLnFUx9ckfD85Sif8yn2z2NRnrCcrR+3n1gTN8B+6sdIKOd1jFBPiw5Pf2UQrql5JqXoIh4mCRJ11z35UEaWpCZRtQhe8IzgYGXaXOY8f9XLFG5bag7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YRvrK1kut6U2N3pnHfYfHllt6DIemO4JrzN1ckb2IMw=; b=lXfr7Ds1wntsBSxd9ewl7PR7YGLZOl3VWDs6/hXmO4OsybGcBvRCIIMJf5oEPeej3hBZu6g5+Chyi53ZugzIoW1Zm8oJWmEzgI8hT1uAHOZ9EFVdMutko0f3zRBY4MkSGCjH5WKHxEKNeV4eN72sWtIDCk1rzGDWuXJH2HEGu8hPAN2lEOW+AoMPmzb/tP1H+Q416RJ1jPtApiauI5NyGD92s9PhSQiQSAwO6mQRb3bOiqvl0xbxSVk9eUP6eJNnNwTYFir+pdvDPtRs6VTSlWQdd8GncC/0aP+RG6rdC/UD652zd9ja6AngIZ01pOyiqFG8/3KQswcWl3codaxoXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=arm.com;dmarc=pass action=none header.from=arm.com;dkim=pass header.d=arm.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YRvrK1kut6U2N3pnHfYfHllt6DIemO4JrzN1ckb2IMw=; b=AejH8zAaTD/HQnYrtZ++gNJ7FXqO4OfkE8ZXCKXuq8pm0et+9nYF4QGiaq8Yfp5rxyYfERSV1v7hQBq0cZRj3rjGzZIRtVeww2CBT3GAFr2eKg1478mHEsZ5VPDa/J/VvO5d6g5i9Hy8Ui3Qgr2EI1cZ7xfU7WK48G77aE37kBQ= Received: from DB6PR0802MB2375.eurprd08.prod.outlook.com (10.172.228.142) by DB6PR0802MB2440.eurprd08.prod.outlook.com (10.172.251.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.12; Thu, 18 Jul 2019 11:18:28 +0000 Received: from DB6PR0802MB2375.eurprd08.prod.outlook.com ([fe80::f9c1:cd3e:68a0:7eca]) by DB6PR0802MB2375.eurprd08.prod.outlook.com ([fe80::f9c1:cd3e:68a0:7eca%8]) with mapi id 15.20.2073.015; Thu, 18 Jul 2019 11:18:28 +0000 From: "Sami Mujawar" To: Krzysztof Koch , "devel@edk2.groups.io" CC: "jaben.carsey@intel.com" , "ray.ni@intel.com" , "zhichao.gao@intel.com" , Matteo Carlini , nd Subject: Re: [PATCH v1 0/8] Remove redundant forward declarations in acpiview Thread-Topic: [PATCH v1 0/8] Remove redundant forward declarations in acpiview Thread-Index: AQHVPVBafdxCRvFC9E2ohtNdajZElKbQOkDA Date: Thu, 18 Jul 2019 11:18:27 +0000 Message-ID: References: <20190718100502.24688-1-krzysztof.koch@arm.com> In-Reply-To: <20190718100502.24688-1-krzysztof.koch@arm.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 7f77c7c5-9dc1-4348-af15-e68b8c49d4a6.1 x-checkrecipientchecked: true authentication-results: spf=none (sender IP is ) smtp.mailfrom=Sami.Mujawar@arm.com; x-originating-ip: [217.140.106.54] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e1d8f5d7-4d4a-4a62-7f23-08d70b71a8a1 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:DB6PR0802MB2440; x-ms-traffictypediagnostic: DB6PR0802MB2440: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: nodisclaimer: True x-ms-oob-tlc-oobclassifiers: OLM:4941; x-forefront-prvs: 01026E1310 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(376002)(366004)(136003)(396003)(39860400002)(346002)(189003)(199004)(13464003)(6246003)(6436002)(2906002)(478600001)(71190400001)(71200400001)(52536014)(66946007)(8936002)(74316002)(8676002)(25786009)(81166006)(81156014)(2501003)(86362001)(64756008)(66556008)(66476007)(14454004)(76116006)(256004)(966005)(4326008)(3846002)(6116002)(66446008)(26005)(316002)(9686003)(99286004)(54906003)(11346002)(446003)(33656002)(68736007)(53936002)(110136005)(229853002)(102836004)(186003)(486006)(6506007)(7696005)(5660300002)(7736002)(66066001)(476003)(55016002)(6306002)(53546011)(76176011)(305945005);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2440;H:DB6PR0802MB2375.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: h+oZSCJEmiz19eFhhmjKEjCXXsMHJzzzPhLJCWZQoYiP6tQgevD6+V2s+uKTKMbn1xb/brLIxHRDuZWmHWlPPAWwEE+W6HrwcuXaQYF1GmkfBnZLBNbZw9gyHB/nyEUvIKDgPejcuKoTrOmwR6M5uKMUUB0O7yTJ3DbfTTe+R/Zynm66s8NB20fleRG41ZG9+fNR1lIWo/p1TW5iGn2kcgtWPUXYTc0raOh7e2AywGOl9A8e7rb4bw/+KVtYk/g4I1DaKD+XJ2DdsQ/tNGznE0Y31631pCHS6MMvT/AqUOZO6OEBOu0zzC8jsmcyrQ1SsR9lrNEyLhZY7KJ3yijGycKZkklsqKyfcYhzwPnhZEa3LDw1NTvdDyrUhwq84Bxp2EJ5w4FT0cffDfECyzo3BCjg0A5KJ+Ehi8kH30B9ZDU= MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: e1d8f5d7-4d4a-4a62-7f23-08d70b71a8a1 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2019 11:18:27.8743 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Sami.Mujawar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2440 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sami Mujawar -----Original Message----- From: Krzysztof Koch =20 Sent: 18 July 2019 11:05 AM To: devel@edk2.groups.io Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com; Sami M= ujawar ; Matteo Carlini ; nd = Subject: [PATCH v1 0/8] Remove redundant forward declarations in acpiview This patch series removes forward static function declarations in the acpiv= iew table parsers. After repositioning blocks of code, these forward declar= ations are no longer needed and they increase the code size. What is more, some of the existing ACPI table parsers don't have these dupl= icate declarations, so this set of patches makes the code structure consist= ent across all acpiview parsers. Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/tree/612_rem= ove_forward_decl_v1 Krzysztof Koch (8): ShellPkg: acpiview: RSDP: Remove redundant forward declarations ShellPkg: acpiview: FADT: Remove redundant forward declarations ShellPkg: acpiview: SPCR: Remove redundant forward declaration ShellPkg: acpiview: SRAT: Remove redundant forward declarations ShellPkg: acpiview: MADT: Remove redundant forward declarations ShellPkg: acpiview: IORT: Remove redundant forward declarations ShellPkg: acpiview: GTDT: Remove redundant forward declarations ShellPkg: acpiview: DBG2: Remove redundant forward declarations ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parser.c | = 62 +++------- ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/Fa= dtParser.c | 113 ++++++------------- ShellPkg/Library/UefiShellAcpiViewCom= mandLib/Parsers/Gtdt/GtdtParser.c | 91 ++++++--------- ShellPkg/Library/U= efiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c | 58 +++------- Shel= lPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c | 118 ++= ++++++------------ ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rs= dp/RsdpParser.c | 116 +++++++------------ ShellPkg/Library/UefiShellAcpiVi= ewCommandLib/Parsers/Spcr/SpcrParser.c | 98 ++++++---------- ShellPkg/Lib= rary/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c | 64 +++-------= - 8 files changed, 236 insertions(+), 484 deletions(-) -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'