From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector1-arm-com header.b=PpwQdbBW; spf=fail (domain: arm.com, ip: , mailfrom: sami.mujawar@arm.com) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (EUR02-VE1-obe.outbound.protection.outlook.com []) by groups.io with SMTP; Thu, 09 May 2019 06:36:58 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p0m0uj9FSL1aftLFSAtldcU7TODOWmcymzXzaOIWdMI=; b=PpwQdbBWLbwvLL5ce9WYLQb/reTZ1x+2BOEre8+NkWFXh7zYUjHdMUkRIZb6fj11SOZaSK3sgHj/TwExaPMqjBORmWCfUY1Sbu2i7EwMl8yAdKUUH5cXDvY1DhRZEn5zCKoivOGJk6yqXHh4qUsW80eURBaYdAOGUrmpvCyDYDg= Received: from DB6PR0802MB2375.eurprd08.prod.outlook.com (10.172.228.142) by DB6PR0802MB2278.eurprd08.prod.outlook.com (10.172.227.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1878.22; Thu, 9 May 2019 13:36:54 +0000 Received: from DB6PR0802MB2375.eurprd08.prod.outlook.com ([fe80::bca8:53e0:bf8a:3fa1]) by DB6PR0802MB2375.eurprd08.prod.outlook.com ([fe80::bca8:53e0:bf8a:3fa1%10]) with mapi id 15.20.1856.016; Thu, 9 May 2019 13:36:54 +0000 From: "Sami Mujawar" To: "devel@edk2.groups.io" CC: "jaben.carsey@intel.com" , "ray.ni@intel.com" , Matteo Carlini , Stephanie Hughes-Fitt , nd , Krzysztof Koch Subject: Re: [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT cache attributes validation Thread-Topic: [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT cache attributes validation Thread-Index: AQHUuWkdvH8DmLst5kClxxYBn+yNt6ZjY7xg Date: Thu, 9 May 2019 13:36:54 +0000 Message-ID: References: <20190131133008.14620-1-krzysztof.koch@arm.com> In-Reply-To: <20190131133008.14620-1-krzysztof.koch@arm.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Sami.Mujawar@arm.com; x-originating-ip: [217.140.106.51] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ede006e9-0f17-46f2-bc2a-08d6d48366ac x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020);SRVR:DB6PR0802MB2278; x-ms-traffictypediagnostic: DB6PR0802MB2278: x-ms-exchange-purlcount: 1 nodisclaimer: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1443; x-forefront-prvs: 003245E729 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(136003)(396003)(376002)(346002)(366004)(13464003)(199004)(189003)(5640700003)(6436002)(316002)(81166006)(4326008)(99286004)(8676002)(81156014)(1730700003)(8936002)(54906003)(9686003)(6306002)(55016002)(2501003)(25786009)(68736007)(7696005)(6246003)(11346002)(53936002)(446003)(476003)(486006)(76176011)(6506007)(53546011)(229853002)(102836004)(186003)(33656002)(2351001)(66066001)(26005)(6916009)(6116002)(3846002)(71190400001)(71200400001)(2906002)(5660300002)(52536014)(256004)(72206003)(966005)(66446008)(14454004)(86362001)(478600001)(74316002)(7736002)(76116006)(73956011)(66946007)(66476007)(305945005)(64756008)(66556008)(213903007);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2278;H:DB6PR0802MB2375.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: dri/AcGD3GlyydXtP3KpArBabAdVl2J9mZEM1ckw6hbW0UxaSqTkcHCSODKKM498VqGCLzleu7Xq6wdOQ+Hu9klzuec/BTfrrLWcQJejRht0GjW/BfyAqIARCVUOkLsdI1KIiejLh2TpFuIpvYqjdm/6RySvvom/dUH8RfZT23vrhtrc92YSEQA2DJnAzWRjFOGd9/LUUo0CGLNkEe6nsNmZBNbmb7x6pGnG/w78Cc6k8nDBRRuPvJgpblUa/ScWL51yJ/E6lnwtLNWAybpHteVJhSx6d0te06HImjuQKHLMJaEFKpNlxIi1zg7Jv6YOX45SY3gvDXUxLyBqQ/pAAKdIg4UVo3ng2S+CAXRCwDygxhnxHVGZhFsO4KmW7Buvzpix3Gm7HEGp72onObYVkYZ6gnEZlyh+5/bQEh9eRRs= MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: ede006e9-0f17-46f2-bc2a-08d6d48366ac X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2019 13:36:54.1479 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2278 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sami Mujawar Regards, Sami Mujawar -----Original Message----- From: Krzysztof Koch =20 Sent: 31 January 2019 01:30 PM To: edk2-devel@lists.01.org Cc: jaben.carsey@intel.com; ray.ni@intel.com; Matteo Carlini ; Stephanie Hughes-Fitt ; Sami Muj= awar ; nd Subject: [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT cach= e attributes validation Removed conditional pre-compiling for ARM CPUs because function ValidateCacheAttributes(..) is based on ACPI PPTT specification. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Krzysztof Koch Reported-by: Zhichao Gao --- The code can be found at:=20 https://github.com/KrzysztofKoch1/edk2/tree/woa_422_cache_valid_fix_v1 Notes: v1: - removed conditional precompilation [Krzysztof] ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c | 3= --- 1 file changed, 3 deletions(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/Pptt= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttPa= rser.c index bc56fe9ea1dd9c1e98a6a568d3f9191263bedc90..b6b420890a3494869020ed8bcc7= b791fcf7d70f3 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.= c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.= c @@ -86,11 +86,9 @@ ValidateCacheAttributes ( IN VOID* Context ) { -#if defined(MDE_CPU_ARM) || defined (MDE_CPU_AARCH64) // Reference: Advanced Configuration and Power Interface (ACPI) Specific= ation // Version 6.2 Errata A, September 2017 // Table 5-153: Cache Type Structure - UINT8 Attributes; Attributes =3D *(UINT8*)Ptr; =20 @@ -102,7 +100,6 @@ ValidateCacheAttributes ( ); return; } -#endif } =20 /** --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'