From: "Sami Mujawar" <sami.mujawar@arm.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
Pierre Gondois <Pierre.Gondois@arm.com>
Cc: "michael.d.kinney@intel.com" <michael.d.kinney@intel.com>,
"liming.gao@intel.com" <liming.gao@intel.com>,
Sami Mujawar <Sami.Mujawar@arm.com>, nd <nd@arm.com>
Subject: Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML OpCode definition for ExternalOp
Date: Wed, 30 Oct 2019 15:14:44 +0000 [thread overview]
Message-ID: <DB6PR0802MB2375AC0647CDC64ADB38451484600@DB6PR0802MB2375.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20191030141729.124444-1-pierre.gondois@arm.com>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of PierreGondois via Groups.Io
Sent: 30 October 2019 02:17 PM
To: devel@edk2.groups.io
Cc: Pierre Gondois <Pierre.Gondois@arm.com>; michael.d.kinney@intel.comliming.gao@intel.comSami.Mujawar@arm.com; nd <nd@arm.com>
Subject: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML OpCode definition for ExternalOp
From: Pierre Gondois <pierre.gondois@arm.com>
The ACPI specification, version 6.3, January 2019, defines the Named Object Encoding for ExternalOp in section '20.2.5.2 Named Objects Encoding'.
This patch adds the definition for ExternalOp to the list of Primary Opcode definitions.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
The changes can be seen at https://github.com/PierreARM/edk2/commits/677_Add_ExternalOp_definition_v1
Notes:
v1:
- Add the ExternalOp AML OpCode [Pierre]
MdePkg/Include/IndustryStandard/AcpiAml.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MdePkg/Include/IndustryStandard/AcpiAml.h b/MdePkg/Include/IndustryStandard/AcpiAml.h
index 6919622af212c58dd92fc4d2bbd3b9447961d20a..3dd5408b359f9192e2fa9cedd0260a0f6bb5603a 100644
--- a/MdePkg/Include/IndustryStandard/AcpiAml.h
+++ b/MdePkg/Include/IndustryStandard/AcpiAml.h
@@ -2,6 +2,7 @@
This file contains AML code definition in the latest ACPI spec.
Copyright (c) 2011, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2019, ARM Limited. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -30,6 +31,7 @@
#define AML_PACKAGE_OP 0x12
#define AML_VAR_PACKAGE_OP 0x13
#define AML_METHOD_OP 0x14
+#define AML_EXTERNAL_OP 0x15
#define AML_DUAL_NAME_PREFIX 0x2e
#define AML_MULTI_NAME_PREFIX 0x2f
#define AML_NAME_CHAR_A 0x41
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
next prev parent reply other threads:[~2019-10-30 15:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191030141729.124444-1-pierre.gondois@arm.com>
2019-10-30 15:04 ` [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML OpCode definition for ExternalOp Liming Gao
2019-10-30 15:14 ` Sami Mujawar [this message]
2019-11-04 2:08 ` Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB6PR0802MB2375AC0647CDC64ADB38451484600@DB6PR0802MB2375.eurprd08.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox