From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (EUR02-HE1-obe.outbound.protection.outlook.com [40.107.1.75]) by mx.groups.io with SMTP id smtpd.web12.7065.1580385513690711970 for ; Thu, 30 Jan 2020 03:58:34 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=xmUZQF3W; spf=pass (domain: arm.com, ip: 40.107.1.75, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kOOXncocVpTkBvs6xVNLYqYNq3kboHORa7zUrgymwRQ=; b=xmUZQF3WVjwUSECFtk6ED/oFIdy7UGZpAJBtjRuY6U5owItWc3pISqW7kgLrP4TO6QmX76jFVT4COIcLbxlbg3kG7S+AcAoBrgMG4lRehzZRB94ubDTgHU4PevbXwAXktGULN0gFoaRHJjvE3/XVsNkz8dBdLlYSszZQO8Tb87Q= Received: from AM6PR08CA0028.eurprd08.prod.outlook.com (2603:10a6:20b:c0::16) by AM6PR08MB5013.eurprd08.prod.outlook.com (2603:10a6:20b:ef::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2665.24; Thu, 30 Jan 2020 11:58:30 +0000 Received: from AM5EUR03FT041.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::202) by AM6PR08CA0028.outlook.office365.com (2603:10a6:20b:c0::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2665.22 via Frontend Transport; Thu, 30 Jan 2020 11:58:30 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT041.mail.protection.outlook.com (10.152.17.186) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2665.18 via Frontend Transport; Thu, 30 Jan 2020 11:58:30 +0000 Received: ("Tessian outbound 0420f1404d58:v42"); Thu, 30 Jan 2020 11:58:29 +0000 X-CR-MTA-TID: 64aa7808 Received: from 72e06c59dc6d.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C93FE002-0EF7-4C19-9B14-5A0694E93D48.1; Thu, 30 Jan 2020 11:58:24 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 72e06c59dc6d.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 30 Jan 2020 11:58:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HjsM7JDquNwaZcbBTtW+uD6bnBSYDXAIPRkG+7BEjk52IwkeLswizTYmRgwnCYrPdMNYG5ibFyssm6EmBdedUAvMcBm0PlQi/g/Hu+VUCbJi3ScQE4GhfNLw+shPNW9bu9tuEOWnBG2igrZ+nx22ZQTCeit2Qlz+UQSRs6PWKKuBVVcs6+586d8xBZxYP/B11e7xNLOBfLKp9VtQwbUcrfI+1Q5qGujAhNHoAZhgCEwkM7yLRImfyE3DaesXirPeBUHKd9Yv3cMQ51fVGARZmg83lkjpx7vNoc+nGRPWrKZLIoPklRLZEDg4u1OU7vxORZSyQX1TlYC2gwpFMTzapA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kOOXncocVpTkBvs6xVNLYqYNq3kboHORa7zUrgymwRQ=; b=PPBQd9YsUOxAn2skxww8VafEGA25yMGt+GbCejyboPBQGY0Ze/LngddwD0NeKhZaPmtxQBoHvjCnnmwfqiIbChtA6ZYlvNv/nH4+6Nl5ArP59m3n792Ixr5KniX+PciP4m/WYiqshiHo5wnLzBrBSLXJoD3S8TXe1jPueBLNIaIp8sAh6R0OyoIzieD1qRqy9GYpfrahNsx08gokqd2maTj0fqxOSqgIhWL+Ztx3QoOILnSFWmAq5MhFuCGiCNK3NaJcLLVk/NcRqrCsq/DR86XU6+T4zfHjQe9ij/w0XcXqyw7/kbpG53ss8Rfr1BpQTBOkkcN666QXQyp5XTgcwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kOOXncocVpTkBvs6xVNLYqYNq3kboHORa7zUrgymwRQ=; b=xmUZQF3WVjwUSECFtk6ED/oFIdy7UGZpAJBtjRuY6U5owItWc3pISqW7kgLrP4TO6QmX76jFVT4COIcLbxlbg3kG7S+AcAoBrgMG4lRehzZRB94ubDTgHU4PevbXwAXktGULN0gFoaRHJjvE3/XVsNkz8dBdLlYSszZQO8Tb87Q= Received: from DB6PR0802MB2375.eurprd08.prod.outlook.com (10.172.228.142) by DB6PR0802MB2472.eurprd08.prod.outlook.com (10.172.251.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2665.24; Thu, 30 Jan 2020 11:58:21 +0000 Received: from DB6PR0802MB2375.eurprd08.prod.outlook.com ([fe80::1d26:35ed:a0cc:f7f]) by DB6PR0802MB2375.eurprd08.prod.outlook.com ([fe80::1d26:35ed:a0cc:f7f%9]) with mapi id 15.20.2665.026; Thu, 30 Jan 2020 11:58:21 +0000 From: "Sami Mujawar" To: Krzysztof Koch , "devel@edk2.groups.io" CC: "ray.ni@intel.com" , "zhichao.gao@intel.com" , Matteo Carlini , nd , Laura Moretta Subject: Re: [PATCH v1 1/1] ShellPkg: acpiview: Remove duplicate ACPI structure size definitions Thread-Topic: [PATCH v1 1/1] ShellPkg: acpiview: Remove duplicate ACPI structure size definitions Thread-Index: AQHV12J2eOg3RPPWW0mLwkvjhUi8A6gDFx6w Date: Thu, 30 Jan 2020 11:58:21 +0000 Message-ID: References: <20200130114255.57188-1-krzysztof.koch@arm.com> In-Reply-To: <20200130114255.57188-1-krzysztof.koch@arm.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 04fc90d1-38b3-4341-ba0c-98c4ef7e0c39.1 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Sami.Mujawar@arm.com; x-originating-ip: [217.140.106.51] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 21236ba9-d740-46a0-48b9-08d7a57bb945 X-MS-TrafficTypeDiagnostic: DB6PR0802MB2472:|DB6PR0802MB2472:|AM6PR08MB5013: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; x-forefront-prvs: 02981BE340 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(39860400002)(136003)(376002)(396003)(346002)(366004)(199004)(189003)(110136005)(478600001)(71200400001)(5660300002)(54906003)(52536014)(966005)(55016002)(9686003)(316002)(2906002)(33656002)(4326008)(7696005)(81166006)(81156014)(76116006)(186003)(8676002)(86362001)(66446008)(26005)(66946007)(66476007)(8936002)(53546011)(64756008)(66556008)(6506007);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2472;H:DB6PR0802MB2375.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: vghGxZYHlHc7erjRZRvwpezWPbO3eYovcs/Z/4jCgL4GlrcTb9z4+QeI51wvL6+YmiGAowlKHVzddH3QsYLH5OqEvhd0OXIONU7WHQNFq97eVUIzD+XNGJIK15gaIN1/2d8Zjhvcl9FFotZAq/MlqBTqwaqZZ5CaObIzXt5l2K4UaFl+610uNhhotqBHgzoxnF8r0wkh+DB0NziGMyEDAmFu45Jtaw/4xmyaVA5dp/5IcsctPkG8JUVSgeBhNyiRD4sC71m6kQydG5fkz1XTiJrbF2AvqPyf791bn8soamldU6vcP15+xAUOSHDNr9AE34/wgpsRAMk1yKJkqGGsESftEA5q0P4Kcl0t8n6ABdT0a6UBPcuYXVWFPi64RHcniRr12GOOlrEubcrELBKez2YJN14Bg58C3mdubmV/5g97SjoUXx181RXBTcyRieNdvDfse1cyB8I8sQ0gtzoJwbqBsiNOjCQgGQ0Kl0Hknhc3uJXBfj3u+0vpVSbto9QKZNLdcT3SXm7PF5A0h/Bd6w== x-ms-exchange-antispam-messagedata: 7vPxktcybAfnmuk8T5w1YOw9xOMP3yyTOE92klW8r4SNKio5FzH3f3bgq/Q6HnYimim/lxuB84xmXSrJgoDmgl98ThJHMxxgkeHpkB3a9nLBEW6Tvz4C0zMnLUtLKHCFLJdqaaXzSNWBb5uE0N2ZVw== MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2472 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Sami.Mujawar@arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT041.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(346002)(376002)(39860400002)(396003)(136003)(189003)(199004)(9686003)(336012)(186003)(55016002)(26005)(6506007)(53546011)(2906002)(478600001)(26826003)(316002)(966005)(110136005)(54906003)(36906005)(7696005)(70206006)(52536014)(5660300002)(70586007)(356004)(4326008)(8936002)(81156014)(81166006)(86362001)(8676002)(33656002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM6PR08MB5013;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:Pass;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;MX:1;A:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 89964e54-46ea-493b-2f87-08d7a57bb429 X-Forefront-PRVS: 02981BE340 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: boh9DyXLoE2tzVlRI6xoBxoRTxVcJCVb0se7uzm4BAJIAbOH8lEQiqn0OMUZpGRpqg25qjVkK4aKAV6I0UmDwaLkYIpaPGX6z2u4lHuv8gb8jTRf86QmWcLGwW2HCisHmOX2CM8y5Ht6MBspHMrr5V95sNZSJWU34JhEhouWqFSDdXSXHmSjJusaf8RYQyCPzoLvK7gqRcjTCaXxuvXRUAE9dy0sLPF8XXB5KFvqt9lqpwEg60faJeyD5hfJtNFp9n859slF1Djw4e99B1HanJrWxhbFpskLO+e7NxsxjN2jk06wQsOORXvcRhTScTh+bmvQMjv0sJvkhq8+gswM5xaDv352ajLy5ruow2+/MJ2emzEyauX1vhRbiGZqXXRw3s5GteUyGqPYlLthVpqQ8vW7tNffKmnfQqEQBTyBT1YZlyDhVsEa5QRbjlvaTc/dqNGmvoec+SN/YQB6D6zJizw7xPKK15i1AtZsAf4Mi59uUQSuzNNa/Ozs+cB4snc6VkVRu/fp2dWB030jSMNW+A== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2020 11:58:30.3470 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 21236ba9-d740-46a0-48b9-08d7a57bb945 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5013 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sami Mujawar Regards, Sami Mujawar -----Original Message----- From: Krzysztof Koch =20 Sent: 30 January 2020 11:43 To: devel@edk2.groups.io Cc: ray.ni@intel.com; zhichao.gao@intel.com; Matteo Carlini ; Sami Mujawar ; nd Subject: [PATCH v1 1/1] ShellPkg: acpiview: Remove duplicate ACPI structure= size definitions Remove duplicate Generic Address Structure (GAS) and ACPI table header size= definitions. Replace any dependencies with the definitions from Acpi63.h. AcpiParser.h redefines the size of Generic Address Structure (GAS) and the = ACPI table header. The motivation is to 'minimise any reference to the EDK2= ACPI headers in an attempt to provide cross checking'. While the redefined= values are unlikely to change, redefinition causes unnecessary maintenance= overhead for acpiview. In addition to this, EDK2 ACPI headers are referenced throughout the entire= project, so the assumption should be that the definitions in these header = files are correct. Signed-off-by: Krzysztof Koch --- Changes can be seen at: https://github.com/tianocore/edk2/compare/master...= KrzysztofKoch1:remove_dup_defs_acpiview_v1?expand=3D1 Notes: v1: - Remove duplicate definitions [Krzysztof] ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 8 +++---- Sh= ellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h | 22 +-------------= ------ 2 files changed, 5 insertions(+), 25 deletions(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c b/Sh= ellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c index 2b2ecb93cef9ee28b752e7bf2d920b059dbf7d6b..ed8767da64280d0b02fe42b7d21= 20690d5573bba 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c @@ -1,7 +1,7 @@ /** @file ACPI parser =20 - Copyright (c) 2016 - 2019, ARM Limited. All rights reserved. + Copyright (c) 2016 - 2020, ARM Limited. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent **/ =20 @@ -666,7 +666,7 @@ DumpGas ( IN UINT8* Ptr ) { - DumpGasStruct (Ptr, 2, GAS_LENGTH); + DumpGasStruct (Ptr, 2, sizeof=20 + (EFI_ACPI_6_3_GENERIC_ADDRESS_STRUCTURE)); } =20 /** @@ -687,7 +687,7 @@ DumpAcpiHeader ( 0, "ACPI Table Header", Ptr, - ACPI_DESCRIPTION_HEADER_LENGTH, + sizeof (EFI_ACPI_DESCRIPTION_HEADER), PARSER_PARAMS (AcpiHeaderParser) ); } @@ -721,7 +721,7 @@ ParseAcpiHeader ( 0, NULL, Ptr, - ACPI_DESCRIPTION_HEADER_LENGTH, + sizeof (EFI_ACPI_DESCRIPTION_HEADER), PARSER_PARAMS (AcpiHeaderParser) ); =20 diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h b/Sh= ellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h index 6deee3542e09bc18b03fdd18dece5b6f9725839c..f81ccac7e118378aa185db4b625= e5bcd75f78347 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h @@ -1,7 +1,7 @@ /** @file Header file for ACPI parser =20 - Copyright (c) 2016 - 2019, ARM Limited. All rights reserved. + Copyright (c) 2016 - 2020, ARM Limited. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent **/ =20 @@ -396,26 +396,6 @@ ParseAcpi ( { L"Creator Revision", 4, 32, L"0x%X", NULL, \ (VOID**)&(Info)->CreatorRevision, NULL, NULL } =20 -/** - Length of the ACPI GAS structure. - - NOTE: This might normally be defined as - sizeof (EFI_ACPI_6_2_GENERIC_ADDRESS_STRUCTURE). - However, we deliberately minimise any reference to the EDK2 ACPI - headers in an attempt to provide cross checking. -**/ -#define GAS_LENGTH 12 - -/** - Length of the ACPI Header structure. - - NOTE: This might normally be defined as - sizeof (EFI_ACPI_DESCRIPTION_HEADER). - However, we deliberately minimise any reference to the EDK2 ACPI - headers in an attempt to provide cross checking. -**/ -#define ACPI_DESCRIPTION_HEADER_LENGTH 36 - /** This function indents and traces the GAS structure as described by the G= asParser. =20 -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'