public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3
@ 2019-06-12 12:30 Krzysztof Koch
  0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Koch @ 2019-06-12 12:30 UTC (permalink / raw)
  To: devel
  Cc: jaben.carsey, ray.ni, zhichao.gao, michael.d.kinney, liming.gao,
	Sami.Mujawar, Matteo.Carlini, Stephanie.Hughes-Fitt, nd

This patch adds a number of definitions to the ACPI 6.3 header file for
the purpose of parsing Revision 3 of the System Resource Affinity Table
(SRAT) in the Acpiview UEFI shell tool.

By defining the Generic Initiator Affinity Structure's Type ID and the
allowed Device Handle Types for the structure, it is possible to dump
and validate the contents of the latest version of the SRAT table in
acpiview.

References:
- ACPI 6.3 January 2019, Section 5.2.16.6

Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/tree/582_acpiview_6_3_srat_v1

Krzysztof Koch (2):
  MdePkg: Add Generic Initiator Affinity Structure definitions to SRAT
  ShellPkg: acpiview: Update SRAT parser to ACPI 6.3

 MdePkg/Include/IndustryStandard/Acpi63.h                               |  11 +-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c              |  35 ++-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h              |  16 ++
 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c | 256 +++++++++++++++++++-
 4 files changed, 309 insertions(+), 9 deletions(-)

--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3
@ 2019-06-12 14:10 Krzysztof Koch
  2019-10-21 16:06 ` Sami Mujawar
  0 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Koch @ 2019-06-12 14:10 UTC (permalink / raw)
  To: devel
  Cc: jaben.carsey, ray.ni, zhichao.gao, michael.d.kinney, liming.gao,
	Sami.Mujawar, Matteo.Carlini, Stephanie.Hughes-Fitt, nd

This patch adds a number of definitions to the ACPI 6.3 header file for
the purpose of parsing Revision 3 of the System Resource Affinity Table
(SRAT) in the Acpiview UEFI shell tool.

By defining the Generic Initiator Affinity Structure's Type ID and the
allowed Device Handle Types for the structure, it is possible to dump
and validate the contents of the latest version of the SRAT table in
acpiview.

References:
- ACPI 6.3 January 2019, Section 5.2.16.6

Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/tree/582_acpiview_6_3_srat_v1

Krzysztof Koch (2):
  MdePkg: Add Generic Initiator Affinity Structure definitions to SRAT
  ShellPkg: acpiview: Update SRAT parser to ACPI 6.3

 MdePkg/Include/IndustryStandard/Acpi63.h                               |  11 +-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c              |  35 ++-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h              |  16 ++
 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c | 256 +++++++++++++++++++-
 4 files changed, 309 insertions(+), 9 deletions(-)

--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3
@ 2019-06-12 14:10 Krzysztof Koch
  0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Koch @ 2019-06-12 14:10 UTC (permalink / raw)
  To: devel
  Cc: jaben.carsey, ray.ni, zhichao.gao, michael.d.kinney, liming.gao,
	Sami.Mujawar, Matteo.Carlini, Stephanie.Hughes-Fitt, nd

This patch adds a number of definitions to the ACPI 6.3 header file for
the purpose of parsing Revision 3 of the System Resource Affinity Table
(SRAT) in the Acpiview UEFI shell tool.

By defining the Generic Initiator Affinity Structure's Type ID and the
allowed Device Handle Types for the structure, it is possible to dump
and validate the contents of the latest version of the SRAT table in
acpiview.

References:
- ACPI 6.3 January 2019, Section 5.2.16.6

Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/tree/582_acpiview_6_3_srat_v1

Krzysztof Koch (2):
  MdePkg: Add Generic Initiator Affinity Structure definitions to SRAT
  ShellPkg: acpiview: Update SRAT parser to ACPI 6.3

 MdePkg/Include/IndustryStandard/Acpi63.h                               |  11 +-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c              |  35 ++-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h              |  16 ++
 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c | 256 +++++++++++++++++++-
 4 files changed, 309 insertions(+), 9 deletions(-)

--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3
  2019-06-12 14:10 [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3 Krzysztof Koch
@ 2019-10-21 16:06 ` Sami Mujawar
  2019-11-01 13:59   ` Sudipto Paul
  0 siblings, 1 reply; 8+ messages in thread
From: Sami Mujawar @ 2019-10-21 16:06 UTC (permalink / raw)
  To: Krzysztof Koch, devel@edk2.groups.io
  Cc: jaben.carsey@intel.com, ray.ni@intel.com, zhichao.gao@intel.com,
	michael.d.kinney@intel.com, liming.gao@intel.com, Matteo Carlini,
	nd, Deepak Pandey, Sudipto Paul

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

-----Original Message-----
From: Krzysztof Koch <krzysztof.koch@arm.com> 
Sent: 12 June 2019 03:10 PM
To: devel@edk2.groups.io
Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com; michael.d.kinney@intel.com; liming.gao@intel.com; Sami Mujawar <Sami.Mujawar@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>; Stephanie Hughes-Fitt <Stephanie.Hughes-Fitt@arm.com>; nd <nd@arm.com>
Subject: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3

This patch adds a number of definitions to the ACPI 6.3 header file for the purpose of parsing Revision 3 of the System Resource Affinity Table
(SRAT) in the Acpiview UEFI shell tool.

By defining the Generic Initiator Affinity Structure's Type ID and the allowed Device Handle Types for the structure, it is possible to dump and validate the contents of the latest version of the SRAT table in acpiview.

References:
- ACPI 6.3 January 2019, Section 5.2.16.6

Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/tree/582_acpiview_6_3_srat_v1

Krzysztof Koch (2):
  MdePkg: Add Generic Initiator Affinity Structure definitions to SRAT
  ShellPkg: acpiview: Update SRAT parser to ACPI 6.3

 MdePkg/Include/IndustryStandard/Acpi63.h                               |  11 +-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c              |  35 ++-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h              |  16 ++
 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c | 256 +++++++++++++++++++-
 4 files changed, 309 insertions(+), 9 deletions(-)

--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3
  2019-10-21 16:06 ` Sami Mujawar
@ 2019-11-01 13:59   ` Sudipto Paul
  2019-11-04  2:12     ` Gao, Zhichao
  0 siblings, 1 reply; 8+ messages in thread
From: Sudipto Paul @ 2019-11-01 13:59 UTC (permalink / raw)
  To: Sami Mujawar, Krzysztof Koch, devel@edk2.groups.io
  Cc: jaben.carsey@intel.com, ray.ni@intel.com, zhichao.gao@intel.com,
	michael.d.kinney@intel.com, liming.gao@intel.com, Matteo Carlini,
	nd, Deepak Pandey

Tested-by: Sudipto Paul <sudipto.paul@arm.com

This patch has been tested on N1SDP. This is a public Neoverse branded cores System Development Platform.
https://community.arm.com/developer/tools-software/oss-platforms/w/docs/440/neoverse-n1-sdp


-Sudipto

-----Original Message-----
From: Sami Mujawar <Sami.Mujawar@arm.com>
Sent: 21 October 2019 17:06
To: Krzysztof Koch <Krzysztof.Koch@arm.com>; devel@edk2.groups.io
Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com; michael.d.kinney@intel.com; liming.gao@intel.com; Matteo Carlini <Matteo.Carlini@arm.com>; nd <nd@arm.com>; Deepak Pandey <Deepak.Pandey@arm.com>; Sudipto Paul <Sudipto.Paul@arm.com>
Subject: RE: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

-----Original Message-----
From: Krzysztof Koch <krzysztof.koch@arm.com>
Sent: 12 June 2019 03:10 PM
To: devel@edk2.groups.io
Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com; michael.d.kinney@intel.com; liming.gao@intel.com; Sami Mujawar <Sami.Mujawar@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>; Stephanie Hughes-Fitt <Stephanie.Hughes-Fitt@arm.com>; nd <nd@arm.com>
Subject: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3

This patch adds a number of definitions to the ACPI 6.3 header file for the purpose of parsing Revision 3 of the System Resource Affinity Table
(SRAT) in the Acpiview UEFI shell tool.

By defining the Generic Initiator Affinity Structure's Type ID and the allowed Device Handle Types for the structure, it is possible to dump and validate the contents of the latest version of the SRAT table in acpiview.

References:
- ACPI 6.3 January 2019, Section 5.2.16.6

Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/tree/582_acpiview_6_3_srat_v1

Krzysztof Koch (2):
  MdePkg: Add Generic Initiator Affinity Structure definitions to SRAT
  ShellPkg: acpiview: Update SRAT parser to ACPI 6.3

 MdePkg/Include/IndustryStandard/Acpi63.h                               |  11 +-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c              |  35 ++-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h              |  16 ++
 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c | 256 +++++++++++++++++++-
 4 files changed, 309 insertions(+), 9 deletions(-)

--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3
  2019-11-01 13:59   ` Sudipto Paul
@ 2019-11-04  2:12     ` Gao, Zhichao
  2019-11-04  3:26       ` Liming Gao
  0 siblings, 1 reply; 8+ messages in thread
From: Gao, Zhichao @ 2019-11-04  2:12 UTC (permalink / raw)
  To: Sudipto Paul, Sami Mujawar, Krzysztof Koch, devel@edk2.groups.io
  Cc: Carsey, Jaben, Ni, Ray, Kinney, Michael D, Gao, Liming,
	Matteo Carlini, nd, Deepak Pandey

Thanks for the T-B.
But the patch has conflict now, can you help to address it? As I know the previous change aims to remove the declaration of the internal used function. So I suggest to remove the declaration of the new added function and move the definition to the location of the declaration.

Thanks,
Zhichao

> -----Original Message-----
> From: Sudipto Paul <Sudipto.Paul@arm.com>
> Sent: Friday, November 1, 2019 9:59 PM
> To: Sami Mujawar <Sami.Mujawar@arm.com>; Krzysztof Koch
> <Krzysztof.Koch@arm.com>; devel@edk2.groups.io
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>; Gao,
> Zhichao <zhichao.gao@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Matteo
> Carlini <Matteo.Carlini@arm.com>; nd <nd@arm.com>; Deepak Pandey
> <Deepak.Pandey@arm.com>
> Subject: RE: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3
> 
> Tested-by: Sudipto Paul <sudipto.paul@arm.com
> 
> This patch has been tested on N1SDP. This is a public Neoverse branded cores
> System Development Platform.
> https://community.arm.com/developer/tools-software/oss-
> platforms/w/docs/440/neoverse-n1-sdp
> 
> 
> -Sudipto
> 
> -----Original Message-----
> From: Sami Mujawar <Sami.Mujawar@arm.com>
> Sent: 21 October 2019 17:06
> To: Krzysztof Koch <Krzysztof.Koch@arm.com>; devel@edk2.groups.io
> Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com;
> michael.d.kinney@intel.com; liming.gao@intel.com; Matteo Carlini
> <Matteo.Carlini@arm.com>; nd <nd@arm.com>; Deepak Pandey
> <Deepak.Pandey@arm.com>; Sudipto Paul <Sudipto.Paul@arm.com>
> Subject: RE: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3
> 
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
> 
> Regards,
> 
> Sami Mujawar
> 
> -----Original Message-----
> From: Krzysztof Koch <krzysztof.koch@arm.com>
> Sent: 12 June 2019 03:10 PM
> To: devel@edk2.groups.io
> Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com;
> michael.d.kinney@intel.com; liming.gao@intel.com; Sami Mujawar
> <Sami.Mujawar@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>;
> Stephanie Hughes-Fitt <Stephanie.Hughes-Fitt@arm.com>; nd <nd@arm.com>
> Subject: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3
> 
> This patch adds a number of definitions to the ACPI 6.3 header file for the
> purpose of parsing Revision 3 of the System Resource Affinity Table
> (SRAT) in the Acpiview UEFI shell tool.
> 
> By defining the Generic Initiator Affinity Structure's Type ID and the allowed
> Device Handle Types for the structure, it is possible to dump and validate the
> contents of the latest version of the SRAT table in acpiview.
> 
> References:
> - ACPI 6.3 January 2019, Section 5.2.16.6
> 
> Changes can be seen at:
> https://github.com/KrzysztofKoch1/edk2/tree/582_acpiview_6_3_srat_v1
> 
> Krzysztof Koch (2):
>   MdePkg: Add Generic Initiator Affinity Structure definitions to SRAT
>   ShellPkg: acpiview: Update SRAT parser to ACPI 6.3
> 
>  MdePkg/Include/IndustryStandard/Acpi63.h                               |  11 +-
>  ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c              |  35 ++-
>  ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h              |  16 ++
>  ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c |
> 256 +++++++++++++++++++-
>  4 files changed, 309 insertions(+), 9 deletions(-)
> 
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> 
> 
> 
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended recipient,
> please notify the sender immediately and do not disclose the contents to any
> other person, use it for any purpose, or store or copy the information in any
> medium. Thank you.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3
  2019-11-04  2:12     ` Gao, Zhichao
@ 2019-11-04  3:26       ` Liming Gao
  2019-11-04  4:28         ` Gao, Zhichao
  0 siblings, 1 reply; 8+ messages in thread
From: Liming Gao @ 2019-11-04  3:26 UTC (permalink / raw)
  To: Gao, Zhichao, Sudipto Paul, Sami Mujawar, Krzysztof Koch,
	devel@edk2.groups.io
  Cc: Carsey, Jaben, Ni, Ray, Kinney, Michael D, Matteo Carlini, nd,
	Deepak Pandey

I see the change in MdePkg has been pushed. So, the remaining discussion is about the change in ShellPkg, right?

Thanks
Liming
>-----Original Message-----
>From: Gao, Zhichao
>Sent: Monday, November 04, 2019 10:13 AM
>To: Sudipto Paul <Sudipto.Paul@arm.com>; Sami Mujawar
><Sami.Mujawar@arm.com>; Krzysztof Koch <Krzysztof.Koch@arm.com>;
>devel@edk2.groups.io
>Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>;
>Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
><liming.gao@intel.com>; Matteo Carlini <Matteo.Carlini@arm.com>; nd
><nd@arm.com>; Deepak Pandey <Deepak.Pandey@arm.com>
>Subject: RE: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3
>
>Thanks for the T-B.
>But the patch has conflict now, can you help to address it? As I know the
>previous change aims to remove the declaration of the internal used function.
>So I suggest to remove the declaration of the new added function and move
>the definition to the location of the declaration.
>
>Thanks,
>Zhichao
>
>> -----Original Message-----
>> From: Sudipto Paul <Sudipto.Paul@arm.com>
>> Sent: Friday, November 1, 2019 9:59 PM
>> To: Sami Mujawar <Sami.Mujawar@arm.com>; Krzysztof Koch
>> <Krzysztof.Koch@arm.com>; devel@edk2.groups.io
>> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>;
>Gao,
>> Zhichao <zhichao.gao@intel.com>; Kinney, Michael D
>> <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>;
>Matteo
>> Carlini <Matteo.Carlini@arm.com>; nd <nd@arm.com>; Deepak Pandey
>> <Deepak.Pandey@arm.com>
>> Subject: RE: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3
>>
>> Tested-by: Sudipto Paul <sudipto.paul@arm.com
>>
>> This patch has been tested on N1SDP. This is a public Neoverse branded
>cores
>> System Development Platform.
>> https://community.arm.com/developer/tools-software/oss-
>> platforms/w/docs/440/neoverse-n1-sdp
>>
>>
>> -Sudipto
>>
>> -----Original Message-----
>> From: Sami Mujawar <Sami.Mujawar@arm.com>
>> Sent: 21 October 2019 17:06
>> To: Krzysztof Koch <Krzysztof.Koch@arm.com>; devel@edk2.groups.io
>> Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com;
>> michael.d.kinney@intel.com; liming.gao@intel.com; Matteo Carlini
>> <Matteo.Carlini@arm.com>; nd <nd@arm.com>; Deepak Pandey
>> <Deepak.Pandey@arm.com>; Sudipto Paul <Sudipto.Paul@arm.com>
>> Subject: RE: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3
>>
>> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
>>
>> Regards,
>>
>> Sami Mujawar
>>
>> -----Original Message-----
>> From: Krzysztof Koch <krzysztof.koch@arm.com>
>> Sent: 12 June 2019 03:10 PM
>> To: devel@edk2.groups.io
>> Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com;
>> michael.d.kinney@intel.com; liming.gao@intel.com; Sami Mujawar
>> <Sami.Mujawar@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>;
>> Stephanie Hughes-Fitt <Stephanie.Hughes-Fitt@arm.com>; nd
><nd@arm.com>
>> Subject: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3
>>
>> This patch adds a number of definitions to the ACPI 6.3 header file for the
>> purpose of parsing Revision 3 of the System Resource Affinity Table
>> (SRAT) in the Acpiview UEFI shell tool.
>>
>> By defining the Generic Initiator Affinity Structure's Type ID and the allowed
>> Device Handle Types for the structure, it is possible to dump and validate
>the
>> contents of the latest version of the SRAT table in acpiview.
>>
>> References:
>> - ACPI 6.3 January 2019, Section 5.2.16.6
>>
>> Changes can be seen at:
>> https://github.com/KrzysztofKoch1/edk2/tree/582_acpiview_6_3_srat_v1
>>
>> Krzysztof Koch (2):
>>   MdePkg: Add Generic Initiator Affinity Structure definitions to SRAT
>>   ShellPkg: acpiview: Update SRAT parser to ACPI 6.3
>>
>>  MdePkg/Include/IndustryStandard/Acpi63.h                               |  11 +-
>>  ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c              |  35
>++-
>>  ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h              |  16
>++
>>  ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c
>|
>> 256 +++++++++++++++++++-
>>  4 files changed, 309 insertions(+), 9 deletions(-)
>>
>> --
>> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
>>
>>
>>
>> IMPORTANT NOTICE: The contents of this email and any attachments are
>> confidential and may also be privileged. If you are not the intended recipient,
>> please notify the sender immediately and do not disclose the contents to
>any
>> other person, use it for any purpose, or store or copy the information in any
>> medium. Thank you.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3
  2019-11-04  3:26       ` Liming Gao
@ 2019-11-04  4:28         ` Gao, Zhichao
  0 siblings, 0 replies; 8+ messages in thread
From: Gao, Zhichao @ 2019-11-04  4:28 UTC (permalink / raw)
  To: Gao, Liming, Sudipto Paul, Sami Mujawar, Krzysztof Koch,
	devel@edk2.groups.io
  Cc: Carsey, Jaben, Ni, Ray, Kinney, Michael D, Matteo Carlini, nd,
	Deepak Pandey

Exactly. The #2 should be updated.

Thanks,
Zhichao

> -----Original Message-----
> From: Gao, Liming
> Sent: Monday, November 4, 2019 11:27 AM
> To: Gao, Zhichao <zhichao.gao@intel.com>; Sudipto Paul
> <Sudipto.Paul@arm.com>; Sami Mujawar <Sami.Mujawar@arm.com>;
> Krzysztof Koch <Krzysztof.Koch@arm.com>; devel@edk2.groups.io
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Matteo Carlini
> <Matteo.Carlini@arm.com>; nd <nd@arm.com>; Deepak Pandey
> <Deepak.Pandey@arm.com>
> Subject: RE: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3
> 
> I see the change in MdePkg has been pushed. So, the remaining discussion is
> about the change in ShellPkg, right?
> 
> Thanks
> Liming
> >-----Original Message-----
> >From: Gao, Zhichao
> >Sent: Monday, November 04, 2019 10:13 AM
> >To: Sudipto Paul <Sudipto.Paul@arm.com>; Sami Mujawar
> ><Sami.Mujawar@arm.com>; Krzysztof Koch <Krzysztof.Koch@arm.com>;
> >devel@edk2.groups.io
> >Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>;
> >Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> ><liming.gao@intel.com>; Matteo Carlini <Matteo.Carlini@arm.com>; nd
> ><nd@arm.com>; Deepak Pandey <Deepak.Pandey@arm.com>
> >Subject: RE: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3
> >
> >Thanks for the T-B.
> >But the patch has conflict now, can you help to address it? As I know
> >the previous change aims to remove the declaration of the internal used
> function.
> >So I suggest to remove the declaration of the new added function and
> >move the definition to the location of the declaration.
> >
> >Thanks,
> >Zhichao
> >
> >> -----Original Message-----
> >> From: Sudipto Paul <Sudipto.Paul@arm.com>
> >> Sent: Friday, November 1, 2019 9:59 PM
> >> To: Sami Mujawar <Sami.Mujawar@arm.com>; Krzysztof Koch
> >> <Krzysztof.Koch@arm.com>; devel@edk2.groups.io
> >> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray
> >> <ray.ni@intel.com>;
> >Gao,
> >> Zhichao <zhichao.gao@intel.com>; Kinney, Michael D
> >> <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>;
> >Matteo
> >> Carlini <Matteo.Carlini@arm.com>; nd <nd@arm.com>; Deepak Pandey
> >> <Deepak.Pandey@arm.com>
> >> Subject: RE: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI
> >> 6.3
> >>
> >> Tested-by: Sudipto Paul <sudipto.paul@arm.com
> >>
> >> This patch has been tested on N1SDP. This is a public Neoverse
> >> branded
> >cores
> >> System Development Platform.
> >> https://community.arm.com/developer/tools-software/oss-
> >> platforms/w/docs/440/neoverse-n1-sdp
> >>
> >>
> >> -Sudipto
> >>
> >> -----Original Message-----
> >> From: Sami Mujawar <Sami.Mujawar@arm.com>
> >> Sent: 21 October 2019 17:06
> >> To: Krzysztof Koch <Krzysztof.Koch@arm.com>; devel@edk2.groups.io
> >> Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com;
> >> michael.d.kinney@intel.com; liming.gao@intel.com; Matteo Carlini
> >> <Matteo.Carlini@arm.com>; nd <nd@arm.com>; Deepak Pandey
> >> <Deepak.Pandey@arm.com>; Sudipto Paul <Sudipto.Paul@arm.com>
> >> Subject: RE: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI
> >> 6.3
> >>
> >> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
> >>
> >> Regards,
> >>
> >> Sami Mujawar
> >>
> >> -----Original Message-----
> >> From: Krzysztof Koch <krzysztof.koch@arm.com>
> >> Sent: 12 June 2019 03:10 PM
> >> To: devel@edk2.groups.io
> >> Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com;
> >> michael.d.kinney@intel.com; liming.gao@intel.com; Sami Mujawar
> >> <Sami.Mujawar@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>;
> >> Stephanie Hughes-Fitt <Stephanie.Hughes-Fitt@arm.com>; nd
> ><nd@arm.com>
> >> Subject: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3
> >>
> >> This patch adds a number of definitions to the ACPI 6.3 header file
> >> for the purpose of parsing Revision 3 of the System Resource Affinity
> >> Table
> >> (SRAT) in the Acpiview UEFI shell tool.
> >>
> >> By defining the Generic Initiator Affinity Structure's Type ID and
> >> the allowed Device Handle Types for the structure, it is possible to
> >> dump and validate
> >the
> >> contents of the latest version of the SRAT table in acpiview.
> >>
> >> References:
> >> - ACPI 6.3 January 2019, Section 5.2.16.6
> >>
> >> Changes can be seen at:
> >>
> https://github.com/KrzysztofKoch1/edk2/tree/582_acpiview_6_3_srat_v1
> >>
> >> Krzysztof Koch (2):
> >>   MdePkg: Add Generic Initiator Affinity Structure definitions to SRAT
> >>   ShellPkg: acpiview: Update SRAT parser to ACPI 6.3
> >>
> >>  MdePkg/Include/IndustryStandard/Acpi63.h                               |  11 +-
> >>  ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c              |  35
> >++-
> >>  ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h              |  16
> >++
> >>
> >> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.
> >> c
> >|
> >> 256 +++++++++++++++++++-
> >>  4 files changed, 309 insertions(+), 9 deletions(-)
> >>
> >> --
> >> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> >>
> >>
> >>
> >> IMPORTANT NOTICE: The contents of this email and any attachments are
> >> confidential and may also be privileged. If you are not the intended
> >> recipient, please notify the sender immediately and do not disclose
> >> the contents to
> >any
> >> other person, use it for any purpose, or store or copy the
> >> information in any medium. Thank you.

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2019-11-04  4:28 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-12 14:10 [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3 Krzysztof Koch
2019-10-21 16:06 ` Sami Mujawar
2019-11-01 13:59   ` Sudipto Paul
2019-11-04  2:12     ` Gao, Zhichao
2019-11-04  3:26       ` Liming Gao
2019-11-04  4:28         ` Gao, Zhichao
  -- strict thread matches above, loose matches on Subject: below --
2019-06-12 14:10 Krzysztof Koch
2019-06-12 12:30 Krzysztof Koch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox