Re: [PATCH v1 1/2] MdePkg: Add Generic Initiator Affinity Structure definitions to SRAT

["Sami Mujawar" <sami.mujawar@arm.com>]

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

-----Original Message-----
From: Krzysztof Koch <krzysztof.koch@arm.com> 
Sent: 12 June 2019 03:11 PM
To: devel@edk2.groups.io
Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com; michael.d.kinney@intel.com; liming.gao@intel.com; Sami Mujawar <Sami.Mujawar@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>; Stephanie Hughes-Fitt <Stephanie.Hughes-Fitt@arm.com>; nd <nd@arm.com>
Subject: [PATCH v1 1/2] MdePkg: Add Generic Initiator Affinity Structure definitions to SRAT

Add Generic Initiator Affinity Structure to the list of recognised System Resource Affinity Table (SRAT) structure types.

Add definitions for Device Handle Types inside the Generic Initiator Affinity Structure.

References:
- ACPI 6.3 January 2019, Table 5-78

Signed-off-by: Krzysztof Koch <krzysztof.koch@arm.com>
---

Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/tree/582_acpiview_6_3_srat_v1

Notes:
    v1:
    - define the SRAT Generic Initiator Affinity Struct type [Krzysztof]
    - define the SRAT Device Handle Types [Krzysztof]

 MdePkg/Include/IndustryStandard/Acpi63.h | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/MdePkg/Include/IndustryStandard/Acpi63.h b/MdePkg/Include/IndustryStandard/Acpi63.h
index a8e011579ffcf070ecdfd2c6726a16d1afd65891..eca1f9357b70f10887e680ff13c97c0beab3600b 100644
--- a/MdePkg/Include/IndustryStandard/Acpi63.h
+++ b/MdePkg/Include/IndustryStandard/Acpi63.h
@@ -639,7 +639,7 @@ typedef struct {
 
 //
 // SRAT structure types.
-// All other values between 0x05 an 0xFF are reserved and
+// All other values between 0x06 an 0xFF are reserved and
 // will be ignored by OSPM.
 //
 #define EFI_ACPI_6_3_PROCESSOR_LOCAL_APIC_SAPIC_AFFINITY  0x00 @@ -647,6 +647,7 @@ typedef struct {
 #define EFI_ACPI_6_3_PROCESSOR_LOCAL_X2APIC_AFFINITY      0x02
 #define EFI_ACPI_6_3_GICC_AFFINITY                        0x03
 #define EFI_ACPI_6_3_GIC_ITS_AFFINITY                     0x04
+#define EFI_ACPI_6_3_GENERIC_INITIATOR_AFFINITY           0x05
 
 ///
 /// Processor Local APIC/SAPIC Affinity Structure Definition @@ -733,6 +734,14 @@ typedef struct {
   UINT32  ItsId;
 } EFI_ACPI_6_3_GIC_ITS_AFFINITY_STRUCTURE;
 
+//
+// Generic Initiator Affinity Structure Device Handle Types // All 
+other values between 0x02 an 0xFF are reserved and // will be ignored 
+by OSPM.
+//
+#define EFI_ACPI_6_3_ACPI_DEVICE_HANDLE     0x00
+#define EFI_ACPI_6_3_PCI_DEVICE_HANDLE      0x01
+
 ///
 /// Device Handle - ACPI
 ///
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'