From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (EUR01-HE1-obe.outbound.protection.outlook.com [40.107.13.40]) by mx.groups.io with SMTP id smtpd.web09.2461.1575632499061653438 for ; Fri, 06 Dec 2019 03:41:40 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=R2hMrN+Y; spf=pass (domain: arm.com, ip: 40.107.13.40, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8svyGepyQe7WwTaPc+Acv9XAVBvCMsugEdI4+DZy27E=; b=R2hMrN+Yh7QBDNR3MsjIX5LRnp0ZXRMNC3iuhi/Wba776HZhCVUyZ/jXX3Nt0y/TquSsrxrwQws51DvJ7sSjddL0+sK1w5VyregxMtI1NCGdaHtFxQh4Pn2LWpR8AUpA59ckWpM6mRcKPQuALpgl+J3ZVjyMPQWVpLUASn9ldhM= Received: from AM6PR08CA0009.eurprd08.prod.outlook.com (2603:10a6:20b:b2::21) by DB6PR0801MB1846.eurprd08.prod.outlook.com (2603:10a6:4:35::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2516.14; Fri, 6 Dec 2019 11:41:36 +0000 Received: from VE1EUR03FT057.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::204) by AM6PR08CA0009.outlook.office365.com (2603:10a6:20b:b2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2516.12 via Frontend Transport; Fri, 6 Dec 2019 11:41:36 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT057.mail.protection.outlook.com (10.152.19.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2495.18 via Frontend Transport; Fri, 6 Dec 2019 11:41:36 +0000 Received: ("Tessian outbound d87d9aeb44be:v37"); Fri, 06 Dec 2019 11:41:36 +0000 X-CR-MTA-TID: 64aa7808 Received: from 5e8c973940c1.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8B5AAC1F-49E7-496A-AAE6-7B8580A8B945.1; Fri, 06 Dec 2019 11:41:30 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5e8c973940c1.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 06 Dec 2019 11:41:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jWpKtDndyZeKe7SHVhBg8gt8mTHU9VmwzSW9BLjHiiSNjIq9BYh1k0aEVSbFkeVtvLwIuutJBASGEZXI/+vWbS8djXiPrM8KOAVjbnPzbvyA7ZdlNkgeAlHExrq/5oEntH9j8ILDPZbKEtiOg+gqoR4/A0zDr9FZVk0i6hyM9RzuGEnGqOlRrCBuIbvoAwxMTbB003y7vnhJDln53pGiN6ZK+W9uqiPnkv4t4QvYxyi0I2yUrNU9JBh0LTcYUz4tFW9zSsHB2sedzQDdi0oPwY1xE8360b+77Vhtf1lIrYYE3sJ3J8om/PPGWqjV3m5xfQg4lJbp+2QFm/e0LRym9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=++hFgIGg5B7Hrx3UL6msiLR++Bgb7ptMS6t9Xbq7jF8=; b=hMTYujb8Z91nGqrLvCTY2GbGqHoxn2UbpADMV6QCosl25palM921i3rbmFfbHbq0ZH2toPNrnPXoaqiZWPLWbroWeqEAHFR5qsDqyudxio91wIinExd5yhvYuv103qFWPHwyeUT+zuGBMbFfAdb1z+HojW6CWht526QCm8Py4xRSK6LpgVQSsLPBO5Zbdokk3zZBHUrackcW2G0IbN6nvh6uYRrSs5FX8JQcrGXUW4wxqZFJWWfEVQAMFBY7YbfkoNXdES5mBAgUyYvXXONCvPBfD3TP4q7IKKqyz3yIxBPAHC2erTFpE0l5+7eRoHFimwFyAZh+Jiu6rgop2Rqzcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=++hFgIGg5B7Hrx3UL6msiLR++Bgb7ptMS6t9Xbq7jF8=; b=FJRetWv98kv44VG46Wff57lIgFvEFRctS1wNC/qpfw2+h816Uge163i9CL/59yO+SvA6y0lq6wAfULV/c5NUgr97Cp4inTBFPjyLMOoPO3u8EKOZuRlUGZAHHRkHfnEdbYYTZmRWzT3+O3rsd8/huiDeRvyBVPvM4bTLIxmqBOc= Received: from DB6PR0802MB2375.eurprd08.prod.outlook.com (10.172.228.142) by DB6PR0802MB2342.eurprd08.prod.outlook.com (10.172.228.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2516.14; Fri, 6 Dec 2019 11:41:29 +0000 Received: from DB6PR0802MB2375.eurprd08.prod.outlook.com ([fe80::a4fa:10cb:41f5:222f]) by DB6PR0802MB2375.eurprd08.prod.outlook.com ([fe80::a4fa:10cb:41f5:222f%12]) with mapi id 15.20.2495.026; Fri, 6 Dec 2019 11:41:29 +0000 From: "Sami Mujawar" To: Leif Lindholm , Ard Biesheuvel CC: "devel@edk2.groups.io" , Laszlo Ersek Subject: Re: [PATCH edk2-platforms 0/2] Platform/ARM/Juno: remove explicit PCIe enumeration Thread-Topic: [PATCH edk2-platforms 0/2] Platform/ARM/Juno: remove explicit PCIe enumeration Thread-Index: AQHVrCShNi2ygf7MCkqJQdLG6aGVjqes8+MAgAAGeRA= Date: Fri, 6 Dec 2019 11:41:29 +0000 Message-ID: References: <20191206110219.32190-1-ard.biesheuvel@linaro.org> <20191206111246.GR7359@bivouac.eciton.net> In-Reply-To: <20191206111246.GR7359@bivouac.eciton.net> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: e27b675c-120f-4b61-9da8-a1bd4a6f5009.2 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Sami.Mujawar@arm.com; x-originating-ip: [217.140.106.52] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: f4a502f8-5da5-4ede-e76a-08d77a414007 X-MS-TrafficTypeDiagnostic: DB6PR0802MB2342:|DB6PR0801MB1846: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273; x-forefront-prvs: 0243E5FD68 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(396003)(136003)(346002)(376002)(39860400002)(366004)(199004)(13464003)(189003)(5660300002)(99286004)(7696005)(76176011)(26005)(86362001)(8936002)(66946007)(66556008)(66446008)(76116006)(52536014)(66476007)(64756008)(81166006)(81156014)(2906002)(14444005)(4326008)(305945005)(25786009)(8676002)(229853002)(9686003)(11346002)(74316002)(54906003)(110136005)(6506007)(53546011)(102836004)(316002)(478600001)(71200400001)(186003)(33656002)(14454004)(55016002)(71190400001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2342;H:DB6PR0802MB2375.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 4LtilsNv2y6Zu8pUBv6ik0YacZZshmLzUaWHlx+ZvKEd/uvXuU3+IR4nMe5dY379zgY11hWpgeMU+6QGUuRi+4ucuKpz3myCQJJy9FEH9Pku0n8IODEugZu1g9rTFmMLDC+4ffM6uhpzYKBiWGYDs66KvsIepv4A2BkG+yeXRdssWRvbUw7SMW5oH6SCdbWOJxpaA0REPABN6CoFPeezaNbEnN3sXFruhdeNCGSZGueYbJX85ynkMcezgvc4bJCMfWESe8dTX00Ltc5NbMH00u21sRYPaYRXk7UPQ98r+ybKel+O7nws3dO4wUVO2LiiZDrLWg1I0yxSTgOM6RdBFk12xt3tjz4Uxc7rl1QwScBVB0etxlh69cobMfved5f6TiEgp2ziD9wvMUM3X/Q5dKAjnt/lkBBnquIiI6jNnYztPZw1O0PeZZ4IVlFjMG3PMtZ0mj3rCLYWvwpAoTwaRb9Yphmpgx3ddH/K4bDmrx4i00mr+SKfc5lrhqQ2nvXb x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2342 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Sami.Mujawar@arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT057.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(136003)(376002)(396003)(346002)(39860400002)(13464003)(40434004)(199004)(189003)(26826003)(478600001)(305945005)(25786009)(74316002)(26005)(6506007)(52536014)(76130400001)(4326008)(70586007)(23726003)(70206006)(22756006)(33656002)(14444005)(46406003)(356004)(5660300002)(76176011)(2906002)(229853002)(8676002)(336012)(107886003)(97756001)(102836004)(81166006)(9686003)(53546011)(86362001)(316002)(99286004)(186003)(81156014)(36906005)(11346002)(54906003)(50466002)(7696005)(14454004)(8936002)(55016002)(110136005);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0801MB1846;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:Pass;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;A:1;MX:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 193adc63-0627-4f99-cfee-08d77a413c37 X-Forefront-PRVS: 0243E5FD68 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VDpbqPglT8TZoo6u1F0Y6UvO2r1yzjhzDM+V8HUwjLMPqp6puDJ/DOCComXup02mOBrph0OYL1Z4aRawYHJ+aM8MtKDsmjGjKH09O9QWlHb/goBCCAthkNhHXNlJxOcoi7lXzDHls913WgiXW/Cb+QsWwZhYcTGNVnfywWjgTyDkJcCMwChTgTItOKtty0pF+B1h3Ru1QsVrREFbH/tiQUeO3pxDEiqiAZ/Wtg+Pga9IkReRzAuYtJxChIBbkgOtqKyN6Z9hrcl5XoFIsI6cYAHapYXf3zofT9/FAEfQWWOcCOiWYespc6g9Wqp19nPolzMbPWwwcr7xlZIxpFnoZw6Ddfu+W+GQtWrhO8j1BUmwZJE7VZ7ETejta28bu6Qqonco+jLMCJ1IqbFWaLkMGLz2liVoErB1F9lYN/6a+vzPrsSKliONZGrioD7WW+F5oOUW2vqKWdhvnRXOrlaMLGBXWxw7L/qWy2pT2Szf1td9lGCl4tI+0EkQNqJ83ipp4b3uB0Wdxl2+K3//F1SOZg== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2019 11:41:36.0886 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f4a502f8-5da5-4ede-e76a-08d77a414007 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1846 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Tested on Juno R2, the MAC address for Marvel Yukon NIC is programmed corre= ctly. Tested-by: Sami Mujawar Regards, Sami Mujawar -----Original Message----- From: Leif Lindholm Sent: 06 December 2019 11:13 AM To: Ard Biesheuvel Cc: devel@edk2.groups.io; Sami Mujawar ; Laszlo Ersek= Subject: Re: [PATCH edk2-platforms 0/2] Platform/ARM/Juno: remove explicit = PCIe enumeration On Fri, Dec 06, 2019 at 11:02:17 +0000, Ard Biesheuvel wrote: > The platform DXE driver of the Juno platform enumerates the PCIe > explicitly by calling ConnectController on the PCIe root bridge, in > order to ensure that all PCI I/O protocols have been instantiated when > we try to locate the one describing the Marvel Yukon NIC, so that we can = program its MAC address. > > Taking control of core firmware behavior like this has already caused > confusion when reasoning about why and when PCIe option ROMs get > dispatched, and is likely to cause more confusion down the road. > > So let's fix this, by triggering the MAC programming via a protocol > notify on the PCI I/O protocol. > > This has been build tested only at the moment. > > Cc: Sami Mujawar > Cc: Laszlo Ersek > Cc: Leif Lindholm This looks sensible to me (and way more can-of-wormish than I would have ex= pected) - so: Acked-by: Leif Lindholm *but* we need tested-by from somewhere before merging 2/2. 1/2 could go in whenever. / Leif > Ard Biesheuvel (2): > Platform/ARM/ArmJunoDxe: make mAcpiRegistration STATIC > Platform/ARM/ArmJunoDxe: use PciIo protocol notify to program the > MAC > > .../JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c | 163 ++++-------------- > .../JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf | 1 - > 2 files changed, 31 insertions(+), 133 deletions(-) > > -- > 2.17.1 > IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.