public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Krzysztof Koch <Krzysztof.Koch@arm.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "jaben.carsey@intel.com" <jaben.carsey@intel.com>,
	"ray.ni@intel.com" <ray.ni@intel.com>,
	"zhichao.gao@intel.com" <zhichao.gao@intel.com>, nd <nd@arm.com>
Subject: Re: [PATCH v1 0/5] Clean up acpiview input parameters
Date: Tue, 2 Jul 2019 08:44:20 +0000	[thread overview]
Message-ID: <DB6PR0802MB2375F4C78877AD01A998AEBB84F80@DB6PR0802MB2375.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20190628085700.17472-1-krzysztof.koch@arm.com>

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

-----Original Message-----
From: Krzysztof Koch <krzysztof.koch@arm.com> 
Sent: 28 June 2019 09:57 AM
To: devel@edk2.groups.io
Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com; Sami Mujawar <Sami.Mujawar@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>; nd <nd@arm.com>
Subject: [PATCH v1 0/5] Clean up acpiview input parameters

The following patches modify the user interface to the Acpiview UEFI shell tool.

These changes are aimed to simplify interaction with the tool as well as to remove redundant/non-functional command line parameters.

Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/tree/612_acpiview_flags_fix_v1

Krzysztof Koch (5):
  ShellPkg: acpiview: Remove '/?' from valid command line flags
  ShellPkg: acpiview: Fix '\n\n' printing in Table Checksum reporting
  ShellPkg: acpiview: Allow disabling consistency checks (-q flag)
  ShellPkg: acpiview: Remove '-v' flag from allowed command line args
  ShellPkg: acpiview: Make '-h' option not require a parameter

 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c                    | 14 ++--
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.c               |  6 +-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c                      | 71 ++++++++++----------
 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.h                      | 23 ++++++-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni |  9 +--
 5 files changed, 74 insertions(+), 49 deletions(-)

--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



      parent reply	other threads:[~2019-07-02  8:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-28  8:56 [PATCH v1 0/5] Clean up acpiview input parameters Krzysztof Koch
2019-06-28  8:56 ` [PATCH v1 1/5] ShellPkg: acpiview: Remove '/?' from valid command line flags Krzysztof Koch
2019-06-28 11:06   ` [edk2-devel] " Alexei Fedorov
2019-06-28  8:56 ` [PATCH v1 2/5] ShellPkg: acpiview: Fix '\n\n' printing in Table Checksum reporting Krzysztof Koch
2019-06-28 11:06   ` [edk2-devel] " Alexei Fedorov
2019-06-28  8:56 ` [PATCH v1 3/5] ShellPkg: acpiview: Allow disabling consistency checks (-q flag) Krzysztof Koch
2019-06-28 11:06   ` [edk2-devel] " Alexei Fedorov
2019-06-28  8:56 ` [PATCH v1 4/5] ShellPkg: acpiview: Remove '-v' flag from allowed command line args Krzysztof Koch
2019-06-28 11:06   ` [edk2-devel] " Alexei Fedorov
2019-06-28  8:57 ` [PATCH v1 5/5] ShellPkg: acpiview: Make '-h' option not require a parameter Krzysztof Koch
2019-06-28 11:05   ` [edk2-devel] " Alexei Fedorov
2019-06-28 11:07 ` [edk2-devel] [PATCH v1 0/5] Clean up acpiview input parameters Alexei Fedorov
2019-07-01  3:51 ` Gao, Zhichao
2019-07-02  8:44 ` Sami Mujawar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB6PR0802MB2375F4C78877AD01A998AEBB84F80@DB6PR0802MB2375.eurprd08.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox