From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=Jh++hAD8; spf=pass (domain: arm.com, ip: 40.107.14.43, mailfrom: sami.mujawar@arm.com) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (EUR01-VE1-obe.outbound.protection.outlook.com [40.107.14.43]) by groups.io with SMTP; Thu, 18 Jul 2019 05:58:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DDBosuKVU4SmX91C+KMS/7yruCte5ts8hgjXo0zGH+8JecMFHugapyit5ykYz8ZEPlJNKsN0nHSwnVbGQTVcNK4pAiRxbR870wRlQ9ct6iw/ZKdUEKgOoBjZLVfZhOPxZH6EpkHOLZx6h0AjFv/Grfvxxx8RO+UUMj6VqJdHYz1ZgCOPyxrdAnBCRlg7ke35p/jpwwJ+VUorCLoC09C6ZxjnOOuWh2bs9gUNZZmQh3W5zsk4kymoLjwsVv4vIURO9aUqRBKRUQmp/ooVi8imgiqodOn5p9t9Ul3FIEvxuO22gh/A/9/SA/x3FR5W3iT5/T4BhoYLIXAcZPqGHsgjzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+bEIgr0uSQhgFbLaIGASKPr20IZPGj6JiSeHhg4kL0U=; b=Jw+kX//faveRAJ1OgeEdGNWvuyD8WIPLF37dRsLaNexgjjAi6zH/zrqblcXjo4kMLi59tA6+ogvjF0u77JDRza37bVffQUImnRm2rqYKPk3mo04Lb/RwYwTWDDHhrFdiiR3e+j7zDo9ftGSvvCxQpqlo05rhyJR9iRriKbpYHRXUUsbwA4kajX+zqSSdW0f6vP357InVLmwB5RWOMFGGvpvl5hpubnaILk/vi0mlLzCCwoVoUStKIl12FYzrdVIoML3zhKg+yKHVwCyfxRN74D8xP/yevoRQTBbbI46hRU/Yyovc7UXV7Kv7EbXhygNVTjRpPcS39QN+7SAqz6SCoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=arm.com;dmarc=pass action=none header.from=arm.com;dkim=pass header.d=arm.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+bEIgr0uSQhgFbLaIGASKPr20IZPGj6JiSeHhg4kL0U=; b=Jh++hAD869HcAduMsyJrHNZPv34VBxK//09FRjbnmmwTLgLuG90ZiKEG0XitHs8VyKEHk86f4ov5yFbDwHY1IasFQLDFhHIKZryNLWjYeKUqhnfOadH80sX139ml0AgeO0POCzQbaHWFnPTn+Yk72PiY0BYJdvT9LVpjPfnShNc= Received: from DB6PR0802MB2375.eurprd08.prod.outlook.com (10.172.228.142) by DB6PR0802MB2280.eurprd08.prod.outlook.com (10.172.225.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2073.10; Thu, 18 Jul 2019 12:58:34 +0000 Received: from DB6PR0802MB2375.eurprd08.prod.outlook.com ([fe80::f9c1:cd3e:68a0:7eca]) by DB6PR0802MB2375.eurprd08.prod.outlook.com ([fe80::f9c1:cd3e:68a0:7eca%8]) with mapi id 15.20.2073.015; Thu, 18 Jul 2019 12:58:34 +0000 From: "Sami Mujawar" To: Krzysztof Koch , "devel@edk2.groups.io" CC: "jaben.carsey@intel.com" , "ray.ni@intel.com" , "zhichao.gao@intel.com" , Matteo Carlini , nd Subject: Re: [PATCH v1 0/6] Acpiview table parsers code style enhancements and refactoring Thread-Topic: [PATCH v1 0/6] Acpiview table parsers code style enhancements and refactoring Thread-Index: AQHVPWTHF3YiHQnnyUOdzPees0vMg6bQVhAw Date: Thu, 18 Jul 2019 12:58:33 +0000 Message-ID: References: <20190718123142.5696-1-krzysztof.koch@arm.com> In-Reply-To: <20190718123142.5696-1-krzysztof.koch@arm.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 5529bc1f-eaa6-444a-92a4-c09c87eb3ec3.1 x-checkrecipientchecked: true authentication-results: spf=none (sender IP is ) smtp.mailfrom=Sami.Mujawar@arm.com; x-originating-ip: [217.140.106.54] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4908d999-0d35-43a0-f79d-08d70b7fa43c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:DB6PR0802MB2280; x-ms-traffictypediagnostic: DB6PR0802MB2280: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: nodisclaimer: True x-ms-oob-tlc-oobclassifiers: OLM:6430; x-forefront-prvs: 01026E1310 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(136003)(376002)(346002)(366004)(396003)(39860400002)(199004)(189003)(13464003)(81156014)(316002)(81166006)(110136005)(478600001)(256004)(55016002)(68736007)(66946007)(71190400001)(14454004)(7736002)(86362001)(486006)(2906002)(11346002)(966005)(186003)(2501003)(54906003)(5660300002)(25786009)(446003)(4326008)(8676002)(8936002)(76176011)(102836004)(66066001)(7696005)(52536014)(6246003)(476003)(26005)(99286004)(53546011)(3846002)(6506007)(6116002)(66476007)(53936002)(66556008)(71200400001)(66446008)(6306002)(6436002)(76116006)(229853002)(305945005)(64756008)(9686003)(33656002)(74316002);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2280;H:DB6PR0802MB2375.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: HVoWltTs/jcXbEkEmU4EfJ27BkmIWQ099QwThZhHrzTvB5AD3Aj/QK3UxZm8XxUwxt0QKyrcDGz8pOBcuVMMUvGDjM7Y13IKzTuW2KKzrWwBh6uhHT500XFurCBON16p9jer+JWgbqPife7yMQdnn1trbvQmlYRXJdZYrFEkNtUG8XfJXruR9PqReVsGIUhm4NsZgs21tgQ/BqjHTlgswjBuCUCW1j/3yaxm7kFrvKmXjqngrMKi+NoWlzC1L9f8Ni50skXFC7xsLrVAJ7SAhfcgZGc8Slf9zMHxhKlEvqP87HSXF7BN1WAjvFvL9+dXEH1+nCixppjCcyqjW/s4Smrh7FjiCuShF5mpYF8EU0OOQyQ+WGLWDvVbOhqLS2MwaDfkzNhEDyB7iHQ26tlVUi40NCr9jFXWXnl0jGvJyj0= MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4908d999-0d35-43a0-f79d-08d70b7fa43c X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2019 12:58:33.9036 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Sami.Mujawar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2280 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sami Mujawar -----Original Message----- From: Krzysztof Koch =20 Sent: 18 July 2019 01:32 PM To: devel@edk2.groups.io Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com; Sami M= ujawar ; Matteo Carlini ; nd = Subject: [PATCH v1 0/6] Acpiview table parsers code style enhancements and = refactoring This set of patches consists of a number of changes which make the code str= ucture consistent across the existing ACPI table parsers. These are all ref= actoring changes which do not modify the existing functionality of the acpi= view UEFI shell tool. Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/tree/612_acp= iview_code_style_enhance_v1 Krzysztof Koch (6): ShellPkg: acpiview: Allow passing buffer length to DumpGasStruct() ShellPkg: acpiview: XSDT: Remove redundant ParseAcpi() call ShellPkg: acpiview: RSDP: Make code consistent with other parsers ShellPkg: acpiview: SRAT: Minor code style enhancements ShellPkg: acpiview: MADT: Split structure length validation ShellPkg: acpiview: IORT: Refactor PMCG node mapping count validation ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 2= 6 +++++++++------- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h | = 8 +++-- ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parser.c | = 2 +- ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.= c | 32 ++++++++++++++------ ShellPkg/Library/UefiShellAcpiViewCommandLib/P= arsers/Madt/MadtParser.c | 30 +++++++++++++----- ShellPkg/Library/UefiShel= lAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.c | 11 +++++-- ShellPkg/Librar= y/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c | 3 +- ShellPkg/L= ibrary/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.c | 18 +++------= -- 8 files changed, 82 insertions(+), 48 deletions(-) -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'