From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a01:111:f400:fe07::602; helo=eur02-am5-obe.outbound.protection.outlook.com; envelope-from=supreeth.venkatesh@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02on0602.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe07::602]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 66F6621962301 for ; Tue, 27 Nov 2018 06:37:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ESBsvAg1o5WY6lVd+6OOrl7s613P0YVRwdsy9TESxs0=; b=q7P7WJAKBovjSDPZhhFAZTfEgFXmKWyHTMLiCoIa7gXOSZRtN1mFRhYD4thFP9OJekZ3ypk8q7ziw9Lv5PHVI9tHeek7vP/VnBas/OeNvlE6N7G4a/3lk8B/j0W8uCYDzq8X2b1zEX3NkyVT+3n7Vm8Uy6piLboR4xYeFuoKKSo= Received: from DB6PR08MB2790.eurprd08.prod.outlook.com (10.170.222.145) by DB6PR08MB2822.eurprd08.prod.outlook.com (10.170.222.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1361.19; Tue, 27 Nov 2018 14:37:21 +0000 Received: from DB6PR08MB2790.eurprd08.prod.outlook.com ([fe80::a44c:e620:5dc3:983a]) by DB6PR08MB2790.eurprd08.prod.outlook.com ([fe80::a44c:e620:5dc3:983a%3]) with mapi id 15.20.1361.019; Tue, 27 Nov 2018 14:37:21 +0000 From: Supreeth Venkatesh To: Lokesh Belathur Veerappa CC: "eric.jin@intel.com" , "edk2-devel@lists.01.org" Thread-Topic: [edk2-test][PATCH] SctPkg/Tools: Fix incorrect line ending detection by GenBin tool Thread-Index: AQHUgJ1RFiSRUA2b+UmLUQ0fHQOspqViiPLQgADFd4CAAG0JcA== Date: Tue, 27 Nov 2018 14:37:21 +0000 Message-ID: References: <1542696618-2284-1-git-send-email-lokesh.bv@arm.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Supreeth.Venkatesh@arm.com; x-originating-ip: [2600:1700:8c61:400:e13b:d8cf:af87:d49] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB6PR08MB2822; 6:nuS6IJ5+I7O3qbvVmVYnhTqR01C/fqPrNyllWJkfZBeZ/4YiULwvHL4D0pyUVslu5FSYXbq4rvUNRGsN9xae6iZTY0tSX2VeskhRendI/8D3Bu5aaVJ6CWTriRbbliCCsgdz/hU+09pdPFT6qSqnelAtJHksQrPKGMLmVXy9aYXt1XwUCPNTAfeA9oQgla/r/pdNFC/HOf47Mn7VpEz6nRsYq3eClMhBQwESLXl57lT2/6DSg1K4ckC8UYNHnmm+AWeyq9JeTJqpwoP5pfyoPbOIg6NI+KLMqZIHswEU6tXYD/ar/fKzQXpjywcEzsjx/nILaNFkpfuM1WuDParutsUmUfTYt7WOpOGFLfoNgfwyECozbDHIbOMxxeQpCAjSEHCztkmzpyxnjbVKJR04M+2LxzKUL/0pVIcAHQ1AwCKBDna+s5nM7BJKuavufSDVDVGFHqXtrebg91MiqC1LOQ==; 5:+c1MHZJkQdtV0WBiW3w9rt8RIJtzbOZMlj2e/a6n1WMr4WOyPbxa/AsVwQqIJAM8HYXhBsb8sXO+ZywkQFTL7EEKF6bz30VAV4C9Cc12jjEVR/zpoDaViHbNql5RsYtPRmXtYxLDRZdbOoJt7ziJQ+M5+2jj8BM7k+jtg/1YFoM=; 7:eKxFZ7mCVlvrkdUPojS/miVtgqRMvMnyXIUGollFKnlq5qRI5RT0XUiP5F9XOuc/djUnEqvEX9pNt0yELHVQLHpe1ngeU+V+kJRZKclLsPFacAnEdxlUn9PNru8QG+tLlgGBHFpmWwhQnr3TlWGIrw== x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-correlation-id: 45c38c97-0fb0-468b-aa44-08d65475d73f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:DB6PR08MB2822; x-ms-traffictypediagnostic: DB6PR08MB2822: x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231443)(944501410)(52105112)(93006095)(93001095)(10201501046)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201708071742011)(7699051)(76991095); SRVR:DB6PR08MB2822; BCL:0; PCL:0; RULEID:; SRVR:DB6PR08MB2822; x-forefront-prvs: 086943A159 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(366004)(346002)(39860400002)(136003)(396003)(40434004)(189003)(199004)(13464003)(46003)(486006)(14444005)(14454004)(2906002)(5024004)(11346002)(186003)(74316002)(81156014)(6636002)(9686003)(81166006)(8676002)(8936002)(99286004)(476003)(305945005)(55016002)(86362001)(102836004)(72206003)(7736002)(54906003)(53546011)(6436002)(478600001)(68736007)(229853002)(6116002)(316002)(7696005)(6506007)(53936002)(71190400001)(97736004)(105586002)(106356001)(76176011)(5660300001)(256004)(446003)(25786009)(4326008)(6862004)(71200400001)(33656002)(6246003); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR08MB2822; H:DB6PR08MB2790.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: Ql0WR8hSvq6PJN4cVLiEcfn68qERe9CNQKToDTw1sca17pNPKWuCH6uo2OvUxvsg1PqUhY8yFsmXp6/ZbZ5pYeJR8CO7mW/MXG8EGc+Mv2h3XV6xvK0maCbyeN/NxRBOksI6cf3B17BO9L55rX+zPaoO4hFBKhfbB2Ph2XUn8F89/nOOl7lTcwilff03dAmVRp0+s/CBjxIY1Iq6YhvnOwZu1Mo+OpldtPz7aBCX/CeHwZXrGZCRtU0sxXmiDscHKEa+xW9hQly6Ri1fW5GEOJ6Hbb8wFDQpFDlXcSXCP3fxMkywD7iuQF0izxN5QGi5Uy1ZPNHdDEF6SxgY4T0dRM15BroNFJBcbNV5qSBO1IM= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 45c38c97-0fb0-468b-aa44-08d65475d73f X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Nov 2018 14:37:21.7903 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2822 Subject: Re: [edk2-test][PATCH] SctPkg/Tools: Fix incorrect line ending detection by GenBin tool X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2018 14:37:25 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Lokesh, I had applied the GenBin tool rebuild patch before this. I will check again on my side but please recheck on your side. Thanks, Supreeth -----Original Message----- From: Lokesh Belathur Veerappa Sent: Tuesday, November 27, 2018 2:04 AM To: Supreeth Venkatesh ; edk2-devel@lists.01.or= g; eric.jin@intel.com Subject: RE: [edk2-test][PATCH] SctPkg/Tools: Fix incorrect line ending det= ection by GenBin tool Hi Supreeth, The 'GenBin' tool has to be rebuilt with this change. The GenBin tool buil= d support is added in the patch "[edk2-test][PATCH] SctPkg/build: Add suppo= rt for GenBin tool build". I will upload a single patch which includes both the changes. Please verify= and merge it. Thanks, Lokesh -----Original Message----- From: Supreeth Venkatesh Sent: Tuesday, November 27, 2018 1:56 AM To: Lokesh Belathur Veerappa ; edk2-devel@lists.01.org; = eric.jin@intel.com Cc: Lokesh Belathur Veerappa Subject: RE: [edk2-test][PATCH] SctPkg/Tools: Fix incorrect line ending det= ection by GenBin tool With the latest edk2, I am getting this compilation error (even when this p= atch is applied). I will be looking at it tomorrow. Please check this out if you get a chance= . GenBin /data/users/supreeth/supven01/work/sct_workspace/edk2/SctPkg/TestCa= se/UEFI/EFI/Protocol/Decompress/BlackBoxTest/Dependency/UncompressedFile2/U= ncompressedFile2.ini /data/users/supreeth/supven01/work/sct_workspace/edk2/= Build/UefiSct/DEBUG_GCC49/AARCH64/Decompress_UncompressedFile2.ucmp Error: Invalid format (Line 30) Error: Cannot generate the binary file GNUmakefile:232: recipe for target '/data/users/supreeth/supven01/work/sct_= workspace/edk2/Build/UefiSct/DEBUG_GCC49/AARCH64/Decompress_UncompressedFil= e2.ucmp' failed make: *** [/data/users/supreeth/supven01/work/sct_workspace/edk2/Build/Uefi= Sct/DEBUG_GCC49/AARCH64/Decompress_UncompressedFile2.ucmp] Error 255 build.py... : error 7000: Failed to execute command make tbuild [/data/users/supreeth/supven01/work/sct_workspace/edk2/Build/Ue= fiSct/DEBUG_GCC49/AARCH64/SctPkg/TestCase/UEFI/EFI/Protocol/Decompress/Blac= kBoxTest/Dependency/UncompressedFile2/UncompressedFile2] Thanks, Supreeth -----Original Message----- From: Lokesh B V Sent: Tuesday, November 20, 2018 12:50 AM To: edk2-devel@lists.01.org; Supreeth Venkatesh ; eric.jin@intel.com Cc: Lokesh Belathur Veerappa Subject: [edk2-test][PATCH] SctPkg/Tools: Fix incorrect line ending detecti= on by GenBin tool Some windows editors uses "\r\n" for line feed. While processing uefi testc= ase info file, the GenBin tool logic to skip line feed doesn't consider the= presence of carraige return(\r) in line feed. So this results in incorrect= format error. Signed-off-by: Lokesh B V --- uefi-sct/SctPkg/Tools/Source/GenBin/GenBin.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/uefi-sct/SctPkg/Tools/Source/GenBin/GenBin.c b/uefi-sct/SctPkg= /Tools/Source/GenBin/GenBin.c index 61bb35b..ce271a1 100644 --- a/uefi-sct/SctPkg/Tools/Source/GenBin/GenBin.c +++ b/uefi-sct/SctPkg/Tools/Source/GenBin/GenBin.c @@ -176,6 +176,7 @@ Trim ( for (Index1 =3D 0; Index1 < Length; Index1++) { if ((String[Index1] !=3D ' ' ) && (String[Index1] !=3D '\t') && + (String[Index1] !=3D '\r') && (String[Index1] !=3D '\n')) { break; } @@ -193,6 +194,7 @@ Trim ( for (Index1 =3D 0; Index1 < Length; Index1++) { if ((String[Length - 1 - Index1] !=3D ' ' ) && (String[Length - 1 - Index1] !=3D '\t') && + (String[Length - 1 - Index1] !=3D '\r') && (String[Length - 1 - Index1] !=3D '\n')) { break; } -- 2.7.4 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.