From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.107.8.72; helo=eur04-vi1-obe.outbound.protection.outlook.com; envelope-from=supreeth.venkatesh@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80072.outbound.protection.outlook.com [40.107.8.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EB18821195913 for ; Mon, 26 Nov 2018 12:26:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IK9X0TzHQldxVMiwR1/2VpJkL70o1gkXt8uYQhLBRdA=; b=NwZkYzTFcyv3jC4L/aKblxPuiHpz+Qhp2DESxbyGI9GlVtE7if4JaamgL2QAelcAZn6J4JtVbEU5D56Nq3coraNYt+S+wMZCmYVl9k3Ns4RO64lC0UpJ2G3q0VQdkHYaHf74aPkSrziXQmMwci8o5DdoT+yjnbcNlcWknlfFFo8= Received: from DB6PR08MB2790.eurprd08.prod.outlook.com (10.170.222.145) by DB6PR08MB2824.eurprd08.prod.outlook.com (10.175.234.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1361.19; Mon, 26 Nov 2018 20:26:09 +0000 Received: from DB6PR08MB2790.eurprd08.prod.outlook.com ([fe80::a44c:e620:5dc3:983a]) by DB6PR08MB2790.eurprd08.prod.outlook.com ([fe80::a44c:e620:5dc3:983a%3]) with mapi id 15.20.1361.019; Mon, 26 Nov 2018 20:26:09 +0000 From: Supreeth Venkatesh To: Lokesh Belathur Veerappa , "edk2-devel@lists.01.org" , "eric.jin@intel.com" Thread-Topic: [edk2-test][PATCH] SctPkg/Tools: Fix incorrect line ending detection by GenBin tool Thread-Index: AQHUgJ1RFiSRUA2b+UmLUQ0fHQOspqViiPLQ Date: Mon, 26 Nov 2018 20:26:09 +0000 Message-ID: References: <1542696618-2284-1-git-send-email-lokesh.bv@arm.com> In-Reply-To: <1542696618-2284-1-git-send-email-lokesh.bv@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Supreeth.Venkatesh@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB6PR08MB2824; 6:hVe2Ub9A+yS2qmbvJuF1DxPhcwMAsF1i7MNicCuSOi750ijhB7in3KqukEoU3U8iBMjTVfkqePTgEDQd6Nu+biXjiXSiRthZUSpduEpXK458e5AwCSAQVv4ZBrlxBXkAru03djdEIjaeHQTEcVgNVdFUSwVYohWiK2Czt2vh/S73+OZreA7jNRkyjCiD7wTPAvJqnVugAxC7G7DiuaBFOrwrdRtdzTLyBNZ0HEYNg1kFYzTaL9PqoiPXMFkYCTo1d0JtIhLOc8pMJMql0CuPP5feKOO+5wVaBTNX3mCqBOABdbV8VSQtJBrKWnleyxM42YCJiYqzJqH2M88/TywmSuXOzlX8N64F3QL8bNgnmV7jgyhVZtcEbKYbYA+hzgB7x+VH3BaJjTS/JninpsnOTMnCwQPXlAZuI66QQ4NC6q/p0/JkxpHy9Qro7TodlISt8jq7jSpSDPxyXJdcQLufig==; 5:ZrA5OP43wPldLdufa/MotplesJX7vH8VfcI0sSErkt3YSgSE7Sy6/pwypkcZId94cz1slz4MchVl1rOEiGEgvmD8jLExxnsv9xEKcQus0PlHLKzAvjuzC5QiywgK4jJ5JjkIPsHTKD02RLsZfQTgLutgDkzSnGlawCsSTZVYf00=; 7:stEUAOM2usi/fpyxy8UHs74XraZO/efvwj8L6+38xy1sJSxDgAarkGfM5UAUe/Of4HRXXNpM6rl1TrIUrLL7YPgjXLj4mJd/zeADiJ8MyKhJLBBaOMEw5Z7yW1jYoAZ+QkRAWXKAwW6sxuGMRcvChw== x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-correlation-id: ad582b99-51d2-4451-5691-08d653dd66e3 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:DB6PR08MB2824; x-ms-traffictypediagnostic: DB6PR08MB2824: x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(3231443)(944501410)(52105112)(6055026)(148016)(149066)(150057)(6041310)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(201708071742011)(7699051)(76991095); SRVR:DB6PR08MB2824; BCL:0; PCL:0; RULEID:; SRVR:DB6PR08MB2824; x-forefront-prvs: 086831DFB4 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(136003)(346002)(396003)(376002)(39860400002)(189003)(199004)(40434004)(13464003)(14454004)(14444005)(5024004)(6436002)(71190400001)(71200400001)(53546011)(7696005)(81156014)(76176011)(186003)(26005)(6506007)(229853002)(81166006)(8936002)(102836004)(305945005)(256004)(476003)(11346002)(446003)(486006)(55016002)(2201001)(33656002)(9686003)(3846002)(6116002)(97736004)(86362001)(25786009)(105586002)(5660300001)(2501003)(68736007)(4326008)(7736002)(53936002)(478600001)(74316002)(110136005)(8676002)(99286004)(66066001)(316002)(6246003)(72206003)(2906002)(106356001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR08MB2824; H:DB6PR08MB2790.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: crX3obAe3AquBJxLgzyCjGP9BG8cWWyOvLAXmodYpMNAFqR3joVRV823kaGKWe2bHepIMMClw3YlAnCCezLZHTjw5u0GV0W2rMsKf1r2MIVxo+f9xv3UFMP+A+04THN/BR3ahL2P3GYuavYQoo3FNGHDFnQMwgm91g6rOQUXABHpsexxUkl26r7PAqoNeTxZNCjxTQbtYdP9mHQqOAa06GL9DzxVJLw/lkBgmDjZ3spWezlfyGbjUTDj2Jd1poNyP5zTi+AM2QrLqTBy/ID1G12yK6kiCZgfVVOsMwZRCuFxG+tdGnJygnLcH61U1xoRDcuJcZT4m/n6gZA/HbNEZQuVhhqYB7UrtPEVrZfMN3c= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad582b99-51d2-4451-5691-08d653dd66e3 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Nov 2018 20:26:09.7775 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2824 Subject: Re: [edk2-test][PATCH] SctPkg/Tools: Fix incorrect line ending detection by GenBin tool X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Nov 2018 20:26:13 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable With the latest edk2, I am getting this compilation error (even when this p= atch is applied). I will be looking at it tomorrow. Please check this out if you get a chance= . GenBin /data/users/supreeth/supven01/work/sct_workspace/edk2/SctPkg/TestCa= se/UEFI/EFI/Protocol/Decompress/BlackBoxTest/Dependency/UncompressedFile2/U= ncompressedFile2.ini /data/users/supreeth/supven01/work/sct_workspace/edk2/= Build/UefiSct/DEBUG_GCC49/AARCH64/Decompress_UncompressedFile2.ucmp Error: Invalid format (Line 30) Error: Cannot generate the binary file GNUmakefile:232: recipe for target '/data/users/supreeth/supven01/work/sct_= workspace/edk2/Build/UefiSct/DEBUG_GCC49/AARCH64/Decompress_UncompressedFil= e2.ucmp' failed make: *** [/data/users/supreeth/supven01/work/sct_workspace/edk2/Build/Uefi= Sct/DEBUG_GCC49/AARCH64/Decompress_UncompressedFile2.ucmp] Error 255 build.py... : error 7000: Failed to execute command make tbuild [/data/users/supreeth/supven01/work/sct_workspace/edk2/Build/Ue= fiSct/DEBUG_GCC49/AARCH64/SctPkg/TestCase/UEFI/EFI/Protocol/Decompress/Blac= kBoxTest/Dependency/UncompressedFile2/UncompressedFile2] Thanks, Supreeth -----Original Message----- From: Lokesh B V Sent: Tuesday, November 20, 2018 12:50 AM To: edk2-devel@lists.01.org; Supreeth Venkatesh ; eric.jin@intel.com Cc: Lokesh Belathur Veerappa Subject: [edk2-test][PATCH] SctPkg/Tools: Fix incorrect line ending detecti= on by GenBin tool Some windows editors uses "\r\n" for line feed. While processing uefi testc= ase info file, the GenBin tool logic to skip line feed doesn't consider the= presence of carraige return(\r) in line feed. So this results in incorrect= format error. Signed-off-by: Lokesh B V --- uefi-sct/SctPkg/Tools/Source/GenBin/GenBin.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/uefi-sct/SctPkg/Tools/Source/GenBin/GenBin.c b/uefi-sct/SctPkg= /Tools/Source/GenBin/GenBin.c index 61bb35b..ce271a1 100644 --- a/uefi-sct/SctPkg/Tools/Source/GenBin/GenBin.c +++ b/uefi-sct/SctPkg/Tools/Source/GenBin/GenBin.c @@ -176,6 +176,7 @@ Trim ( for (Index1 =3D 0; Index1 < Length; Index1++) { if ((String[Index1] !=3D ' ' ) && (String[Index1] !=3D '\t') && + (String[Index1] !=3D '\r') && (String[Index1] !=3D '\n')) { break; } @@ -193,6 +194,7 @@ Trim ( for (Index1 =3D 0; Index1 < Length; Index1++) { if ((String[Length - 1 - Index1] !=3D ' ' ) && (String[Length - 1 - Index1] !=3D '\t') && + (String[Length - 1 - Index1] !=3D '\r') && (String[Length - 1 - Index1] !=3D '\n')) { break; } -- 2.7.4 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.