public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH edk2-platforms v1 0/3][platforms/devel-dynamictables] Update for ACPICA compiler enhancements
@ 2018-04-27 14:58 Sami Mujawar
  2018-04-27 14:58 ` [PATCH edk2-platforms v1 1/3][platforms/devel-dynamictables] Platform/ARM: Match asl compiler output for Juno Sami Mujawar
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Sami Mujawar @ 2018-04-27 14:58 UTC (permalink / raw)
  To: edk2-devel
  Cc: Arvind Chauhan, Daniil Egranov, Thomas Panakamattam Abraham,
	ard.biesheuvel, leif.lindholm, Matteo.Carlini,
	Stephanie.Hughes-Fitt, nd

The ACPICA iAsl compiler has recently been enhanced to support a
feature required by Dynamic Tables Framework for processing ASL
files. The compiler however generates slightly different symbol
names to what was previously referenced in the Configuration Manager.

This patchset adapts to the latest iASL compiler options.

Sami Mujawar (3):
  Platform/ARM: Match asl compiler output for Juno
  Platform/ARM: Match asl compiler output for FVP
  Update Readme.md to reflect ACPICA compiler update

 Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c     |  8 ++++----
 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c |  2 +-
 Readme.md                                                                                    | 21 +++++++++++---------
 3 files changed, 17 insertions(+), 14 deletions(-)

-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'




^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH edk2-platforms v1 1/3][platforms/devel-dynamictables] Platform/ARM: Match asl compiler output for Juno
  2018-04-27 14:58 [PATCH edk2-platforms v1 0/3][platforms/devel-dynamictables] Update for ACPICA compiler enhancements Sami Mujawar
@ 2018-04-27 14:58 ` Sami Mujawar
  2018-05-09 11:07   ` Leif Lindholm
  2018-04-27 14:58 ` [PATCH edk2-platforms v1 2/3][platforms/devel-dynamictables] Platform/ARM: Match asl compiler output for FVP Sami Mujawar
  2018-04-27 14:58 ` [PATCH edk2-platforms v1 3/3][platforms/devel-dynamictables] Update Readme.md to reflect ACPICA compiler update Sami Mujawar
  2 siblings, 1 reply; 8+ messages in thread
From: Sami Mujawar @ 2018-04-27 14:58 UTC (permalink / raw)
  To: edk2-devel
  Cc: Arvind Chauhan, Daniil Egranov, Thomas Panakamattam Abraham,
	ard.biesheuvel, leif.lindholm, Matteo.Carlini,
	Stephanie.Hughes-Fitt, nd

The iASL compiler's -tc option has been updated to generate
output that is suitable for including from a C file. The iASL
compiler uniquely names the C array containing the processed
table data as <ASL filename>_aml_code. This update can be seen
in the ACPICA git repository at
https://github.com/acpica/acpica/commit/f9a88a4c1cd020b6a5475d63b29626852a0b5f37

A corresponding change is required in the ConfigurationManager
and this patch contains the necessary changes to adapt to the
generated iASL compiler output.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Evan Lloyd <evan.lloyd@arm.com>
---
The changes can be seen at
https://github.com/samimujawar/edk2-platforms/tree/258_reflect_acpica_compiler_enhancement_v1

Notes:
    v1:
    - Update Configuration Manager to match iASL compiler output.   [SAMI]

 Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index 0e67dfa1f47cc3004b775ec43d02e07754675e26..4c878f663ab247307a17582c07f303ddb11b7d41 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -74,7 +74,7 @@ EFI_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryInfo = {
     {
       EFI_ACPI_6_2_DIFFERENTIATED_SYSTEM_DESCRIPTION_TABLE_SIGNATURE,
       CREATE_STD_ACPI_TABLE_GEN_ID (ESTD_ACPI_TABLE_ID_DSDT),
-      (EFI_ACPI_DESCRIPTION_HEADER*)dsdt_AmlCode
+      (EFI_ACPI_DESCRIPTION_HEADER*)dsdt_aml_code
     },
     // DBG2 Table
     {
@@ -86,13 +86,13 @@ EFI_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryInfo = {
     {
       EFI_ACPI_6_2_SECONDARY_SYSTEM_DESCRIPTION_TABLE_SIGNATURE,
       CREATE_STD_ACPI_TABLE_GEN_ID (ESTD_ACPI_TABLE_ID_SSDT),
-      (EFI_ACPI_DESCRIPTION_HEADER*)ssdtjunousb_AmlCode
+      (EFI_ACPI_DESCRIPTION_HEADER*)ssdtjunousb_aml_code
     },
     // SSDT table describing the PL011 UART
     {
       EFI_ACPI_6_2_SECONDARY_SYSTEM_DESCRIPTION_TABLE_SIGNATURE,
       CREATE_STD_ACPI_TABLE_GEN_ID (ESTD_ACPI_TABLE_ID_SSDT),
-      (EFI_ACPI_DESCRIPTION_HEADER*)ssdtuart_AmlCode
+      (EFI_ACPI_DESCRIPTION_HEADER*)ssdtuart_aml_code
     },
 
     /* PCI MCFG Table
@@ -109,7 +109,7 @@ EFI_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryInfo = {
     {
       EFI_ACPI_6_2_SECONDARY_SYSTEM_DESCRIPTION_TABLE_SIGNATURE,
       CREATE_STD_ACPI_TABLE_GEN_ID (ESTD_ACPI_TABLE_ID_SSDT),
-      (EFI_ACPI_DESCRIPTION_HEADER*)ssdtpci_AmlCode
+      (EFI_ACPI_DESCRIPTION_HEADER*)ssdtpci_aml_code
     }
   },
 
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'




^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH edk2-platforms v1 2/3][platforms/devel-dynamictables] Platform/ARM: Match asl compiler output for FVP
  2018-04-27 14:58 [PATCH edk2-platforms v1 0/3][platforms/devel-dynamictables] Update for ACPICA compiler enhancements Sami Mujawar
  2018-04-27 14:58 ` [PATCH edk2-platforms v1 1/3][platforms/devel-dynamictables] Platform/ARM: Match asl compiler output for Juno Sami Mujawar
@ 2018-04-27 14:58 ` Sami Mujawar
  2018-04-27 14:58 ` [PATCH edk2-platforms v1 3/3][platforms/devel-dynamictables] Update Readme.md to reflect ACPICA compiler update Sami Mujawar
  2 siblings, 0 replies; 8+ messages in thread
From: Sami Mujawar @ 2018-04-27 14:58 UTC (permalink / raw)
  To: edk2-devel
  Cc: Arvind Chauhan, Daniil Egranov, Thomas Panakamattam Abraham,
	ard.biesheuvel, leif.lindholm, Matteo.Carlini,
	Stephanie.Hughes-Fitt, nd

The iASL compiler's -tc option has been updated to generate
output that is suitable for including from a C file. The iASL
compiler uniquely names the C array containing the processed
table data as <ASL filename>_aml_code. This update can be seen
in the ACPICA git repository at
https://github.com/acpica/acpica/commit/f9a88a4c1cd020b6a5475d63b29626852a0b5f37

A corresponding change is required in the ConfigurationManager
and this patch contains the necessary changes to adapt to the
generated iASL compiler output.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Evan Lloyd <evan.lloyd@arm.com>
---
The changes can be seen at
https://github.com/samimujawar/edk2-platforms/tree/258_reflect_acpica_compiler_enhancement_v1

Notes:
    v1:
    - Update Configuration Manager to match iASL compiler output.   [SAMI]

 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index d45528813e2db9f44e1745392dfd35ffe05f1dca..2e1be34acf49962fd1899d84dec96c8cb9155b2c 100644
--- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -71,7 +71,7 @@ EFI_PLATFORM_REPOSITORY_INFO VExpressPlatRepositoryInfo = {
     {
       EFI_ACPI_6_2_DIFFERENTIATED_SYSTEM_DESCRIPTION_TABLE_SIGNATURE,
       CREATE_STD_ACPI_TABLE_GEN_ID (ESTD_ACPI_TABLE_ID_DSDT),
-      (EFI_ACPI_DESCRIPTION_HEADER*)dsdt_AmlCode
+      (EFI_ACPI_DESCRIPTION_HEADER*)dsdt_aml_code
     },
     // DBG2 Table
     {
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'




^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH edk2-platforms v1 3/3][platforms/devel-dynamictables] Update Readme.md to reflect ACPICA compiler update
  2018-04-27 14:58 [PATCH edk2-platforms v1 0/3][platforms/devel-dynamictables] Update for ACPICA compiler enhancements Sami Mujawar
  2018-04-27 14:58 ` [PATCH edk2-platforms v1 1/3][platforms/devel-dynamictables] Platform/ARM: Match asl compiler output for Juno Sami Mujawar
  2018-04-27 14:58 ` [PATCH edk2-platforms v1 2/3][platforms/devel-dynamictables] Platform/ARM: Match asl compiler output for FVP Sami Mujawar
@ 2018-04-27 14:58 ` Sami Mujawar
  2018-05-09 11:04   ` Leif Lindholm
  2 siblings, 1 reply; 8+ messages in thread
From: Sami Mujawar @ 2018-04-27 14:58 UTC (permalink / raw)
  To: edk2-devel
  Cc: Arvind Chauhan, Daniil Egranov, Thomas Panakamattam Abraham,
	ard.biesheuvel, leif.lindholm, Matteo.Carlini,
	Stephanie.Hughes-Fitt, nd

The ACPICA iASL compiler has been enhanced to support the
generation of an AML hex file which is required by the
Dynamic Tables Framework. The patch for this enhancement
has been integrated in the ACPICA repository. Therefore
the Prerequisites section in the Readme has been updated
accordingly.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Evan Lloyd <evan.lloyd@arm.com>
---
The changes can be seen at
https://github.com/samimujawar/edk2-platforms/tree/258_reflect_acpica_compiler_enhancement_v1

Notes:
    v1:
    - Update ACPICA iAsl compiler usage guidelines.                 [SAMI]

 Readme.md | 21 +++++++++++---------
 1 file changed, 12 insertions(+), 9 deletions(-)

diff --git a/Readme.md b/Readme.md
index b72efca18e8ab5de17cab06f0a1a0725991256d4..2300fa6be9f83525e8c0ee21800751d9067b02e0 100644
--- a/Readme.md
+++ b/Readme.md
@@ -87,9 +87,9 @@ contains the Dynamic Tables Framework.
 ### ACPICA iASL compiler
 The RAW table generator, used to process the DSDT/SSDT files depends on
 the iASL compiler to convert the DSDT/SSDT ASL files to a C array containing
-the hex AML code. The current implementation of the iASL compiler does not
-support generation of a C header file suitable for including from a C source
-file.
+the hex AML code. The "-tc" option of the iASL compiler has been enhanced to
+support generation of an AML hex file (C header) with a unique symbol name
+so that it is suitable for inclusion from a C source file.
 
 Related Links
 --------------
@@ -135,16 +135,19 @@ or
 
 Prerequisites
 -------------
-ACPICA iASL compiler with support for generating a C header file.
+ACPICA iASL compiler with the enhanced "-tc" option to support generation of
+AML hex (C header) files with unique symbol names.
 
-A patch ***'Modify hex AML C header file generation'***, to enable
-this support has been submitted to the ACPICA source repository.
-<https://lists.acpica.org/pipermail/devel/2018-March/001755.html>
+A patch ***'[iASL: Enhance the -tc option (create AML hex file in C)](https://github.com/acpica/acpica/commit/f9a88a4c1cd020b6a5475d63b29626852a0b5f37)'***,
+to enable this support has been integrated to the ACPICA source repository.
+
+
+Ensure that the iASL compiler used for building *Dynamic Tables Framework*
+has this feature enabled.
 
 Documentation
 -------------
-A description document is in preparation, and should be available in the
-near future.
+[Dynamic Tables Framework: A Step Towards Automatic Generation of Advanced Configuration and Power Interface (ACPI) & System Management BIOS (SMBIOS) Tables – Sami Mujawar (Arm).](http://www.uefi.org/sites/default/files/resources/Arm_Dynamic%20Tables%20Framework%20A%20Step%20Towards%20Automatic%20Generation%20of%20Advanced%20Configuration%20and%20Power%20Interface%20%28ACPI%29%20%26%20System%20Management%20BIOS%20%28SMBIOS%29%20Tables%20_0.pdf)
 
 Miscellaneous
 -------------
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'




^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH edk2-platforms v1 3/3][platforms/devel-dynamictables] Update Readme.md to reflect ACPICA compiler update
  2018-04-27 14:58 ` [PATCH edk2-platforms v1 3/3][platforms/devel-dynamictables] Update Readme.md to reflect ACPICA compiler update Sami Mujawar
@ 2018-05-09 11:04   ` Leif Lindholm
  2018-05-11 13:29     ` Evan Lloyd
  0 siblings, 1 reply; 8+ messages in thread
From: Leif Lindholm @ 2018-05-09 11:04 UTC (permalink / raw)
  To: Sami Mujawar
  Cc: edk2-devel, Arvind Chauhan, Daniil Egranov,
	Thomas Panakamattam Abraham, ard.biesheuvel, Matteo.Carlini,
	Stephanie.Hughes-Fitt, nd

On Fri, Apr 27, 2018 at 03:58:16PM +0100, Sami Mujawar wrote:
> The ACPICA iASL compiler has been enhanced to support the
> generation of an AML hex file which is required by the
> Dynamic Tables Framework. The patch for this enhancement
> has been integrated in the ACPICA repository. Therefore
> the Prerequisites section in the Readme has been updated
> accordingly.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> Reviewed-by: Evan Lloyd <evan.lloyd@arm.com>
> ---
> The changes can be seen at
> https://github.com/samimujawar/edk2-platforms/tree/258_reflect_acpica_compiler_enhancement_v1
> 
> Notes:
>     v1:
>     - Update ACPICA iAsl compiler usage guidelines.                 [SAMI]
> 
>  Readme.md | 21 +++++++++++---------
>  1 file changed, 12 insertions(+), 9 deletions(-)
> 
> diff --git a/Readme.md b/Readme.md
> index b72efca18e8ab5de17cab06f0a1a0725991256d4..2300fa6be9f83525e8c0ee21800751d9067b02e0 100644
> --- a/Readme.md
> +++ b/Readme.md
> @@ -87,9 +87,9 @@ contains the Dynamic Tables Framework.
>  ### ACPICA iASL compiler
>  The RAW table generator, used to process the DSDT/SSDT files depends on
>  the iASL compiler to convert the DSDT/SSDT ASL files to a C array containing
> -the hex AML code. The current implementation of the iASL compiler does not
> -support generation of a C header file suitable for including from a C source
> -file.
> +the hex AML code. The "-tc" option of the iASL compiler has been enhanced to
> +support generation of an AML hex file (C header) with a unique symbol name
> +so that it is suitable for inclusion from a C source file.
>  
>  Related Links
>  --------------
> @@ -135,16 +135,19 @@ or
>  
>  Prerequisites
>  -------------
> -ACPICA iASL compiler with support for generating a C header file.
> +ACPICA iASL compiler with the enhanced "-tc" option to support generation of
> +AML hex (C header) files with unique symbol names.
>  
> -A patch ***'Modify hex AML C header file generation'***, to enable
> -this support has been submitted to the ACPICA source repository.
> -<https://lists.acpica.org/pipermail/devel/2018-March/001755.html>
> +A patch ***'[iASL: Enhance the -tc option (create AML hex file in C)](https://github.com/acpica/acpica/commit/f9a88a4c1cd020b6a5475d63b29626852a0b5f37)'***,
> +to enable this support has been integrated to the ACPICA source repository.

Linux distributions tend to use dates to refer to what particular
point a version is based on, since snapshot updates are frequently
necessary.

In this case, that is 16 March 2018 - please mention that as well in
the message.

> +
> +
> +Ensure that the iASL compiler used for building *Dynamic Tables Framework*
> +has this feature enabled.
>  
>  Documentation
>  -------------
> -A description document is in preparation, and should be available in the
> -near future.
> +[Dynamic Tables Framework: A Step Towards Automatic Generation of Advanced Configuration and Power Interface (ACPI) & System Management BIOS (SMBIOS) Tables – Sami Mujawar (Arm).](http://www.uefi.org/sites/default/files/resources/Arm_Dynamic%20Tables%20Framework%20A%20Step%20Towards%20Automatic%20Generation%20of%20Advanced%20Configuration%20and%20Power%20Interface%20%28ACPI%29%20%26%20System%20Management%20BIOS%20%28SMBIOS%29%20Tables%20_0.pdf)

Add a description?
I.e.: "Presentation from UEFI Plugfest Seattle 2018"?

>  
>  Miscellaneous
>  -------------
> -- 
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> 
> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH edk2-platforms v1 1/3][platforms/devel-dynamictables] Platform/ARM: Match asl compiler output for Juno
  2018-04-27 14:58 ` [PATCH edk2-platforms v1 1/3][platforms/devel-dynamictables] Platform/ARM: Match asl compiler output for Juno Sami Mujawar
@ 2018-05-09 11:07   ` Leif Lindholm
  0 siblings, 0 replies; 8+ messages in thread
From: Leif Lindholm @ 2018-05-09 11:07 UTC (permalink / raw)
  To: Sami Mujawar
  Cc: edk2-devel, Arvind Chauhan, Daniil Egranov,
	Thomas Panakamattam Abraham, ard.biesheuvel, Matteo.Carlini,
	Stephanie.Hughes-Fitt, nd

On Fri, Apr 27, 2018 at 03:58:14PM +0100, Sami Mujawar wrote:
> The iASL compiler's -tc option has been updated to generate
> output that is suitable for including from a C file. The iASL
> compiler uniquely names the C array containing the processed
> table data as <ASL filename>_aml_code. This update can be seen
> in the ACPICA git repository at
> https://github.com/acpica/acpica/commit/f9a88a4c1cd020b6a5475d63b29626852a0b5f37

For both 1-2/3, please add a date here, like in the Readme.md.
No further comments on this set.

/
    Leif

> A corresponding change is required in the ConfigurationManager
> and this patch contains the necessary changes to adapt to the
> generated iASL compiler output.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> Reviewed-by: Evan Lloyd <evan.lloyd@arm.com>
> ---
> The changes can be seen at
> https://github.com/samimujawar/edk2-platforms/tree/258_reflect_acpica_compiler_enhancement_v1
> 
> Notes:
>     v1:
>     - Update Configuration Manager to match iASL compiler output.   [SAMI]
> 
>  Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
> index 0e67dfa1f47cc3004b775ec43d02e07754675e26..4c878f663ab247307a17582c07f303ddb11b7d41 100644
> --- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
> +++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
> @@ -74,7 +74,7 @@ EFI_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryInfo = {
>      {
>        EFI_ACPI_6_2_DIFFERENTIATED_SYSTEM_DESCRIPTION_TABLE_SIGNATURE,
>        CREATE_STD_ACPI_TABLE_GEN_ID (ESTD_ACPI_TABLE_ID_DSDT),
> -      (EFI_ACPI_DESCRIPTION_HEADER*)dsdt_AmlCode
> +      (EFI_ACPI_DESCRIPTION_HEADER*)dsdt_aml_code
>      },
>      // DBG2 Table
>      {
> @@ -86,13 +86,13 @@ EFI_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryInfo = {
>      {
>        EFI_ACPI_6_2_SECONDARY_SYSTEM_DESCRIPTION_TABLE_SIGNATURE,
>        CREATE_STD_ACPI_TABLE_GEN_ID (ESTD_ACPI_TABLE_ID_SSDT),
> -      (EFI_ACPI_DESCRIPTION_HEADER*)ssdtjunousb_AmlCode
> +      (EFI_ACPI_DESCRIPTION_HEADER*)ssdtjunousb_aml_code
>      },
>      // SSDT table describing the PL011 UART
>      {
>        EFI_ACPI_6_2_SECONDARY_SYSTEM_DESCRIPTION_TABLE_SIGNATURE,
>        CREATE_STD_ACPI_TABLE_GEN_ID (ESTD_ACPI_TABLE_ID_SSDT),
> -      (EFI_ACPI_DESCRIPTION_HEADER*)ssdtuart_AmlCode
> +      (EFI_ACPI_DESCRIPTION_HEADER*)ssdtuart_aml_code
>      },
>  
>      /* PCI MCFG Table
> @@ -109,7 +109,7 @@ EFI_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryInfo = {
>      {
>        EFI_ACPI_6_2_SECONDARY_SYSTEM_DESCRIPTION_TABLE_SIGNATURE,
>        CREATE_STD_ACPI_TABLE_GEN_ID (ESTD_ACPI_TABLE_ID_SSDT),
> -      (EFI_ACPI_DESCRIPTION_HEADER*)ssdtpci_AmlCode
> +      (EFI_ACPI_DESCRIPTION_HEADER*)ssdtpci_aml_code
>      }
>    },
>  
> -- 
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> 
> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH edk2-platforms v1 3/3][platforms/devel-dynamictables] Update Readme.md to reflect ACPICA compiler update
  2018-05-09 11:04   ` Leif Lindholm
@ 2018-05-11 13:29     ` Evan Lloyd
  2018-05-12 11:25       ` Leif Lindholm
  0 siblings, 1 reply; 8+ messages in thread
From: Evan Lloyd @ 2018-05-11 13:29 UTC (permalink / raw)
  To: Leif Lindholm, Sami Mujawar
  Cc: nd, Arvind Chauhan, ard.biesheuvel@linaro.org,
	edk2-devel@lists.01.org, Stephanie Hughes-Fitt



> -----Original Message-----
> From: edk2-devel <edk2-devel-bounces@lists.01.org> On Behalf Of Leif
> Lindholm
> Sent: 09 May 2018 12:04
> To: Sami Mujawar <Sami.Mujawar@arm.com>
> Cc: nd <nd@arm.com>; Arvind Chauhan <Arvind.Chauhan@arm.com>;
> ard.biesheuvel@linaro.org; edk2-devel@lists.01.org; Stephanie Hughes-Fitt
> <Stephanie.Hughes-Fitt@arm.com>
> Subject: Re: [edk2] [PATCH edk2-platforms v1 3/3][platforms/devel-
> dynamictables] Update Readme.md to reflect ACPICA compiler update
>
...
> > -A patch ***'Modify hex AML C header file generation'***, to enable
> > -this support has been submitted to the ACPICA source repository.
> > -<https://lists.acpica.org/pipermail/devel/2018-March/001755.html>
> > +A patch ***'[iASL: Enhance the -tc option (create AML hex file in
> >
> +C)](https://github.com/acpica/acpica/commit/f9a88a4c1cd020b6a5475d63
> b
> > +29626852a0b5f37)'***, to enable this support has been integrated to
> > +the ACPICA source repository.
> 
> Linux distributions tend to use dates to refer to what particular point a
> version is based on, since snapshot updates are frequently necessary.
[[Evan Lloyd]] Whilst agreeing that a date would be helpful, I don't think that Linux usage is relevant.  EDK II seems to go to some lengths to avoid Linux usage (e.g. CR LF).
> 
> In this case, that is 16 March 2018 - please mention that as well in the
> message.
[[Evan Lloyd]] Given the international nature of edk2-devel, I suggest there is a strong case for adopting ISO-8601 date format, so I'd prefer 2018-03-16.
> 
> > +
> > +
> > +Ensure that the iASL compiler used for building *Dynamic Tables
> > +Framework* has this feature enabled.
> >
> >  Documentation
> >  -------------
> > -A description document is in preparation, and should be available in
> > the -near future.
> > +[Dynamic Tables Framework: A Step Towards Automatic Generation of
> > +Advanced Configuration and Power Interface (ACPI) & System
> Management
> > +BIOS (SMBIOS) Tables – Sami Mujawar
> > +(Arm).](http://www.uefi.org/sites/default/files/resources/Arm_Dynamic
> >
> +%20Tables%20Framework%20A%20Step%20Towards%20Automatic%20Gen
> eration%2
> >
> +0of%20Advanced%20Configuration%20and%20Power%20Interface%20%28
> ACPI%29
> >
> +%20%26%20System%20Management%20BIOS%20%28SMBIOS%29%20Table
> s%20_0.pdf)
> 
> Add a description?
> I.e.: "Presentation from UEFI Plugfest Seattle 2018"?
> 
> >
> >  Miscellaneous
> >  -------------
> > --
> > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> >
> >
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH edk2-platforms v1 3/3][platforms/devel-dynamictables] Update Readme.md to reflect ACPICA compiler update
  2018-05-11 13:29     ` Evan Lloyd
@ 2018-05-12 11:25       ` Leif Lindholm
  0 siblings, 0 replies; 8+ messages in thread
From: Leif Lindholm @ 2018-05-12 11:25 UTC (permalink / raw)
  To: Evan Lloyd
  Cc: Sami Mujawar, nd, Arvind Chauhan, ard.biesheuvel@linaro.org,
	edk2-devel@lists.01.org, Stephanie Hughes-Fitt

On Fri, May 11, 2018 at 01:29:47PM +0000, Evan Lloyd wrote:
> 
> 
> > -----Original Message-----
> > From: edk2-devel <edk2-devel-bounces@lists.01.org> On Behalf Of Leif
> > Lindholm
> > Sent: 09 May 2018 12:04
> > To: Sami Mujawar <Sami.Mujawar@arm.com>
> > Cc: nd <nd@arm.com>; Arvind Chauhan <Arvind.Chauhan@arm.com>;
> > ard.biesheuvel@linaro.org; edk2-devel@lists.01.org; Stephanie Hughes-Fitt
> > <Stephanie.Hughes-Fitt@arm.com>
> > Subject: Re: [edk2] [PATCH edk2-platforms v1 3/3][platforms/devel-
> > dynamictables] Update Readme.md to reflect ACPICA compiler update
> >
> ...
> > > -A patch ***'Modify hex AML C header file generation'***, to enable
> > > -this support has been submitted to the ACPICA source repository.
> > > -<https://lists.acpica.org/pipermail/devel/2018-March/001755.html>
> > > +A patch ***'[iASL: Enhance the -tc option (create AML hex file in
> > >
> > +C)](https://github.com/acpica/acpica/commit/f9a88a4c1cd020b6a5475d63
> > b
> > > +29626852a0b5f37)'***, to enable this support has been integrated to
> > > +the ACPICA source repository.
> > 
> > Linux distributions tend to use dates to refer to what particular point a
> > version is based on, since snapshot updates are frequently
> > necessary.
>
> [[Evan Lloyd]] Whilst agreeing that a date would be helpful, I don't
> think that Linux usage is relevant.  EDK II seems to go to some
> lengths to avoid Linux usage (e.g. CR LF).

Linux distributions are consumers of edk2 code in the form of
packaged builds of ArmVirtPkg and OvmfPkg.

> > In this case, that is 16 March 2018 - please mention that as well in the
> > message.
> [[Evan Lloyd]] Given the international nature of edk2-devel, I
> suggest there is a strong case for adopting ISO-8601 date format, so
> I'd prefer 2018-03-16.

Yes please.

/
    Leif


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2018-05-12 11:25 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-27 14:58 [PATCH edk2-platforms v1 0/3][platforms/devel-dynamictables] Update for ACPICA compiler enhancements Sami Mujawar
2018-04-27 14:58 ` [PATCH edk2-platforms v1 1/3][platforms/devel-dynamictables] Platform/ARM: Match asl compiler output for Juno Sami Mujawar
2018-05-09 11:07   ` Leif Lindholm
2018-04-27 14:58 ` [PATCH edk2-platforms v1 2/3][platforms/devel-dynamictables] Platform/ARM: Match asl compiler output for FVP Sami Mujawar
2018-04-27 14:58 ` [PATCH edk2-platforms v1 3/3][platforms/devel-dynamictables] Update Readme.md to reflect ACPICA compiler update Sami Mujawar
2018-05-09 11:04   ` Leif Lindholm
2018-05-11 13:29     ` Evan Lloyd
2018-05-12 11:25       ` Leif Lindholm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox