From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a01:111:f400:fe02::612; helo=eur01-db5-obe.outbound.protection.outlook.com; envelope-from=evan.lloyd@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0612.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe02::612]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CDCA1211F886F for ; Wed, 27 Jun 2018 09:57:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ER/1i0YW5Q/8Nq8dzVMks6VvsJfre1gThrxWwcxIyps=; b=NeIR3i0BB0h+nsIbT0mExo1zmSFdFEQKZnaFytE8O26E6qoYtktBVNmNqvdlnCLx51snYr22dKMLBOaFH/+PaXa/yqWdn717/cqeGiBxPa+If3/mC0M/r9oINf5ssNlThArF4OLsICla+5OzqmXrQmnScljkts+wiqXdy6mqIio= Received: from DB6PR08MB2806.eurprd08.prod.outlook.com (10.170.222.149) by DB6PR08MB2789.eurprd08.prod.outlook.com (10.170.222.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.23; Wed, 27 Jun 2018 16:57:17 +0000 Received: from DB6PR08MB2806.eurprd08.prod.outlook.com ([fe80::3121:feab:c41a:7885]) by DB6PR08MB2806.eurprd08.prod.outlook.com ([fe80::3121:feab:c41a:7885%3]) with mapi id 15.20.0884.024; Wed, 27 Jun 2018 16:57:17 +0000 From: Evan Lloyd To: Sami Mujawar , "edk2-devel@lists.01.org" CC: "leif.lindholm@linaro.org" , Matteo Carlini , Stephanie Hughes-Fitt , nd Thread-Topic: [staging/dynamictables PATCH v1 0/5] Fix issues reported by ecc tool Thread-Index: AQHUDjaZpGQNv1Z/Sk6lK6ZeV3x2gqR0Uz7Q Date: Wed, 27 Jun 2018 16:57:17 +0000 Message-ID: References: <20180627164746.36188-1-sami.mujawar@arm.com> In-Reply-To: <20180627164746.36188-1-sami.mujawar@arm.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Evan.Lloyd@arm.com; x-originating-ip: [217.140.96.140] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB6PR08MB2789; 7:R4sxd82DDjcuM4r5/R2MU92fwztzWYJQHi4y+zBosMGfDs+79rU84b7xWYgpwoJg0LTPPB4D/Y/iYwdh85B7X25SbykAkK60OpsMz/qeJOm4Kt5lgdgNqjjkzZZTetowPDV28eMYWJ8ts4vkavK8U7yvqhHCvYj//t2KEuHDlVc7DKFP74U8UH8AoOJy7I0BXLWUMTBC6W5EhAK0VAV5qcGBDFV90N3zmR3Wb4/vHWvmNemdkQX1r77TQltPRXc2 x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-correlation-id: ffd3ca8a-8573-4be3-857b-08d5dc4f0a50 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989117)(5600026)(711020)(48565401081)(2017052603328)(7153060)(7193020); SRVR:DB6PR08MB2789; x-ms-traffictypediagnostic: DB6PR08MB2789: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(166708455590820)(162533806227266); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3231254)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:DB6PR08MB2789; BCL:0; PCL:0; RULEID:; SRVR:DB6PR08MB2789; x-forefront-prvs: 0716E70AB6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(39860400002)(136003)(366004)(396003)(189003)(199004)(13464003)(476003)(7696005)(6246003)(5250100002)(2900100001)(76176011)(2906002)(305945005)(26005)(102836004)(7736002)(68736007)(105586002)(74316002)(8676002)(106356001)(11346002)(81156014)(8936002)(486006)(81166006)(446003)(5660300001)(14454004)(55016002)(6306002)(97736004)(2501003)(229853002)(66066001)(6116002)(9686003)(6436002)(966005)(54906003)(256004)(316002)(99286004)(478600001)(53936002)(4326008)(72206003)(53546011)(6506007)(86362001)(3846002)(110136005)(25786009)(33656002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR08MB2789; H:DB6PR08MB2806.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: eTaAGDR+ZKJil3r3pJIw+jRoY+vyTk5oSp9lN5+gCZrTiGm8OrcXfB6DoPCPYsO7xuP0Cx1fGiKwxHdntS8d5LayZhPj+9ygrQkYA7YggDKu/9J9lvcRm3yCwMUgTen08UQ7CHCEEg40SkncX8TgMMAN0jeR/AcB7yY5xjWSs5lQ6F3cH7Dcqxrzh1qvov+7CfB4HZpRpAwJSEM85mxtB60gNJXrCVihK1pqngSStHbV6b3A3T2858JXtlDHOXwk9jMxaEBO75b5M8Qkh7+xzzjj8MtvR09s315YKFrlNPMQS8ZYe+1hs3oHOL/7OEJ2wNZNd/CnP8FkUU4xMxmAOmej3MyfucWTlL6g5gXYybs= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: ffd3ca8a-8573-4be3-857b-08d5dc4f0a50 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jun 2018 16:57:17.5275 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2789 Subject: Re: [staging/dynamictables PATCH v1 0/5] Fix issues reported by ecc tool X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 16:57:22 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Signed-off-by: Evan Lloyd > -----Original Message----- > From: Sami Mujawar > Sent: 27 June 2018 17:48 > To: edk2-devel@lists.01.org > Cc: leif.lindholm@linaro.org; Evan Lloyd ; Matteo > Carlini ; Stephanie Hughes-Fitt > ; nd > Subject: [staging/dynamictables PATCH v1 0/5] Fix issues reported by ecc = tool >=20 > This patch series fixes the issues reported by the ecc tool. >=20 > The changes can be seen at https://github.com/samimujawar/edk2- > staging/tree/290_fix_ecc_issues_v1 >=20 > Sami Mujawar (5): > DynamicTablesPkg: Add module info to file header > DynamicTablesPkg: Fix function documentation > DynamicTablesPkg: Fix variable naming issue > DynamicTablesPkg: Fix macro to prevent side effect > DynamicTablesPkg: Fix variable declaration >=20 >=20 > DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/AcpiTableFactory/Acpi > TableFactory.c | 6 +- >=20 > DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DeviceTreeTableFactor > y/DeviceTreeTableFactory.c | 6 +- >=20 > DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactory. > h | 6 +- >=20 > DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryD > xe.c | 2 +- >=20 > DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryD > xe.inf | 1 + >=20 > DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/SmbiosTableFactory/S > mbiosTableFactory.c | 6 +- >=20 > DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManag > erDxe.c | 59 +++--- >=20 > DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManag > erDxe.inf | 1 + > DynamicTablesPkg/DynamicTablesPkg.dec = | > 5 +- > DynamicTablesPkg/Include/AcpiTableGenerator.h > | 30 +-- > DynamicTablesPkg/Include/ConfigurationManagerHelper.h > | 2 +- > DynamicTablesPkg/Include/ConfigurationManagerObject.h > | 12 +- > DynamicTablesPkg/Include/DeviceTreeTableGenerator.h > | 24 +-- > DynamicTablesPkg/Include/Library/TableHelperLib.h > | 6 +- > DynamicTablesPkg/Include/Protocol/ConfigurationManagerProtocol.h > | 4 +- > DynamicTablesPkg/Include/Protocol/DynamicTableFactoryProtocol.h > | 6 +- > DynamicTablesPkg/Include/SmbiosTableGenerator.h > | 24 +-- > DynamicTablesPkg/Include/StandardNameSpaceObjects.h > | 2 +- > DynamicTablesPkg/Include/TableGenerator.h > | 32 ++-- > DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/AcpiDbg2LibArm.inf > | 1 + > DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c > | 16 +- > DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/AcpiFadtLibArm.inf > | 1 + > DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c > | 20 +- > DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/AcpiGtdtLibArm.inf > | 1 + > DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c > | 38 ++-- > DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.inf > | 1 + > DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c > | 194 ++++++++++---------- > DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/AcpiMadtLibArm.inf > | 1 + > DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c > | 32 ++-- > DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/AcpiMcfgLibArm.inf > | 1 + > DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/McfgGenerator.c > | 16 +- > DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/AcpiRawLibArm.inf > | 1 + > DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/RawGenerator.c > | 13 +- > DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/AcpiSpcrLibArm.inf > | 1 + > DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c > | 12 +- > DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c > | 4 +- > DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf > | 1 + > 37 files changed, 316 insertions(+), 272 deletions(-) >=20 > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >=20