From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=104.47.1.84; helo=eur01-ve1-obe.outbound.protection.outlook.com; envelope-from=evan.lloyd@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0084.outbound.protection.outlook.com [104.47.1.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 61E592113DA2A for ; Wed, 20 Jun 2018 10:00:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Efk7LhIIUjxcgIzUmUZMVeS4u79zc0LaRuPq2/3ckAs=; b=CMu4FVNSOLIQWcBuSbAsWs/Ap7ezA3Z65yDfh7AYwcd+qX4Dmp3Bqdzxpe+EObcHyn2KiOfN8fGIUGa8aTWbzgEvoMXmcljTi5hz5Mn5+9UGXzrNhytyqONKEtFlirESs9Hz65p4MgiKQiU9fKDBdPCH1jThSQzmw84LWUqZmdQ= Received: from DB6PR08MB2806.eurprd08.prod.outlook.com (10.170.222.149) by DB6PR08MB2759.eurprd08.prod.outlook.com (10.170.222.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.19; Wed, 20 Jun 2018 17:00:09 +0000 Received: from DB6PR08MB2806.eurprd08.prod.outlook.com ([fe80::c9e1:cd4d:545f:649d]) by DB6PR08MB2806.eurprd08.prod.outlook.com ([fe80::c9e1:cd4d:545f:649d%2]) with mapi id 15.20.0863.016; Wed, 20 Jun 2018 17:00:09 +0000 From: Evan Lloyd To: Sami Mujawar , "edk2-devel@lists.01.org" CC: Arvind Chauhan , Daniil Egranov , Thomas Abraham , "leif.lindholm@linaro.org" , Matteo Carlini , Stephanie Hughes-Fitt , nd Thread-Topic: [PATCH edk2-platforms v1][platforms/devel-dynamictables] Platform/ARM: Fix OEM Table ID length in DSDT Thread-Index: AQHUCLXCEtjXja6TxE+Gz1avhfgvsqRpXfTQ Date: Wed, 20 Jun 2018 17:00:08 +0000 Message-ID: References: <20180620164254.5076-1-sami.mujawar@arm.com> In-Reply-To: <20180620164254.5076-1-sami.mujawar@arm.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Evan.Lloyd@arm.com; x-originating-ip: [217.140.96.140] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB6PR08MB2759; 7:EUUm01B0qna6CNEnKIme1dCIyHmfNQe9vxYgAfZQIJQGdvls5yqQ8nkSynrVJH35GaYtllZ2cqZaOEKr9QBwGtBNNVHZd91JkiuAbxSQJC96mGOE9larYcZKfrGfYdKT5jh+Q1O0CiRuytkbUDKxVLrDKbG967mQ0pNN59XnfGJapXBgZkoh6YWJkB953spj7y+S3Qn+TMzniDLV0OKXvpexgpubcSEH/7CUV5aaTkGM83sFUXt9sif4fIRpfNqM x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-correlation-id: d068f188-6ec7-4ae1-8242-08d5d6cf4795 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(711020)(48565401081)(2017052603328)(7153060)(7193020); SRVR:DB6PR08MB2759; x-ms-traffictypediagnostic: DB6PR08MB2759: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(166708455590820)(162533806227266); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123562045)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:DB6PR08MB2759; BCL:0; PCL:0; RULEID:; SRVR:DB6PR08MB2759; x-forefront-prvs: 070912876F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(366004)(346002)(39860400002)(39380400002)(396003)(199004)(189003)(13464003)(446003)(81156014)(3280700002)(305945005)(2900100001)(9686003)(5660300001)(8676002)(5250100002)(26005)(2501003)(476003)(6306002)(55016002)(81166006)(478600001)(11346002)(74316002)(68736007)(97736004)(2906002)(86362001)(8936002)(66066001)(7736002)(575784001)(486006)(6116002)(106356001)(3846002)(6246003)(4326008)(229853002)(105586002)(110136005)(14454004)(316002)(59450400001)(25786009)(6506007)(76176011)(7696005)(33656002)(72206003)(53546011)(102836004)(3660700001)(54906003)(6436002)(99286004)(53936002)(966005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR08MB2759; H:DB6PR08MB2806.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: QQtkwqRGIJPR/5lwBUmu8GOzXhWrv17shThAScshBnB7nBkwYAlrx4A+kyETDCkn27FtzZnKF/h13LpT4ef9ZPhzv8CdxlAiJoyYmkBALLmx3oVXjKk32xFESvYNla9zARNeGHH7x46tfGTjo620AtnEdlI9mPQZoaIudCdAAAk/Dkuy1ev2fAdy87GPeHZD6ZTzSuJdMCfIQ3WGHOy/jlXVxuguU8GT18kfnKNg+OA/cgHAwIM5gwxtQRTAc/b/D8OXl4y2zWM5L4olnkrxp66AtfvElziV2B071fTOua5P5YQWOdf1blHWorn9lQWamA7ijJjkaOlk9C3gxk3tWQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: d068f188-6ec7-4ae1-8242-08d5d6cf4795 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jun 2018 17:00:08.9410 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2759 Subject: Re: [PATCH edk2-platforms v1][platforms/devel-dynamictables] Platform/ARM: Fix OEM Table ID length in DSDT X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jun 2018 17:00:14 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Evan Lloyd > -----Original Message----- > From: Sami Mujawar > Sent: 20 June 2018 17:43 > To: edk2-devel@lists.01.org > Cc: Arvind Chauhan ; Daniil Egranov > ; Thomas Abraham > ; leif.lindholm@linaro.org; Evan Lloyd > ; Matteo Carlini ; > Stephanie Hughes-Fitt ; nd > > Subject: [PATCH edk2-platforms v1][platforms/devel-dynamictables] > Platform/ARM: Fix OEM Table ID length in DSDT >=20 > The OEM Table ID length cannot be more than 8 characters. > Moreover, the ACPICA iASL compiler patch "Add error messages for ACPI > tables with bad OEM and OEM Table IDs" dated > 13 April 2018 [20180413] > (https://github.com/acpica/acpica/commit/ca828bd15604699c14a02e98f4d0 > d9c4d6885e44) > introduced checks for the OEM Table ID length. If the OEM Table ID length= is > more than 8 characters in the DSDT/SSDT table's DefinitionBlock(), it fla= gs > them as an error. >=20 > This patch adjusts the length of the OEM Table ID to > 8 characters in the DSDT and SSDT tables. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Sami Mujawar > --- >=20 > The changes can be seen at https://github.com/samimujawar/edk2- > platforms/tree/289_fix_dsdt_definitionblock_v1 >=20 > Notes: > v1: > - Fixed DSDT build error flagged by latest ACPICA iasl compiler [SAMI= ] >=20 >=20 > Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/D > sdt.asl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git > a/Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/ > Dsdt.asl > b/Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib > /Dsdt.asl > index > 15ce7c020045d42f08cf92ad76644b07f0a1e25e..fae6a4be423b4b7da5e96771 > 39f2ab3deac5520e 100644 > --- > a/Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/ > Dsdt.asl > +++ > b/Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib > +++ /Dsdt.asl > @@ -12,7 +12,7 @@ >=20 > **/ >=20 > -DefinitionBlock("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-VEXPRESS", 1) > { > +DefinitionBlock("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-VEXP", 1) { > Scope(_SB) { > // > // Processor > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >=20