[PATCH edk2-platforms v2 0/3][platforms/devel-dynamictables] Update for ACPICA compiler enhancements

[PATCH edk2-platforms v2 0/3][platforms/devel-dynamictables] Update for ACPICA compiler enhancements

[Sami Mujawar]

The ACPICA iAsl compiler has recently been enhanced to support a
feature required by Dynamic Tables Framework for processing ASL
files. The compiler however generates slightly different symbol
names to what was previously referenced in the Configuration Manager.

This patchset adapts to the latest iASL compiler options.

The changes can be seen at
https://github.com/samimujawar/edk2-platforms/tree/258_reflect_acpica_compiler_enhancement_v2

Sami Mujawar (3):
  Platform/ARM: Match asl compiler output for Juno
  Platform/ARM: Match asl compiler output for FVP
  Update Readme.md to reflect ACPICA compiler update

 Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c     |  8 +++----
 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c |  2 +-
 Readme.md                                                                                    | 25 +++++++++++++-------
 3 files changed, 21 insertions(+), 14 deletions(-)

-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v2 1/3][platforms/devel-dynamictables] Platform/ARM: Match asl compiler output for Juno

[Sami Mujawar]

The iASL compiler's -tc option has been updated to generate
output that is suitable for including from a C file. The iASL
compiler uniquely names the C array containing the processed
table data as <ASL filename>_aml_code.The patch for this update,
'iASL: Enhance the -tc option (create AML hex file in C)',
dated 16 March 2018 (2018-03-16), can be seen in the ACPICA git
repository at
https://github.com/acpica/acpica/commit/f9a88a4c1cd020b6a5475d63b29626852a0b5f37

A corresponding change is required in the ConfigurationManager
and this patch contains the necessary changes to adapt to the
generated iASL compiler output.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---

Notes:
    v2:
    - Add patch commit date.                                          [LEIF]
    - Updated commit message to add date for referenced ACPICA patch. [SAMI]
    
    v1:
    - Update Configuration Manager to match iASL compiler output.     [SAMI]

 Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index 0e67dfa1f47cc3004b775ec43d02e07754675e26..4c878f663ab247307a17582c07f303ddb11b7d41 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -74,7 +74,7 @@ EFI_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryInfo = {
     {
       EFI_ACPI_6_2_DIFFERENTIATED_SYSTEM_DESCRIPTION_TABLE_SIGNATURE,
       CREATE_STD_ACPI_TABLE_GEN_ID (ESTD_ACPI_TABLE_ID_DSDT),
-      (EFI_ACPI_DESCRIPTION_HEADER*)dsdt_AmlCode
+      (EFI_ACPI_DESCRIPTION_HEADER*)dsdt_aml_code
     },
     // DBG2 Table
     {
@@ -86,13 +86,13 @@ EFI_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryInfo = {
     {
       EFI_ACPI_6_2_SECONDARY_SYSTEM_DESCRIPTION_TABLE_SIGNATURE,
       CREATE_STD_ACPI_TABLE_GEN_ID (ESTD_ACPI_TABLE_ID_SSDT),
-      (EFI_ACPI_DESCRIPTION_HEADER*)ssdtjunousb_AmlCode
+      (EFI_ACPI_DESCRIPTION_HEADER*)ssdtjunousb_aml_code
     },
     // SSDT table describing the PL011 UART
     {
       EFI_ACPI_6_2_SECONDARY_SYSTEM_DESCRIPTION_TABLE_SIGNATURE,
       CREATE_STD_ACPI_TABLE_GEN_ID (ESTD_ACPI_TABLE_ID_SSDT),
-      (EFI_ACPI_DESCRIPTION_HEADER*)ssdtuart_AmlCode
+      (EFI_ACPI_DESCRIPTION_HEADER*)ssdtuart_aml_code
     },
 
     /* PCI MCFG Table
@@ -109,7 +109,7 @@ EFI_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryInfo = {
     {
       EFI_ACPI_6_2_SECONDARY_SYSTEM_DESCRIPTION_TABLE_SIGNATURE,
       CREATE_STD_ACPI_TABLE_GEN_ID (ESTD_ACPI_TABLE_ID_SSDT),
-      (EFI_ACPI_DESCRIPTION_HEADER*)ssdtpci_AmlCode
+      (EFI_ACPI_DESCRIPTION_HEADER*)ssdtpci_aml_code
     }
   },
 
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v2 2/3][platforms/devel-dynamictables] Platform/ARM: Match asl compiler output for FVP

[Sami Mujawar]

The iASL compiler's -tc option has been updated to generate
output that is suitable for including from a C file. The iASL
compiler uniquely names the C array containing the processed
table data as <ASL filename>_aml_code. The patch for this update,
'iASL: Enhance the -tc option (create AML hex file in C)',
dated 16 March 2018 (2018-03-16), can be seen in the ACPICA git
repository at
https://github.com/acpica/acpica/commit/f9a88a4c1cd020b6a5475d63b29626852a0b5f37

A corresponding change is required in the ConfigurationManager
and this patch contains the necessary changes to adapt to the
generated iASL compiler output.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---

Notes:
    v2:
    - Add patch commit date.                                          [LEIF]
    - Updated commit message to add date for referenced ACPICA patch. [SAMI]
    
    v1:
    - Update Configuration Manager to match iASL compiler output.   [SAMI]

 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index d45528813e2db9f44e1745392dfd35ffe05f1dca..2e1be34acf49962fd1899d84dec96c8cb9155b2c 100644
--- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -71,7 +71,7 @@ EFI_PLATFORM_REPOSITORY_INFO VExpressPlatRepositoryInfo = {
     {
       EFI_ACPI_6_2_DIFFERENTIATED_SYSTEM_DESCRIPTION_TABLE_SIGNATURE,
       CREATE_STD_ACPI_TABLE_GEN_ID (ESTD_ACPI_TABLE_ID_DSDT),
-      (EFI_ACPI_DESCRIPTION_HEADER*)dsdt_AmlCode
+      (EFI_ACPI_DESCRIPTION_HEADER*)dsdt_aml_code
     },
     // DBG2 Table
     {
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v2 3/3][platforms/devel-dynamictables] Update Readme.md to reflect ACPICA compiler update

[Sami Mujawar]

The ACPICA iASL compiler has been enhanced to support the
generation of an AML hex file which is required by the
Dynamic Tables Framework. The patch for this enhancement
has been integrated in the ACPICA repository. Therefore
the Prerequisites section in the Readme has been updated
accordingly.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---

Notes:
    v2:
    - Add patch commit date and info about presentation.              [LEIF]
    - Updated Readme.md to add date for referencing ACPICA patch.
      Also annotated the UEFI presentation.                           [SAMI]
    
    v1:
    - Update ACPICA iAsl compiler usage guidelines.                   [SAMI]

 Readme.md | 25 +++++++++++++-------
 1 file changed, 16 insertions(+), 9 deletions(-)

diff --git a/Readme.md b/Readme.md
index b72efca18e8ab5de17cab06f0a1a0725991256d4..6501623503d6ec8ef4840aebc70561d44cf1ca12 100644
--- a/Readme.md
+++ b/Readme.md
@@ -87,9 +87,9 @@ contains the Dynamic Tables Framework.
 ### ACPICA iASL compiler
 The RAW table generator, used to process the DSDT/SSDT files depends on
 the iASL compiler to convert the DSDT/SSDT ASL files to a C array containing
-the hex AML code. The current implementation of the iASL compiler does not
-support generation of a C header file suitable for including from a C source
-file.
+the hex AML code. The "-tc" option of the iASL compiler has been enhanced to
+support generation of an AML hex file (C header) with a unique symbol name
+so that it is suitable for inclusion from a C source file.
 
 Related Links
 --------------
@@ -135,16 +135,23 @@ or
 
 Prerequisites
 -------------
-ACPICA iASL compiler with support for generating a C header file.
+ACPICA iASL compiler with the enhanced "-tc" option to support generation of
+AML hex (C header) files with unique symbol names.
 
-A patch ***'Modify hex AML C header file generation'***, to enable
-this support has been submitted to the ACPICA source repository.
-<https://lists.acpica.org/pipermail/devel/2018-March/001755.html>
+A patch *'[iASL: Enhance the -tc option (create AML hex file in C)](https://github.com/acpica/acpica/commit/f9a88a4c1cd020b6a5475d63b29626852a0b5f37)'*, dated 16 March 2018 (2018-03-16),
+to enable this support has been integrated to the ACPICA source repository.
+
+Ensure that the iASL compiler used for building *Dynamic Tables Framework* has this feature enabled.
+
+This feature was made available in the *ACPICA Compiler update
+[Version 20180508](https://www.acpica.org/node/156)*, dated 8 May 2018 (2018-05-08).
 
 Documentation
 -------------
-A description document is in preparation, and should be available in the
-near future.
+
+Refer to the following presentation from *UEFI Plugfest Seattle 2018*:
+
+[Dynamic Tables Framework: A Step Towards Automatic Generation of Advanced Configuration and Power Interface (ACPI) & System Management BIOS (SMBIOS) Tables – Sami Mujawar (Arm).](http://www.uefi.org/sites/default/files/resources/Arm_Dynamic%20Tables%20Framework%20A%20Step%20Towards%20Automatic%20Generation%20of%20Advanced%20Configuration%20and%20Power%20Interface%20%28ACPI%29%20%26%20System%20Management%20BIOS%20%28SMBIOS%29%20Tables%20_0.pdf)
 
 Miscellaneous
 -------------
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

Re: [PATCH edk2-platforms v2 0/3][platforms/devel-dynamictables] Update for ACPICA compiler enhancements

[Evan Lloyd]

Reviewed-by: Evan Lloyd <Evan.Lloyd@arm.com>

Leif, Ard - are you happy to accept this for the patchset, or should I respond to each patch?

Regards,
Evan

> -----Original Message-----
> From: edk2-devel <edk2-devel-bounces@lists.01.org> On Behalf Of Sami
> Mujawar
> Sent: 18 May 2018 14:13
> To: edk2-devel@lists.01.org
> Cc: nd <nd@arm.com>; Arvind Chauhan <Arvind.Chauhan@arm.com>;
> ard.biesheuvel@linaro.org; leif.lindholm@linaro.org; Stephanie Hughes-Fitt
> <Stephanie.Hughes-Fitt@arm.com>
> Subject: [edk2] [PATCH edk2-platforms v2 0/3][platforms/devel-
> dynamictables] Update for ACPICA compiler enhancements
> 
> The ACPICA iAsl compiler has recently been enhanced to support a feature
> required by Dynamic Tables Framework for processing ASL files. The
> compiler however generates slightly different symbol names to what was
> previously referenced in the Configuration Manager.
> 
> This patchset adapts to the latest iASL compiler options.
> 
> The changes can be seen at
> https://github.com/samimujawar/edk2-
> platforms/tree/258_reflect_acpica_compiler_enhancement_v2
> 
> Sami Mujawar (3):
>   Platform/ARM: Match asl compiler output for Juno
>   Platform/ARM: Match asl compiler output for FVP
>   Update Readme.md to reflect ACPICA compiler update
> 
> 
> Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/C
> onfigurationManager.c     |  8 +++----
> 
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerD
> xe/ConfigurationManager.c |  2 +-
>  Readme.md                                                                                    | 25
> +++++++++++++-------
>  3 files changed, 21 insertions(+), 14 deletions(-)
> 
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> 
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

Re: [PATCH edk2-platforms v2 0/3][platforms/devel-dynamictables] Update for ACPICA compiler enhancements

[Leif Lindholm]

On Fri, May 18, 2018 at 02:29:20PM +0000, Evan Lloyd wrote:
> Reviewed-by: Evan Lloyd <Evan.Lloyd@arm.com>
> 
> Leif, Ard - are you happy to accept this for the patchset, or should I respond to each patch?

This is ideal, thanks.
For series: Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as e28edfba42..8b567a9cf8.

> Regards,
> Evan
> 
> > -----Original Message-----
> > From: edk2-devel <edk2-devel-bounces@lists.01.org> On Behalf Of Sami
> > Mujawar
> > Sent: 18 May 2018 14:13
> > To: edk2-devel@lists.01.org
> > Cc: nd <nd@arm.com>; Arvind Chauhan <Arvind.Chauhan@arm.com>;
> > ard.biesheuvel@linaro.org; leif.lindholm@linaro.org; Stephanie Hughes-Fitt
> > <Stephanie.Hughes-Fitt@arm.com>
> > Subject: [edk2] [PATCH edk2-platforms v2 0/3][platforms/devel-
> > dynamictables] Update for ACPICA compiler enhancements
> > 
> > The ACPICA iAsl compiler has recently been enhanced to support a feature
> > required by Dynamic Tables Framework for processing ASL files. The
> > compiler however generates slightly different symbol names to what was
> > previously referenced in the Configuration Manager.
> > 
> > This patchset adapts to the latest iASL compiler options.
> > 
> > The changes can be seen at
> > https://github.com/samimujawar/edk2-
> > platforms/tree/258_reflect_acpica_compiler_enhancement_v2
> > 
> > Sami Mujawar (3):
> >   Platform/ARM: Match asl compiler output for Juno
> >   Platform/ARM: Match asl compiler output for FVP
> >   Update Readme.md to reflect ACPICA compiler update
> > 
> > 
> > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/C
> > onfigurationManager.c     |  8 +++----
> > 
> > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerD
> > xe/ConfigurationManager.c |  2 +-
> >  Readme.md                                                                                    | 25
> > +++++++++++++-------
> >  3 files changed, 21 insertions(+), 14 deletions(-)
> > 
> > --
> > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> > 
> > 
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel