From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (EUR04-VI1-obe.outbound.protection.outlook.com [40.107.8.82]) by mx.groups.io with SMTP id smtpd.web10.8470.1582091961530499140 for ; Tue, 18 Feb 2020 21:59:22 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nxp.com header.s=selector2 header.b=kKiyYAXo; spf=pass (domain: nxp.com, ip: 40.107.8.82, mailfrom: gaurav.jain@nxp.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=egcbSrfCDu2Aku8VHU5yP3nnmA+quWW5v7D4y3tNCt4FLgMfxoSLDp8ov8b8NJg9woIaNdLz5wTRv8M1cl/Nu9QVzvPICDQStMcGtHVTJhVYXDugRkyOVZKH1ziBNKXDM9Xh75Es/Xdv5CrFhUVZXdGLDC57s9MZAHejDXKQnpcfiMyRuNj8w1w7vevjsOQBM9+PlMCYQMWtoplKqNOuHh3HExyjYUeijU0ilE+JNgqvglwFy03DEw/gIfIlTUJa9Cz8d/YEv6JH1iEWkWLbD7KQPoFNMxklRAdUMhn6+5CYC2kssQ6PvedRDlHP9CPYdALC0CGyEpTIPSNU7wjYrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kCvkzCRXMSENhE4h4DX5F4y0BQocQpmapQR94EsdTzo=; b=i3yt8eNISun+GLwIJl8bIsla9fdx4CcaErFQN1gq2orvVUhqKecMBgp0PSUen+D2CBXDEN1HBi/l1z4Spn4L6912XUZ5379m5gSRhyYraVn1kw213R1zfDLvVNp1/AOraK5LWzTOwJ+Q+M/jyglCvM4zJyyJH3TxerSdtCGLZQ7dHrLfZEpEnwtCyOM9mhJOi6hsMAN9ajjk5KpCIj7jbuGFq/nJZzdfAkTzuKpNtnwD6HigMCKtGVDB+wApEP6X3U6D+90Yk9L259DQYcKb3ks55sDJSpFzRZvK+Lgq1ZJPKwkTLFx3fL7Mc6+KlxGj76wbx8PGn7MX9roqr2TWBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kCvkzCRXMSENhE4h4DX5F4y0BQocQpmapQR94EsdTzo=; b=kKiyYAXoAP1qRcksq5a3+n6BsG3QlZAv6OcqFA+WJlTnS8FiI/2rd6vsLUB0ovH5Yd1rZ4lzNkpJoERnF3YVW+gvLaCKs3vdDzlQ5v6zWe7Z5ZKuUTChhp8g4UPXCQli3Gx+zI1yN7/dpU/j9YjfK53mVVUyxN2dv9SuDhim9ZY= Received: from DB7PR04MB4091.eurprd04.prod.outlook.com (52.134.110.144) by DB7PR04MB4668.eurprd04.prod.outlook.com (52.135.140.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.25; Wed, 19 Feb 2020 05:59:18 +0000 Received: from DB7PR04MB4091.eurprd04.prod.outlook.com ([fe80::183:969:2508:3c92]) by DB7PR04MB4091.eurprd04.prod.outlook.com ([fe80::183:969:2508:3c92%6]) with mapi id 15.20.2729.032; Wed, 19 Feb 2020 05:59:18 +0000 From: "Gaurav Jain" To: "Gao, Liming" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Wu, Hao A" , "Ni, Ray" , Pankaj Bansal Subject: Re: [EXT] RE: [edk2-devel] [PATCH 1/1] MdeModulePkg/Pci: Fixed Asserts in SCT PCIIO Protocol Test. Thread-Topic: [EXT] RE: [edk2-devel] [PATCH 1/1] MdeModulePkg/Pci: Fixed Asserts in SCT PCIIO Protocol Test. Thread-Index: AQHV10XR5XjIzUYbAkmv942vGaqAFKgfFgBggAAYJHCAAvZIYA== Date: Wed, 19 Feb 2020 05:59:18 +0000 Message-ID: References: <20200130133804.32261-1-gaurav.jain@nxp.com> <29132e3964bf4675a31517d230687c22@intel.com> In-Reply-To: <29132e3964bf4675a31517d230687c22@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=gaurav.jain@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 4902181b-fd8f-4138-d25a-08d7b500dbc9 x-ms-traffictypediagnostic: DB7PR04MB4668:|DB7PR04MB4668: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1122; x-forefront-prvs: 0318501FAE x-forefront-antispam-report: SFV:NSPM;SFS:(10001)(10009020)(4636009)(346002)(366004)(39860400002)(376002)(136003)(396003)(189003)(199004)(26005)(186003)(45080400002)(7696005)(55016002)(5660300002)(9686003)(44832011)(110136005)(54906003)(316002)(966005)(478600001)(71200400001)(81156014)(6506007)(81166006)(53546011)(4326008)(8676002)(66476007)(66556008)(64756008)(66946007)(52536014)(66446008)(2906002)(76116006)(33656002)(8936002)(86362001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB7PR04MB4668;H:DB7PR04MB4091.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uIoEIFozejmmU+h/c0jjMCoDmfh3ntC68BhAfUAohh4MkkvedOalGCcnb0wSMmpjDC4zB7nupodUvzux0FI/CAIkj60ON4In8TmQZiietisjAnLK2bY2tiFVvZFYQ2kBp4rhVGs2O7R6DUKKL5/dHm/BVttlFb1UIygXAuXd21MoX3s7NgC2/WY3DNizaG5K0+ifyE//ueCtqVGRjW90XUo2jSWBcNMvh5cqP444iR9vKoF8shlaip2J2MUmoz9swP/wc57hr7KF/SjO6+mEmNun0MOv4M8MlRROsK8xkh3WODSnnez0W7qhaIn39Yx2K6Ooyn0Jfu3U+Ni3oZPYiGsyzfdwF07Ma0Kk8TGKpW2sb5hDFvIMTq6yV1+8XHL8q5T3mhOSuvyu0z3bv6BhNM740aR7eXrKo5W7ASjjRCQp/efXtkSLRP7e3//5mRJKaAHvrm3TMLYBSwTZKEga5n0a2Ymd0e9MB9V2JTBSsvBVf+YJi5fCw7n9Wa1zJUQ01a25IoIM3WxTaHfMCuKIGIqaPXMzSvr4rp5xzqjhus9WwNTOORbT6p+foSLXODhGToFYNA30LPz7J59Nd4sSZ/rAd3qm5CsxvTEMnTvdcLfEItCGFXac9PV3ldwuAxZ8 x-ms-exchange-antispam-messagedata: XykdQs7SDTrew+5cvTvfxC+/6AOsLXaPbZV8fVO4sSe57GKWI9o5GUFpC0fIjcxa3kqSg6thRgZCsuxLbOZXuc5+4q+po2udpvTAGgJ+ZOm1SKFHBuw+OhW86ZV3RhsgmiInKC49j19OPun4+qvuQg== MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4902181b-fd8f-4138-d25a-08d7b500dbc9 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Feb 2020 05:59:18.6559 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xACRRxmwUTddZr481Ah1Nl3QoyC7GlVBcqf5lPWAiLOsmj65zwzngJW/G66Bdiw8va6PoLhSxsiya5DjsVwEEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4668 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Gao > Gaurav: > Does this patch catch to edk2 stable tag 202002? Yes > -----Original Message----- > From: Gao, Liming > Sent: Monday, February 17, 2020 2:15 PM > To: devel@edk2.groups.io; Gaurav Jain ; Gao, Liming > > Cc: Wang, Jian J ; Wu, Hao A = ; > Ni, Ray ; Pankaj Bansal > Subject: [EXT] RE: [edk2-devel] [PATCH 1/1] MdeModulePkg/Pci: Fixed Asse= rts in > SCT PCIIO Protocol Test. >=20 > Caution: EXT Email >=20 > Gaurav: > Does this patch catch to edk2 stable tag 202002? >=20 > Thanks > Liming > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Gaurav > > Jain > > Sent: Monday, February 17, 2020 3:18 PM > > To: devel@edk2.groups.io > > Cc: Wang, Jian J ; Wu, Hao A > > ; Ni, Ray ; Pankaj Bansal > > > > Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/Pci: Fixed Asserts = in SCT > PCIIO Protocol Test. > > > > Gentle Reminder!! > > Please review.. > > > > > -----Original Message----- > > > From: Gaurav Jain > > > Sent: Thursday, January 30, 2020 1:48 PM > > > To: devel@edk2.groups.io > > > Cc: Jian J Wang ; Hao A Wu > > > ; Ray Ni ; Pankaj Bansal > > > ; Gaurav Jain > > > Subject: [PATCH 1/1] MdeModulePkg/Pci: Fixed Asserts in SCT PCIIO > > > Protocol Test. > > > > > > ASSERT in CopyMem_Conf, PollMem_Conf, SetBarAttributes_Conf > > > Conformance Test. > > > SCT Test expect return as Invalid Parameter. > > > So removed ASSERT(). > > > > > > Signed-off-by: Gaurav Jain > > > --- > > > .../NonDiscoverablePciDeviceIo.c | 20 ++++++++++++++++= --- > > > 1 file changed, 17 insertions(+), 3 deletions(-) > > > > > > diff --git > > > > a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePc > > > iD > > > eviceIo.c > > > > b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePc > > > iD > > > eviceIo.c > > > index 2d55c9699322..76cb000602fc 100644 > > > --- > > > > a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePc > > > iD > > > eviceIo.c > > > +++ > > > > b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePc > > > +++ iDeviceIo.c > > > @@ -93,7 +93,15 @@ PciIoPollMem ( > > > OUT UINT64 *Result > > > ) > > > { > > > - ASSERT (FALSE); > > > + if ((UINT32)Width >=3D EfiPciIoWidthMaximum || > > > + Width > EfiPciIoWidthUint64) { > > > + return EFI_INVALID_PARAMETER; > > > + } > > > + > > > + if (Result =3D=3D NULL) { > > > + return EFI_INVALID_PARAMETER; > > > + } > > > + > > > return EFI_UNSUPPORTED; > > > } > > > > > > @@ -556,7 +564,10 @@ PciIoCopyMem ( > > > IN UINTN Count > > > ) > > > { > > > - ASSERT (FALSE); > > > + if ((UINT32)Width >=3D EfiPciIoWidthMaximum || > > > + Width > EfiPciIoWidthUint64) { > > > + return EFI_INVALID_PARAMETER; > > > + } > > > return EFI_UNSUPPORTED; > > > } > > > > > > @@ -1414,7 +1425,10 @@ PciIoSetBarAttributes ( > > > IN OUT UINT64 *Length > > > ) > > > { > > > - ASSERT (FALSE); > > > + if (Offset =3D=3D NULL || Length =3D=3D NULL) { > > > + return EFI_INVALID_PARAMETER; > > > + } > > > + > > > return EFI_UNSUPPORTED; > > > } > > > > > > -- > > > 2.17.1 > > > > > >=20