Re: [PATCH edk2-platforms v1 0/7] Updates to support Dynamic AML

["Sami Mujawar" <sami.mujawar@arm.com>]

Hi Ard,

Thanks for reviewing this series.

I missed removing the commit IDs after rebasing the patches. I will fix that and resend the series.

Can you also review the dependent patch series at https://edk2.groups.io/g/devel/message/63246, please?

Regards,

Sami Mujawar

-----Original Message-----
From: Ard Biesheuvel <ard.biesheuvel@arm.com> 
Sent: 13 August 2020 01:32 PM
To: Sami Mujawar <Sami.Mujawar@arm.com>; devel@edk2.groups.io
Cc: leif@nuviainc.com; Alexei Fedorov <Alexei.Fedorov@arm.com>; Pierre Gondois <Pierre.Gondois@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>; Ben Adderson <Ben.Adderson@arm.com>; Thomas Abraham <thomas.abraham@arm.com>; Hemendra Dassanayake <Hemendra.Dassanayake@arm.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; nd <nd@arm.com>
Subject: Re: [PATCH edk2-platforms v1 0/7] Updates to support Dynamic AML

On 8/13/20 11:08 AM, Sami Mujawar wrote:
> Dynamic Tables Framework has been updated to add support for Dynamic 
> AML at 
> https://edk2.groups.io/g/devel/topic/patch_v1_00_30_add_dynamic/761491
> 33
> 
> The SPCR and DBG2 generators have been updated to use the Serial Port 
> Fixup Library to dynamically generate the corresponding Serial ports 
> as Definition Block tables. This makes the static description of the 
> SPCR and DBG2 Serial Port definition blocks redundant.
> 
> To dynamically describe the platform serial ports a SSDT Serial Port 
> generator has also been introduced.
> 
> In light of the above, the patches in this series:
>   - Remove the redundant static Serial port definition blocks.
>   - Use the SSDT Serial Port generator to describe the FVP
>     platform Serial ports.
>   - Fix an issue with incorrect interrupt assignment on FVP
>     platform.
>   - Remove unnecessary libraries linked with the Configuration
>     Manager.
>   - Increase the Juno FD size to accommodate AmlLib.
> 
> Note: This patch series is dependent on the patch series at 
> https://edk2.groups.io/g/devel/message/63246, which must be merged 
> before this series can be integrated.
> 
> The changes for this patch series can be seen at:
> https://github.com/samimujawar/edk2-platforms/tree/675_dynamic_aml_v1
> 
> Pierre Gondois (1):
>    ArmPlatformPkg: Juno: Increase FD size
> 
> Sami Mujawar (6):
>    Platform/ARM/Juno: Remove SSDT UART table
>    Platform/ARM: FVP: Fix serial port interrupt
>    Platform/ARM: FVP: Add UART base address length
>    Platform/ARM: FVP: Enable SSDT Serial generation
>    Platform/ARM: Juno: Configuration Mgr lib linkage
>    Platform/ARM: FVP: Configuration Mgr lib linkage
> 

For the series

Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

but please drop the Gerrit change IDs from the commit messages before pushing.


>   Platform/ARM/JunoPkg/ArmJuno.fdf                                                                  |  8 ++--
>   Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtUart.asl          | 42 -------------------
>   Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c          |  7 ----
>   Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h          |  3 +-
>   Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf     |  4 +-
>   Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc                                              |  4 +-
>   Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/Dsdt.asl          | 25 ++---------
>   Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c      | 44 ++++++++++++++++++--
>   Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h      |  5 ++-
>   Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf |  2 -
>   10 files changed, 56 insertions(+), 88 deletions(-)
>   delete mode 100644 Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtUart.asl
>