acpiview error handling patches

acpiview error handling patches

[Tomas Pilar (tpilar)]

[-- Attachment #1: Type: text/plain, Size: 102 bytes --]

Hi Ray, Zhichao,

Did you have any opinions on my acpiview error handling patches?

Cheers,
Tom

[-- Attachment #2: Type: text/html, Size: 1800 bytes --]

Re: acpiview error handling patches

[Gao, Zhichao]

[-- Attachment #1: Type: text/plain, Size: 481 bytes --]

Hi Tomas,

I would review the patch set and give comments before end of this week.

Thanks,
Zhichao

From: Tomas Pilar <Tomas.Pilar@arm.com>
Sent: Monday, July 6, 2020 6:12 PM
To: devel@edk2.groups.io
Cc: nd <nd@arm.com>; Sami Mujawar <Sami.Mujawar@arm.com>; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>
Subject: acpiview error handling patches

Hi Ray, Zhichao,

Did you have any opinions on my acpiview error handling patches?

Cheers,
Tom

[-- Attachment #2: Type: text/html, Size: 4022 bytes --]

Re: [edk2-devel] acpiview error handling patches

[Tomas Pilar (tpilar)]

(change of email)

Hi Zhichao,

I've amended the patches and respun a v3 version. Any chance you could have a look to see if I've fixed the issues correctly?

Cheers,
Tom

Re: [edk2-devel] acpiview error handling patches

[Gao, Zhichao]

I am  busy at other works recent weeks. I plan to review the patch in next two weeks. Hope it is acceptable for you.

Thanks,
Zhichao

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Tomas Pilar
> (tpilar)
> Sent: Wednesday, July 29, 2020 7:23 PM
> To: Gao; Gao, Zhichao <zhichao.gao@intel.com>; devel@edk2.groups.io
> Subject: Re: [edk2-devel] acpiview error handling patches
> 
> (change of email)
> 
> Hi Zhichao,
> 
> I've amended the patches and respun a v3 version. Any chance you could have a
> look to see if I've fixed the issues correctly?
> 
> Cheers,
> Tom
> 
> 

Re: [edk2-devel] acpiview error handling patches

[Sami Mujawar]

Hi Zhichao,

Some patches in this series need reworking.

Example - For '[PATCH v3 1/8] ShellPkg/AcpiView: Extract configuration struct' & '[PATCH v3 2/8] ShellPkg/AcpiView: Declutter error counters'
I feel accessor methods offer a better design and should be retained.

Other patches in the series need a bit of rework to follow coding conventions etc.

This patch series has too many changes to the parsers. I request to put this patch series on hold as we have other patches that need to go in on priority. e.g. loop detection in PPTT table.

Since Tomas is no longer with Arm, someone from Arm will pick up repost the reworked series.

Regards,

Sami Mujawar

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gao, Zhichao via groups.io
Sent: 31 July 2020 01:43 AM
To: devel@edk2.groups.io; tomas@nuviainc.com
Subject: Re: [edk2-devel] acpiview error handling patches

I am  busy at other works recent weeks. I plan to review the patch in next two weeks. Hope it is acceptable for you.

Thanks,
Zhichao

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Tomas
> Pilar
> (tpilar)
> Sent: Wednesday, July 29, 2020 7:23 PM
> To: Gao; Gao, Zhichao <zhichao.gao@intel.com>; devel@edk2.groups.io
> Subject: Re: [edk2-devel] acpiview error handling patches
>
> (change of email)
>
> Hi Zhichao,
>
> I've amended the patches and respun a v3 version. Any chance you could
> have a look to see if I've fixed the issues correctly?
>
> Cheers,
> Tom
>
>




IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Re: [edk2-devel] acpiview error handling patches

[Gao, Zhichao]

I am fine with that. BTW, it is better to add a BZ for this change. BZ would make a good history of the discussion on this feature or bug fix.
Consumers may not aware of the discussion thru devel@edk2.groups.io, but they will always find the record in BZ link.

Thanks,
Zhichao

> -----Original Message-----
> From: Sami Mujawar <Sami.Mujawar@arm.com>
> Sent: Tuesday, August 11, 2020 9:45 PM
> To: devel@edk2.groups.io; Gao, Zhichao <zhichao.gao@intel.com>
> Cc: tomas@nuviainc.com; Matteo Carlini <Matteo.Carlini@arm.com>
> Subject: RE: [edk2-devel] acpiview error handling patches
> 
> Hi Zhichao,
> 
> Some patches in this series need reworking.
> 
> Example - For '[PATCH v3 1/8] ShellPkg/AcpiView: Extract configuration struct' &
> '[PATCH v3 2/8] ShellPkg/AcpiView: Declutter error counters'
> I feel accessor methods offer a better design and should be retained.
> 
> Other patches in the series need a bit of rework to follow coding conventions etc.
> 
> This patch series has too many changes to the parsers. I request to put this
> patch series on hold as we have other patches that need to go in on priority. e.g.
> loop detection in PPTT table.
> 
> Since Tomas is no longer with Arm, someone from Arm will pick up repost the
> reworked series.
> 
> Regards,
> 
> Sami Mujawar
> 
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gao, Zhichao
> via groups.io
> Sent: 31 July 2020 01:43 AM
> To: devel@edk2.groups.io; tomas@nuviainc.com
> Subject: Re: [edk2-devel] acpiview error handling patches
> 
> I am  busy at other works recent weeks. I plan to review the patch in next two
> weeks. Hope it is acceptable for you.
> 
> Thanks,
> Zhichao
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Tomas
> > Pilar
> > (tpilar)
> > Sent: Wednesday, July 29, 2020 7:23 PM
> > To: Gao; Gao, Zhichao <zhichao.gao@intel.com>; devel@edk2.groups.io
> > Subject: Re: [edk2-devel] acpiview error handling patches
> >
> > (change of email)
> >
> > Hi Zhichao,
> >
> > I've amended the patches and respun a v3 version. Any chance you could
> > have a look to see if I've fixed the issues correctly?
> >
> > Cheers,
> > Tom
> >
> >
> 
> 
> 
> 
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended recipient,
> please notify the sender immediately and do not disclose the contents to any
> other person, use it for any purpose, or store or copy the information in any
> medium. Thank you.

Re: [edk2-devel] acpiview error handling patches

[Sami Mujawar]

Hi Zhichao,

Thanks.  I have logged this in Bugzilla "Bug 2893 - Acpiview: Standardise error log output format" (https://bugzilla.tianocore.org/show_bug.cgi?id=2893).

Regards,

Sami Mujawar

-----Original Message-----
From: Gao, Zhichao <zhichao.gao@intel.com> 
Sent: 12 August 2020 01:41 AM
To: Sami Mujawar <Sami.Mujawar@arm.com>; devel@edk2.groups.io
Cc: tomas@nuviainc.com; Matteo Carlini <Matteo.Carlini@arm.com>
Subject: RE: [edk2-devel] acpiview error handling patches

I am fine with that. BTW, it is better to add a BZ for this change. BZ would make a good history of the discussion on this feature or bug fix.
Consumers may not aware of the discussion thru devel@edk2.groups.io, but they will always find the record in BZ link.

Thanks,
Zhichao

> -----Original Message-----
> From: Sami Mujawar <Sami.Mujawar@arm.com>
> Sent: Tuesday, August 11, 2020 9:45 PM
> To: devel@edk2.groups.io; Gao, Zhichao <zhichao.gao@intel.com>
> Cc: tomas@nuviainc.com; Matteo Carlini <Matteo.Carlini@arm.com>
> Subject: RE: [edk2-devel] acpiview error handling patches
> 
> Hi Zhichao,
> 
> Some patches in this series need reworking.
> 
> Example - For '[PATCH v3 1/8] ShellPkg/AcpiView: Extract configuration 
> struct' & '[PATCH v3 2/8] ShellPkg/AcpiView: Declutter error counters'
> I feel accessor methods offer a better design and should be retained.
> 
> Other patches in the series need a bit of rework to follow coding conventions etc.
> 
> This patch series has too many changes to the parsers. I request to 
> put this patch series on hold as we have other patches that need to go in on priority. e.g.
> loop detection in PPTT table.
> 
> Since Tomas is no longer with Arm, someone from Arm will pick up 
> repost the reworked series.
> 
> Regards,
> 
> Sami Mujawar
> 
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gao, 
> Zhichao via groups.io
> Sent: 31 July 2020 01:43 AM
> To: devel@edk2.groups.io; tomas@nuviainc.com
> Subject: Re: [edk2-devel] acpiview error handling patches
> 
> I am  busy at other works recent weeks. I plan to review the patch in 
> next two weeks. Hope it is acceptable for you.
> 
> Thanks,
> Zhichao
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Tomas 
> > Pilar
> > (tpilar)
> > Sent: Wednesday, July 29, 2020 7:23 PM
> > To: Gao; Gao, Zhichao <zhichao.gao@intel.com>; devel@edk2.groups.io
> > Subject: Re: [edk2-devel] acpiview error handling patches
> >
> > (change of email)
> >
> > Hi Zhichao,
> >
> > I've amended the patches and respun a v3 version. Any chance you 
> > could have a look to see if I've fixed the issues correctly?
> >
> > Cheers,
> > Tom
> >
> >
> 
> 
> 
> 
> IMPORTANT NOTICE: The contents of this email and any attachments are 
> confidential and may also be privileged. If you are not the intended 
> recipient, please notify the sender immediately and do not disclose 
> the contents to any other person, use it for any purpose, or store or 
> copy the information in any medium. Thank you.