From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (EUR02-HE1-obe.outbound.protection.outlook.com [40.107.1.76]) by mx.groups.io with SMTP id smtpd.web11.10602.1589892039848395031 for ; Tue, 19 May 2020 05:40:40 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=CgPH5fnI; spf=pass (domain: arm.com, ip: 40.107.1.76, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vp2GSRt695fzRUFrxGEOl/opnz8FIFsZnN/NTqLJfFI=; b=CgPH5fnI8KtNDlBRdlPvttyNS6/QU8b4B+iNSXemizGXwagebgqu/lLbWfy/twRcfDG/lowXWYpkb7r9T+qE3APYxMqW1piGdKbedss0QdWZ3BGVXWDxdZHDWYXbGFKvShCwsLcs5mCO7lQjKxhJ3wtJyNlurniekOovPfbPLxQ= Received: from DB6PR1001CA0037.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::23) by AM6PR08MB4424.eurprd08.prod.outlook.com (2603:10a6:20b:73::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.20; Tue, 19 May 2020 12:40:37 +0000 Received: from DB5EUR03FT015.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:55:cafe::4) by DB6PR1001CA0037.outlook.office365.com (2603:10a6:4:55::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.25 via Frontend Transport; Tue, 19 May 2020 12:40:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT015.mail.protection.outlook.com (10.152.20.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.19 via Frontend Transport; Tue, 19 May 2020 12:40:36 +0000 Received: ("Tessian outbound d078647f4174:v57"); Tue, 19 May 2020 12:40:36 +0000 X-CR-MTA-TID: 64aa7808 Received: from 3449e6316833.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 20925C4B-D4DA-430F-8948-64C9A941F600.1; Tue, 19 May 2020 12:40:31 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3449e6316833.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 19 May 2020 12:40:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I61GRptuJtq7SoKhAVv66U4AcwyLFdJLJz1XXYTG9xnxLngtNCMpGVxaiCI62s/X570gRm8h81ZJt79X0agvG1zO4Ww6yeefsdsKE4EPjiNQITD/rTrAPHtrb1M3NfTV8vFW2TwYQEDI16dMmwpErudIFuGLZEBF9xfJadd+IsvG4K4a30Ee8gby0cjmpa53Bq/nkXRelAZXIamjQwDwLnAEVUWQ+g4iGooCkg1U+evX1l0cWvWyEqL4n264JxyfBr9T97CpCRu4UMvubBJ3kpjZG5hIahkXm4IbRp57bDEwemYyl99T1h2F245zWXu/NFokWZx1XQR9upE2dK2Z2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vp2GSRt695fzRUFrxGEOl/opnz8FIFsZnN/NTqLJfFI=; b=Q0EdWXIuLxOJmWO0k4XJYJGD+60ewQkNXri3XuHNg2DBCTxTUnY8BrpTsrf6NUVP3zAkJKEbFfSMLXR1fQkQWOvSVP7AE/fH2Km3iSkDuRJrVrLRG+BSykjTJk61NZnRx+OUF0ylpL5AhHQevX2MaOCa3/VFvpGZ/c3USDbQcmGMmLq7d8HtDvToTzFaU2zJrwAtoUA6QE4VpQNnlUishSwZ5hgYRbE95nzoBxzBQShKeVvRAOwjQUAIdsJKtdLA0mGx+Qe9D8FomJiJUMvVnOyBAyqM9VTNRxviIfoPL8z8UY24Ehtc/w2BXagDyf/1miZoSYqvTz1xFB+cSSYypg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vp2GSRt695fzRUFrxGEOl/opnz8FIFsZnN/NTqLJfFI=; b=CgPH5fnI8KtNDlBRdlPvttyNS6/QU8b4B+iNSXemizGXwagebgqu/lLbWfy/twRcfDG/lowXWYpkb7r9T+qE3APYxMqW1piGdKbedss0QdWZ3BGVXWDxdZHDWYXbGFKvShCwsLcs5mCO7lQjKxhJ3wtJyNlurniekOovPfbPLxQ= Received: from DB7PR08MB3097.eurprd08.prod.outlook.com (2603:10a6:5:1d::27) by DB7PR08MB3051.eurprd08.prod.outlook.com (2603:10a6:5:1e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.20; Tue, 19 May 2020 12:40:30 +0000 Received: from DB7PR08MB3097.eurprd08.prod.outlook.com ([fe80::587:15d3:8425:65f9]) by DB7PR08MB3097.eurprd08.prod.outlook.com ([fe80::587:15d3:8425:65f9%6]) with mapi id 15.20.3000.034; Tue, 19 May 2020 12:40:30 +0000 From: "Sami Mujawar" To: Ard Biesheuvel , "devel@edk2.groups.io" CC: "leif@nuviainc.com" , "graeme.gregory@linaro.org" , "tanmay.jagdale@linaro.org" , "lersek@redhat.com" , Ard Biesheuvel Subject: Re: [PATCH v2 0/2] ArmPkg/PlatformBootManagerLib: add build time checks for serial terminal settings Thread-Topic: [PATCH v2 0/2] ArmPkg/PlatformBootManagerLib: add build time checks for serial terminal settings Thread-Index: AQHWLdhpjsmJuzIZl0yYt5d8WBdTqqivWN2A Date: Tue, 19 May 2020 12:40:30 +0000 Message-ID: References: <20200519122351.18405-1-ard.biesheuvel@arm.com> In-Reply-To: <20200519122351.18405-1-ard.biesheuvel@arm.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 558f5c8c-052c-4160-afe3-33a6f4303d2d.1 x-checkrecipientchecked: true Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [2a00:23c6:548a:4800:25d4:ae52:bc8b:5b5f] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 38a122c5-c609-436e-8b84-08d7fbf1d4a2 x-ms-traffictypediagnostic: DB7PR08MB3051:|AM6PR08MB4424: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:6108;OLM:10000; x-forefront-prvs: 040866B734 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: AxEOr34k1KgxK2JZT/fl5lAXEHJCrmZih3uw3cl5vu4ryTwl0i6EDvV54CGmuQyCpk3kWYijD/KxfCxmA8MmT94/bDkB+IMkLxDXtd0JOQ+RQVNIFI47T3/VgXYb1botFfF4yhff7SGkkpulkSpAiEVoArod8g+zzWyTT6+St5HGkb9QqjO/oivh082FV7vC/2IQSlJZKbtGqDRO6f0nLMY6JtUVj+TeKRyiLxWHxKNSbRfEn1ROl+PaTgU9jfVU/V8E844y6hJTY8A4CLh1BDR73ETixewszSg2Ct5lVN1o7lVT6dlPveqLqGiTALaC11waEKqfrgcf2Trn4gPAAzacmAumo2SpRzgRPHcIawTX+RoS8NRHH9hLNkCyfiQkTFHAZoBDRwNeiDCqt4+ffH7q6ye/Ql3fDGsVk0dLE35YjxhB6DWqT09LTSI+GTVo X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3097.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(366004)(39860400002)(346002)(376002)(396003)(136003)(33656002)(4326008)(71200400001)(52536014)(53546011)(86362001)(186003)(110136005)(5660300002)(54906003)(6506007)(7696005)(316002)(9686003)(64756008)(66946007)(66476007)(66556008)(66446008)(55016002)(8936002)(8676002)(2906002)(76116006)(478600001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: AiCCw4RMpuB3CXcz+8g5Kvt1W3GekJTteXjhQ+44EQQljwH4rySQR9N7caQMQiJUzX7/3IBt6w37gakNqcBrhxTB4yD9jIuhn//2puByMBvSKL57pfyCXF02tl5IIWFjdNeJguByZYaKoiM6JwweyhgdfcjfspPyV7L5+XOHW1i90api1vb/IEDEd3IIZI41Ov6Av5v4akGjrWSdn0zgr+zctDATtgAWCvmqYM+mna04sTs+9FJQw5tiEWYy6kzrxUpC648AWtFAPBBuA52wl6Z0quvKBnszkCMcBtNXK+WqazT1u+GURjvpQDPJ5/Ldo9r/AOuwgYvtXaOtElcCpCASB5ecRGsF2TF14W8lflenOlCmO/OWmmUqOZC3z5Xf0zapV6Zgg8hMsaZlern9p4XtjgGaOP4Lz2v+2Gto1qzTqUABP5UxVwEgT4DztMc+A4YKWdwnh+ESDvHhn6ooOTEPsjDeAvyq7Tm6Jc1dbA9wXbmL7Dt8Cv66qUlflBtIgA66i7Dr/G6cq3QcJeKr7Ef/UagbkUYsygJoa75F6PW3maWft1g0nRkleDgNNd8v MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3051 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT015.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFTY:;SFS:(4636009)(376002)(396003)(346002)(39860400002)(136003)(46966005)(54906003)(478600001)(8676002)(4326008)(5660300002)(8936002)(55016002)(186003)(82740400003)(47076004)(33656002)(9686003)(2906002)(86362001)(110136005)(316002)(82310400002)(52536014)(356005)(7696005)(26005)(81166007)(53546011)(336012)(6506007)(70586007)(70206006);DIR:OUT;SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: 6097eb93-8d8c-432f-3544-08d7fbf1d0ae X-Forefront-PRVS: 040866B734 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4nl2WsEAMeS0oJ6goWFF5yemjgCx1oqGR/Hs7oAAlNF6zCLxOO9vzk9HTtoXdydKgDkDgjlChhaRRYzRTx543F1URrd7X+MNED9O9Ub1IbE02FX2pO9u17G8Uw40JBd9iME/I6rialKBnL69VGWJ5qiVXj34Gl8HlIyxy4M/bzPaIl8PCduNgryrtBUPKFYzfDsu0gS2+2SRUDn6Xj4VLDgCZnhkBMuCGEb+cq30mbhGkKt0CWFk97aKpLJbjB/+3WeEwnxIgIOFBn2x8KvFTHm1XezX2Ak0JYvaAv3GhYWR6nPi3Ib3NS/G7YYf9ao2mBn742VFPPEdsvBxiuhWzMfmCV1dRaaa7xNL+vP3HxNIlg7sltflrBJLUBLb4J3lqLIHI0X5bLFO/epe7qXnZRWHnqfkK5ni7ske3SP0LleYO9pFDKhsoYMie6yOQQlQk+R7odG/5ZlNVV0EGc/zzbHheLTlEzJGrRGkoRUxJaaFkX4ORiJKO222oYJYO7QDkPsa0d70we6zTG+oFC46Wg== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2020 12:40:36.9257 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 38a122c5-c609-436e-8b84-08d7fbf1d4a2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4424 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sami Mujawar Regards, Sami Mujawar -----Original Message----- From: Ard Biesheuvel Sent: 19 May 2020 01:24 PM To: devel@edk2.groups.io Cc: leif@nuviainc.com; graeme.gregory@linaro.org; tanmay.jagdale@linaro.org= ; lersek@redhat.com; Sami Mujawar ; Ard Biesheuvel Subject: [PATCH v2 0/2] ArmPkg/PlatformBootManagerLib: add build time check= s for serial terminal settings Add build time checks for serial terminal settings, so we don't end up with= a non-functional serial console if the PCDs are set incorrectly v1 was just the second patch. v2 adds the first patch switching to STATIC_A= SSERT first, and then uses STATIC_ASSERT in the second one as well. Ard Biesheuvel (2): ArmPkg/PlatformBootManagerLib: use static assertion for console type ArmPkg/PlatformBootManagerLib: reject 'default' parity and stop bit count ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) -- 2.17.1 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.