From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.61]) by mx.groups.io with SMTP id smtpd.web09.664.1613432268083408745 for ; Mon, 15 Feb 2021 15:37:49 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=wOUzGGh7; spf=pass (domain: arm.com, ip: 40.107.21.61, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7X9eeP/BnpmjvCzJqI9a2DK1inuUMx0fGBYzF45PULg=; b=wOUzGGh7bSZvoY5LPK5kZa0H0f0NPNFYQ0AI9Ytt4OwaaZ/AOwtDEDnZRjxjcwvyflaM/UoWPBxHfYV3khr8b/1tbgwkseqQzujH0FbauxybKlJRnm3Cb6ssF6f8kDZSjaRkDuz19ah1Y0GAZiYJIof65uDVeJ0U5gbb6yCriFE= Received: from AM5PR0601CA0032.eurprd06.prod.outlook.com (2603:10a6:203:68::18) by AM0PR08MB5140.eurprd08.prod.outlook.com (2603:10a6:208:162::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.28; Mon, 15 Feb 2021 23:37:44 +0000 Received: from VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:68:cafe::6f) by AM5PR0601CA0032.outlook.office365.com (2603:10a6:203:68::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.27 via Frontend Transport; Mon, 15 Feb 2021 23:37:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT043.mail.protection.outlook.com (10.152.19.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.25 via Frontend Transport; Mon, 15 Feb 2021 23:37:44 +0000 Received: ("Tessian outbound 2db1bbc8a1d2:v71"); Mon, 15 Feb 2021 23:37:44 +0000 X-CR-MTA-TID: 64aa7808 Received: from 172a297d0ec3.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1189D6DF-8CF5-4223-9C8D-6AAF2A3459D0.1; Mon, 15 Feb 2021 23:37:38 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 172a297d0ec3.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 15 Feb 2021 23:37:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fXkRpUHKWIss8B2OqxJy7kdjFae5wUYqkZXCLcjy1BchoLENPDkuxvzlhvqgZ7uXdWq2b92xcEEx935Tq4FA1YsrXqiEBI6msUfH9rd1S+OnwTQlPZg1FbuofwcrwWwgdJw+kZ3GTp98qIwt9VH8AGizkFNLifHtAO3ha6waVyoluX2oGqH9M8QZQ4zmAhy/qHeLDpdj83R9Id5BNHyujzyWFJ9zo9QVWE4CaplGr51/etVhg9w3CcwIzu9QyXWqdPOAmJHVGuKanmKJMrLOsBvH3FJwtjR6Om1DPe32GQABN+spgRtl/rVsVc271PIc+NVfQMMfysxgzyFYnWIvkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7X9eeP/BnpmjvCzJqI9a2DK1inuUMx0fGBYzF45PULg=; b=AOmLI/N3+2gfc3yOYcXwOBziRvXFfFXCli7wiAZOMtTsc97eI5EErp3YNUpDNtbme/DMCVDD1eJFb7L/JQb+K4N1/ERsU9AEJiU0DQ+3hnvoVtbX6eeEy1D2xJYVGfwM0oUjb1omrjqJje7+3iLUITNOeKjuViUOxM6+YkK8toz4J3MpGtBcZnb98J7O7nt/tljD+ZLyqthtonP/bFSWLK0yQI3LhPKljs6Vb3E8lNM0fs9gMOzeuP0AW0NZwY4YWGlmc8CY5fLHLcmrJHeUnNyUjNiI1YO2KHKfwh0ofej9HSibXAMyGR4hnobbkE/o1HLZnDJ+hipmYkcJtQde7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7X9eeP/BnpmjvCzJqI9a2DK1inuUMx0fGBYzF45PULg=; b=wOUzGGh7bSZvoY5LPK5kZa0H0f0NPNFYQ0AI9Ytt4OwaaZ/AOwtDEDnZRjxjcwvyflaM/UoWPBxHfYV3khr8b/1tbgwkseqQzujH0FbauxybKlJRnm3Cb6ssF6f8kDZSjaRkDuz19ah1Y0GAZiYJIof65uDVeJ0U5gbb6yCriFE= Received: from DB7PR08MB3097.eurprd08.prod.outlook.com (2603:10a6:5:1d::27) by DBBPR08MB4553.eurprd08.prod.outlook.com (2603:10a6:10:d2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.25; Mon, 15 Feb 2021 23:37:37 +0000 Received: from DB7PR08MB3097.eurprd08.prod.outlook.com ([fe80::8c43:eec3:76be:9001]) by DB7PR08MB3097.eurprd08.prod.outlook.com ([fe80::8c43:eec3:76be:9001%4]) with mapi id 15.20.3846.041; Mon, 15 Feb 2021 23:37:30 +0000 From: "Sami Mujawar" To: Leif Lindholm , Pierre Gondois CC: "devel@edk2.groups.io" , Alexei Fedorov , nd Subject: Re: [PATCH 1/1] DynamicTablesPkg/AmlLib: Remove unused variables Thread-Topic: [PATCH 1/1] DynamicTablesPkg/AmlLib: Remove unused variables Thread-Index: AQHXA8i0H9rtEMuxOUG8NUeHnwregapZo92AgAA7ZyA= Date: Mon, 15 Feb 2021 23:37:29 +0000 Message-ID: References: <20210215182957.14642-1-Pierre.Gondois@arm.com> <20210215200407.GE1664@vanye> In-Reply-To: <20210215200407.GE1664@vanye> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 5216CA2310DED84F859EA6D7548E32A4.0 x-checkrecipientchecked: true Authentication-Results-Original: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [86.156.70.33] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 0b7a9efa-f646-41d0-cc0e-08d8d20ab1b7 x-ms-traffictypediagnostic: DBBPR08MB4553:|AM0PR08MB5140: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:3044;OLM:3044; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: NOeR1ijGybnbrr6u7MenzBInOsDjXus62XBoxE8tX6wRR6Tc8f715EotT2QT+MRln2/tadNyDhhPYmlnJiYd6xmBYhwVmoswQHewHSxENXQjRGTyQIe20HNNCXxB3z1pvwJ4bG+bmqzgLS2ITZob8uTJDj9f2jwlqQIhMJ9Sc+oSX2+NCc+vCB6+VYUVF6YJTmY30O/nkglKx9G3xnpZft/lQRUvDfOk+ag5+7VCIra73sWWU3PmrhRrKl3PsEuGd2Nseb7dcfgjgyGihD37eppI1TV4PoE0yzkWBKJx4vx1HiNrRjlbrCKqocU4HWasSeBAQ7YZSrDfw6g4O87eskoFd+0H6ScrgF1dG8oRvXDbjp2BnDHIsCsS+MvQsgpATHZSys22g9VPVYuxSpGXMKSF5kCRub+iS0RhMcFS+Hk5nrZ3iMtP1EFJSVg1n2uKO2GYcKf0yKbzuTWVRq+FWItfV6kYN4dNUbr9leI4oQMnRClDkZo+baz+TtNL1vyb7ygGDM0+dShK5zasMMxjbA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3097.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(39860400002)(346002)(396003)(136003)(366004)(76116006)(2906002)(52536014)(478600001)(5660300002)(86362001)(8676002)(4326008)(110136005)(54906003)(316002)(66446008)(64756008)(66556008)(6636002)(66476007)(8936002)(71200400001)(9686003)(6506007)(55016002)(7696005)(186003)(33656002)(26005)(83380400001)(53546011)(66946007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?4oAUnvEMGwHlRuPuWTLg6371nsFvkaes5MvsLq5bPFl/JArxq+9CdMfd3vtO?= =?us-ascii?Q?LhBbmnH9JP8/xdcYyfa/PAglAr2ivnoHX+LNxoF6r05NAd3IMWpyBHYqu62V?= =?us-ascii?Q?c209XhCkSpshVoTXK0f8y4t+N0k2e1t3R9bB8YOSqUi1so4VLepadgEeXwH7?= =?us-ascii?Q?eXe3NwkP7PetJyvZSAqotkgnPAcoINrrgcg6Lrd2CsXCjTR/AFb9HgSOznZ9?= =?us-ascii?Q?v/9PJ3qUum0HO/CqqfeF3o2PdHQYtOQXUsbIhvQxfASl46g4YPAHBa+NqBiu?= =?us-ascii?Q?xDlSblmX6aoZ1M42eg9wt+ZdfrrWMXWp3rFiJmUDW4RID4T+tGNdLam7GgvY?= =?us-ascii?Q?fEIZH2xYep+G1oXBaOhfU314g0/QeSGi+o0E/JByS1jyEmPS69gXtSb+eJ7Y?= =?us-ascii?Q?9Ei0/IxvyN4XUfTMCZSnZO8KP9bWQ2eCvux64xMInhQQ8DbsS/7dGEdaOI3s?= =?us-ascii?Q?XIa0avazXkh+HYy5UjGVGBSU9vdYVifwVkhRaaJMVL3vdeMFU/9dToVrIiI6?= =?us-ascii?Q?XO/JXSoRd8dW+QsI1nBPz+OTsZGj7SmHBKQQ28GWHAJcBxRc28PrUZVduNuL?= =?us-ascii?Q?Oc0fMTo0GJUiywnZCOydaQ6DbUFLiQJkncXtQp7+575hTo3VQHywQXzCJAaY?= =?us-ascii?Q?lfDaN9cYgaS8rRxFFFPN4tb+dkpSpNyJ9xWCpQrR7Q0TCWXy+odhD22zhZLV?= =?us-ascii?Q?rOLqkcWM0AnkbfWKMVTsBSlqLDsyJP43LqVlq8zQpL/zgT2NS7ZECZulF6/l?= =?us-ascii?Q?fqwxWfAYHe2VBz980j5WM6B2kpMc96ECX0zCdOV+3Gzbh6Jnj2Jx9/rj5ZeK?= =?us-ascii?Q?AQRw4KzSb9CCJoTPlo60/5i0r5qDAx8t6mzWe72PJyCHFTn3jJ2Vbw3FcMQH?= =?us-ascii?Q?Vr1y2wHvOy/3oDFc1iOmHUXjNNs860WB2ix1hc2+BcbrwRYHYiXMnI0uLpbi?= =?us-ascii?Q?pPrAdkbUewWCmesaNQKIMK/1soFA7NLghTtyFe6UcczfpKhjYYeN39OtSddq?= =?us-ascii?Q?gD6VR2DP36YyJgElxSzRQ1l9/FPTJi9miUBzJYzPZf4537tChM3b/j9tL8FW?= =?us-ascii?Q?tBfc5KhydPTtf9a/IeoaiesAlmOaUX2KWlxBs3smrodVys/wlOL0eE+Sd1zO?= =?us-ascii?Q?F2Wc/ogYjmeMOIjwtIoCFbEx+T0A2AKa2auvaXn047tYDdSwKQFGAJpme2EG?= =?us-ascii?Q?DlxgU7RKBhTNrAYUwj7CXLrPYw+YMjkDlovMaKh5E4OnAaPvriCjpt+6pHmE?= =?us-ascii?Q?aGCVDJlUGlD8AfNsnYTIlDEBXJxR4TNslTWl1oMGaqivXA2NUbWyinvLFcK/?= =?us-ascii?Q?gQk=3D?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4553 Original-Authentication-Results: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: d0acea73-d4cd-4e3d-534d-08d8d20aa986 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vqTDsV/EgiooJwz5ZZAJgM+vKem+k4CJ8j8lpB0SA/aJ9WyEHroQ3DxE1ZdK8aDqlqJPWnuvABNovo+ZhEZ8JAkIRprDiZzstKp9QwoUjgAYg/QN++r6L5mpkpcMMLWRbsf5Q5u2pVAlu1K+rurUHUMsjI7r/eV0Svpo9lXDwe2cIiBMCNqmPMrRo/GoWtgQD6mgiwabLxTU2CaMn9iaZLFHxod7TTyCU6nQxNX5zfqpGUAc912X7rLCMlpHuF6YyK8tGaotcQ/j7DgvpiIpV+UEu6qau8vaeanSr4j0OaIYWBNBkKzHPAeRNDeVorTbbLX/CXnhnuvYB9iRWzxzhvR8uOoATYYI/8DA3aTiCQ/4NicVHTtVcQr3lfXNVVEOIrdHFrjwpkER1GGU5aEYkmQsWfrHfS9RAMhnGcl9atbtb0/QXyCZeM3j2Bp7jAmdR/mYFcNOKokkXmj3vl594KnY+R5mD9toAHGxstbRn4glK4CU2afb8K+vaDrlXdZUEahomir28uHUMeFP3rdlhuv+nlq+Z4kuiGH3NX4g5q62uFldbFPNrMPsCTfgjZWc+nOBJfmpVU+jEjsBvh8Q7ADVfAKtmuxo2wI+KO/ysBitFJntB02Kzk1WDpSmqESxUazf1B5MV5+WgTAqGJqIHQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(396003)(376002)(39860400002)(346002)(46966006)(36840700001)(36860700001)(2906002)(110136005)(54906003)(4326008)(82740400003)(9686003)(478600001)(6636002)(316002)(83380400001)(55016002)(336012)(82310400003)(52536014)(8936002)(5660300002)(86362001)(47076005)(81166007)(6506007)(7696005)(70586007)(53546011)(8676002)(70206006)(26005)(33656002)(356005)(186003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2021 23:37:44.4714 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0b7a9efa-f646-41d0-cc0e-08d8d20ab1b7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5140 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed as 2e1e8c35f317..4f4d862c1c72 Thanks, Sami Mujawar -----Original Message----- From: Leif Lindholm =20 Sent: 15 February 2021 08:04 PM To: Pierre Gondois Cc: devel@edk2.groups.io; Alexei Fedorov ; Sami Muj= awar Subject: Re: [PATCH 1/1] DynamicTablesPkg/AmlLib: Remove unused variables On Mon, Feb 15, 2021 at 18:29:57 +0000, Pierre.Gondois@arm.com wrote: > From: Pierre Gondois >=20 > Building the DynamicTablesPkg for a NOOPT target > fails because unused variables are set. > Remove these variables. >=20 > Fixes: d9800046ea43 > Reported-by: Leif Lindholm > Signed-off-by: Pierre Gondois Reviewed-by: Leif Lindholm (also build tested) Thanks for quick turnaround! > --- > .../Library/Common/AmlLib/NameSpace/AmlNameSpace.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) >=20 > diff --git a/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpac= e.c b/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c > index 2d055e9fb964..8da47405af85 100644 > --- a/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c > +++ b/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c > @@ -1,7 +1,7 @@ > /** @file > AML NameSpace. > =20 > - Copyright (c) 2019 - 2020, Arm Limited. All rights reserved.
> + Copyright (c) 2019 - 2021, Arm Limited. All rights reserved.
> =20 > SPDX-License-Identifier: BSD-2-Clause-Patent > **/ > @@ -1075,10 +1075,8 @@ AmlEnumeratePathCallback ( > AML_PATH_SEARCH_CONTEXT * PathSearchContext; > =20 > AML_STREAM * SearchPathBStream; > - CHAR8 * SearchedPath; > =20 > AML_STREAM * CurrNodePathBStream; > - CHAR8 * CurrNodePath; > UINT32 CurrNodePathSize; > =20 > ContinueEnum =3D TRUE; > @@ -1123,9 +1121,6 @@ AmlEnumeratePathCallback ( > goto exit_handler; > } > =20 > - SearchedPath =3D (CHAR8*)AmlStreamGetCurrPos (SearchPathBStream); > - CurrNodePath =3D (CHAR8*)AmlStreamGetCurrPos (CurrNodePathBStream); > - > // Get the raw AML absolute pathname of the current node. > Status1 =3D AmlGetRawNameSpacePath (Node, 0, CurrNodePathBStream); > if (EFI_ERROR (Status1)) { > --=20 > 2.17.1 >=20