public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"leif@nuviainc.com" <leif@nuviainc.com>,
	"andrew.goodbody@linaro.org" <andrew.goodbody@linaro.org>
Cc: Ard Biesheuvel <Ard.Biesheuvel@arm.com>,
	Thomas Abraham <thomas.abraham@arm.com>,
	Liming Gao <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] Cannot build due to recent change
Date: Thu, 1 Oct 2020 11:07:11 +0000	[thread overview]
Message-ID: <DB7PR08MB30974EDD067C27350427080C84300@DB7PR08MB3097.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20201001104332.GG5623@vanye>

Hi All,

I am looking into this and will provide a fix shortly.

Regards,

Sami Mujawar

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Leif Lindholm via groups.io
Sent: 01 October 2020 11:44 AM
To: devel@edk2.groups.io; andrew.goodbody@linaro.org
Cc: Ard Biesheuvel <Ard.Biesheuvel@arm.com>; Thomas Abraham <thomas.abraham@arm.com>; Liming Gao <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] Cannot build due to recent change

Hi Andrew,

Welcome to the list.

First of all, it helps to cc maintainers of the bits you're having
issues with.

The GetMaintainer.py script can look these up for you automatically
for a given path:
python ../edk2/BaseTools/Scripts/GetMaintainer.py -l Platform/ARM/JunoPkg/ArmJuno.dsc
Platform/ARM/JunoPkg/ArmJuno.dsc
  Leif Lindholm <leif@nuviainc.com>
  Ard Biesheuvel <ard.biesheuvel@arm.com>
  Thomas Abraham <thomas.abraham@arm.com>

Anyway, yes - commit b5701a4c7a0f ("CryptoPkg: OpensslLib: Use RngLib
to generate entropy in rand_pool"), merged through
https://github.com/tianocore/edk2/pull/938 broke EmulatorPkg, and most
platforms outside the main edk2 tree.

This should have been handled better.

But the fix is simple - if the platform port produces EFI_RNG_PROTOCOL
from some onboard hw, you can use the approach from edk2-platforms
commit 1e09147a01ae ("Platforms/RaspberryPi: Fix RPi4 RngLib build error").
Otherwise, you can use the approach used in edk2 commit 416813753726
("ArmVirtPkg: Add RngLib based on TimerLib for CryptoPkg").

If you're just trying to build something, you can rewind your edk2
HEAD to the edk2-stable202008 tag.

Best Regards,

Leif

On Wed, Sep 30, 2020 at 13:16:22 +0100, Andrew Goodbody wrote:
> Looks like a recent change is not working for AARCH64
>
> https://github.com/tianocore/edk2/commit/b5701a4c7a0fb185e0c5b9db9525939c78664bfd
>
> edk2-platforms/Platform/ARM/JunoPkg/ArmJuno.dsc(...): error 4000: Instance
> of library class [RngLib] is not found
> in [/home/andrew/src/edk2/CryptoPkg/Library/OpensslLib/OpensslLib.inf]
> [AARCH64]
> consumed by module [/home/andrew/src/edk2/NetworkPkg/IScsiDxe/IScsiDxe.inf]
>
>
> - Failed -
> Build end time: 12:56:54, Sep.30 2020
> Build total time: 00:00:01
>
> Sorry but I have not found my way around here yet. Is there anyone that can
> see what the best fix is for this please?
>
> Thanks,
> Andrew
>
>
>
>
>





IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

  parent reply	other threads:[~2020-10-01 11:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30 12:16 Cannot build due to recent change andrew.goodbody
2020-10-01 10:43 ` [edk2-devel] " Leif Lindholm
2020-10-01 11:06   ` Andrew Goodbody
2020-10-01 11:12     ` Leif Lindholm
2020-10-01 11:07   ` Sami Mujawar [this message]
2020-10-02  9:18   ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB7PR08MB30974EDD067C27350427080C84300@DB7PR08MB3097.eurprd08.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox