public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH v4 0/2] Enable EDKII CI support for DynamicTablesPkg
@ 2020-08-07 17:29 Sami Mujawar
  2020-08-07 17:29 ` [PATCH v4 1/2] .pytool: CI Settings to support DynamicTablesPkg Sami Mujawar
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Sami Mujawar @ 2020-08-07 17:29 UTC (permalink / raw)
  To: devel
  Cc: Sami Mujawar, Alexei.Fedorov, sean.brogan, liming.gao,
	michael.d.kinney, Bret.Barkelew, ard.biesheuvel, Matteo.Carlini,
	Laura.Moretta, nd

The TianoCore EDKII project has introduced a Core CI infrastructure
using TianoCore EDKII Tools PIP modules.

The v2 patch series at https://edk2.groups.io/g/devel/message/63259
adds support for building DynamicTablesPkg using the EKDII Core CI.

Splitting the v2 patch series into 2 separate series. This v4 series
contains the patches for enabling Core CI for DynamicTablesPkg in
.pytools and .azurepipelines i.e. the last two patches from the v2
series.

The v3 series containing the patches for DynamicTablesPkg has
already been merged in edk2 master at:
- https://github.com/tianocore/edk2/commit/2d0c42fdf2cf1855b0a042ef82d848c7716adefe
- https://github.com/tianocore/edk2/commit/e3f8605a23ebe9c54ae2b17819d00e185069667d
Ref (v3 series): https://edk2.groups.io/g/devel/topic/patch_v3_0_2_add_edkii_ci/76052351

There is no code change other than splitting the v2 series.

The changes for this v4 series can be seen at:
https://github.com/samimujawar/edk2/tree/839_dynamictablespkg_ci_v4

Sami Mujawar (2):
  .pytool: CI Settings to support DynamicTablesPkg
  .azurepipelines: Add DynamicTablesPkg to CI matrix

 .azurepipelines/templates/pr-gate-build-job.yml | 3 ++-
 .pytool/CISettings.py                           | 2 ++
 .pytool/Readme.md                               | 2 +-
 3 files changed, 5 insertions(+), 2 deletions(-)

-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v4 1/2] .pytool: CI Settings to support DynamicTablesPkg
  2020-08-07 17:29 [PATCH v4 0/2] Enable EDKII CI support for DynamicTablesPkg Sami Mujawar
@ 2020-08-07 17:29 ` Sami Mujawar
  2020-08-07 17:29 ` [PATCH v4 2/2] .azurepipelines: Add DynamicTablesPkg to CI matrix Sami Mujawar
  2020-08-14 13:24 ` [PATCH v4 0/2] Enable EDKII CI support for DynamicTablesPkg Sami Mujawar
  2 siblings, 0 replies; 8+ messages in thread
From: Sami Mujawar @ 2020-08-07 17:29 UTC (permalink / raw)
  To: devel
  Cc: Sami Mujawar, Alexei.Fedorov, sean.brogan, liming.gao,
	michael.d.kinney, Bret.Barkelew, ard.biesheuvel, Matteo.Carlini,
	Laura.Moretta, nd

Update pytools configuration to enable DynamicTablesPkg
and update package status in documentation.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Alexei Fedorov <Alexei.Fedorov@arm.com>
Reviewed-by: Shenglei Zhang <shenglei.zhang@intel.com>
---

Notes:
    v4:
      - No code change. Splitting v2 patch series into two series.     [Sami]
        This v4 series contains the patches for enabling Core CI for
        DynamicTablesPkg in .pytools and .azurepipelines.
        Ref: https://edk2.groups.io/g/devel/message/63257
    
        The v3 series containing the patches for DynamicTablesPkg has
        already been merged in edk2 master at:
         - https://github.com/tianocore/edk2/commit/2d0c42fdf2cf1855b0a042ef82d848c7716adefe
         - https://github.com/tianocore/edk2/commit/e3f8605a23ebe9c54ae2b17819d00e185069667d
    
    v2:
      - No change, resend patch with v2 series              [Sami]
    
    v1:
      - Add CI settings to support DynamicTablesPkg         [Sami]

 .pytool/CISettings.py | 2 ++
 .pytool/Readme.md     | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py
index bac60ecbaaf51ef4cf2f3ec7616e8ba2caa645ea..0c2dd0181aa2d3b3650e255da924d028d872513d 100644
--- a/.pytool/CISettings.py
+++ b/.pytool/CISettings.py
@@ -2,6 +2,7 @@
 #
 # Copyright (c) Microsoft Corporation.
 # Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All rights reserved.<BR>
+# Copyright (c) 2020, ARM Limited. All rights reserved.<BR>
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 import os
@@ -41,6 +42,7 @@ class Settings(CiBuildSettingsManager, UpdateSettingsManager, SetupSettingsManag
         These should be edk2 workspace relative paths '''
 
         return ("ArmVirtPkg",
+                "DynamicTablesPkg",
                 "EmulatorPkg",
                 "MdePkg",
                 "MdeModulePkg",
diff --git a/.pytool/Readme.md b/.pytool/Readme.md
index c401dba18fbf39a1431c3dbbfa30353de3ecb4b4..2fc905b8674fc217044baa2ff721f3c6afa504c9 100644
--- a/.pytool/Readme.md
+++ b/.pytool/Readme.md
@@ -8,7 +8,7 @@
 | ArmPlatformPkg       |
 | ArmVirtPkg           | SEE PACKAGE README | SEE PACKAGE README |
 | CryptoPkg            | :heavy_check_mark: | :heavy_check_mark: | Spell checking in audit mode
-| DynamicTablesPkg     |
+| DynamicTablesPkg     |                    | :heavy_check_mark: |
 | EmbeddedPkg          |
 | EmulatorPkg          | SEE PACKAGE README | SEE PACKAGE README | Spell checking in audit mode
 | FatPkg               | :heavy_check_mark: | :heavy_check_mark: |
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH v4 2/2] .azurepipelines: Add DynamicTablesPkg to CI matrix
  2020-08-07 17:29 [PATCH v4 0/2] Enable EDKII CI support for DynamicTablesPkg Sami Mujawar
  2020-08-07 17:29 ` [PATCH v4 1/2] .pytool: CI Settings to support DynamicTablesPkg Sami Mujawar
@ 2020-08-07 17:29 ` Sami Mujawar
  2020-08-14 13:24 ` [PATCH v4 0/2] Enable EDKII CI support for DynamicTablesPkg Sami Mujawar
  2 siblings, 0 replies; 8+ messages in thread
From: Sami Mujawar @ 2020-08-07 17:29 UTC (permalink / raw)
  To: devel
  Cc: Sami Mujawar, Alexei.Fedorov, sean.brogan, liming.gao,
	michael.d.kinney, Bret.Barkelew, ard.biesheuvel, Matteo.Carlini,
	Laura.Moretta, nd

Add DynamicTablesPkg to the Core CI matrix.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Suggested-by: Sean Brogan <sean.brogan@microsoft.com>
Reviewed-by: Alexei Fedorov <Alexei.Fedorov@arm.com>
Reviewed-by: Shenglei Zhang <shenglei.zhang@intel.com>
---

Notes:
    v4:
      - No code change. Splitting v2 patch series into two series.     [Sami]
        This v4 series contains the patches for enabling Core CI for
        DynamicTablesPkg in .pytools and .azurepipelines.
        Ref: https://edk2.groups.io/g/devel/message/63258
    
        The v3 series containing the patches for DynamicTablesPkg has
        already been merged in edk2 master at:
         - https://github.com/tianocore/edk2/commit/2d0c42fdf2cf1855b0a042ef82d848c7716adefe
         - https://github.com/tianocore/edk2/commit/e3f8605a23ebe9c54ae2b17819d00e185069667d
    
    v2:
      - New patch in series to add DynamicTablesPkg to Core CI matrix  [Sami]
      - Add DynamicTablesPkg to Core CI matrix                         [Sean]

 .azurepipelines/templates/pr-gate-build-job.yml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
index a9f89aa68451b5f7de6a4163487b267f94a383ad..2683687a1c7b869519dae5183b7dd2cb8c349272 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -4,6 +4,7 @@
 # template file used to build supported packages.
 #
 # Copyright (c) Microsoft Corporation.
+# Copyright (c) 2020, ARM Limited. All rights reserved.<BR>
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 
@@ -36,7 +37,7 @@ jobs:
         Build.Pkgs: 'PcAtChipsetPkg,ShellPkg'
         Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
       TARGET_FMP_FAT_TEST:
-        Build.Pkgs: 'FmpDevicePkg,FatPkg,UnitTestFrameworkPkg'
+        Build.Pkgs: 'FmpDevicePkg,FatPkg,UnitTestFrameworkPkg,DynamicTablesPkg'
         Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
       TARGET_CRYPTO:
         Build.Pkgs: 'CryptoPkg'
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH v4 0/2] Enable EDKII CI support for DynamicTablesPkg
  2020-08-07 17:29 [PATCH v4 0/2] Enable EDKII CI support for DynamicTablesPkg Sami Mujawar
  2020-08-07 17:29 ` [PATCH v4 1/2] .pytool: CI Settings to support DynamicTablesPkg Sami Mujawar
  2020-08-07 17:29 ` [PATCH v4 2/2] .azurepipelines: Add DynamicTablesPkg to CI matrix Sami Mujawar
@ 2020-08-14 13:24 ` Sami Mujawar
  2020-08-17  6:37   ` Liming Gao
  2 siblings, 1 reply; 8+ messages in thread
From: Sami Mujawar @ 2020-08-14 13:24 UTC (permalink / raw)
  To: liming.gao@intel.com, devel@edk2.groups.io,
	Bret.Barkelew@microsoft.com, sean.brogan@microsoft.com,
	michael.d.kinney@intel.com
  Cc: Alexei Fedorov, Sami Mujawar, Ard Biesheuvel, Matteo Carlini,
	Ben Adderson, nd

Hi All,

Is there anything else needed before this patch series can be merged?
If possible, we would like this feature enabled in the edk2-stable202008.

Regards,

Sami Mujawar

-----Original Message-----
From: Sami Mujawar <sami.mujawar@arm.com> 
Sent: 07 August 2020 06:30 PM
To: devel@edk2.groups.io
Cc: Sami Mujawar <Sami.Mujawar@arm.com>; Alexei Fedorov <Alexei.Fedorov@arm.com>; sean.brogan@microsoft.com; liming.gao@intel.com; michael.d.kinney@intel.com; Bret.Barkelew@microsoft.com; Ard Biesheuvel <Ard.Biesheuvel@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>; Laura Moretta <Laura.Moretta@arm.com>; nd <nd@arm.com>
Subject: [PATCH v4 0/2] Enable EDKII CI support for DynamicTablesPkg

The TianoCore EDKII project has introduced a Core CI infrastructure using TianoCore EDKII Tools PIP modules.

The v2 patch series at https://edk2.groups.io/g/devel/message/63259
adds support for building DynamicTablesPkg using the EKDII Core CI.

Splitting the v2 patch series into 2 separate series. This v4 series contains the patches for enabling Core CI for DynamicTablesPkg in .pytools and .azurepipelines i.e. the last two patches from the v2 series.

The v3 series containing the patches for DynamicTablesPkg has already been merged in edk2 master at:
- https://github.com/tianocore/edk2/commit/2d0c42fdf2cf1855b0a042ef82d848c7716adefe
- https://github.com/tianocore/edk2/commit/e3f8605a23ebe9c54ae2b17819d00e185069667d
Ref (v3 series): https://edk2.groups.io/g/devel/topic/patch_v3_0_2_add_edkii_ci/76052351

There is no code change other than splitting the v2 series.

The changes for this v4 series can be seen at:
https://github.com/samimujawar/edk2/tree/839_dynamictablespkg_ci_v4

Sami Mujawar (2):
  .pytool: CI Settings to support DynamicTablesPkg
  .azurepipelines: Add DynamicTablesPkg to CI matrix

 .azurepipelines/templates/pr-gate-build-job.yml | 3 ++-
 .pytool/CISettings.py                           | 2 ++
 .pytool/Readme.md                               | 2 +-
 3 files changed, 5 insertions(+), 2 deletions(-)

--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v4 0/2] Enable EDKII CI support for DynamicTablesPkg
  2020-08-14 13:24 ` [PATCH v4 0/2] Enable EDKII CI support for DynamicTablesPkg Sami Mujawar
@ 2020-08-17  6:37   ` Liming Gao
  2020-08-17 16:30     ` Laszlo Ersek
  2020-08-18 11:34     ` Leif Lindholm
  0 siblings, 2 replies; 8+ messages in thread
From: Liming Gao @ 2020-08-17  6:37 UTC (permalink / raw)
  To: Sami Mujawar, devel@edk2.groups.io, Bret.Barkelew@microsoft.com,
	sean.brogan@microsoft.com, Kinney, Michael D, Leif Lindholm,
	afish@apple.com, Laszlo Ersek
  Cc: Alexei Fedorov, Ard Biesheuvel, Matteo Carlini, Ben Adderson, nd

Sami:
  I think this change is OK. And, Shenglei and Alexei gave reviewed-by before soft feature freeze. 

Mike, Leif, Andrew and Laszlo:
  Have you any comments to merge this patch to edk2-stable202008 stable tag. 

Thanks
Liming
-----Original Message-----
From: Sami Mujawar <Sami.Mujawar@arm.com> 
Sent: 2020年8月14日 21:24
To: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io; Bret.Barkelew@microsoft.com; sean.brogan@microsoft.com; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>; Sami Mujawar <Sami.Mujawar@arm.com>; Ard Biesheuvel <Ard.Biesheuvel@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>; Ben Adderson <Ben.Adderson@arm.com>; nd <nd@arm.com>
Subject: RE: [PATCH v4 0/2] Enable EDKII CI support for DynamicTablesPkg

Hi All,

Is there anything else needed before this patch series can be merged?
If possible, we would like this feature enabled in the edk2-stable202008.

Regards,

Sami Mujawar

-----Original Message-----
From: Sami Mujawar <sami.mujawar@arm.com> 
Sent: 07 August 2020 06:30 PM
To: devel@edk2.groups.io
Cc: Sami Mujawar <Sami.Mujawar@arm.com>; Alexei Fedorov <Alexei.Fedorov@arm.com>; sean.brogan@microsoft.com; liming.gao@intel.com; michael.d.kinney@intel.com; Bret.Barkelew@microsoft.com; Ard Biesheuvel <Ard.Biesheuvel@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>; Laura Moretta <Laura.Moretta@arm.com>; nd <nd@arm.com>
Subject: [PATCH v4 0/2] Enable EDKII CI support for DynamicTablesPkg

The TianoCore EDKII project has introduced a Core CI infrastructure using TianoCore EDKII Tools PIP modules.

The v2 patch series at https://edk2.groups.io/g/devel/message/63259
adds support for building DynamicTablesPkg using the EKDII Core CI.

Splitting the v2 patch series into 2 separate series. This v4 series contains the patches for enabling Core CI for DynamicTablesPkg in .pytools and .azurepipelines i.e. the last two patches from the v2 series.

The v3 series containing the patches for DynamicTablesPkg has already been merged in edk2 master at:
- https://github.com/tianocore/edk2/commit/2d0c42fdf2cf1855b0a042ef82d848c7716adefe
- https://github.com/tianocore/edk2/commit/e3f8605a23ebe9c54ae2b17819d00e185069667d
Ref (v3 series): https://edk2.groups.io/g/devel/topic/patch_v3_0_2_add_edkii_ci/76052351

There is no code change other than splitting the v2 series.

The changes for this v4 series can be seen at:
https://github.com/samimujawar/edk2/tree/839_dynamictablespkg_ci_v4

Sami Mujawar (2):
  .pytool: CI Settings to support DynamicTablesPkg
  .azurepipelines: Add DynamicTablesPkg to CI matrix

 .azurepipelines/templates/pr-gate-build-job.yml | 3 ++-
 .pytool/CISettings.py                           | 2 ++
 .pytool/Readme.md                               | 2 +-
 3 files changed, 5 insertions(+), 2 deletions(-)	

--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v4 0/2] Enable EDKII CI support for DynamicTablesPkg
  2020-08-17  6:37   ` Liming Gao
@ 2020-08-17 16:30     ` Laszlo Ersek
  2020-08-18 11:34     ` Leif Lindholm
  1 sibling, 0 replies; 8+ messages in thread
From: Laszlo Ersek @ 2020-08-17 16:30 UTC (permalink / raw)
  To: Gao, Liming, Sami Mujawar, devel@edk2.groups.io,
	Bret.Barkelew@microsoft.com, sean.brogan@microsoft.com,
	Kinney, Michael D, Leif Lindholm, afish@apple.com
  Cc: Alexei Fedorov, Ard Biesheuvel, Matteo Carlini, Ben Adderson, nd

On 08/17/20 08:37, Gao, Liming wrote:
> Sami:
>   I think this change is OK. And, Shenglei and Alexei gave reviewed-by before soft feature freeze. 
> 
> Mike, Leif, Andrew and Laszlo:
>   Have you any comments to merge this patch to edk2-stable202008 stable tag. 

I'm OK with merging this series now.

Thanks
Laszlo



> -----Original Message-----
> From: Sami Mujawar <Sami.Mujawar@arm.com> 
> Sent: 2020年8月14日 21:24
> To: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io; Bret.Barkelew@microsoft.com; sean.brogan@microsoft.com; Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>; Sami Mujawar <Sami.Mujawar@arm.com>; Ard Biesheuvel <Ard.Biesheuvel@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>; Ben Adderson <Ben.Adderson@arm.com>; nd <nd@arm.com>
> Subject: RE: [PATCH v4 0/2] Enable EDKII CI support for DynamicTablesPkg
> 
> Hi All,
> 
> Is there anything else needed before this patch series can be merged?
> If possible, we would like this feature enabled in the edk2-stable202008.
> 
> Regards,
> 
> Sami Mujawar
> 
> -----Original Message-----
> From: Sami Mujawar <sami.mujawar@arm.com> 
> Sent: 07 August 2020 06:30 PM
> To: devel@edk2.groups.io
> Cc: Sami Mujawar <Sami.Mujawar@arm.com>; Alexei Fedorov <Alexei.Fedorov@arm.com>; sean.brogan@microsoft.com; liming.gao@intel.com; michael.d.kinney@intel.com; Bret.Barkelew@microsoft.com; Ard Biesheuvel <Ard.Biesheuvel@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>; Laura Moretta <Laura.Moretta@arm.com>; nd <nd@arm.com>
> Subject: [PATCH v4 0/2] Enable EDKII CI support for DynamicTablesPkg
> 
> The TianoCore EDKII project has introduced a Core CI infrastructure using TianoCore EDKII Tools PIP modules.
> 
> The v2 patch series at https://edk2.groups.io/g/devel/message/63259
> adds support for building DynamicTablesPkg using the EKDII Core CI.
> 
> Splitting the v2 patch series into 2 separate series. This v4 series contains the patches for enabling Core CI for DynamicTablesPkg in .pytools and .azurepipelines i.e. the last two patches from the v2 series.
> 
> The v3 series containing the patches for DynamicTablesPkg has already been merged in edk2 master at:
> - https://github.com/tianocore/edk2/commit/2d0c42fdf2cf1855b0a042ef82d848c7716adefe
> - https://github.com/tianocore/edk2/commit/e3f8605a23ebe9c54ae2b17819d00e185069667d
> Ref (v3 series): https://edk2.groups.io/g/devel/topic/patch_v3_0_2_add_edkii_ci/76052351
> 
> There is no code change other than splitting the v2 series.
> 
> The changes for this v4 series can be seen at:
> https://github.com/samimujawar/edk2/tree/839_dynamictablespkg_ci_v4
> 
> Sami Mujawar (2):
>   .pytool: CI Settings to support DynamicTablesPkg
>   .azurepipelines: Add DynamicTablesPkg to CI matrix
> 
>  .azurepipelines/templates/pr-gate-build-job.yml | 3 ++-
>  .pytool/CISettings.py                           | 2 ++
>  .pytool/Readme.md                               | 2 +-
>  3 files changed, 5 insertions(+), 2 deletions(-)	
> 
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v4 0/2] Enable EDKII CI support for DynamicTablesPkg
  2020-08-17  6:37   ` Liming Gao
  2020-08-17 16:30     ` Laszlo Ersek
@ 2020-08-18 11:34     ` Leif Lindholm
  2020-08-19  9:20       ` [edk2-devel] " Liming Gao
  1 sibling, 1 reply; 8+ messages in thread
From: Leif Lindholm @ 2020-08-18 11:34 UTC (permalink / raw)
  To: Gao, Liming
  Cc: Sami Mujawar, devel@edk2.groups.io, Bret.Barkelew@microsoft.com,
	sean.brogan@microsoft.com, Kinney, Michael D, afish@apple.com,
	Laszlo Ersek, Alexei Fedorov, Ard Biesheuvel, Matteo Carlini,
	Ben Adderson, nd

No objections from me.

On Mon, Aug 17, 2020 at 06:37:02 +0000, Gao, Liming wrote:
> Sami:
>   I think this change is OK. And, Shenglei and Alexei gave reviewed-by before soft feature freeze. 
> 
> Mike, Leif, Andrew and Laszlo:
>   Have you any comments to merge this patch to edk2-stable202008 stable tag. 
> 
> Thanks
> Liming
> -----Original Message-----
> From: Sami Mujawar <Sami.Mujawar@arm.com> 
> Sent: 2020年8月14日 21:24
> To: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io; Bret.Barkelew@microsoft.com; sean.brogan@microsoft.com; Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>; Sami Mujawar <Sami.Mujawar@arm.com>; Ard Biesheuvel <Ard.Biesheuvel@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>; Ben Adderson <Ben.Adderson@arm.com>; nd <nd@arm.com>
> Subject: RE: [PATCH v4 0/2] Enable EDKII CI support for DynamicTablesPkg
> 
> Hi All,
> 
> Is there anything else needed before this patch series can be merged?
> If possible, we would like this feature enabled in the edk2-stable202008.
> 
> Regards,
> 
> Sami Mujawar
> 
> -----Original Message-----
> From: Sami Mujawar <sami.mujawar@arm.com> 
> Sent: 07 August 2020 06:30 PM
> To: devel@edk2.groups.io
> Cc: Sami Mujawar <Sami.Mujawar@arm.com>; Alexei Fedorov <Alexei.Fedorov@arm.com>; sean.brogan@microsoft.com; liming.gao@intel.com; michael.d.kinney@intel.com; Bret.Barkelew@microsoft.com; Ard Biesheuvel <Ard.Biesheuvel@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>; Laura Moretta <Laura.Moretta@arm.com>; nd <nd@arm.com>
> Subject: [PATCH v4 0/2] Enable EDKII CI support for DynamicTablesPkg
> 
> The TianoCore EDKII project has introduced a Core CI infrastructure using TianoCore EDKII Tools PIP modules.
> 
> The v2 patch series at https://edk2.groups.io/g/devel/message/63259
> adds support for building DynamicTablesPkg using the EKDII Core CI.
> 
> Splitting the v2 patch series into 2 separate series. This v4 series contains the patches for enabling Core CI for DynamicTablesPkg in .pytools and .azurepipelines i.e. the last two patches from the v2 series.
> 
> The v3 series containing the patches for DynamicTablesPkg has already been merged in edk2 master at:
> - https://github.com/tianocore/edk2/commit/2d0c42fdf2cf1855b0a042ef82d848c7716adefe
> - https://github.com/tianocore/edk2/commit/e3f8605a23ebe9c54ae2b17819d00e185069667d
> Ref (v3 series): https://edk2.groups.io/g/devel/topic/patch_v3_0_2_add_edkii_ci/76052351
> 
> There is no code change other than splitting the v2 series.
> 
> The changes for this v4 series can be seen at:
> https://github.com/samimujawar/edk2/tree/839_dynamictablespkg_ci_v4
> 
> Sami Mujawar (2):
>   .pytool: CI Settings to support DynamicTablesPkg
>   .azurepipelines: Add DynamicTablesPkg to CI matrix
> 
>  .azurepipelines/templates/pr-gate-build-job.yml | 3 ++-
>  .pytool/CISettings.py                           | 2 ++
>  .pytool/Readme.md                               | 2 +-
>  3 files changed, 5 insertions(+), 2 deletions(-)	
> 
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [edk2-devel] [PATCH v4 0/2] Enable EDKII CI support for DynamicTablesPkg
  2020-08-18 11:34     ` Leif Lindholm
@ 2020-08-19  9:20       ` Liming Gao
  0 siblings, 0 replies; 8+ messages in thread
From: Liming Gao @ 2020-08-19  9:20 UTC (permalink / raw)
  To: devel@edk2.groups.io, leif@nuviainc.com
  Cc: Sami Mujawar, Bret.Barkelew@microsoft.com,
	sean.brogan@microsoft.com, Kinney, Michael D, afish@apple.com,
	Laszlo Ersek, Alexei Fedorov, Ard Biesheuvel, Matteo Carlini,
	Ben Adderson, nd

Merged a048af3c9073e4b8108e6cf920bbb35574059639..5a6d764e1d073d28e8f398289ccb5592bf9a72ba

Thanks
Liming
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Leif Lindholm
Sent: 2020年8月18日 19:34
To: Gao, Liming <liming.gao@intel.com>
Cc: Sami Mujawar <Sami.Mujawar@arm.com>; devel@edk2.groups.io; Bret.Barkelew@microsoft.com; sean.brogan@microsoft.com; Kinney, Michael D <michael.d.kinney@intel.com>; afish@apple.com; Laszlo Ersek <lersek@redhat.com>; Alexei Fedorov <Alexei.Fedorov@arm.com>; Ard Biesheuvel <Ard.Biesheuvel@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>; Ben Adderson <Ben.Adderson@arm.com>; nd <nd@arm.com>
Subject: Re: [edk2-devel] [PATCH v4 0/2] Enable EDKII CI support for DynamicTablesPkg

No objections from me.

On Mon, Aug 17, 2020 at 06:37:02 +0000, Gao, Liming wrote:
> Sami:
>   I think this change is OK. And, Shenglei and Alexei gave reviewed-by before soft feature freeze. 
> 
> Mike, Leif, Andrew and Laszlo:
>   Have you any comments to merge this patch to edk2-stable202008 stable tag. 
> 
> Thanks
> Liming
> -----Original Message-----
> From: Sami Mujawar <Sami.Mujawar@arm.com>
> Sent: 2020年8月14日 21:24
> To: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io; 
> Bret.Barkelew@microsoft.com; sean.brogan@microsoft.com; Kinney, 
> Michael D <michael.d.kinney@intel.com>
> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>; Sami Mujawar 
> <Sami.Mujawar@arm.com>; Ard Biesheuvel <Ard.Biesheuvel@arm.com>; 
> Matteo Carlini <Matteo.Carlini@arm.com>; Ben Adderson 
> <Ben.Adderson@arm.com>; nd <nd@arm.com>
> Subject: RE: [PATCH v4 0/2] Enable EDKII CI support for 
> DynamicTablesPkg
> 
> Hi All,
> 
> Is there anything else needed before this patch series can be merged?
> If possible, we would like this feature enabled in the edk2-stable202008.
> 
> Regards,
> 
> Sami Mujawar
> 
> -----Original Message-----
> From: Sami Mujawar <sami.mujawar@arm.com>
> Sent: 07 August 2020 06:30 PM
> To: devel@edk2.groups.io
> Cc: Sami Mujawar <Sami.Mujawar@arm.com>; Alexei Fedorov 
> <Alexei.Fedorov@arm.com>; sean.brogan@microsoft.com; 
> liming.gao@intel.com; michael.d.kinney@intel.com; 
> Bret.Barkelew@microsoft.com; Ard Biesheuvel <Ard.Biesheuvel@arm.com>; 
> Matteo Carlini <Matteo.Carlini@arm.com>; Laura Moretta 
> <Laura.Moretta@arm.com>; nd <nd@arm.com>
> Subject: [PATCH v4 0/2] Enable EDKII CI support for DynamicTablesPkg
> 
> The TianoCore EDKII project has introduced a Core CI infrastructure using TianoCore EDKII Tools PIP modules.
> 
> The v2 patch series at https://edk2.groups.io/g/devel/message/63259
> adds support for building DynamicTablesPkg using the EKDII Core CI.
> 
> Splitting the v2 patch series into 2 separate series. This v4 series contains the patches for enabling Core CI for DynamicTablesPkg in .pytools and .azurepipelines i.e. the last two patches from the v2 series.
> 
> The v3 series containing the patches for DynamicTablesPkg has already been merged in edk2 master at:
> - 
> https://github.com/tianocore/edk2/commit/2d0c42fdf2cf1855b0a042ef82d84
> 8c7716adefe
> - 
> https://github.com/tianocore/edk2/commit/e3f8605a23ebe9c54ae2b17819d00
> e185069667d Ref (v3 series): 
> https://edk2.groups.io/g/devel/topic/patch_v3_0_2_add_edkii_ci/7605235
> 1
> 
> There is no code change other than splitting the v2 series.
> 
> The changes for this v4 series can be seen at:
> https://github.com/samimujawar/edk2/tree/839_dynamictablespkg_ci_v4
> 
> Sami Mujawar (2):
>   .pytool: CI Settings to support DynamicTablesPkg
>   .azurepipelines: Add DynamicTablesPkg to CI matrix
> 
>  .azurepipelines/templates/pr-gate-build-job.yml | 3 ++-
>  .pytool/CISettings.py                           | 2 ++
>  .pytool/Readme.md                               | 2 +-
>  3 files changed, 5 insertions(+), 2 deletions(-)	
> 
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> 




^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-08-19  9:20 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-07 17:29 [PATCH v4 0/2] Enable EDKII CI support for DynamicTablesPkg Sami Mujawar
2020-08-07 17:29 ` [PATCH v4 1/2] .pytool: CI Settings to support DynamicTablesPkg Sami Mujawar
2020-08-07 17:29 ` [PATCH v4 2/2] .azurepipelines: Add DynamicTablesPkg to CI matrix Sami Mujawar
2020-08-14 13:24 ` [PATCH v4 0/2] Enable EDKII CI support for DynamicTablesPkg Sami Mujawar
2020-08-17  6:37   ` Liming Gao
2020-08-17 16:30     ` Laszlo Ersek
2020-08-18 11:34     ` Leif Lindholm
2020-08-19  9:20       ` [edk2-devel] " Liming Gao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox