From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (EUR02-HE1-obe.outbound.protection.outlook.com [40.107.1.62]) by mx.groups.io with SMTP id smtpd.web10.35502.1606142033162226585 for ; Mon, 23 Nov 2020 06:33:54 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=kHlV6Duq; spf=pass (domain: arm.com, ip: 40.107.1.62, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9VuuRC6IGQoI0df0tRAINDsK1ERU7Z+JGt5A7BcXD28=; b=kHlV6Duq5xe8pwXXLmUMF0OjENTu0dYUpE0N+tkRjquJZgfCZvC7hR3j91RqVfxZxhkWyF7W65AmuwD+ykE3w9OwYfI1O981TWwlWaxkmaL76tsty4D7zXKukR/qZZcnfjQlK62tXYtwhJCzmam6BFODGIAAmpcli7QA/U04Glw= Received: from AS8PR04CA0078.eurprd04.prod.outlook.com (2603:10a6:20b:313::23) by AM0PR08MB5075.eurprd08.prod.outlook.com (2603:10a6:208:15b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20; Mon, 23 Nov 2020 14:33:50 +0000 Received: from VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:313:cafe::12) by AS8PR04CA0078.outlook.office365.com (2603:10a6:20b:313::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.15 via Frontend Transport; Mon, 23 Nov 2020 14:33:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT023.mail.protection.outlook.com (10.152.18.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20 via Frontend Transport; Mon, 23 Nov 2020 14:33:49 +0000 Received: ("Tessian outbound d6c201accd3c:v71"); Mon, 23 Nov 2020 14:33:49 +0000 X-CR-MTA-TID: 64aa7808 Received: from ff3ab1a8469f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F812E1F8-A341-474F-A7ED-E0CF238814DD.1; Mon, 23 Nov 2020 14:33:44 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ff3ab1a8469f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 23 Nov 2020 14:33:44 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nG/EZQlD63uM6zBFPbZTzafUaEAXtldP9CoOJnG1oJN+2RNp7IpMP8vrDt/wx1YSfyWaM+FXeiyBAuZOEOCjt1F1V0yjr4pajtewc+jw5AyEv6rn38AzDOZCMDb6J90XhZBLVE2Yu6+jDEUnmECHFSkEEapxMiL0g7u4aRw+QXutUIdpI/vmzPfamOuqKnVPa62DX66xOODgvfp0oujHwalggtpx9B2oUU6ZMSW3SYuf621xLSJ039nlGoFqKAIhiyovNpxIWMY//ujmxRA8evcoJ7pBHLUfTuCkMUkr3IzVo1JiF54GtMNO3waunZaCX1l/o6KMHofvt0uE0VMZ1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9VuuRC6IGQoI0df0tRAINDsK1ERU7Z+JGt5A7BcXD28=; b=LGYVexk7X6TAF1J5l0V7C7dOcigGO8f/R0QUi8MJ9S3PN6l7OwTKycnxYwrBbWk+S9VZLQYICEsjmoNbwj48+azNGNVJ/32e6VvZ4C9RoGotUTLi1J5PHIwTHinh1sjpNeUtYaPKwvge7S/q5cwiDDcLp7qh8ziRqoV8/v/Isa2wT5d1Jj2Mwslg/zRsSyOMDaI9yXDSCvXW7ICr1h6SXoMGEdvpfXmwdiqauLfKd3x/RrS8IAGV89Cs0cvuyLmqYePBpeqVb+4Xa+mhZ4spYwAyFGWJX+TfZjvohRTTXczVuJ3yKZnyPMhbFtFDrrGXGCa2wZH09COq0WrpZwlkbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9VuuRC6IGQoI0df0tRAINDsK1ERU7Z+JGt5A7BcXD28=; b=kHlV6Duq5xe8pwXXLmUMF0OjENTu0dYUpE0N+tkRjquJZgfCZvC7hR3j91RqVfxZxhkWyF7W65AmuwD+ykE3w9OwYfI1O981TWwlWaxkmaL76tsty4D7zXKukR/qZZcnfjQlK62tXYtwhJCzmam6BFODGIAAmpcli7QA/U04Glw= Received: from DB7PR08MB3097.eurprd08.prod.outlook.com (2603:10a6:5:1d::27) by DBBPR08MB4460.eurprd08.prod.outlook.com (2603:10a6:10:cc::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20; Mon, 23 Nov 2020 14:33:43 +0000 Received: from DB7PR08MB3097.eurprd08.prod.outlook.com ([fe80::315c:f6c3:2600:bd39]) by DB7PR08MB3097.eurprd08.prod.outlook.com ([fe80::315c:f6c3:2600:bd39%6]) with mapi id 15.20.3589.030; Mon, 23 Nov 2020 14:33:37 +0000 From: "Sami Mujawar" To: Sughosh Ganu , "devel@edk2.groups.io" CC: Ard Biesheuvel , Jiewen Yao , nd Subject: Re: [PATCH v1 00/12] Add support for using FF-A calls Thread-Topic: [PATCH v1 00/12] Add support for using FF-A calls Thread-Index: AQHWp54BA6wVz2xlr0y3vB4vavStR6nV+Wyg Date: Mon, 23 Nov 2020 14:33:37 +0000 Message-ID: References: <20201021113233.25548-1-sughosh.ganu@linaro.org> In-Reply-To: <20201021113233.25548-1-sughosh.ganu@linaro.org> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: A35B85A3E1FBA146A6EA8A2106F8D14B.1 x-checkrecipientchecked: true Authentication-Results-Original: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [2a00:23c6:548a:4800:e1e2:5e02:5cb9:6f61] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 21043160-8b57-48cd-a521-08d88fbccb22 x-ms-traffictypediagnostic: DBBPR08MB4460:|AM0PR08MB5075: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:1186;OLM:1186; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: RSGqCJ/3iFqzFPz3i+DzC+UKgcVp+fiG8lnbdVXLgPmKtkaS+Wbgp3NsQ4ug3ibge9gDlKLSSsNKQF0Laq1Xcbbd3Tbx2dCLwasQ11aooJ+7ZQpzhpBT2uZTMWUHRDr+9OMEkyWzKkG04Xf52zes+KRCJSWgJ8wvbeDen7fX1WNqaWvTm2KWMcwwre0OpmL2yXqNfosL1dJYcABa0rGsfO9pu9TuukBIwjAKvcfKNyul46ZVAiUcJAH/ifKl01w7Hq42XF459Ej50LAcfcWus6k8ROIF1LR/hibtyr3rjUKc11D8ifkuYAJ+nF5hr6KvkMsQXzjJY/HF+CxiOQuNug== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3097.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(396003)(346002)(39860400002)(366004)(376002)(19627235002)(83380400001)(4326008)(8936002)(316002)(33656002)(478600001)(71200400001)(86362001)(66946007)(9686003)(53546011)(52536014)(76116006)(66476007)(66446008)(64756008)(54906003)(110136005)(6506007)(55016002)(5660300002)(186003)(7696005)(8676002)(66556008)(2906002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?ezCPN4VZcBeJkH1RdY2F4E5bGRVHQZK5aXuQD8oy0TL1rlv3zEIoWZHPRd3y?= =?us-ascii?Q?+GIs3a+OTsyiHXRuof21PWG0iQWsjaChzeW4NXCl38ly4cqMv/hsx5adpysa?= =?us-ascii?Q?/Hu10SFCqsuup4hl/Je2rC9BI/kD8BDT9CRRO0sgCrrJBCjOTpAHHFQETQHf?= =?us-ascii?Q?hCU122BwwIpJZ3Nr+OXcj2hjqqR1rknlicBASISEUrRuF6QdQYsBEg8ikqy6?= =?us-ascii?Q?zTyVWRZyQJ2W8iFNwtQYpHhoJ3psodvmd8VZclJyWbMl8VtW+HkwYEDEMcLL?= =?us-ascii?Q?YNm3QKIjqTUZpmpvflxbXEiNXr41Aco1JJr99Y+28WtOS8KRdr4lcHYi4Aet?= =?us-ascii?Q?SNZNOxaTt7fj8/B9Iuz2spEDxwRVGqNGIvDuwIzM2hQ1ck/3AItfEdTA+2rw?= =?us-ascii?Q?eqdIX47Ro2MO5SxQyvlMjRxlaBnS6zu00wqQXntPtSF0JnGe/2eEEOlRu8Sp?= =?us-ascii?Q?wE/d+2oV2SDaqZC7FDpEVc7i/5O3xZfJT9mEYxFge/nSL6wAYatRDoMjFL56?= =?us-ascii?Q?3frSuS684PSDkFAtow7A/fKsbEYjZzHnBYjwFXA0ywgtW/aKozWJOy7LWjoY?= =?us-ascii?Q?7W7uI1EsD0sfUaZE5PdGIJ+o5dxQiOj405zGJlcK39tldlZuZp3S4chuz1TE?= =?us-ascii?Q?f5JpSPEKfyPzyeBLvufmPDVn8UAFkSx438vTI4scSNSIHR7yFe2MVHE0+VKy?= =?us-ascii?Q?gE2oO2/jdLTu5iZlvcw1izezNKgr7uvETKyo7PM+Rh/NlqC5pSZRMABjXPu2?= =?us-ascii?Q?gg06sZFOjVsZ9nJLdHWcB8ZT576bV4a6SCbAGz06P23YCkueqzduBbvdWh8o?= =?us-ascii?Q?6N8MJFh3lfw/qwUXNcPH8U8iuHk8IawqZH5quWWMux3zPrEwcyfqf6MInJkN?= =?us-ascii?Q?6xD2xzgGu89Nb04wfg7JffxRKrZBk+/6L6Wg9s8sfaNX4ou09gE24iOzR0nB?= =?us-ascii?Q?YKCKRHEOChBaL3CWrhgMyQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4460 Original-Authentication-Results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: e1d01bac-2c3a-47b5-7118-08d88fbcc3cf X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: geFJ/fhgkgGDpwLdGn6zLlOkSzrXXy7of1b/dJSQqRxN92KSnaqFe0kz5zXNQ3OvymDbPB2H59kHCr24szlXkkvDmlWHOW6lc100epnRNzfwBS8pVKBrfZmVNkw+NiCXB7Lg7ed52HxsERnbUrkPH/KVk9XUeuRMOz07O+hA2UeoS063GEHcCGrGSfWTGaGHG24ViB0o3qiVTb1jQW7JeB8FyK00pMKHXC7GxkNutcDLiJKG0SNWkeL1CGz1RKqdQuLn/gZhsggVzMtut/Y32+DUQ7UIGBP3CM/qy5K90hrIQeImzIA7soboLynFsWQXDF+t5jS3JTBvUXWV16ZNt+x5kk/K5BaWaeQBsErRRLG2Y71CVR2hrcnQELP2OB2Praa5/zdet5IU66la/yzDqQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(346002)(39860400002)(136003)(396003)(376002)(46966005)(19627235002)(26005)(83380400001)(4326008)(8936002)(82310400003)(316002)(33656002)(478600001)(86362001)(9686003)(70586007)(53546011)(54906003)(336012)(70206006)(6506007)(110136005)(55016002)(52536014)(5660300002)(186003)(7696005)(8676002)(47076004)(356005)(81166007)(82740400003)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2020 14:33:49.6324 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 21043160-8b57-48cd-a521-08d88fbccb22 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5075 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Sughosh, I have completed reviewing this patch series. Please add some description in the commit message for the following patches= . Otherwise patch 3 & 8 look good to me. [PATCH v1 08/12] StandaloneMmPkg: Use FF-A header file in Standalone MM Arm= MMU library [PATCH v1 03/12] StandaloneMmPkg: Use FF-A header file in Standalone MM Cor= e entry point Regards, Sami Mujawar -----Original Message----- From: Sughosh Ganu =20 Sent: 21 October 2020 12:32 PM To: devel@edk2.groups.io Cc: Ard Biesheuvel ; Sami Mujawar ; Jiewen Yao Subject: [PATCH v1 00/12] Add support for using FF-A calls Achin Gupta (8): ArmPkg/IndustryStandard: Add barebones FF-A header ArmPkg/ArmSvcLib: Return x4-x7 in output parameters StandaloneMmPkg: Use FF-A header file in Standalone MM Core entry point StandaloneMmPkg: Add option to use FF-A calls for getting SPM version StandaloneMmPkg: Add option to use FF-A calls for communication with SPM StandaloneMmPkg: Use FF-A header file in Standalone MM Arm MMU library ArmPkg/StandaloneMmMmuLib: Add option to use FF-A calls to get memory region's permissions ArmPkg/StandaloneMmMmuLib: Add option to use FF-A calls to set memory region's permissions Ilias Apalodimas (2): MdeModulePkg/VariableStandaloneMm: Set PcdFlashNvStorageVariableBase to Pcd StandaloneMmPkg: Allow sending FFA Direct Request message to StandaloneMm Sughosh Ganu (1): ArmPkg: Introduce support for PcdFfaEnable Sughossh Ganu (1): StandaloneMmPkg: Add the SPM version for FF-A ArmPkg/ArmPkg.dec | 3 + .../ArmMmuStandaloneMmLib.inf | 3 + .../RuntimeDxe/VariableStandaloneMm.inf | 6 +- .../StandaloneMmCoreEntryPoint.inf | 3 + ArmPkg/Include/IndustryStandard/ArmFfaSvc.h | 16 +++ .../AArch64/ArmMmuStandaloneMmLib.c | 53 +++++++-- .../StandaloneMmCpu/AArch64/EventHandle.c | 4 +- .../AArch64/StandaloneMmCoreEntryPoint.c | 103 ++++++++++++++---- ArmPkg/Library/ArmSvcLib/AArch64/ArmSvc.S | 2 + 9 files changed, 155 insertions(+), 38 deletions(-) create mode 100644 ArmPkg/Include/IndustryStandard/ArmFfaSvc.h --=20 2.17.1