From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (EUR02-AM5-obe.outbound.protection.outlook.com [40.107.0.81]) by mx.groups.io with SMTP id smtpd.web10.26621.1605009788675628440 for ; Tue, 10 Nov 2020 04:03:09 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=SPUZfmQh; spf=pass (domain: arm.com, ip: 40.107.0.81, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sCgvYf7uZx8vqc31jndLhN2hwmh5N6O5fyJDptDaQkg=; b=SPUZfmQhpCCsYxYND6hAImEob+sNQi0wbYKPh7XDgHIBfMQVgpLXWytohVLy6MOEchTNYDWJDHY4a9hlQQT3lRzI5wmpnYe0tbA63MBQ4ItMkOpaafMiy0V6l44+Nn96rqNUskkogih5xXbdx/gktAWZsN7+V76D4hIAFWtSRn0= Received: from AM6P193CA0111.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:85::16) by AM6PR08MB3157.eurprd08.prod.outlook.com (2603:10a6:209:48::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Tue, 10 Nov 2020 12:03:04 +0000 Received: from VE1EUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:85:cafe::4f) by AM6P193CA0111.outlook.office365.com (2603:10a6:209:85::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21 via Frontend Transport; Tue, 10 Nov 2020 12:03:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT014.mail.protection.outlook.com (10.152.19.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.17 via Frontend Transport; Tue, 10 Nov 2020 12:03:04 +0000 Received: ("Tessian outbound fcd5bc555ddc:v71"); Tue, 10 Nov 2020 12:02:56 +0000 X-CR-MTA-TID: 64aa7808 Received: from fbe50da8f8b4.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CE6DA794-7C92-4A98-8EA7-2860CD0A01EF.1; Tue, 10 Nov 2020 12:02:51 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fbe50da8f8b4.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 10 Nov 2020 12:02:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aMtqgeCvtHTVe1m2k98cGX+BiWj+12jFBWcnEgnyk8zsqmkzzZXGVIBd7fUq8r29SxNcuPtdk/K5pqIGTiLjJvEGWuCI+eQYm+rmHjv75u9oMimFg3f1RTlUJmyioJncthPHO83aPXjdgvEFydfswAxD4lXoakdbU+3JQVrLfrdMt/DNCl6shdf3GR/AYNx8H7/5MI0FwLOL7sJKRQGHTFdGce/OKHUFIcUn81740Nzaf2b5kSi6P1qrTnrFoJWe9wdm13/fUduVsKt/rREFT9EkhHW3tS3xXC7GNIuz6BbWN4/fYwan9CrdDws5do9R+dpPHPxQSc0AI3cwOYQahw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sCgvYf7uZx8vqc31jndLhN2hwmh5N6O5fyJDptDaQkg=; b=iPXCXss46pGL1qjTXh4SHSqMvoHre1JVwF/e8Krus5cBt9XJrdqkmhfKo5fARGVtL/R1jqacEl5hzgxl3gviNv4kfhdEWdlhm3mrySjBD/pcvJmXWxD9YfYCQsbADZ3Wk/aQBYPT1wiNGh53Mtu5fblVzuQDMgDCk/JZXCkJ3bN057N57xv6fLhPffqcBK94hsI2WTkIyVepSM8eFA1OTQS6e8z+ILkEH5H5qRT3I6Zlkem/4cHl3M3iAjE3P4pmYVMMiiUONkF0HjYSZtWhbTFProlJ7w5qCJ3ISDpqLCAOPzUAVFlSv9wmajCBjelfIP3O1T1YpX5ZA6kFHVQB8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sCgvYf7uZx8vqc31jndLhN2hwmh5N6O5fyJDptDaQkg=; b=SPUZfmQhpCCsYxYND6hAImEob+sNQi0wbYKPh7XDgHIBfMQVgpLXWytohVLy6MOEchTNYDWJDHY4a9hlQQT3lRzI5wmpnYe0tbA63MBQ4ItMkOpaafMiy0V6l44+Nn96rqNUskkogih5xXbdx/gktAWZsN7+V76D4hIAFWtSRn0= Received: from DB7PR08MB3097.eurprd08.prod.outlook.com (2603:10a6:5:1d::27) by DBBPR08MB4235.eurprd08.prod.outlook.com (2603:10a6:10:c2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Tue, 10 Nov 2020 12:02:46 +0000 Received: from DB7PR08MB3097.eurprd08.prod.outlook.com ([fe80::897b:8573:fd4b:d06b]) by DB7PR08MB3097.eurprd08.prod.outlook.com ([fe80::897b:8573:fd4b:d06b%7]) with mapi id 15.20.3499.032; Tue, 10 Nov 2020 12:02:46 +0000 From: "Sami Mujawar" To: Sughosh Ganu , "devel@edk2.groups.io" CC: Ard Biesheuvel , Jiewen Yao , Achin Gupta , nd Subject: Re: [PATCH v1 02/12] ArmPkg/ArmSvcLib: Return x4-x7 in output parameters Thread-Topic: [PATCH v1 02/12] ArmPkg/ArmSvcLib: Return x4-x7 in output parameters Thread-Index: AQHWp54SBHyhlgCTO0uwECN7ptvxpqm7ZDvg Date: Tue, 10 Nov 2020 12:02:46 +0000 Message-ID: References: <20201021113233.25548-1-sughosh.ganu@linaro.org> <20201021113233.25548-3-sughosh.ganu@linaro.org> In-Reply-To: <20201021113233.25548-3-sughosh.ganu@linaro.org> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: A76BF86076F8154E8D1DD332F57C38C3.0 x-checkrecipientchecked: true Authentication-Results-Original: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [2a00:23c6:548a:4800:801b:d0a6:931:5e26] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: af932c61-2f6c-4321-5590-08d885709455 x-ms-traffictypediagnostic: DBBPR08MB4235:|AM6PR08MB3157: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: fZQBFMHz/mERosMMeE2vjD37HN6ejVI1Qo/pnFfNxcPmbW9mBR5jkCdo6XHsaWlj1h9AkFeTfVq3fqc2Z/OBW3ulknpcnpGJg+ZhPmdW6e9ZB72+vXKdm+RKXTcCQrBFMXEsC/tm//28Pwk3fUSx7UpQMEg6/FBbqoMF9ZIb7hX0otwb+2iXyxYQjiHSqlVxc0zdzlWNccmJpcnGM+QoWTh20KU0fOk8EAacZ+3Fk8gPnbkaFpFgsja6lTTEuBUCjomd2qFlNP+NC3xjemnarKL0DIJ1XcoanLnV4O1wcyeg6O8wjvglo48+fV+FUBY0DuUmEE9zpfK7VL3Q2MJm/r4/0JCo9Hs3jVojlK9h8pi8xNpM1is22HkfNqTPgX80DHVV+zMVuee8jmAXpGa95A== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3097.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(366004)(396003)(39860400002)(346002)(376002)(54906003)(8936002)(8676002)(316002)(478600001)(86362001)(966005)(5660300002)(71200400001)(53546011)(19627235002)(52536014)(7696005)(66446008)(55016002)(33656002)(9686003)(6506007)(66556008)(76116006)(64756008)(66476007)(2906002)(186003)(66946007)(83380400001)(4326008)(110136005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: eiBoBqTRpphI2CySgCHt7jktqQKGA6MiEDhfxs7soV0Dlyv9thJgYfRxLw6gow+Oh+LQovCqlUZw4tZYe8PY4e5V93/XQFRXKtfc8OyEgMKJdFwrGkkhq3KTCcK/FuMYVSKoeWiwQomPt/S3DvLsbiK9SweBGxluvbGZnT8zOFg/odZ4c7svxO+IW28IARhRFrxavtQvDd07/RWGdqnOKJmMLpH5tPAMqSx0ShF941x7ccNgG/QZJLu/Sp+UEg3kwLeQtWlv98rhoRvUwnDgvhm47akmj6tiIAiBSMjjFw8cvEDvTn2m/PVJUbZg+yxJGpxMt3oznLg9HTg8qQc8+nvVbOfTqtNJJs6xWiYEXS2gbNzhLJSKv4jBkqd6tK4UnfW+Jjs9L5gMk/q6fb79/998BLQQ6HlSTbIDLBpUP3FPXG3Q8VfvpJaYNz74MIbm35gSmlch5YCxCsh6b7eOWFHoR8aU5C17qdjZrwVrn3izxkvUzrypEPuhYtr53vW6gayiFeDX4EpOExzjfqP1obR1l/MGXjuOGHeiD0gZe1R3ddP8gaE9T+E7ZsLL5EhNnyoujN9zCx0j0Ejb6p85D3GFTTSdXuS8hBa1vhGZXNAcZZjMXaJ14OffoFyAW0EQl0ddIGOp7S5bU+i3caIeY3aeITr97Xx0ktEiW7S15Nxty6NtUITSP6YpD02qa34uZ39IFdAocLe63joODrc/2g== MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4235 Original-Authentication-Results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: b81e0eb6-a8dd-4349-c356-08d88570897d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FwkFv6qIxiHJ6AWfVJTh1t03FSDu4ktXctFklmTu3w4+TPVMkNViDZeJL+xmhGOIpZPQwN/8kj733nMZkUZyZd2PHLyfvC+MNveW9q2Yh1bULqBY9NmUl4Yd41GCI598rXBsqJY9G6CdkdFL3SIhdhVr4cUKnV3XTB6knxUmNwcFwgxVAq07s59pAC+32mDVamN3cyrIfUc1rPejFX1gazB7Vcg8buF+HfQfS61wuNR8MVyR+OGYga/CfUn4MInOhuFPul6Xj7niVOfErhPwrIAhHXT0q/ylirloCrvKZbVtV1D1vETe2p5kK6pr+GQeas+l35P7oCRXD8WHj2E3cq5ZwQLuQSKS6huam89F2B8HsbWYrKBcpw+WDyL4ScadVeU7q8xw0K6mCFlE/jldko3C9bilGiuFQ1TkvoVi/uEPBXt+gWJ9ROZGkxd444p0rF4Vlop5Ok3y900SmIhpXP2NC2aGtNll9TDLJuvLqVE= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(396003)(39860400002)(376002)(346002)(46966005)(356005)(19627235002)(70586007)(70206006)(52536014)(316002)(86362001)(966005)(478600001)(7696005)(54906003)(110136005)(82310400003)(4326008)(186003)(2906002)(9686003)(6506007)(53546011)(33656002)(47076004)(81166007)(26005)(82740400003)(336012)(8936002)(8676002)(55016002)(83380400001)(5660300002)(36906005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2020 12:03:04.0448 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: af932c61-2f6c-4321-5590-08d885709455 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3157 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Sughosh, Please find my response inline marked [SAMI]. General feedback: - Add reference to the SMCC v1.2 spec and FF-A spec in the file header. - Do you plan to submit a similar patch for AArch32? - Can you update the function documentation for ArmCallSvc () in ArmPkg\Inc= lude\Library\ArmSvcLib.h, please?=20 Ref: https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification= /appendix_a_common_examples#functioon-declarations Regards, Sami Mujawar -----Original Message----- From: Sughosh Ganu =20 Sent: 21 October 2020 12:32 PM To: devel@edk2.groups.io Cc: Ard Biesheuvel ; Sami Mujawar ; Jiewen Yao ; Achin Gupta Subject: [PATCH v1 02/12] ArmPkg/ArmSvcLib: Return x4-x7 in output paramete= rs From: Achin Gupta The Arm SMC calling convention standard v1.2 allows 8 input and output parameter registers. The FF-A specification relies on this communication. This patch extends the number of output registers returned by ArmCallSvc() to match this convention. Signed-off-by: Achin Gupta --- ArmPkg/Library/ArmSvcLib/AArch64/ArmSvc.S | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ArmPkg/Library/ArmSvcLib/AArch64/ArmSvc.S b/ArmPkg/Library/Arm= SvcLib/AArch64/ArmSvc.S index ee265f94b9..8cb5c45582 100644 --- a/ArmPkg/Library/ArmSvcLib/AArch64/ArmSvc.S +++ b/ArmPkg/Library/ArmSvcLib/AArch64/ArmSvc.S @@ -36,6 +36,8 @@ ASM_PFX(ArmCallSvc): // A SVC call can return up to 4 values - we do not need to store back x= 4-x7. [SAMI] Please update the comment to reflect that 8 values can be returned.= =20 [/SAMI] stp x0, x1, [x9, #0] stp x2, x3, [x9, #16] + stp x4, x5, [x9, #32] + stp x6, x7, [x9, #48] =20 mov x0, x9 =20 --=20 2.17.1