From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.74]) by mx.groups.io with SMTP id smtpd.web08.35791.1606141329969379075 for ; Mon, 23 Nov 2020 06:22:10 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=UjP4nfs2; spf=pass (domain: arm.com, ip: 40.107.22.74, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xS7FA4NidE+3JbOzbMveg9/Im+td924TyA/0A8hcrKA=; b=UjP4nfs2coXVmK1rXKtFYK30RRuOAf6QRmU2qs1hKWxn9bFithauqmrZYnxqWHQkAa3p+ZpCcy2gyFZopAmoPl2dAU6uqbVl8zhkTUS0GPbJvtKQKY+Nk1FjA6ZDQY1ECstkrbEfyWcKSn/VhQDY8G2TL3XhrffX+ppYAv+c5OM= Received: from DB8PR06CA0053.eurprd06.prod.outlook.com (2603:10a6:10:120::27) by AM9PR08MB6033.eurprd08.prod.outlook.com (2603:10a6:20b:286::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.21; Mon, 23 Nov 2020 14:22:07 +0000 Received: from DB5EUR03FT019.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:120:cafe::5) by DB8PR06CA0053.outlook.office365.com (2603:10a6:10:120::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20 via Frontend Transport; Mon, 23 Nov 2020 14:22:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT019.mail.protection.outlook.com (10.152.20.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20 via Frontend Transport; Mon, 23 Nov 2020 14:22:07 +0000 Received: ("Tessian outbound 39167997cde8:v71"); Mon, 23 Nov 2020 14:22:07 +0000 X-CR-MTA-TID: 64aa7808 Received: from 4d5d984e2353.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 72928360-64B9-406D-86BD-BBB13087CB71.1; Mon, 23 Nov 2020 14:22:02 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4d5d984e2353.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 23 Nov 2020 14:22:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eqDyZkTjm0wuomfiXm42SplaHwiMmnW2dv6a86laYsy4HJEFOegxlgkBUlu4pXW3qdHUNmBpanhQnW2yfPhS2x2px+2r+BiXS/xroRUPCV0pxJWSDkK7ADVuDFQ5IqrMurxB4w6IIBSDAawoG0pH4xKo/gV9eoOx5rudAuTvR1akHKQiU7w/1rk43tXGUmQ8haQ2zMyYWeKxqmEakxesqQ5QS8XHBIcaUAlqbKo72N4ltMOr7kocwE405CluZoBf9sBmXOK70CLvaG9/ulcLyXmRjWI+eVWQvS671aJJ8Os36PPUHvUA7skeFnFYp57vQramTFhQYJ+dAB6Z9nfMng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xS7FA4NidE+3JbOzbMveg9/Im+td924TyA/0A8hcrKA=; b=dAAKNcO/Vduth6DtvFy4tW9sVwZ6Hs9lmWG+9mURP4xAAtJhN8lWa3EzLVOcBpLu+V8QSuZlSC/QlT//x2jyzaV4oUMLGyOrSoRiyblkQsoIEYW+yepQybeJL+f9epj8vq6srSyQLhE15XADXUElEMBuQHmGsEq/2PDIzHWAZE0z1Egm450JcHoKwbG0onWpeUkhB1Cy4JxO9fTIxdnQjU82QSwtobjMwR/ksbACGgAZmAaiwqyzy+958X6VPRu2mHC9xiADV9IFXGQ643zcjDKyrcu3dEgjCEOkURSabcj4/hRYX9iOGowLIx/n4VAf3d7rPd7+u7bfitSMzsxiig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xS7FA4NidE+3JbOzbMveg9/Im+td924TyA/0A8hcrKA=; b=UjP4nfs2coXVmK1rXKtFYK30RRuOAf6QRmU2qs1hKWxn9bFithauqmrZYnxqWHQkAa3p+ZpCcy2gyFZopAmoPl2dAU6uqbVl8zhkTUS0GPbJvtKQKY+Nk1FjA6ZDQY1ECstkrbEfyWcKSn/VhQDY8G2TL3XhrffX+ppYAv+c5OM= Received: from DB7PR08MB3097.eurprd08.prod.outlook.com (2603:10a6:5:1d::27) by DBBPR08MB4460.eurprd08.prod.outlook.com (2603:10a6:10:cc::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20; Mon, 23 Nov 2020 14:21:59 +0000 Received: from DB7PR08MB3097.eurprd08.prod.outlook.com ([fe80::315c:f6c3:2600:bd39]) by DB7PR08MB3097.eurprd08.prod.outlook.com ([fe80::315c:f6c3:2600:bd39%6]) with mapi id 15.20.3589.030; Mon, 23 Nov 2020 14:21:59 +0000 From: "Sami Mujawar" To: "devel@edk2.groups.io" , Sami Mujawar , Sughosh Ganu CC: Ard Biesheuvel , Jiewen Yao , Achin Gupta , nd Subject: Re: [edk2-devel] [PATCH v1 10/12] ArmPkg/StandaloneMmMmuLib: Add option to use FF-A calls to set memory region's permissions Thread-Topic: [edk2-devel] [PATCH v1 10/12] ArmPkg/StandaloneMmMmuLib: Add option to use FF-A calls to set memory region's permissions Thread-Index: AQHWp54bVrXPhwiiLUeLwbKacary6qnBjPTggBRqoEA= Date: Mon, 23 Nov 2020 14:21:59 +0000 Message-ID: References: <20201021113233.25548-1-sughosh.ganu@linaro.org> <20201021113233.25548-11-sughosh.ganu@linaro.org> <164A26E48323EBBE.21019@groups.io> In-Reply-To: <164A26E48323EBBE.21019@groups.io> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: CF79C5B5D0807048A4082C93526885B2.0 x-checkrecipientchecked: true Authentication-Results-Original: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; x-originating-ip: [2a00:23c6:548a:4800:e1e2:5e02:5cb9:6f61] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 6cdbfd85-5226-417b-fabd-08d88fbb284f x-ms-traffictypediagnostic: DBBPR08MB4460:|AM9PR08MB6033: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: CvFm2glLnYUsijYAjt4doaUHgBwcEZxf2jT/7sYfn4ogTGiRrqwQXgskCWev308w1ScMZqlFSDARHA3Vi5Dirad2uz4pN0J7l+jbeUCfT4mO6hfcvtvbnGjkVu0VyZZRJ8qHakrK5mmdlEjOe7RDHLqkxyxP98+R2DfduKxLiJ979qjYgyGjUmzLvm4KNhujJZGFb05zR8ySEU/hLIzQI9qQuDluvnObq2MX2/l/uzhftR2gqyRPFmYvMc+FHCMwQTVx0CqXYBwYQQMYBjpSGhHVUBoPwX8JUOVark6spA1OlCIOVmQcsbTXeaGhNP7rqaHGRzoidirja/2St8Y6tmbMYq/sN3iWk4A46Ri6WpsqpyWa0AiUwtFZxKcs/7Ifd8O9A+GdQi642dKmK7tM3w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3097.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(376002)(366004)(136003)(39860400002)(346002)(396003)(110136005)(6506007)(5660300002)(55016002)(52536014)(76116006)(53546011)(966005)(9686003)(66946007)(54906003)(64756008)(66446008)(66476007)(2906002)(66556008)(186003)(7696005)(8676002)(4326008)(316002)(8936002)(19627235002)(83380400001)(71200400001)(86362001)(478600001)(33656002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?d7QXWYv2taZDsObwuHG0YPW+uOcUB8yEX58Oor/MFpK924NcdQCLuIz0iPHk?= =?us-ascii?Q?Z9xITqySDLiwAzwaYDPIJv56/7sCEveHtF3Cc8YGJpGU+1LnQy7Lw2bbmY77?= =?us-ascii?Q?8DjrAWEAaE4UT6o9XiZIooTUmF+DYjwrhRAlyTA5iBRWBpNRF0jehTYJDF/t?= =?us-ascii?Q?us4fsvbsdQOkdatdOvqC2q05vt1qA2zMrfNqF6oW37fjRGOYkbHBHTG+ZnFo?= =?us-ascii?Q?8eoGVbN7lg4RAPBw6nDUCCSmPk80zbS2VVg4q3QYm6H1VnIEZpVX3ck6F4JB?= =?us-ascii?Q?ADFtTP2/UW73GQ/jHEiBFHesfZhEEXlq1p2Np0nNFXpmDKYkchB2WX9bb8n9?= =?us-ascii?Q?yF4hz/RSQEziZJ+MUrWKPeyuueY3Eoq8RCkGX8KEYCLfJGZzdgkpHbxlLv6b?= =?us-ascii?Q?CP3wtY1mWnkHVJTaOdg9GYF5QcAXXk+5GXed5Qj7Y2Uk1CijMfeIfhK7p42l?= =?us-ascii?Q?b0XKmeyZy+UtROeWzRlUOCTy4+pdyfulNmNL1dKXKvTw06CiygLvAKORH35Q?= =?us-ascii?Q?E0j+0V/WCe0VE/t/UtchmcTR6h8HDZYGyQlYjYFm23Af/eb0M62j+UYwN3ml?= =?us-ascii?Q?Ze67XPiMbRDwv/Ik4FArM1C9ikZmu5ePN/MuTxbskRiShH8nyOvIJb7ReNyV?= =?us-ascii?Q?U84Smq3LQFKGaixYPKGyoSpf1Da0295YdzMoGBP9CKHIPwTbpfTJJAQAy2a2?= =?us-ascii?Q?Qf3NfCx+vJA61A4k6Rxyd7HnlJzmJRyxOXbtaAexTVb4ByJvGSAJHACG5mNS?= =?us-ascii?Q?PeIvj0J0BbOSosVKlRASN7N+MTmX+0TMsvtU/Oj6Bbi/SFW8WI5cxF4Qf6pc?= =?us-ascii?Q?sLSE6LqiJ/sCy5aZbdMh8s7KSMLA+T0nYQPdAUSXGIdOTh544JJLaSB/emtO?= =?us-ascii?Q?yQMuXnnj7GXFvzjzB9pBJHWdCSAlNt8y5rG0GK/BFVSzHa4g/Ny/d+u3dDh+?= =?us-ascii?Q?X9/VL03IG+oThGR9cziOkw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4460 Original-Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 78939426-66f0-4576-1adf-08d88fbb23e1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7w9p07Zirdv7rTvOZWZFbbQOht4RwVaIk+z0x3jQGhJSp49AhWxGiq9b0EM066YUiDK7AOqw4D56UXZRlkNuN7I/kmY1FSwutJl5Y538KTMdV/V9pRQhRsF9Xw4F6bB/hF3xY1wgSPqgoKhTByYrm6JjeyqIBjvuw+CA7s7VaG/JTkwI+rA7PD4TzFqOaPWpIHE0DJCmAd5KdVCwSWUVGvhuYV91aa1X93fUnZZsIKaT1+nEtWxF6wfHfm0dskZ6MwCrGuSRwVpMXutTmLdUg9CFJ+qU9UweDHG/zr52LfHSkJXhjf8wopodTPzYfPMBERHJ3RSRDJBUoOmdc/mnyI8kk5D600OmPwHXsKGRK5BldBGwTzP94sJ2tDmHsYPLY1QgfB8/66EYII/ZjrV6XHXWVyl3sJF1UkBYNMHamAnybPsN63oWbMG0oYObQbTKp1EynnroTo2Qp++0rJbOhhOmbTcs1eCLowx9OXJ7kDI= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(6029001)(4636009)(396003)(39860400002)(346002)(376002)(136003)(46966005)(8936002)(47076004)(2906002)(55016002)(316002)(70206006)(8676002)(478600001)(86362001)(19627235002)(356005)(81166007)(33656002)(336012)(82740400003)(5660300002)(9686003)(26005)(4326008)(54906003)(110136005)(7696005)(83380400001)(52536014)(966005)(53546011)(70586007)(6506007)(186003)(82310400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2020 14:22:07.0841 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6cdbfd85-5226-417b-fabd-08d88fbb284f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6033 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable One more suggestion added inline marked [SAMI]. Regards, Sami Mujawar -----Original Message----- From: devel@edk2.groups.io On Behalf Of Sami Mujawa= r via groups.io Sent: 23 November 2020 01:43 PM To: Sughosh Ganu ; devel@edk2.groups.io Cc: Ard Biesheuvel ; Jiewen Yao ; Achin Gupta ; nd Subject: Re: [edk2-devel] [PATCH v1 10/12] ArmPkg/StandaloneMmMmuLib: Add = option to use FF-A calls to set memory region's permissions Hi Sughosh, Please find my response inline marked [SAMI]. Regards, Sami Mujawar -----Original Message----- From: Sughosh Ganu =20 Sent: 21 October 2020 12:33 PM To: devel@edk2.groups.io Cc: Ard Biesheuvel ; Sami Mujawar ; Jiewen Yao ; Achin Gupta Subject: [PATCH v1 10/12] ArmPkg/StandaloneMmMmuLib: Add option to use FF-= A calls to set memory region's permissions From: Achin Gupta Allow setting memory region's permissions using either of the Firmware Framework(FF-A) ABI transport or through the earlier used SVC calls. Signed-off-by: Achin Gupta Co-developed-by: Sughosh Ganu --- ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c | 24 ++= ++++++++++++++---- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmL= ib.c b/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c index ab13602556..fef5eb4d22 100644 --- a/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c +++ b/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c @@ -63,17 +63,31 @@ RequestMemoryPermissionChange ( IN UINTN Permissions ) { + BOOLEAN FfaEnabled; EFI_STATUS Status; ARM_SVC_ARGS ChangeMemoryPermissionsSvcArgs =3D {0}; =20 - ChangeMemoryPermissionsSvcArgs.Arg0 =3D ARM_SVC_ID_SP_SET_MEM_ATTRIBUTE= S_AARCH64; - ChangeMemoryPermissionsSvcArgs.Arg1 =3D BaseAddress; - ChangeMemoryPermissionsSvcArgs.Arg2 =3D EFI_SIZE_TO_PAGES(Length); - ChangeMemoryPermissionsSvcArgs.Arg3 =3D Permissions; + FfaEnabled =3D FeaturePcdGet (PcdFfaEnable); + + if (FfaEnabled) { + ChangeMemoryPermissionsSvcArgs.Arg0 =3D ARM_SVC_ID_FFA_MSG_SEND_DIREC= T_REQ_AARCH64; + ChangeMemoryPermissionsSvcArgs.Arg1 =3D 0x3; [SAMI] Can you define macros for the endpoint IDs, please? Also add refere= nce to where information/documentation about the endpoint Ids can be found. [/SAMI] + ChangeMemoryPermissionsSvcArgs.Arg2 =3D 0; + ChangeMemoryPermissionsSvcArgs.Arg3 =3D ARM_SVC_ID_SP_SET_MEM_ATTRIBU= TES_AARCH64; + ChangeMemoryPermissionsSvcArgs.Arg4 =3D BaseAddress; + ChangeMemoryPermissionsSvcArgs.Arg5 =3D EFI_SIZE_TO_PAGES(Length); [SAMI] Add a space between EFI_SIZE_TO_PAGES and starting parenthesis. [/= SAMI] + ChangeMemoryPermissionsSvcArgs.Arg6 =3D Permissions; + } else { + ChangeMemoryPermissionsSvcArgs.Arg0 =3D ARM_SVC_ID_SP_SET_MEM_ATTRIBU= TES_AARCH64; + ChangeMemoryPermissionsSvcArgs.Arg1 =3D BaseAddress; + ChangeMemoryPermissionsSvcArgs.Arg2 =3D EFI_SIZE_TO_PAGES(Length); [SAMI] Add a space between EFI_SIZE_TO_PAGES and starting parenthesis. [/= SAMI] + ChangeMemoryPermissionsSvcArgs.Arg3 =3D Permissions; + } =20 ArmCallSvc (&ChangeMemoryPermissionsSvcArgs); =20 - Status =3D ChangeMemoryPermissionsSvcArgs.Arg0; + Status =3D FfaEnabled ? + ChangeMemoryPermissionsSvcArgs.Arg3 : ChangeMemoryPermissionsSvcArgs.= Arg0; [SAMI] In case of FFA, Arg0 may also contain an error code, right? See FFA= spec, section 10.2. [/SAMI] =20 switch (Status) { case ARM_SVC_SPM_RET_SUCCESS: --=20 2.17.1