From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.62]) by mx.groups.io with SMTP id smtpd.web12.5866.1608116779454896377 for ; Wed, 16 Dec 2020 03:06:20 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=tVqxQdJ4; spf=pass (domain: arm.com, ip: 40.107.6.62, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xRHVAhCxvRmegf4c8QpSsndGfvSk3h/Zh6/BIVlVeV0=; b=tVqxQdJ4+KkLS5xqntIfeMY4H/GnuLMV+taUgBjV4kR30BLLRASk0c6VlB2UmEdFbOaSbW5kLT5oPf8ue2DqPP0Z4G6hM/q34Urm7Uf3JxdatIA4GNuAjdCVVZaZtHPlT1rOoK79AaJuBIKr/OdOodD07l8NmREMDIxZm5x7ASU= Received: from AM6P194CA0106.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:8f::47) by PR3PR08MB5675.eurprd08.prod.outlook.com (2603:10a6:102:8a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.14; Wed, 16 Dec 2020 11:06:16 +0000 Received: from VE1EUR03FT027.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8f:cafe::55) by AM6P194CA0106.outlook.office365.com (2603:10a6:209:8f::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Wed, 16 Dec 2020 11:06:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT027.mail.protection.outlook.com (10.152.18.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.22 via Frontend Transport; Wed, 16 Dec 2020 11:06:16 +0000 Received: ("Tessian outbound eeda57fffe7b:v71"); Wed, 16 Dec 2020 11:06:15 +0000 X-CR-MTA-TID: 64aa7808 Received: from 6631f523840c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F584B687-C657-46B1-B5C8-640CB630D474.1; Wed, 16 Dec 2020 11:06:10 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6631f523840c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 16 Dec 2020 11:06:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U46Jk59adOmOTYmo3BeBzkLyBRnk5afyvDCgHVWaz+XafV4+3QwjvAHgeq7hMLYs+KzbE/pZu9hG2kbgG6fvqmlCMagt/cNs2IldrkWyznYvGTzrV0XwZ+TaXuRdIZCgN9ZC9XcR0jtuP1c0v9rPImT7CU+yfODaqNG9xRjaDbs9B9KX9HT2Kz6kQ0tKbDCXhYWmaw3pSOjEGyYkxLUkX/jlMZnfDZidO8HcMUr3Oa42eLWSS0zlJjr64PTTAFQzF5ABCc1fugU2t26s2jOprPeedg6ooyxgaRWBYDkTOJidkBe5eI2wi8lIxOiRULVKg+XkTsMjaOqPDj7+TGHfBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xRHVAhCxvRmegf4c8QpSsndGfvSk3h/Zh6/BIVlVeV0=; b=Gwxdq9ckmtT700UpzKtEO3AIre2dH47kaAEZkp/LRm9BZU94Hl6I86jvXKvMDteMSHFCPc/LD8/2KopHYPOdl6Z9cTxwIUv9lVoeClriNtz/xhUrSlzLca2lvk3WXABTMPt4uDDj9Fx2RSZQ74gNgKxpA4LyO+sCI7W912jy7WqnJgvVYeTYlzKeCtvES9ew3u+M7fkFxfJsWjOuioYoqsuy5FUzMP/Ks8513ZJI00+qMIQ7NXIBv1EqShrONzbKKRUOybWSJP9q9zBxNbOhvq5/AOIIK7V2FtnH/rI4jGDBoWSUHOVV0PMhE8yw7Y1JPOTIuRr6c5p9QDi8S5OPww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xRHVAhCxvRmegf4c8QpSsndGfvSk3h/Zh6/BIVlVeV0=; b=tVqxQdJ4+KkLS5xqntIfeMY4H/GnuLMV+taUgBjV4kR30BLLRASk0c6VlB2UmEdFbOaSbW5kLT5oPf8ue2DqPP0Z4G6hM/q34Urm7Uf3JxdatIA4GNuAjdCVVZaZtHPlT1rOoK79AaJuBIKr/OdOodD07l8NmREMDIxZm5x7ASU= Received: from DB7PR08MB3097.eurprd08.prod.outlook.com (2603:10a6:5:1d::27) by DBBPR08MB6217.eurprd08.prod.outlook.com (2603:10a6:10:201::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.19; Wed, 16 Dec 2020 11:06:10 +0000 Received: from DB7PR08MB3097.eurprd08.prod.outlook.com ([fe80::315c:f6c3:2600:bd39]) by DB7PR08MB3097.eurprd08.prod.outlook.com ([fe80::315c:f6c3:2600:bd39%6]) with mapi id 15.20.3654.025; Wed, 16 Dec 2020 11:06:10 +0000 From: "Sami Mujawar" To: Rebecca Cran , "devel@edk2.groups.io" CC: Michael D Kinney , Liming Gao , Zhiguang Liu , Leif Lindholm , Ard Biesheuvel , nd Subject: Re: [PATCH v4 05/11] ArmPkg: Add helper function to read the Memory Model Feature Register 4 Thread-Topic: [PATCH v4 05/11] ArmPkg: Add helper function to read the Memory Model Feature Register 4 Thread-Index: AQHWx3nNl+XulwtvN0unB5czjmCi5an5lEiw Date: Wed, 16 Dec 2020 11:06:09 +0000 Message-ID: References: <20201201003358.8780-1-rebecca@nuviainc.com> <20201201003358.8780-6-rebecca@nuviainc.com> In-Reply-To: <20201201003358.8780-6-rebecca@nuviainc.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 1A034559D2A0C3439816A423FC480E58.0 x-checkrecipientchecked: true Authentication-Results-Original: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [2a00:23c6:548a:4800:ac83:fe43:cf2a:e70f] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: d61e03f7-2fd3-44c4-1735-08d8a1b29bc7 x-ms-traffictypediagnostic: DBBPR08MB6217:|PR3PR08MB5675: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:3383;OLM:3383; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: KB+Sk3SyuPVh3fyr2rKLh5q8xAo2pfWE2xcX9CizvBxg5mNOW3AtDlq5EVbsHtuq6HEy6XwNdn1uko7L2HrR4Q4Bmecq0Zyjib3ZzRlBrlVoS32yge/rvM333a8m7zyjZHAYS9omJtKwDkX1qdKKa16ExnkI2ofrsP6MeoabfMHiBCFiT100V1rHi7grNS62kZfDWV/r1V+Xgb/7v3+Ruj/D2Q4BjujpM/I4LKsDnB+6oL4QAPxzMDLBgQBJ/6YNkJVrl5Vj5wtcdjqfr3MRFtGNxk79VP7X7chg13BFFjThSxC1gXOe9qI854vcLHAIjlsECtQCxJLcKxd70oHDpw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3097.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(376002)(396003)(136003)(39860400002)(366004)(316002)(66556008)(8676002)(110136005)(6506007)(64756008)(2906002)(19627235002)(86362001)(8936002)(54906003)(66946007)(186003)(55016002)(83380400001)(52536014)(5660300002)(71200400001)(66476007)(33656002)(4326008)(53546011)(478600001)(9686003)(66446008)(76116006)(7696005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?ijMqahLGGvEsnbew0xHaCjizBlxF7OusbAy4DgFnt5tYk9BoM9dR8Wp8jeyU?= =?us-ascii?Q?S/Q8pnTiTL20ePqTSiii8JCpPWhNRNk6KjRVcEjorqtuA4uZsi6mSTQeCHpK?= =?us-ascii?Q?HyNrbsjTX6YtuO7/ZiSuJfa/NL+QEwJZDY/zFpH3lEqJe2U0ulLEz4s66nof?= =?us-ascii?Q?4Ziv9xaxC9Lkp8RGwKzz6SIhkDxDp8Y17WD4nACPCDZe5elKCPLTtV+DcPOZ?= =?us-ascii?Q?uU5oTN3hqfjw9zCgjGUidPKked0XLrvpX9owLwK6Z2oJeHNKeL3qgzO6pIhG?= =?us-ascii?Q?XuJNLv5SrAH2wEIN3XLrgkiQkwfU29+ThFpFC1ovYbu3in8yVB8r1/miLAdd?= =?us-ascii?Q?5eWJwX50tcihS2tzbWolcY7y/g2Ic73x/vP34V73CgRMynRpQYqSb71aGeWc?= =?us-ascii?Q?TcqnyQ9Y7vpJcHXOsOaSpsV8eU9YiRfQH7vDB/ofVfyS1wt29dkRN0qUB1iu?= =?us-ascii?Q?03T4KsmTeNn0Dg3pEZzxY4JmSHZQUCgdIUhu95xoCFZNLWHp8t509qFBKrby?= =?us-ascii?Q?mzyblf8ASHycTsvKvnBB5KYAZQYT6czLzySHkkgeFfLViaLfJ1GdFAPykrPh?= =?us-ascii?Q?A5Qo0dkg1Ok/jpWy/QcAkGXn6LNMJmRYJQewwowvx5K2bYrT2rKfyohzqR/l?= =?us-ascii?Q?xjHE7PxBjxxCGcOE4NYBq+Wzd0ExB4dfmmag4475cQDAMmEuEMEZEmHLLxDW?= =?us-ascii?Q?IbWUyOYMPyK/y5lxJiz+DmWXnHln8OXocgKzkQqf0uOukLth6ZyfpH1p/N5/?= =?us-ascii?Q?YL2uh5nE88lSyNek+UAshfZvnURMJazm2hLOFi1x5urhd2tnWIUOndPa6zUp?= =?us-ascii?Q?kt5fF6B3mSeYdtw2hDuNXPRWO0AMi3Rz8+HwF/+kZI6+za/mA+7qlWoqp0kO?= =?us-ascii?Q?lamHTbjFEOaY96HC4ACahJ+KdtrsjPf8NarYQVa400FiFu6/JUIvAVewkRGH?= =?us-ascii?Q?koalXjnVfHGReAOxsStBtWA7RgbNH8ayEaCQ7KJsm54mOFjgkv5ycxEsHIBj?= =?us-ascii?Q?nPMS+lNBQBhaxjPjv3UVrvbny5BeRjI0p36u93rj1mUZIvI=3D?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6217 Original-Authentication-Results: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 49faabac-6d49-4b4c-df7c-08d8a1b29815 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KLfq09p7VtTuCWB514Ou1yx/ybh/PQnYWeWG8/hflQCBTu4Kg2kGviMXtrGNzwQaTl1Cyyzso94WytM63KaSjmNUVvH8HKwQ49XrG6C9+QYLuovuVsq/cqOI71npgV16Ec7spOWoa5PCe2pv4VhScJQAbVJgGtF7cZKsa3F7z9sRNZ7dbPKuDg6pb9Dy4hQkdrpY0iXw7BqUD0AvRj6XvifpjGSwLPnk8jYpEuLNLCStTIQaF61L9BOgrbSXEqlPUGuoJ0HdmNTw6cGWLu5G9NY32sd6xkUqObUesQsuU8/Qjo51gillwPqjaVVdZhlmUb5lxL4EBWot9dMvnVocz8ohXq5J1QCDZyuKynixHY5GRk2IViWevBrO2kEYymYrpZGsDseejzCbZouErW2zGw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39860400002)(376002)(396003)(136003)(346002)(46966005)(33656002)(86362001)(6506007)(356005)(82740400003)(110136005)(8936002)(55016002)(2906002)(83380400001)(82310400003)(26005)(81166007)(70586007)(54906003)(478600001)(53546011)(19627235002)(316002)(4326008)(186003)(47076004)(70206006)(9686003)(336012)(52536014)(8676002)(5660300002)(7696005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2020 11:06:16.1392 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d61e03f7-2fd3-44c4-1735-08d8a1b29bc7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5675 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Rebecca, Please add doxygen style function documentation for ArmReadIdMmfr4(). With that added: Reviewed-by: Sami Mujawar Regards, Sami Mujawar -----Original Message----- From: Rebecca Cran =20 Sent: 01 December 2020 12:34 AM To: devel@edk2.groups.io Cc: Rebecca Cran ; Michael D Kinney ; Liming Gao ; Zhiguang Liu ; Leif Lindholm ; Ard Biesheuvel ; Sami Mujawar Subject: [PATCH v4 05/11] ArmPkg: Add helper function to read the Memory Mo= del Feature Register 4 In AARCH32, CCIDX support is indicated in the MMFR4 register - unlike under AARCH64 where it's in MMFR2. Add a helper function to read it. Signed-off-by: Rebecca Cran --- ArmPkg/Library/ArmLib/Arm/ArmV7Lib.h | 6 ++++++ ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.S | 4 ++++ ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.asm | 4 ++++ 3 files changed, 14 insertions(+) diff --git a/ArmPkg/Library/ArmLib/Arm/ArmV7Lib.h b/ArmPkg/Library/ArmLib/A= rm/ArmV7Lib.h index 93183e67230e..3b331a3b2088 100644 --- a/ArmPkg/Library/ArmLib/Arm/ArmV7Lib.h +++ b/ArmPkg/Library/ArmLib/Arm/ArmV7Lib.h @@ -48,5 +48,11 @@ ArmCleanInvalidateDataCacheEntryBySetWay ( IN UINTN SetWayFormat ); =20 +UINT32 +EFIAPI +ArmReadIdMmfr4 ( + VOID + ); + #endif // __ARM_V7_LIB_H__ =20 diff --git a/ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.S b/ArmPkg/Library/A= rmLib/Arm/ArmLibSupportV7.S index 01c91b10fcb7..a60a2f634132 100644 --- a/ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.S +++ b/ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.S @@ -60,6 +60,10 @@ ASM_FUNC(ArmDisableInterrupts) isb bx LR =20 +ASM_FUNC(ArmReadIdMmfr4) + mrc p15,0,r0,c0,c2,6 @ Read ID_MMFR4 Register + bx lr + // UINT32 // ReadCCSIDR ( // IN UINT32 CSSELR diff --git a/ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.asm b/ArmPkg/Library= /ArmLib/Arm/ArmLibSupportV7.asm index 26ffa331b929..1679b09b797a 100644 --- a/ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.asm +++ b/ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.asm @@ -64,6 +64,10 @@ isb bx LR =20 + RVCT_ASM_EXPORT ArmReadIdMmfr4 + mrc p15,0,r0,c0,c2,6 ; Read ID_MMFR4 Register + bx LR + // UINT32 // ReadCCSIDR ( // IN UINT32 CSSELR --=20 2.26.2