From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (EUR01-DB5-obe.outbound.protection.outlook.com [40.107.15.71]) by mx.groups.io with SMTP id smtpd.web12.6050.1608117846480743860 for ; Wed, 16 Dec 2020 03:24:07 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=wNmrtaUR; spf=pass (domain: arm.com, ip: 40.107.15.71, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EVDTRT+gk8Y79WKAnupClsJvdCUIXY43OQEMndFDdio=; b=wNmrtaURZLqUwb1BCGoAPFC+PAcTsgCqCA/uhx/gq66k1TvPFFZykcotkY59sCRkt1GHAAMdbIM86gar8s5jmsEnZMBSnHBPGFxaoezqn+oHEhT6LJ0Yp+pyC+WNMN3d8pRjaPANmgUExJNLHGQSYGAX3ronUdPNr9LpOEYU5N8= Received: from DB6PR0301CA0004.eurprd03.prod.outlook.com (2603:10a6:4:3e::14) by VI1PR08MB4254.eurprd08.prod.outlook.com (2603:10a6:803:f4::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.14; Wed, 16 Dec 2020 11:24:03 +0000 Received: from DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:3e:cafe::40) by DB6PR0301CA0004.outlook.office365.com (2603:10a6:4:3e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Wed, 16 Dec 2020 11:24:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT006.mail.protection.outlook.com (10.152.20.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.22 via Frontend Transport; Wed, 16 Dec 2020 11:24:02 +0000 Received: ("Tessian outbound 76bd5a04122f:v71"); Wed, 16 Dec 2020 11:24:02 +0000 X-CR-MTA-TID: 64aa7808 Received: from c34e12da9a81.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4E5B9142-7E4B-427A-AF9C-0998075B9FCD.1; Wed, 16 Dec 2020 11:23:57 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c34e12da9a81.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 16 Dec 2020 11:23:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HeMKu5NhDBRJ9Bm0a9rQiZESof+FQRhtvEpxj8CtBz6eamHOOTDme3c/y4/yNpAwdlW30c+fdQiV/ayYI0IthWM4lnwTI0BSAQBlXHe5NnwzOciNZVnOVn6B4ggh93lg5wj0oSuflt4Fk1ntZ/Yi/ulocG1+6f1zSHnNxHU44XmLpZOQJHWq5XHuKBefNQhDcwL78YWUWjFJXL2IFXZ6sT+J5aYAKm2LPBDkjna1RJd5/K90TdmdNBICYfRzU1X50se2NVjOC5WcjgweCKq7GSIktAth8CtNiA1tI48VHHzjEYKuyx97ffFyeLQHt/iKnrHRp7CWBBzTpVJrZbfkWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EVDTRT+gk8Y79WKAnupClsJvdCUIXY43OQEMndFDdio=; b=HENz2H+6fi7TEoIktCibrlKqEkJZkCCjsWwHx0BGGwG+pcZRLrtv9zRsE1v8F+y01LVF8PBLkIg9WDaXdopPFMSqCsZj8V0FuxR4nKSK5Ye1RcAyNKv7S6l+vvEG4GLW9d8dO9jXX93CHCg8b3LsVPGPG/Q0dniCz2bXNHBDLIK05Nc5NHQcyQmz11PCVCRb2sc6YpQEAbvboS2yHDA5iIJVgVSkMOo46bYZMWoi++RPHgKCjlrsEHtquy1GvYcGg0aRZvFKZ6VpZk+fp4Zca7uDVhzWW/8SotSvzt/puOjSxRt/utOeKaYVUKk5fphTXbrElqZSElM4zAmO8X6HwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EVDTRT+gk8Y79WKAnupClsJvdCUIXY43OQEMndFDdio=; b=wNmrtaURZLqUwb1BCGoAPFC+PAcTsgCqCA/uhx/gq66k1TvPFFZykcotkY59sCRkt1GHAAMdbIM86gar8s5jmsEnZMBSnHBPGFxaoezqn+oHEhT6LJ0Yp+pyC+WNMN3d8pRjaPANmgUExJNLHGQSYGAX3ronUdPNr9LpOEYU5N8= Received: from DB7PR08MB3097.eurprd08.prod.outlook.com (2603:10a6:5:1d::27) by DB8PR08MB4076.eurprd08.prod.outlook.com (2603:10a6:10:b0::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.14; Wed, 16 Dec 2020 11:23:55 +0000 Received: from DB7PR08MB3097.eurprd08.prod.outlook.com ([fe80::315c:f6c3:2600:bd39]) by DB7PR08MB3097.eurprd08.prod.outlook.com ([fe80::315c:f6c3:2600:bd39%6]) with mapi id 15.20.3654.025; Wed, 16 Dec 2020 11:23:55 +0000 From: "Sami Mujawar" To: "devel@edk2.groups.io" , "rebecca@nuviainc.com" CC: Michael D Kinney , Liming Gao , Zhiguang Liu , Leif Lindholm , Ard Biesheuvel , nd Subject: Re: [edk2-devel] [PATCH v4 05/10] ArmPkg: Add helper function to read the Memory Model Feature Register 4 Thread-Topic: [edk2-devel] [PATCH v4 05/10] ArmPkg: Add helper function to read the Memory Model Feature Register 4 Thread-Index: AQHWzMKUOxiZpiph4k6u0cxuU2VzVqn5n/XQ Date: Wed, 16 Dec 2020 11:23:55 +0000 Message-ID: References: <20201207175427.28712-1-rebecca@nuviainc.com> <20201207175427.28712-6-rebecca@nuviainc.com> In-Reply-To: <20201207175427.28712-6-rebecca@nuviainc.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 1097A09CB0DE0C48A73D998A5C2417AA.2 x-checkrecipientchecked: true Authentication-Results-Original: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; x-originating-ip: [2a00:23c6:548a:4800:ac83:fe43:cf2a:e70f] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: f3d43186-c444-4de3-76e5-08d8a1b5178b x-ms-traffictypediagnostic: DB8PR08MB4076:|VI1PR08MB4254: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:6790;OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: L3GicNnnbRwmLtWOU4j17Em3OeWHoJgKVpZJ2OwMBWgnA4T5WV0DoJG2mcfNZKVLLISEFaFzrUyC4fTdUlFTM+zjYbKDd5GCC4SKoz2h3t8dXfgKvpJzeyN6+pS9p5kEv/aHiCTZ4TexlpPE+nLXVZQIhX0B+QqmhbmLwfiFjDPzxuHbQJWZTV+mjmDtUT0n5daqoNW6r/LMWsDpLkO0OOAFQ6Vdw/AK4wOmWUyJvQWD/68MnTDMSW7EzZwhJCGg3hc3Mfx1kr980QDMcYtFZsH7TJN9tDqWOf12SOhA3eLX374Ov9IEivTN8Q2DbdyZB5vSxOeXPsBAQnZmGLsH1yfXCgYsVyWlCI0pLp0f0XH8LZGa46edcvp5nkXnH+nb+uUnzr5tNmPyEEAApoN/KA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3097.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(346002)(376002)(39860400002)(366004)(136003)(316002)(71200400001)(33656002)(76116006)(66446008)(66946007)(19627235002)(478600001)(8936002)(5660300002)(66556008)(4326008)(110136005)(8676002)(52536014)(2906002)(64756008)(66476007)(6506007)(86362001)(9686003)(55016002)(53546011)(966005)(186003)(83380400001)(54906003)(7696005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?zutK11IsGxuwzFCtFYSREikLH/i+Xmr5OAMEtIZFUeThUSGUX/L0JXo+PUcT?= =?us-ascii?Q?xkS5jVehHIQeoh8edZzGCfhp61CHxJYxMZJaq6CdHfEUOa3IPVPOSRUXiIyE?= =?us-ascii?Q?l4pdRaeg2lQdYgyMi+GvJY2JxDUpHIeuuttd12tyShtrsJweJaDLBKNjmGlm?= =?us-ascii?Q?FlBqQvQ+/Pv1nWZBG/HsmgHfTyR8XcTWaz3ykvaU/NxCvKP0M3ok9p6MZGeK?= =?us-ascii?Q?YacMstoNlBgxX2gQk6yZ7ao+1G0MNW4ZN3n3riS5k4/k5IOsXcSX4IkmSBl6?= =?us-ascii?Q?QnQKrasUW6tFYq+K8b3B4uBt82v48spQRpUAFf/ftULvxItyBZ9CKihqWtZ0?= =?us-ascii?Q?TaVhJxUTuefkbENSzMctvD1WsnADeUeWCVbu7KstOkkMVeqH6SYwpEReBqh1?= =?us-ascii?Q?MJvfiCXkNS1sdtNmqt8gFg0u8AA5zUHecAgf/TyNkZXs0HhTvrD78wlABkCT?= =?us-ascii?Q?p686TmRbUJ8mndT9Jq+lDk3DPSWFMb/qFIcG5mXMMDj2fFx6MKSFoelYW2hc?= =?us-ascii?Q?j6RpONfS/dvlby/2ilh0y3kQNFPhUObPKFiyAcMaXUXZMjl5YmUQby1rVNt7?= =?us-ascii?Q?jAdk4/2Fq3Cpj5Rqfz8/l/gjG/z3J7yM8Tw0fbXk6hnrzrkRLFj7vuTNJdtO?= =?us-ascii?Q?/+L03TE32foTPca8jFfZDks6IwGiNOaHelLNaUk8PyJw/2wKOnJrZfnUPp7S?= =?us-ascii?Q?dHT+7Pvpb9KnIQqfIcIHGCLfYDBqILFHkGsapnuXqyvbgACorudsRFQJ9o7S?= =?us-ascii?Q?IKeWyMN66dKE9nhqc6D6L2ohkthK1Ct/9sHU+LIxprY0BEp+353aAyeLBqU1?= =?us-ascii?Q?DOFTyBKH5fEQtGRlxZorbkls97UpxAXu/eATizizTopNtje2KWnbPi10OFW8?= =?us-ascii?Q?ztfJo8/d5GEmldVv3VMkne6PWDUWOeNNGugR+ZrPCu04VnUMg1aoeQly8VoV?= =?us-ascii?Q?hsJji6+bUx947FW2YstP2iROvt90ZRG2x9/NOLKoAzrUmzVIjfIeoCx+B235?= =?us-ascii?Q?kMfn8geU2pvg1iAWu5pbYbKDmLEJZ71BV3rr4HTcyqMtWg4=3D?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4076 Original-Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 059501c5-0e61-4836-097f-08d8a1b512ed X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G+bjnxHpdD/H8RZy9Pj/RkGkp3RJFFfW/Hd75kU7Qz2zv4smxRVF9Lnbm7Kagex1b8MxHRIAXTz0kbBlO/Tdv1obEqku1G9kiE7sGECpoUqaLnZwpYWHeIpJaFTftVb/FMnfffX1chf881YTYjy768BuFNQLI2cSc/G6DPKALcuzoc8nzkZIkFX23XcHeQWVCwNpAh3KFEudiuOsarqnH4FlFgx8/ryCT7OJInzXtdol6szDC1RxpQ9N+HHyuQlgS8aak/HPonL0N7U3gWwPp/2xJ08Mx3RGKnEDtxFx6OdM41g10s1dY67VTSvjR61F5ByRvvLWp1o2JkPlzWG2LM+CFDswHAupH83HazVctgDUylK6A0mS74agYmt5zoTSLqMTS/tqRaY6Zm7dP6MuqBgAmFg4W1KqrE4wMIBT97mZ1TOGJ85/hZ40TRX5/xVq4YKyXe6NV59IvOtZwWv3MgCdySLvzEI0y/945/fw8kU= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(396003)(346002)(376002)(39860400002)(136003)(46966005)(316002)(110136005)(966005)(336012)(8936002)(6506007)(7696005)(186003)(26005)(5660300002)(81166007)(9686003)(55016002)(86362001)(8676002)(70586007)(4326008)(2906002)(478600001)(54906003)(70206006)(52536014)(33656002)(356005)(82740400003)(83380400001)(19627235002)(53546011)(82310400003)(47076004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2020 11:24:02.9023 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f3d43186-c444-4de3-76e5-08d8a1b5178b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4254 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Rebecca, Please add doxygen style function documentation for ArmReadIdMmfr4(). With that added: Reviewed-by: Sami Mujawar Regards, Sami Mujawar -----Original Message----- From: devel@edk2.groups.io On Behalf Of Rebecca Cra= n via groups.io Sent: 07 December 2020 05:54 PM To: devel@edk2.groups.io Cc: Rebecca Cran ; Michael D Kinney ; Liming Gao ; Zhiguang Liu ; Leif Lindholm ; Ard Biesheuvel Subject: [edk2-devel] [PATCH v4 05/10] ArmPkg: Add helper function to read= the Memory Model Feature Register 4 In AARCH32, CCIDX support is indicated in the MMFR4 register - unlike under AARCH64 where it's in MMFR2. Add a helper function to read it. Signed-off-by: Rebecca Cran --- ArmPkg/Library/ArmLib/Arm/ArmV7Lib.h | 6 ++++++ ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.S | 4 ++++ ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.asm | 4 ++++ 3 files changed, 14 insertions(+) diff --git a/ArmPkg/Library/ArmLib/Arm/ArmV7Lib.h b/ArmPkg/Library/ArmLib/= Arm/ArmV7Lib.h index 93183e67230e..3b331a3b2088 100644 --- a/ArmPkg/Library/ArmLib/Arm/ArmV7Lib.h +++ b/ArmPkg/Library/ArmLib/Arm/ArmV7Lib.h @@ -48,5 +48,11 @@ ArmCleanInvalidateDataCacheEntryBySetWay ( IN UINTN SetWayFormat ); =20 +UINT32 +EFIAPI +ArmReadIdMmfr4 ( + VOID + ); + #endif // __ARM_V7_LIB_H__ =20 diff --git a/ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.S b/ArmPkg/Library/= ArmLib/Arm/ArmLibSupportV7.S index 01c91b10fcb7..a60a2f634132 100644 --- a/ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.S +++ b/ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.S @@ -60,6 +60,10 @@ ASM_FUNC(ArmDisableInterrupts) isb bx LR =20 +ASM_FUNC(ArmReadIdMmfr4) + mrc p15,0,r0,c0,c2,6 @ Read ID_MMFR4 Register + bx lr + // UINT32 // ReadCCSIDR ( // IN UINT32 CSSELR diff --git a/ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.asm b/ArmPkg/Librar= y/ArmLib/Arm/ArmLibSupportV7.asm index 26ffa331b929..1679b09b797a 100644 --- a/ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.asm +++ b/ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.asm @@ -64,6 +64,10 @@ isb bx LR =20 + RVCT_ASM_EXPORT ArmReadIdMmfr4 + mrc p15,0,r0,c0,c2,6 ; Read ID_MMFR4 Register + bx LR + // UINT32 // ReadCCSIDR ( // IN UINT32 CSSELR --=20 2.26.2