From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (EUR04-VI1-obe.outbound.protection.outlook.com [40.107.8.48]) by mx.groups.io with SMTP id smtpd.web09.7072.1605779771540587109 for ; Thu, 19 Nov 2020 01:56:12 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=8BoX78b6; spf=pass (domain: arm.com, ip: 40.107.8.48, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/5l8YkKXORalTm9oXlQIWEq18/XudV/eYdyI0Jkh2QE=; b=8BoX78b6oa6BfC3W07tmiSfzAiZzaSsQIaGYXZWTKzPB3jLTGwfJD8S6EGPYwfo6xLVGyMUP7Pmauzs+om4bEWBU2CmBvgzQ+wbUTvA6DaKgT5DQZfghNs+KNeAK6sjjXF6Cl/5ptUpuZUz+sgBcUh3O8cMlM4xLQYW17sOrlBo= Received: from AM5PR0502CA0012.eurprd05.prod.outlook.com (2603:10a6:203:91::22) by DB8PR08MB5194.eurprd08.prod.outlook.com (2603:10a6:10:e8::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.21; Thu, 19 Nov 2020 09:56:07 +0000 Received: from AM5EUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:91:cafe::97) by AM5PR0502CA0012.outlook.office365.com (2603:10a6:203:91::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20 via Frontend Transport; Thu, 19 Nov 2020 09:56:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT040.mail.protection.outlook.com (10.152.17.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20 via Frontend Transport; Thu, 19 Nov 2020 09:56:07 +0000 Received: ("Tessian outbound e0cdfd2b0406:v71"); Thu, 19 Nov 2020 09:56:06 +0000 X-CR-MTA-TID: 64aa7808 Received: from a14823b6ea54.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FEA171A6-6EF6-435C-8859-0D65DC5623A6.1; Thu, 19 Nov 2020 09:56:01 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a14823b6ea54.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 19 Nov 2020 09:56:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DZikcPZdv5HisqsR3WYuGYNnwiOdh/s2B5neG6P9x+vPklUzdy1GPQlGlz2h3h4pCLMKvYiCgQLKogMJjsdqD2JCqaP1fA1OcXcqWMjr40mqVWRNCcDQGiZcDfH1buVH7728BVyFnIUymWtru6WEzWoxgenIRUPh67gx/cpxRk56gA/3lgHdBs+ZhIzilhmAU/eNaT0RF0ASogN+qzOIUCI6gEC2Z1Kx/Jc+eMQsN0fQPSuclkGmXjvJyJIIKtcECPRBoGZi4jjmMc7kX9fI5QQJaO3kf6/w7LSE1v21b9Ny43UbwblQvDURPljCit1ezTd9qhlfVI2uX6He2aFrdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/5l8YkKXORalTm9oXlQIWEq18/XudV/eYdyI0Jkh2QE=; b=EOoSbZgmcqxOiplnRw1Xu8ik9xnEufNAz/WwUgfFxvpoG34MSd/nLN/LwUDOOXL8kr0pni4MzBd4mcZE4GiamtFf20gmWS8SXKY39yrOC7/sBzMjge/OzScs3ExI8CGN8xNvtK2KGorZr5X1jyxjhUcxUsyC8Fp0ljm0yebboF07Qwb1X1eVqjAnxTSynQDxMCi6liO4cLDIvwBOPwjWe9RXAmMjKX4WamwU+oCk+qVArcAkcwglrmJSNpkk4hkvyg8zqAc7j8BPtPf4ICB22oxDaAXrJuHE0eEbzh7gtAmrMgG4Zb9Q281PNMCOKm+ItqL8MB1+J0AKj92AYnzV3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/5l8YkKXORalTm9oXlQIWEq18/XudV/eYdyI0Jkh2QE=; b=8BoX78b6oa6BfC3W07tmiSfzAiZzaSsQIaGYXZWTKzPB3jLTGwfJD8S6EGPYwfo6xLVGyMUP7Pmauzs+om4bEWBU2CmBvgzQ+wbUTvA6DaKgT5DQZfghNs+KNeAK6sjjXF6Cl/5ptUpuZUz+sgBcUh3O8cMlM4xLQYW17sOrlBo= Received: from DB7PR08MB3097.eurprd08.prod.outlook.com (2603:10a6:5:1d::27) by DB8PR08MB5452.eurprd08.prod.outlook.com (2603:10a6:10:111::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20; Thu, 19 Nov 2020 09:56:00 +0000 Received: from DB7PR08MB3097.eurprd08.prod.outlook.com ([fe80::315c:f6c3:2600:bd39]) by DB7PR08MB3097.eurprd08.prod.outlook.com ([fe80::315c:f6c3:2600:bd39%6]) with mapi id 15.20.3589.020; Thu, 19 Nov 2020 09:56:00 +0000 From: "Sami Mujawar" To: Sughosh Ganu , "devel@edk2.groups.io" CC: Ard Biesheuvel , Jiewen Yao , nd Subject: Re: [PATCH v1 04/12] ArmPkg: Introduce support for PcdFfaEnable Thread-Topic: [PATCH v1 04/12] ArmPkg: Introduce support for PcdFfaEnable Thread-Index: AQHWp54RNjpNQ12rhUOkm3tiOVapy6nPWXrw Date: Thu, 19 Nov 2020 09:56:00 +0000 Message-ID: References: <20201021113233.25548-1-sughosh.ganu@linaro.org> <20201021113233.25548-5-sughosh.ganu@linaro.org> In-Reply-To: <20201021113233.25548-5-sughosh.ganu@linaro.org> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 5D8E91E77BE2EC4591EB3A7C79DB659D.0 x-checkrecipientchecked: true Authentication-Results-Original: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [86.137.203.120] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 7be13cea-334f-40fe-5c77-08d88c7155c6 x-ms-traffictypediagnostic: DB8PR08MB5452:|DB8PR08MB5194: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: NxDvPrHbMmmf8I1VP50u71Elf8IiG+3VwK5a3ZhWCfDzwiZCoQ6KoWFdIo8eRuGywClVYYW0p5Y4M+UreUaS3jTFZclHCVhhlyaVG6kkuybhJvhSFpumntA7mX1qLEEwqANjutIgPsjF5N+G2OaHL1LU16zZJR/jvB9mLhNbsitxHXLdaAA2tg/IOhEr2fQ1kjDV2uQ9KlZk5Mz1tnct69Ik8f91yHPP2wCdWzpmEY2XtBoHudoTrQ9tJzJJmL4sWaPOZigk7cnVFCAYHlxC7MJlQeDwAuyD0e6Lu7oi+rcIA1hXgf7rC9nG021QQwfEGleL+UhVvusaVhLCnRPslmSsL4knm32vZrNepWN8KC3nwi3I3A54geBB67O0R0QZvhup+e5WoKFRMsi/M2gOFg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3097.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(396003)(366004)(136003)(376002)(39860400002)(66946007)(5660300002)(76116006)(66556008)(66446008)(64756008)(66476007)(316002)(54906003)(2906002)(83380400001)(110136005)(71200400001)(55016002)(186003)(52536014)(33656002)(966005)(8936002)(26005)(9686003)(7696005)(53546011)(86362001)(6506007)(4326008)(478600001)(8676002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: cDy/sDBnyzVl0yU4SwK/ASTV3Dv2mbmX1ZoYAP9jA+nZMC5MoQwmyClxi8rmeyIVOnu/VQY/Fonze4qgN8g/5KKn6MF+Z7tbLE+jxzoo1KgwmkmauwpsLHMUIWrI91XGajw/OOSAEZFufWI+PBd76r2F3p0Mm2vvZFybQUZ9Y8qgAgUiKPTanC9nhLWGDT8xne76wPzXgigApfubYD27WrEPeaCb7Pdata+D7RVJys0jyyq6OH+QWcuPjN8rfbIU50gP8QcW0cw88oqQe+lCgcc/h/emt0+uF4AUibnATDjLRleVRnUrBFC00iv5iys2RGFFtTISyg38/gWxkMd4eVguOpVH+7c/YPP7jlHYTm3umQ69ZPq/1cFJTUUUEmK8UI34Be1t4NoHxURbzBFqJUAEGRb1vOKgtUPH1/wNgL0hbghI+wLLjeBQO1qvp4W1K45q82DXpZVWQ7VZgclSJ+ajyqNJpKt9fwUMfF4FRpSWh2XpI26ktuRlpVZVr/K6x0gmVM+2cXUtI34Q3evLZjuVxf6ZA7WIQhx+S8AbyXqATui5Iya9G0WJ+KEiMqiswiGdkke+EkacXfc5eBGwFDsMOUAFVZCi3o6K7zBEH9l1iAMitTwbGkWctl9PX4tYTMfJdSZ25L7dcbQKF6Z3kGfhvQJbnEbc10GxB88VnyBs4liIg3CtweACPzYtw0+jfM5qLJhypHNd1i2ckITFkCC9uXoFIzmt8pHwBaCfu255+fhaqB+kn8Q5dhun7YHmpbni3xSy7/B/DttgXcFahoxE7JRIGwyOPK0x4Z3PVfuzafN0GsBTc9e1pRNQSs1dL/6wRhGhVZczv6wdeCzgr3cSCeztqo0BqJk5mtfl6asiYuJMzfl0Y+6JoHWBqJ6tsBr5ocu8fHe2UUk4w8icFw== MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5452 Original-Authentication-Results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: c1dbbb59-9cce-45cf-9b21-08d88c7151a4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jwcMprHNv6NQJIGzQkXPtKAnyScp7fFjYkhi2sX5Ed7O1tAr3VXV3T4s0tJuz70Zk8lwQ17+gwXJZRp0qOzES1W5GRqcv696bn7WocftYKsMWyI/o36hwDg1kJQBknEtv4SHQhRJ6+nPD1Qsxtj5lHFWytMawV4iA+xoXDF7avaCA2hzGTiYUvWgKL6HEhB0cxjyPnOAbmz16osy2gBJ83sNN1F9Bh55d6Iqr3kJIt81cRwuP56jT+pO62Wum0/iR+XPjEVr4ZPUuzEuDCWpEordNjh65Xw67q/r+YWWlK3qqP8TDQvFGmffOk9bWzBb48wyIhhSARebgxbl6fykzwzGlwPk9pPPUbGQN0VxVj38XGpKOm45ptuu5WvrqUDTZYH1Lqyn0sx4yDM8McJR6DHP9V5Np6rNB2Q85kgcTx0dWIGtqqX9IC0ndP1K3qnv5HVYhna6XaQf/vRJdNhVBkbw8MU5pmJHI+ka5IGZzzc= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(39860400002)(346002)(376002)(396003)(46966005)(33656002)(4326008)(70586007)(336012)(316002)(8676002)(478600001)(47076004)(7696005)(70206006)(55016002)(9686003)(83380400001)(5660300002)(966005)(110136005)(36906005)(356005)(54906003)(6506007)(8936002)(81166007)(2906002)(53546011)(82740400003)(186003)(82310400003)(26005)(52536014)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2020 09:56:07.0401 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7be13cea-334f-40fe-5c77-08d88c7155c6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5194 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Sughosh, Please find my response inline marked [SAMI]. With that changed: Reviewed-by: Sami Mujawar Regards, Sami Mujawar -----Original Message----- From: Sughosh Ganu =20 Sent: 21 October 2020 12:32 PM To: devel@edk2.groups.io Cc: Ard Biesheuvel ; Sami Mujawar ; Jiewen Yao ; Sughosh Ganu Subject: [PATCH v1 04/12] ArmPkg: Introduce support for PcdFfaEnable The Secure Partition(SP) can request services from the Secure Partition Manager Core(SPMC) either through FF-A calls or through the existing SVC calls. Add a feature flag Pcd for enabling the FF-A method -- when this is set to FALSE, the SP uses the existing SVC calls for making the requests. Signed-off-by: Sughosh Ganu --- ArmPkg/ArmPkg.dec | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec index eaf1072d9e..979f3e2699 100644 --- a/ArmPkg/ArmPkg.dec +++ b/ArmPkg/ArmPkg.dec @@ -78,6 +78,9 @@ # Define if the GICv3 controller should use the GICv2 legacy gArmTokenSpaceGuid.PcdArmGicV3WithV2Legacy|FALSE|BOOLEAN|0x00000042 =20 + # Used to select method for requesting services from S-EL1 [SAMI] Can you follow the documentation style for PCD definition as done in= MdePkg\MdePkg.dec, please? More information can be found at https://github.com/tianocore-docs/edk2-Dec= Specification/blob/master/3_edk_ii_dec_file_format/310_pcd_sections.md [/SAMI] + gArmTokenSpaceGuid.PcdFfaEnable|FALSE|BOOLEAN|0x0000005B + [PcdsFeatureFlag.ARM] # Whether to map normal memory as non-shareable. FALSE is the safe choic= e, but # TRUE may be appropriate to fix performance problems if you don't care = about --=20 2.17.1