Re: [PATCH v1 05/12] StandaloneMmPkg: Add the SPM version for FF-A

["Sami Mujawar" <sami.mujawar@arm.com>]

Hi Sughosh,

Please find my response inline marked [SAMI].

Regards,

Sami Mujawar

-----Original Message-----
From: Sughosh Ganu <sughosh.ganu@linaro.org> 
Sent: 21 October 2020 12:32 PM
To: devel@edk2.groups.io
Cc: Ard Biesheuvel <Ard.Biesheuvel@arm.com>; Sami Mujawar <Sami.Mujawar@arm.com>; Jiewen Yao <jiewen.yao@intel.com>; Sughossh Ganu <sughosh.ganu@linaro.org>
Subject: [PATCH v1 05/12] StandaloneMmPkg: Add the SPM version for FF-A

From: Sughossh Ganu <sughosh.ganu@linaro.org>

The Firmware Framework(FF-A) requires implementation of SPM version
v1.0. Add new macros for the version that will be used for FF-A.

Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org>
---
 StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c
index c4132b0d78..33f0db654f 100644
--- a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c
+++ b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c
@@ -32,6 +32,9 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #define SPM_MINOR_VER_MASK        0x0000FFFF
 #define SPM_MAJOR_VER_SHIFT       16
 
+CONST UINT32 SPM_MAJOR_VER_FFA = 1;
+CONST UINT32 SPM_MINOR_VER_FFA = 0;
[SAMI] I think these should be defined using macros, see https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/4_naming_conventions/43_identifiers#4-3-5-1-use-all-capital-letters-for-both-define-and-typedef-declarations
Or 
These variables can be declared as static and the variable naming convention as defined in https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/4_naming_conventions/43_identifiers#4-3-3-2-any-variable-with-file-scope-or-better-shall-be-prefixed-by-an-m-or-g
must be followed.
[/SAMI]

+
 CONST UINT32 SPM_MAJOR_VER = 0;
 CONST UINT32 SPM_MINOR_VER = 1;
 
-- 
2.17.1