From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (EUR01-HE1-obe.outbound.protection.outlook.com [40.107.13.80]) by mx.groups.io with SMTP id smtpd.web11.7213.1605779730859035565 for ; Thu, 19 Nov 2020 01:55:31 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=7/W0IrcD; spf=pass (domain: arm.com, ip: 40.107.13.80, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZQPWOt88LYuhilAaAcS5t6ejyrS53K8QGyCy4pdgJDo=; b=7/W0IrcDNs6hyooHZHLhcK12C1ezzZ/KUVHsaBgGx2W9N+KHGq7tu5vONZCEyoioTnwN18i/PCHZT+WhXbR72IVf0gk+yUph0WXkmFoCOGPhFR4uV9PBf5EQ4oMRKD+ixCjQEiDD0uE+gOj0gTJyTwt7J69NPnV/V6Xpr2MPr7E= Received: from AM0PR04CA0079.eurprd04.prod.outlook.com (2603:10a6:208:be::20) by AM0PR08MB3859.eurprd08.prod.outlook.com (2603:10a6:208:107::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.22; Thu, 19 Nov 2020 09:55:28 +0000 Received: from AM5EUR03FT018.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:be:cafe::39) by AM0PR04CA0079.outlook.office365.com (2603:10a6:208:be::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.21 via Frontend Transport; Thu, 19 Nov 2020 09:55:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT018.mail.protection.outlook.com (10.152.16.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20 via Frontend Transport; Thu, 19 Nov 2020 09:55:26 +0000 Received: ("Tessian outbound 39167997cde8:v71"); Thu, 19 Nov 2020 09:55:26 +0000 X-CR-MTA-TID: 64aa7808 Received: from 231278d3f0ed.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7DD471F1-56DD-49B5-95D2-60C354E4434A.1; Thu, 19 Nov 2020 09:55:21 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 231278d3f0ed.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 19 Nov 2020 09:55:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gBtnV3vnaHmCC83hvSlpQqBhk5vaSmm3rN2XNRWPVRthe0iOtAx71SpSU+drd7b/k8GMj3GQ7BpdYxB7a9Z56D+SqylN6UI+cBA3xDCTJVS/DQPPyS5a2bn5c3kHw3e4sBlPJKfmYJRgJktNXIqdHVYqXCafIO8sI3cOqogfZjxuiK6tyrFNwt8B/98iL4dkUibhIvNNjJ4cBz9lAih8DnFeaiDgvFTTcO2Zmt5D2M4p5ruOtJxJ11JhPEAFbhExK2ODezOwoRNrVYZHXix8a476w0JYm/fNHy+jqFkmXDPhBd12tfvJBf2Q3dOxnyIOVO+XANNh/bbIu9T5jCjF8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZQPWOt88LYuhilAaAcS5t6ejyrS53K8QGyCy4pdgJDo=; b=AmnxiQvlgQLpRF5H9wtVmak+VLAIbxurkQ0zXGzS2vMGdDbu1fepQrIEf4nzarLNQSfT+eoZD7N/pCTF9uGp/Pz3YOQfUaDQIob6CtK/6uTSSrJiB9ueTNWzKs3xZZGowYqx0cipAA7m/AdJcVCpVpIN88ZdmBYrAYShq2nbIOiUPcSa6sDd5UsGqnrfd7VJaXyWHT3+EXZf3Y6+zKsnfUJY/Dumged3CUBMS8Au9IIGXpN4ZSVag3cQi8a1dEPL1GfOjEWdL8XtWyDDuL7UrQGWlVh330ax71ipmINVDreuEOA/4xW8U8JHzcnYxVh8aWao3iNOMI5+RYvStlBj3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZQPWOt88LYuhilAaAcS5t6ejyrS53K8QGyCy4pdgJDo=; b=7/W0IrcDNs6hyooHZHLhcK12C1ezzZ/KUVHsaBgGx2W9N+KHGq7tu5vONZCEyoioTnwN18i/PCHZT+WhXbR72IVf0gk+yUph0WXkmFoCOGPhFR4uV9PBf5EQ4oMRKD+ixCjQEiDD0uE+gOj0gTJyTwt7J69NPnV/V6Xpr2MPr7E= Received: from DB7PR08MB3097.eurprd08.prod.outlook.com (2603:10a6:5:1d::27) by DB7PR08MB3420.eurprd08.prod.outlook.com (2603:10a6:10:4a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Thu, 19 Nov 2020 09:54:59 +0000 Received: from DB7PR08MB3097.eurprd08.prod.outlook.com ([fe80::315c:f6c3:2600:bd39]) by DB7PR08MB3097.eurprd08.prod.outlook.com ([fe80::315c:f6c3:2600:bd39%6]) with mapi id 15.20.3589.020; Thu, 19 Nov 2020 09:54:59 +0000 From: "Sami Mujawar" To: Sughosh Ganu , "devel@edk2.groups.io" CC: Ard Biesheuvel , Jiewen Yao , nd Subject: Re: [PATCH v1 05/12] StandaloneMmPkg: Add the SPM version for FF-A Thread-Topic: [PATCH v1 05/12] StandaloneMmPkg: Add the SPM version for FF-A Thread-Index: AQHWp54EdOo0Btlej0aWb3Sx0roGz6nPXnow Date: Thu, 19 Nov 2020 09:54:59 +0000 Message-ID: References: <20201021113233.25548-1-sughosh.ganu@linaro.org> <20201021113233.25548-6-sughosh.ganu@linaro.org> In-Reply-To: <20201021113233.25548-6-sughosh.ganu@linaro.org> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 52246441BC02544CA25BAE492CB8CDC4.0 x-checkrecipientchecked: true Authentication-Results-Original: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [86.137.203.120] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 57e3b209-a530-4fb5-e7c4-08d88c713db5 x-ms-traffictypediagnostic: DB7PR08MB3420:|AM0PR08MB3859: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:6108;OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: KABYdLn0+5Otn67/nVz6u8ceohamAwNPEV/bj+EcMlwVZBHUOAYlTSlmfR6kDjv3fkMJrJvtmpuTLR7MF6M7oWHLvlWpGDKI8F0ruXpUhYI3Xgcehwp4KJcdZ5SdO0HjpkF/6HETUksvGq6EwwFg6Ss9JSHW6FiXcgJUQJIn2dHeeA8EmqwRQQ9SJzX+fwOrKulEkH48h19KTFUOyXCsEhl1wQfKWsHixTBxZF/bQRIG/EJqFCyvV6gd4lEsIMbxqOKBJiILVWCJq5cDUEi+xxxrgKbON1sVFoH8cylrrP7IGJkIONscJmP1P0ODm5XnTim1gXBGyW7BrHaiYuz0IMtbp7kINc2bwERYDJ+Efr8W6QgVON2aPFzK8FOByAkD0/uTI48GTHosmXKh6o1PGw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3097.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(136003)(366004)(376002)(396003)(346002)(39860400002)(54906003)(8676002)(8936002)(86362001)(33656002)(55016002)(9686003)(316002)(76116006)(478600001)(26005)(6506007)(52536014)(53546011)(83380400001)(66946007)(71200400001)(66476007)(186003)(66446008)(966005)(7696005)(110136005)(66556008)(5660300002)(64756008)(4326008)(2906002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: 1dkjffvm3ZDV237xjQvvUjDkD0nLw8midzG6EUGU01aNV9om4o0PxDmM6D25xowqryFi2OmqtfkNQoogrNOpa2ngXmusYMwhlFQZuXe3+Q3kp0JuXlY7A9jR0Jp1/cpa4qXbCtVnNr8uvWKsAZd47yFT2dXUBCZwavEPP5QdzdyQ3RXhHbouwW1q+Bb6YL8+3dvLqD240miAYDnYRCe4mNjyaZpFvlBaIkr2meBiZ+NfhIx4WspgGR/+7haWluTCpOChQKWWYsOn1N8X5AmBGqQqyqwZfUJJy63dsZsDnnHWEo/0qaUbIVGvy1CgZwida+SYlCc1UPh5aJw21F6Wr7BmV2Uz5EmsC66IJI11AeqRQv3wMEifqjaJmGF67Nmg/odrBi1GrmZQaju1kdWMqkIj6DZo1oki2JE3oPIFNDC6mFmoY74hF6IQ4YmzBWlpvgalL6/Z2S2bfs55329aySQ8bntcKVkprqvsJluSWDST8PRIWnayFlgcuULIMdSB3ifCsw5RsioOwMomsvxXQxx2D5a/vtZ2Zx1eTtvIIDvHn6UH/h6gj52zYs/js0o1kDz8qbuG/lBQAbmVB1I+zy0qKs2cDMKSUqyojHL7yXO0IkztyBe6jQZ/N/lSDGDNAz0EDr014z2FO3Ye2PgQJws57s2BOQthRLEjFMGSlkiym+DfaSXELoP+fWsntr2bxnUnnywosKApJGejpj+tCzSVSIJQvjzyeiuZOA/je+H6W1Cs2OLk6lRK7YF/7E0yuijmaalnoIGYQ/qOaRk6XV+bH3WZ+UktCehE7u2sQ/bOfa+vdceHAnpotg7yavvZBVD8GTWGBeBpeZ59z+dadlQgj2l7euMlW1W6Aa/cD0BOa0H02i5lz0jx5xvyH0JigKGR7Fyz/1W3jZpJ53bq9Q== MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3420 Original-Authentication-Results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: f7a5f3cd-5e90-4b72-95ad-08d88c712d80 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IQuVus+FGl5V8t2uM8A7oezobz+CcmSF2YM06jtrJjmeqRwPRFFxjXLLJwNqRV3BQQDSSk2hep9y3FqcozRNdtKJP01ZcEOpPb7Cxwn6y/tKMrV3jEiBfAzNn4kwryicYef9W3PNr0RMJFeqU8WnQ2FmMna1sex5dX5K+3kxAwdlht5adzXV9XmdQvtoQTVkbifkBpEqlPKGbVbH7G/HjD1syqTZRzqRq2+t8anj1rBZhPAIanty5leInQbb0ajq7D/s+nPmacyOCH2O3w6IMBGH1Sp8UrHfb+Fy27gAbRl5arg3hgvMlB71KMq4Lq+0tyto08OEmVYGtXZdcftsCV5G3RE6xfab0bQ9i2KdabHTWySdrowIFvk2KjJj3qtOTaGM1cwruVy+1elJqVy3zNNRMrKJoTKHFejyuLAd1N+ZVjK0hlUs1WR7kZJhMXHQ5dVc/85Zpt72i5EBM4QpfCwN9iiXaROh+8wV2iHmksA= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(6029001)(4636009)(39860400002)(376002)(136003)(346002)(396003)(46966005)(54906003)(110136005)(53546011)(8936002)(33656002)(186003)(47076004)(7696005)(83380400001)(82740400003)(81166007)(336012)(70206006)(82310400003)(8676002)(70586007)(36906005)(316002)(356005)(26005)(966005)(478600001)(9686003)(55016002)(6506007)(52536014)(5660300002)(4326008)(86362001)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2020 09:55:26.6560 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 57e3b209-a530-4fb5-e7c4-08d88c713db5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3859 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Sughosh, Please find my response inline marked [SAMI]. Regards, Sami Mujawar -----Original Message----- From: Sughosh Ganu =20 Sent: 21 October 2020 12:32 PM To: devel@edk2.groups.io Cc: Ard Biesheuvel ; Sami Mujawar ; Jiewen Yao ; Sughossh Ganu Subject: [PATCH v1 05/12] StandaloneMmPkg: Add the SPM version for FF-A From: Sughossh Ganu The Firmware Framework(FF-A) requires implementation of SPM version v1.0. Add new macros for the version that will be used for FF-A. Signed-off-by: Sughosh Ganu --- StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCor= eEntryPoint.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/Sta= ndaloneMmCoreEntryPoint.c b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPo= int/AArch64/StandaloneMmCoreEntryPoint.c index c4132b0d78..33f0db654f 100644 --- a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/Standalone= MmCoreEntryPoint.c +++ b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/Standalone= MmCoreEntryPoint.c @@ -32,6 +32,9 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #define SPM_MINOR_VER_MASK 0x0000FFFF #define SPM_MAJOR_VER_SHIFT 16 =20 +CONST UINT32 SPM_MAJOR_VER_FFA =3D 1; +CONST UINT32 SPM_MINOR_VER_FFA =3D 0; [SAMI] I think these should be defined using macros, see https://edk2-docs.= gitbook.io/edk-ii-c-coding-standards-specification/4_naming_conventions/43_= identifiers#4-3-5-1-use-all-capital-letters-for-both-define-and-typedef-dec= larations Or=20 These variables can be declared as static and the variable naming conventio= n as defined in https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-spec= ification/4_naming_conventions/43_identifiers#4-3-3-2-any-variable-with-fil= e-scope-or-better-shall-be-prefixed-by-an-m-or-g must be followed. [/SAMI] + CONST UINT32 SPM_MAJOR_VER =3D 0; CONST UINT32 SPM_MINOR_VER =3D 1; =20 --=20 2.17.1