From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (EUR03-AM5-obe.outbound.protection.outlook.com [40.107.3.50]) by mx.groups.io with SMTP id smtpd.web10.17210.1614378991154166431 for ; Fri, 26 Feb 2021 14:36:32 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=7nMdgg2+; spf=pass (domain: arm.com, ip: 40.107.3.50, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KPk/JjN33w6DOiZGY7ruiH066a0sLOzaxCOuVYgIXXw=; b=7nMdgg2+t97pEr+7uIVKkAy9Kqcxq+k3HIpLdHBfXsQsWnRiT6TPQRv8yfxaOkDYTY/hZdMNLDtbXgy0clLm2DhQYK4ishGg9pvqA6nmNhCJi1p28MAW3tE3jdoQFltZ9k/MIOr9hbDCNyjSApWIEAUv5f+tlTHhTcaA+uujY/o= Received: from AM6PR02CA0012.eurprd02.prod.outlook.com (2603:10a6:20b:6e::25) by AM6PR08MB5189.eurprd08.prod.outlook.com (2603:10a6:20b:e7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.32; Fri, 26 Feb 2021 22:36:27 +0000 Received: from AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:6e:cafe::c) by AM6PR02CA0012.outlook.office365.com (2603:10a6:20b:6e::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.20 via Frontend Transport; Fri, 26 Feb 2021 22:36:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT007.mail.protection.outlook.com (10.152.16.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.19 via Frontend Transport; Fri, 26 Feb 2021 22:36:26 +0000 Received: ("Tessian outbound 38eaf6505aed:v71"); Fri, 26 Feb 2021 22:36:25 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: ddc99f03434b2bef X-CR-MTA-TID: 64aa7808 Received: from b2e58fc23ebc.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9B3CF8D2-D711-4051-B72C-618F89408BF0.1; Fri, 26 Feb 2021 22:36:19 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b2e58fc23ebc.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 26 Feb 2021 22:36:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GIOi0HMujwgjpPYTpOwWelVdQfAGuHqw4D4Mj9lbv5v6DdutNHOmwEUoGDYcADurYNmc1EY4bWLZWtAnZxKQ6nZ2okwhz5It6ty1zT4fpUuKarcd45qYxq/oVykByhpD99VqfxqrkNnjzUTOAUmR0XLB3qvHXe8u1Wo3priQwFvqgxeufUwQALMVtPe+HvYSrZ9JakI9F3Aj1ISkH9JBsEA/N77ogoOpuIrBhfX3Dyxgg+KDDkjwOPCoJB2j9A+QMSmUN0a9lMpmZHkhqwUWjlAIEJ5SVBaC8BzTpEqFWx0CNYKffQAWJwMwW+Wj8e/yHDLgjQKey90Adwbgto4Cog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KPk/JjN33w6DOiZGY7ruiH066a0sLOzaxCOuVYgIXXw=; b=oHOiYetyE35jtk//vUi/hV7d+ZdF09Ngsg+me8B5OIqWCC2+itgyqCukD/eyukQmekQk/h0P6zYZ409sUq3PCmkL+mhszw4zaGWSS+NlEcoAgReISbV2KjrN0NBUxwMRKQKaFr9YQcFyALwH2DiI9tKhN4HrlG9V6rNibACEmd9Zz2gHnOfIlz3nBgz925XG8CPCqy8KnR9gnoVXrhZuD4KTtyvO+L/BKVLlw6Ae+QlbKSKheXTVXHFs7/D3W+x06N0Xnoe2xD5thkoEP8jyoUjqc+3NAJN0DER53ufRC8kK9mKS4k60hwwj0PUBr877uiyDBH13GrIhgceoHMYszA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KPk/JjN33w6DOiZGY7ruiH066a0sLOzaxCOuVYgIXXw=; b=7nMdgg2+t97pEr+7uIVKkAy9Kqcxq+k3HIpLdHBfXsQsWnRiT6TPQRv8yfxaOkDYTY/hZdMNLDtbXgy0clLm2DhQYK4ishGg9pvqA6nmNhCJi1p28MAW3tE3jdoQFltZ9k/MIOr9hbDCNyjSApWIEAUv5f+tlTHhTcaA+uujY/o= Received: from DB7PR08MB3097.eurprd08.prod.outlook.com (2603:10a6:5:1d::27) by DBBPR08MB5883.eurprd08.prod.outlook.com (2603:10a6:10:206::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.23; Fri, 26 Feb 2021 22:36:17 +0000 Received: from DB7PR08MB3097.eurprd08.prod.outlook.com ([fe80::8c43:eec3:76be:9001]) by DB7PR08MB3097.eurprd08.prod.outlook.com ([fe80::8c43:eec3:76be:9001%4]) with mapi id 15.20.3868.033; Fri, 26 Feb 2021 22:36:16 +0000 From: "Sami Mujawar" To: Ard Biesheuvel , Sughosh Ganu , "Liming Gao (Byosoft address)" CC: "devel@edk2.groups.io" , Ard Biesheuvel , Leif Lindholm , Matteo Carlini , Ben Adderson , nd Subject: Re: [edk2-devel] [PATCH v2 1/1] ArmPkg: Fix uninitialised variable in ArmMmuStandaloneMmLib Thread-Topic: [edk2-devel] [PATCH v2 1/1] ArmPkg: Fix uninitialised variable in ArmMmuStandaloneMmLib Thread-Index: AQHXC5lFda1kwctV3Uajc0rfkhznd6pqRWeAgACCnICAAD+68Q== Date: Fri, 26 Feb 2021 22:36:15 +0000 Message-ID: References: <20210225171110.41324-1-sami.mujawar@arm.com> , In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [86.138.165.102] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 71bbb856-86c5-46c7-9551-08d8daa6f3cd x-ms-traffictypediagnostic: DBBPR08MB5883:|AM6PR08MB5189: x-ms-exchange-minimumurldomainage: github.com#4889 x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:6108;OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 9EaHJ8HHJXCpW9rPKZmpJqM5wQ5Z7rRutY1gnPiI3UTyk+ftsw0cs4+K8rFhdjq4G0Qzp9dHenra7qfB9DipK8ISoiomZXdbbRFSOhiQV030FZod6ntGS/WJWL5dEnSzPg2dcM3iXf9Lad6XzCRX2xpnqJMrVjiWM8I3b7S/TdcXdnm8xCufw/I50oEX5UDUMFXlKFguPh26xFEYXeFDNRg9Yr/SiUW6wWn3tJs/PQ0TFtMBiUmJogBELK738tnr3/IPqsCgbvsI6pyxKVk9p1tjGqnfuj8MFkWIZIdZIQXKb91RVNMGqsx6BfeAWNLeiIT6xQ18Q7ifd/wUreYPegIjWIRvhB4DCDsf/SQfPytg9ZL5/Wc/Lm5LyhjdIdFoY4RgiLpgzxxJXiwxx94tS7GhcEPU8F9uM33LwBBjcGj+C/SbWTVrMi3+jk4b6QkNVoOJkeyGSdQxEtTUh7r+8VR3isfiqAkOslxqrQIxH1nu/PZUCsImBUbqMkieBqbSSsFYHikGyavnxw1mcIeWQV7CiIru0LPPvLpWe0D037paeIjEtkASfycmsqaadaoEz2D5sR7Le18ohDMLQNe6N8sBRd0ilC4wuPXhPStxB+E= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3097.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(366004)(39860400002)(396003)(136003)(376002)(346002)(966005)(8676002)(71200400001)(4326008)(9686003)(6506007)(53546011)(316002)(478600001)(8936002)(26005)(5660300002)(91956017)(110136005)(66556008)(64756008)(76116006)(7696005)(54906003)(52536014)(2906002)(86362001)(33656002)(55016002)(186003)(166002)(83380400001)(66446008)(66946007)(66476007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?vkxyGyAxLDZfWzaI4wSX9Tt90jkEtl16UnoOJBHWB6k7W+5lb0OebKnWAPGt?= =?us-ascii?Q?Zw6SW1cG1jBW/Z6QD0Wq84+qFc/pR0j/m2Q1/J6VfLkUvTXSuNR/68xgviZ0?= =?us-ascii?Q?KFGkwEaQYEyCOFoapTBSXQHnHuujcxLC9A7UCiJBD+jXcB1A86XU1eMdDBsF?= =?us-ascii?Q?N4lI6bj5T9cfTDFTG2PdIemYRd59QvSViIlF/mDPVEbclIqmy+srBD3U5+Lf?= =?us-ascii?Q?qHFUmqtvUPYW7jQL61IDhnzn1BjGbKQuY5FI4wlB5zRK1SxQZBUoUz2j3Yky?= =?us-ascii?Q?NU+Aexz29vQ+hwrZ4Isaitv2ynrNbex2abv5Bn2l0IIMb2MYgcChA8XxjSRB?= =?us-ascii?Q?HsEMYWRY+PXTEgRT9B4m8AOAoHCzINJnbrYYzX3N9lppnu67G7NT733Ejmtm?= =?us-ascii?Q?fdNlystkiEqY/MjK+aqIHDyZSA6NHmu3bX/gTwoEEvaSL0u7DAC1Hdn5WaD5?= =?us-ascii?Q?XkuM/Z4NbKlRSJ1yPgGBEVztWe7vP3AncegB+HeTEoueBVBXh61WcYL8FI1S?= =?us-ascii?Q?CkYxlhJVLMUEMGj2QceALmpOro5/epnR6Kn+EJnNy4uo680fpOA/U6nHS60j?= =?us-ascii?Q?QnI2iEpbJ18ic4qnt17QYsC1iEedOOZE4cPz7n+aLVAtFoggOvmXKV/aqATP?= =?us-ascii?Q?N3wAAJXA6Smbe4Sa7QmloU3yw5euqhyyGCj271yn8mpCm4VlfhK+yFszwyPJ?= =?us-ascii?Q?pKDUIEQAjSJrv2iu6Mobzt+Z74v5A7TYXRmDedoY7vET2GD+vt7D7Y/72xXt?= =?us-ascii?Q?bWk1Nxl1Ci9g2QF5187GJuNQ5qyzvD+ykiUH6qQMvuXIaYeqsk1dSnBOhVRk?= =?us-ascii?Q?lH4GQhUNLblPosMCANi9hQA9HYqVlH2Tx4I7czbKj/z4DVdap8YaZTluA3qT?= =?us-ascii?Q?VNnpPivdsGvB2Ws0DXnRDv+Bd3N75Z8RIJk+Ek9ay3nT2cH+g1+29/8nfhHV?= =?us-ascii?Q?nmUfFtEzr3YrXVov++qBhyBQifTJQ6HPjcTc5y6ZhoWDRmySOatJAAP91lEM?= =?us-ascii?Q?AiF/ik4y5XcsHgylSWOkG32d1WlenFk4UpVmmEEZuk4q1fx3xd8yyUePOqqq?= =?us-ascii?Q?N7nwgt+zOTJSn4CQ8Hnc7rDF/jNaG1bIGqaQYuebtmc6CGPOvzaK9fwVXbBJ?= =?us-ascii?Q?pu18gN9EcBMtrgE9yhhSe/Z3QG42+1Us7viwdR040+yX5q6s49hurNiLtsxV?= =?us-ascii?Q?ALiNvjF20SZLMkl/CZxANzI/CkeMfFrKG6reoo3LfYghG7BhA0wBv9wnrMrH?= =?us-ascii?Q?pglS12DRxXLzjQokk5+RnQYpJDb9LpODQ0W9Xg5JR/V5f5o47q3u69bx/Vgp?= =?us-ascii?Q?FWVXn03fzK+V4ya2sLAKnQZQ8k6kW3C8vB+dckltrcbIsA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5883 Original-Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 289c8c59-2943-4fdc-2995-08d8daa6ee45 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u9+MyqUiEbe4N4qIEcsepG1N3vHCaI1000/4CzRlUJj25BPVyHUijaYV1B3kXMjEWa/+EGoMqZk5zIQjXWUoF20aCopf6TqyzgnpYoX1uc6U4JRdxoDZ5ht8rh2mUBfnw83/h4teHaToj14prrc9LMisYz2/faBa3IrzN496g54qWttZJe/OJgfmLxjbUXzAp5OSP9imK2es6hReTKE/zsJyqPRNtn35oUtnSLrTIRDbvK6CmCG0srj0g56JDxL4BP+bnQ+qp+rG3S2IG7Hf5NAr0vsSKU0y06uWEbL1xCzq7N1GcJyz2GFfseo6QTaOAKHP8Gq8eMDul1CVxNB6oic1gfVtOpjrY3wv3h6ZckYYVjHLDqCWjgXlVyC1LLhS/ghsDhfCMO6dxZEbOcoFUmDt43RqIA3ZZJLishQtcRLLjlopmfhJZNVS0eaRXwVcC4fSHMQ8rUWt4qs1FD8hFL0AF1y1AEcb6LkEzaiGYH8SulBoxHJcfwreCN6KMM6a0Y5+D06e9QZzkf+ilyeSLTPsDQTtuQswm2Gg4SprB4K7sM+Lv5fbBgmnZTd3CuId+afXzeZ/cEP2jdpVGPhvLTiicXwdbUBRJo7+10uGyQJFBtnTIJKpmMO0F+RQNfoRTXnIQlbMt2GjvkBjB41oWJNKGRCBzDcDLovDxeZqV2wKZ//sI77/GjNO5TKZvNxTGRrWEyOmJ1pRi5Se19n8bUHGWaWA8EOORSyi5eDZwG4= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(6029001)(4636009)(39860400002)(136003)(346002)(396003)(376002)(46966006)(36840700001)(186003)(26005)(8676002)(54906003)(2906002)(86362001)(82310400003)(83380400001)(6506007)(47076005)(4326008)(8936002)(356005)(33656002)(316002)(336012)(166002)(81166007)(53546011)(52536014)(5660300002)(478600001)(82740400003)(9686003)(7696005)(70206006)(966005)(36860700001)(70586007)(55016002)(110136005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2021 22:36:26.1979 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 71bbb856-86c5-46c7-9551-08d8daa6f3cd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5189 Content-Language: en-GB Content-Type: multipart/alternative; boundary="_000_DB7PR08MB3097D095A7F111ED45212932849D9DB7PR08MB3097eurp_" --_000_DB7PR08MB3097D095A7F111ED45212932849D9DB7PR08MB3097eurp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ard, Yes. This patch with fix the build failure reported by the CI. Regards, Sami Mujawar ________________________________ From: Ard Biesheuvel Sent: Friday, 26 February 2021, 6:46 pm To: Sughosh Ganu; Liming Gao (Byosoft address) Cc: devel@edk2.groups.io; Sami Mujawar; Ard Biesheuvel; Leif Lindholm; Matt= eo Carlini; Ben Adderson; nd Subject: Re: [edk2-devel] [PATCH v2 1/1] ArmPkg: Fix uninitialised variable= in ArmMmuStandaloneMmLib On Fri, 26 Feb 2021 at 11:58, Sughosh Ganu wrote: > > > On Thu, 25 Feb 2021 at 22:41, Sami Mujawar wrote: >> >> The following patches added support for StandaloneMM using FF-A: >> 9da5ee116a28 ArmPkg: Allow FF-A calls to set memory region's attributes >> 0e43e02b9bd8 ArmPkg: Allow FF-A calls to get memory region's attributes >> >> However, in the error handling logic for the Get/Set Memory attributes, >> the CLANG compiler reports that a status variable could be used without >> initialisation. This issue is a false positive and is not seen with GCC. >> >> The Get/Set Memory attributes operation is atomic and therefore an >> FFA_INTERRUPT or FFA_SUCCESS response is not expected in response >> to FFA_MSG_SEND_DIRECT_REQ. So the remaining cases that could occur >> are: >> - the target sends FFA_MSG_SEND_DIRECT_RESP with a success or >> failure code. >> or >> - FFA_MSG_SEND_DIRECT_REQ transmission failure. >> >> Therefore, >> - reorder the error handling conditions such that it prevents the >> uninitialised variable issue being flagged by CLANG. >> - move the repetitive code to a static helper function and add >> documentation at the appropriate places. >> - fix error handling in functions that invoke GetMemoryPermissions(). >> >> Signed-off-by: Sami Mujawar >> --- >> The changes can be seen at: >> https://github.com/samimujawar/edk2/tree/1657_stmm_ffa_fix_unused_var_v2 > > > Tested the changes on the StandaloneMm image on the Qemu platform. > > Tested-by: Sughosh Ganu > Reviewed-by: Sughosh Ganu > Thanks. Sami, can you confirm that this patch fixes the CI failure I reported to you in private? If so, I intend to merge this during the freeze (assuming Liming is ok with that) --_000_DB7PR08MB3097D095A7F111ED45212932849D9DB7PR08MB3097eurp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Hi Ard,

Yes. This patch with fix the build failure reported by the CI.

Regards,

Sami Mujawar

From: Ard Biesheuvel <ardb@ke= rnel.org>
Sent: Friday, 26 February 2021, 6:46 pm
To: Sughosh Ganu; Liming Gao (Byosoft address)
Cc: devel@edk2.groups.io; Sami Mujawar; Ard Biesheuvel; Le= if Lindholm; Matteo Carlini; Ben Adderson; nd
Subject: Re: [edk2-devel] [PATCH v2 1/1] ArmPkg: Fix unini= tialised variable in ArmMmuStandaloneMmLib

On Fri, 26 Feb 2021 at 11:58, Sughosh Ganu <sug= hosh.ganu@linaro.org> wrote:
>
>
> On Thu, 25 Feb 2021 at 22:41, Sami Mujawar <sami.mujawar@arm.com>= ; wrote:
>>
>> The following patches added support for StandaloneMM using FF-A: >> 9da5ee116a28 ArmPkg: Allow FF-A calls to set memory region's attri= butes
>> 0e43e02b9bd8 ArmPkg: Allow FF-A calls to get memory region's attri= butes
>>
>> However, in the error handling logic for the Get/Set Memory attrib= utes,
>> the CLANG compiler reports that a status variable could be used wi= thout
>> initialisation. This issue is a false positive and is not seen wit= h GCC.
>>
>> The Get/Set Memory attributes operation is atomic and therefore an=
>> FFA_INTERRUPT or FFA_SUCCESS response is not expected in response<= br> >> to FFA_MSG_SEND_DIRECT_REQ. So the remaining cases that could occu= r
>> are:
>>  - the target sends FFA_MSG_SEND_DIRECT_RESP with a success o= r
>>    failure code.
>>  or
>>  - FFA_MSG_SEND_DIRECT_REQ transmission failure.
>>
>> Therefore,
>>  - reorder the error handling conditions such that it prevent= s the
>>    uninitialised variable issue being flagged by CL= ANG.
>>  - move the repetitive code to a static helper function and a= dd
>>    documentation at the appropriate places.
>>  - fix error handling in functions that invoke GetMemoryPermi= ssions().
>>
>> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
>> ---
>> The changes can be seen at:
>> https://github.com/samimujawar/edk2/tree/1657_stmm_ffa_fix_unused_var_v2
>
>
>  Tested the changes on the StandaloneMm image on the Qemu platfor= m.
>
> Tested-by: Sughosh Ganu <sughosh.ganu@linaro.org>
> Reviewed-by: Sughosh Ganu <sughosh.ganu@linaro.org>
>

Thanks. Sami, can you confirm that this patch fixes the CI failure I
reported to you in private? If so, I intend to merge this during the
freeze (assuming Liming is ok with that)

--_000_DB7PR08MB3097D095A7F111ED45212932849D9DB7PR08MB3097eurp_--