From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.59]) by mx.groups.io with SMTP id smtpd.web12.1841.1589908788657666776 for ; Tue, 19 May 2020 10:19:49 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=hxtlmXmS; spf=pass (domain: arm.com, ip: 40.107.22.59, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VuY/6g6Uam7yUXnalCrKI7j5oppupS2FSMeRPOS7rxA=; b=hxtlmXmSFdwRP/hdP0H4KrbwjqW5q63tny2sOgUNkFnUFHiKhKNZ8jbIoRnZGtgjuT+nWDVkUMyt2aWeY/evYMzbX7ambGUc9h5uF+R2ylfQOVrniK9nq29tcKNSGAIE2/437VwB8th6llIYhpz6VqQIl0gOcnhozCYMluzpthk= Received: from AM0PR01CA0107.eurprd01.prod.exchangelabs.com (2603:10a6:208:10e::48) by HE1PR0802MB2187.eurprd08.prod.outlook.com (2603:10a6:3:c5::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.27; Tue, 19 May 2020 17:19:45 +0000 Received: from AM5EUR03FT035.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:10e:cafe::ba) by AM0PR01CA0107.outlook.office365.com (2603:10a6:208:10e::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.25 via Frontend Transport; Tue, 19 May 2020 17:19:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT035.mail.protection.outlook.com (10.152.16.119) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.19 via Frontend Transport; Tue, 19 May 2020 17:19:44 +0000 Received: ("Tessian outbound 9eabd37e4fee:v57"); Tue, 19 May 2020 17:19:44 +0000 X-CR-MTA-TID: 64aa7808 Received: from 43520cb5aa85.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 97F7584F-3EAC-4D29-8608-CF824045D08C.1; Tue, 19 May 2020 17:19:39 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 43520cb5aa85.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 19 May 2020 17:19:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fhFpyZY1063BVn8Lj4bIPC2chZ+eg357TT5cX9eJ17WiMRD0uBmw+ORJfKHwvwtsHS5DzLYnEAIZMS44cz7Iu0DREVLg7x6Jhd7KLS0IVdRKFX34FvcCJCGEYUxGpyWPRdDy5MZMNR9EFKGrWirp9kLuBWuU3GRKxVHASAaSDyyJWCTVn215vTQrIgCi2DObNMOJPfEC20yAbc9+iqVZhCjyB5s3i8st/Ins4BniO8YOn+G5e4XBHmVcQuqEpv5dsU9qI64P7f/BQysUFAn5Vn2XQ0w8JDJSgVy/dAmSTzSOl2/5w/katPZZ0q9WfE4BmwJm9odKRiWBC5edhVgU3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VuY/6g6Uam7yUXnalCrKI7j5oppupS2FSMeRPOS7rxA=; b=EU3SEo/JvJbK4vBU6E2u/2iR5zKWbD1wdzO0mAkBZjyhhmysAZeq18KIw//lzRDHxI0s3/YvKpGOwbLQ8uPsjZ/k4LZm2tevBpTDIa6I12SHE9SSUNqY4j14UrYUOm7EQiKB94TP4vU2L/a5dyiVxptQYhwPwa7t/VRYsY8PZSZ0XtSEVkSxQpTHj3ZWHXAFBNPWUTApaM+066qpNZhwt2Y5FXRtmZh/648EpSB/pOeBg9rZjhlemY52hfoVUDgf7kBtmD7f0cCxy3aKwGV6WmaU767CosjTH0tm2yF5e+dLlLDbqp3wpIJLN8BsyNE43Ni7MCot/eES/of93Qx0XA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VuY/6g6Uam7yUXnalCrKI7j5oppupS2FSMeRPOS7rxA=; b=hxtlmXmSFdwRP/hdP0H4KrbwjqW5q63tny2sOgUNkFnUFHiKhKNZ8jbIoRnZGtgjuT+nWDVkUMyt2aWeY/evYMzbX7ambGUc9h5uF+R2ylfQOVrniK9nq29tcKNSGAIE2/437VwB8th6llIYhpz6VqQIl0gOcnhozCYMluzpthk= Received: from DB7PR08MB3097.eurprd08.prod.outlook.com (2603:10a6:5:1d::27) by DB7PR08MB3641.eurprd08.prod.outlook.com (2603:10a6:10:4e::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.27; Tue, 19 May 2020 17:19:37 +0000 Received: from DB7PR08MB3097.eurprd08.prod.outlook.com ([fe80::587:15d3:8425:65f9]) by DB7PR08MB3097.eurprd08.prod.outlook.com ([fe80::587:15d3:8425:65f9%6]) with mapi id 15.20.3000.034; Tue, 19 May 2020 17:19:37 +0000 From: "Sami Mujawar" To: "Gao, Liming" , "devel@edk2.groups.io" , "Feng, Bob C" CC: Bret Barkelew , "leif@nuviainc.com" , Matteo Carlini , Laura Moretta , nd Subject: Re: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] BaseTools: Remove deprecated Visual Studio Option Thread-Topic: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] BaseTools: Remove deprecated Visual Studio Option Thread-Index: AQHWCeKLPlR/avJWh0uicRQ3W9dRc6huONyAgD/O4cCAACi3gIABsf2A Date: Tue, 19 May 2020 17:19:36 +0000 Message-ID: References: <20200403180547.26432-1-sami.mujawar@arm.com> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-04-07T21:48:41.6769053Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged x-ts-tracking-id: 6238be52-07a9-4a3b-9219-3e750f3c267e.0 x-checkrecipientchecked: true Authentication-Results-Original: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [2a00:23c6:548a:4800:25d4:ae52:bc8b:5b5f] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: d82da5f0-342d-4449-a472-08d7fc18d33a x-ms-traffictypediagnostic: DB7PR08MB3641:|HE1PR0802MB2187: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273; x-forefront-prvs: 040866B734 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ycF3JqRl35UVSx8BmGmpCQ6p8oP+rwVE4smW2RtaGzIuN8B7UJM3jy4aRkmwNz1rasx2Ex1uKuza4rC5FpbrXITysA0K4uuYAap8bdZivlGqRUGwx4lrPgyHR5fhwBwHhMG3T+MNleUXqKEol+7kJaIsv/cQUJaINQkKwb5Ps29zsdZJh3hVXmWzSkxQMxVM6qxhNuEKCjCUWY0NE57PcZQaEwtU1pfEKkRsPRYMERvOiXwt2erROurI0TuhMVEjJKK2vniOo2t39SPNBsQjdmFqAR47Bhxsbxrj9aK73GsU5Rdcs26Q3ywgqKTBgUZdDzpqUiVJVoEOBtRsbe2BjnpN9c2kFfzI+YenG2BtYezZqYDbHQv4b94p5Arucd7vF2OND2EercztnZJ9S8qZ+SGWlhiWx/7DF3w5b/eM0EttXeRdClQ2BKO6Vx6s2nKYo5Nak82THbH41zI5yc7WG8AtA384KuC9t/dmDG8EhWcDOSWjMvlg99hKy487on6xpYkjBNguxkxHvDqZA1jawE3B2OaOhrl4vg81xo5Ka+U6W8x2wlXYtTeVt4zlvnCboxFoNIrrl1CcVf1tSFtbzmJMKiRU0swMGDO5pcL8DxI= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3097.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(366004)(346002)(136003)(376002)(396003)(39850400004)(166002)(186003)(8936002)(2906002)(9326002)(33656002)(60390400001)(7696005)(110136005)(45080400002)(6506007)(53546011)(71200400001)(478600001)(5660300002)(30864003)(66946007)(54906003)(66556008)(66476007)(64756008)(66446008)(4326008)(316002)(86362001)(76116006)(52536014)(8676002)(9686003)(55016002)(966005)(545624004)(460985005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: xJUtaeRnmoiPMWcSRtQiNjp3KFilcqXqCIe8aIRbs3cnLGE3CF71Sw6Og4FNuVrlbj4y4iWb7FsnuD6FyHgntqlfzxIra6T1FvEic4m4rNcwuqLwXV94Pq1rUZRKcCKY9du7Tr9MAywtdJJUDeV2qxSuvBGbA2NTtACKnRUQTN1ZLvSUKSQV9rJzLUS+VcE03IGxUopQA6iXXdbWDXT/xjFrLUC0+8HmlpOprXbtjgDsLLHBHxdRwF0Fcs7egqdPWA2BQb0BPceOLUrIRGhCJiFZ+FVC2Sn6rO3yf4TGugwZkEKd7WbK2JJ6hl+FA6QA9lwr6jWzEySWiA4joLqQrjCBk4aUKBfI19YfL7EzkxCOvH6xtVotWGMe3ppyYHn2sHVj2MWJWR4Z93MKYsOG3i9bIzF4BbwGyufAT2MjYpIwSWRaPyiZ9GbscHvck/sNV+qMLG+Etrafb5MnKup/YUacN1ZT/mhfnEehDNxrGoU2evi2aZ9zw43BnVm3MwgeOec2eFlGEUmHVd9x+LgheoIfFupvx6uKDA4geSzHH1Xf4AqNIAlgEQ06kL/I/OIq MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3641 Original-Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT035.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFTY:;SFS:(4636009)(136003)(396003)(39850400004)(346002)(376002)(46966005)(6506007)(53546011)(336012)(4326008)(186003)(54906003)(8936002)(166002)(110136005)(7696005)(356005)(60390400001)(70206006)(81166007)(36906005)(55016002)(8676002)(316002)(70586007)(9326002)(5660300002)(82310400002)(26005)(2906002)(52536014)(33656002)(478600001)(9686003)(86362001)(966005)(82740400003)(47076004)(30864003)(45080400002)(545624004)(460985005);DIR:OUT;SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: d8e60459-38ae-4a93-7d03-08d7fc18ce9d X-Forefront-PRVS: 040866B734 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JW1tMnVDV44G7Cney1RTe8VWWsJB8iIMlly2I3vN/XX4fur0f/wbT6S5/pyv4WNayztMCEyrwgUBLMFOH/HkK/RoDMo/BKtxOQph7ek1STwRS1h4Ih/Bl+aQeoYg0TGe+2O/wPlKHhV6m1iYk0g4tXqy7AY5qa5bKTWlMazB6XdmE/1q/4+Ml77wTmlZt7CP+ojaCQk5+eWn95jo9DWTmcDZSGxcELAsZqs33im06VMhxq1FxEWrO6ywUblD2wN2jkc1FY9zrMIe4oSOgK3rm9L4NpK20NtTkBX3kIntcAPVF3PBu8aQv55v6XjKZ1laFkBUbU6RaQ42oCrSxlLz4onugHRP/mZWsB1dk6JBT+POKn7t3hkiHaR7Px65Ts+cE3B9jH9QRpOkcetLJLudYDw9kLpG198tsRCD7D7M+EdWcnrfiaTWqlp/SOBVz1MXt8haKMUnvwP/oSDWHQJGdxD4G95X3FhLd9Uq+XdMH8WeO7ORQ9YHNm+uhbGFgi8SaaC62SVdqln7MfmvwzSoqjRBmdZSPNv0l+L8NkVHsTFyPKkYrHrmWLZRzX/lGpbH1ZqrzfV44J4C4WP2dJCgSmZHzHyocdlvhNwZk2JnLbxc+R8B8VUN0ziY6zpPt6lTRfMlsDkxpor1M5hH9bbbsQ== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2020 17:19:44.8635 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d82da5f0-342d-4449-a472-08d7fc18d33a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2187 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_DB7PR08MB3097D3BA6CFBE0E2C98B905A84B90DB7PR08MB3097eurp_" --_000_DB7PR08MB3097D3BA6CFBE0E2C98B905A84B90DB7PR08MB3097eurp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Liming, I did a GitHub Pull Request to verify the change and it passed all checks.= The patch also passes the checks done by BaseTools\Scripts\PatchCheck.py. Ideally, we would like to have this patch merged in edk2 stable tag 202005= . Regards, Sami Mujawar From: Gao, Liming Sent: 18 May 2020 03:39 PM To: Sami Mujawar ; devel@edk2.groups.io; Feng, Bob C= Cc: Bret Barkelew ; leif@nuviainc.com; Matteo= Carlini ; Laura Moretta ; n= d Subject: RE: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] BaseTools: Remove depr= ecated Visual Studio Option Sami: Sorry. I miss this patch. The change is good to me. Please create PR req= uest to verify the change. Seemly, the commit message it too long. Do you v= erify it by BaseTools\Scripts\PatchCheck.py? If the commit message passes RP, you can add my Reviewed-by: Liming Gao = > Last, do you request to catch this change into edk2 stable tag 202005? Thanks Liming From: Sami Mujawar > Sent: Monday, May 18, 2020 8:27 PM To: devel@edk2.groups.io; Feng, Bob C >; Gao, Liming > Cc: Bret Barkelew >; leif@nuviainc.com; Matteo Carlini >; Laura Moretta >; nd > Subject: RE: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] BaseTools: Remove depr= ecated Visual Studio Option Hi Bob, Liming, Is there anything else needed before this patch can be merged? Regards, Sami Mujawar From: Bret Barkelew > Sent: 07 April 2020 10:49 PM To: devel@edk2.groups.io; Sami Mujawar > Cc: Sami Mujawar >; bob.= c.feng@intel.com; liming.gao@intel.com; leif@nuviainc.com; Matteo = Carlini >; Laura More= tta >; nd > Subject: RE: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] BaseTools: Remove depr= ecated Visual Studio Option Reviewed-by: Bret Barkelew > - Bret ________________________________ From: devel@edk2.groups.io > on behalf of Sami Mujawar via groups.io <= sami.mujawar=3Darm.com@groups.io> Sent: Friday, April 3, 2020 11:05:47 AM To: devel@edk2.groups.io > Cc: Sami Mujawar >; bob.= c.feng@intel.com >; liming.gao@intel.com <= liming.gao@intel.com>; leif@nuviainc.com >; Matteo.= Carlini@arm.com >; Laura.Moretta@arm.com >; nd@arm.com > Subject: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] BaseTools: Remove deprecat= ed Visual Studio Option The VS2017 compiler reports 'warning D9035 : option 'Gm' has been deprecated and will be removed in a future release' The documentation for the 'Gm' option at https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fdocs.m= icrosoft.com%2Fen-us%2Fcpp%2Fbuild%2Freference%2Fgm-enable-minimal-rebuild%= 3Fview%3Dvs-2019&data=3D02%7C01%7CBret.Barkelew%40microsoft.com%7C4a458= 8c4ee79488a3e5e08d7d7f9afc9%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C63= 7215339711617971&sdata=3DUl9UkaXpfC1o5SNP3FwuHGjkldZjh879tM2nsHqKzRU%3D= &reserved=3D0 indicates that this option can be safely removed from the project. Therefore, remove the deprecated 'Gm' Visual Studio Compiler option. Ref: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fb= ugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2660&data=3D02%7C01%7CBret.= Barkelew%40microsoft.com%7C4a4588c4ee79488a3e5e08d7d7f9afc9%7C72f988bf86f14= 1af91ab2d7cd011db47%7C1%7C0%7C637215339711617971&sdata=3DRi2yVGQs2JcNvZ= U0bMZ6FhZEWhkN8Jj6oR14%2F3oXYow%3D&reserved=3D0 Signed-off-by: Sami Mujawar > --- The changes can be seen at: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub= .com%2Fsamimujawar%2Fedk2%2Ftree%2F703_vs2017_deprecated_option_v1&data= = =3D02%7C01%7CBret.Barkelew%40microsoft.com%7C4a4588c4ee79488a3e5e08d7d7f9a= fc9%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637215339711617971&sda= ta=3DV%2B9F3QrpY3tX%2B%2BChPK02wOZC0XizIRJI74LLqr9Lw54%3D&reserved=3D0 Notes: V1: - Remove deprecated VS2017 and VS2019 option [SAMI] BaseTools/Conf/tools_def.template | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.= template index 2b17d3b2979a83144444b4d543b383af3198cdd0..67368f5013519a2d7397cbc975= 6acb6ff152727a 100755 --- a/BaseTools/Conf/tools_def.template +++ b/BaseTools/Conf/tools_def.template @@ -1,7 +1,7 @@ # # Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
# Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved. -# Portions copyright (c) 2011 - 2014, ARM Ltd. All rights reserved.
+# Portions copyright (c) 2011 - 2019, ARM Ltd. All rights reserved.
# Copyright (c) 2015, Hewlett-Packard Development Company, L.P.
# (C) Copyright 2016 Hewlett Packard Enterprise Development LP
# Copyright (c) Microsoft Corporation @@ -1682,9 +1682,9 @@ NOOPT_VS2017_X64_DLINK_FLAGS =3D /NOLOGO /NODEFAU= LTLIB /IGNORE:4001 /IGNORE:428 *_VS2017_ARM_ASLDLINK_PATH =3D DEF(VS2017_BIN_ARM)\link.exe *_VS2017_ARM_MAKE_FLAGS =3D /nologo - DEBUG_VS2017_ARM_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /D= UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Gm /Gw /Oi- + DEBUG_VS2017_ARM_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /D= UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Gw /Oi- RELEASE_VS2017_ARM_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /D= UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gw /Oi- -NOOPT_VS2017_ARM_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /D= UNICODE /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Gm /Od /Oi- +NOOPT_VS2017_ARM_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /D= UNICODE /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Od /Oi- DEBUG_VS2017_ARM_ASM_FLAGS =3D /nologo /g RELEASE_VS2017_ARM_ASM_FLAGS =3D /nologo @@ -1709,9 +1709,9 @@ NOOPT_VS2017_ARM_DLINK_FLAGS =3D /NOLOGO /NODEF= AULTLIB /IGNORE:4001 /OPT:REF *_VS2017_AARCH64_ASLDLINK_PATH =3D DEF(VS2017_BIN_AARCH64)\link.exe *_VS2017_AARCH64_MAKE_FLAGS =3D /nologo - DEBUG_VS2017_AARCH64_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /= D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Gm /Gw /Oi- + DEBUG_VS2017_AARCH64_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /= D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Gw /Oi- RELEASE_VS2017_AARCH64_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /= D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gw /Oi- -NOOPT_VS2017_AARCH64_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /= D UNICODE /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Gm /Od /Oi- +NOOPT_VS2017_AARCH64_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /= D UNICODE /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Od /Oi- DEBUG_VS2017_AARCH64_ASM_FLAGS =3D /nologo /g RELEASE_VS2017_AARCH64_ASM_FLAGS =3D /nologo @@ -1845,9 +1845,9 @@ NOOPT_VS2019_X64_DLINK_FLAGS =3D /NOLOGO /NODEFAU= LTLIB /IGNORE:4001 /IGNORE:428 *_VS2019_ARM_ASLDLINK_PATH =3D DEF(VS2019_BIN_ARM)\link.exe *_VS2019_ARM_MAKE_FLAGS =3D /nologo - DEBUG_VS2019_ARM_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /D= UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Gm /Gw /Oi- + DEBUG_VS2019_ARM_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /D= UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Gw /Oi- RELEASE_VS2019_ARM_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /D= UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gw /Oi- -NOOPT_VS2019_ARM_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /D= UNICODE /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Gm /Od /Oi- +NOOPT_VS2019_ARM_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /D= UNICODE /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Od /Oi- DEBUG_VS2019_ARM_ASM_FLAGS =3D /nologo /g RELEASE_VS2019_ARM_ASM_FLAGS =3D /nologo @@ -1872,9 +1872,9 @@ NOOPT_VS2019_ARM_DLINK_FLAGS =3D /NOLOGO /NODEF= AULTLIB /IGNORE:4001 /OPT:REF *_VS2019_AARCH64_ASLDLINK_PATH =3D DEF(VS2019_BIN_AARCH64)\link.exe *_VS2019_AARCH64_MAKE_FLAGS =3D /nologo - DEBUG_VS2019_AARCH64_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /= D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Gm /Gw /Oi- + DEBUG_VS2019_AARCH64_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /= D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Gw /Oi- RELEASE_VS2019_AARCH64_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /= D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gw /Oi- -NOOPT_VS2019_AARCH64_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /= D UNICODE /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Gm /Od /Oi- +NOOPT_VS2019_AARCH64_CC_FLAGS =3D /nologo /c /WX /GS- /W4 /Gs32768 /= D UNICODE /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /Od /Oi- DEBUG_VS2019_AARCH64_ASM_FLAGS =3D /nologo /g RELEASE_VS2019_AARCH64_ASM_FLAGS =3D /nologo -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' --_000_DB7PR08MB3097D3BA6CFBE0E2C98B905A84B90DB7PR08MB3097eurp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi Limin= g,

&nb= sp;

I did a = GitHub Pull Request to verify the change and it passed all checks. The patc= h also passes the checks done by BaseTools\Scripts\PatchCheck.py.

&nb= sp;

Ideally,= we would like to have this patch merged in edk2 stable tag 202005.

 

Regards,

 

Sami Mujawar

&nb= sp;

From: Gao, Liming <liming.gao@intel.com>
Sent: 18 May 2020 03:39 PM
To: Sami Mujawar <Sami.Mujawar@arm.com>; devel@edk2.groups.io= ; Feng, Bob C <bob.c.feng@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>; leif@nuviain= c.com; Matteo Carlini <Matteo.Carlini@arm.com>; Laura Moretta <Lau= ra.Moretta@arm.com>; nd <nd@arm.com>
Subject: RE: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] BaseTools: Remo= ve deprecated Visual Studio Option

 

Sami:

  Sorry. I miss this patc= h. The change is good to me. Please create PR request to verify the change.= Seemly, the commit message it too long. Do you verify it by BaseTools\Scri= pts\PatchCheck.py?

 

  If the commit mess= age passes RP, you can add my Reviewed-by: Liming Gao <liming.gao@intel.com>

 

  Last, do you request to= catch this change into edk2 stable tag 202005?

 

Thanks

Liming

From: Sami Mujawar <Sami.= Mujawar@arm.com>
Sent: Monday, May 18, 2020 8:27 PM
To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel= .com>; Gao, Liming <limin= g.gao@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>; leif@nuviainc.com; Matteo Carlini= <Matteo.Carlini@arm.com&g= t;; Laura Moretta <Laura.Morett= a@arm.com>; nd <nd@arm.com><= br> Subject: RE: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] BaseTools: Remo= ve deprecated Visual Studio Option

 

Hi Bob, = Liming,

&nb= sp;

Is there= anything else needed before this patch can be merged?

&nb= sp;

Regards,=

&nb= sp;

Sami Muj= awar

&nb= sp;

From: Bret Barkelew <Bret.Barkelew@microsoft.com>
Sent: 07 April 2020 10:49 PM
To: devel@edk2.groups.io; Sami Mujawar <Sami.Mujawar@ar= m.com>
Cc: Sami Mujawar <Sami.M= ujawar@arm.com>; bob.c.feng@intel.com; liming.gao@intel.com; leif@nuviai= nc.com; Matteo Carlini <Ma= tteo.Carlini@arm.com>; Laura Moretta <Laura.Moretta@arm.com>; nd <nd@arm.com>
Subject: RE: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] BaseTools: Remo= ve deprecated Visual Studio Option

 

Reviewed-by: Bret Barkelew <= ;bret.barkelew@microsoft.com= >

 

- Bret

 

From:= devel@edk2.groups.io <devel@edk2.groups.io> on behalf o= f Sami Mujawar via groups.io <sami.mujawar=3Darm.com@groups.io>
Sent: Friday, April 3, 2020 11:05:47 AM
To: devel@edk2.groups.io <devel@edk2.groups.io><= br> Cc: Sami Mujawar <sami.m= ujawar@arm.com>; bob.c.feng@intel.com <bob.c.feng@intel.com>; liming.gao@intel.com <liming.gao@intel.com>; leif@nuviainc.com <leif@nuviainc.com>; Matteo.Carlini@arm.com <<= a href=3D"mailto:Matteo.Carlini@arm.com">Matteo.Carlini@arm.com>; Laura.Moretta@arm.com <Laura.Moretta@arm.com>; nd@arm.com <nd@arm.com>
Subject: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] BaseTools: Remove d= eprecated Visual Studio Option

 

The VS2017 compiler reports 'warning D9035 : option
'Gm' has been deprecated and will be removed in a
future release'

The documentation for the 'Gm' option at
https://nam06.safelinks.protectio= n.outlook.com/?url=3Dhttps%3A%2F%2Fdocs.microsoft.com%2Fen-us%2Fcpp%2Fbuild= %2Freference%2Fgm-enable-minimal-rebuild%3Fview%3Dvs-2019&amp;data=3D02= %7C01%7CBret.Barkelew%40microsoft.com%7C4a4588c4ee79488a3e5e08d7d7f9afc9%7C= 72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637215339711617971&amp;sdata= = =3DUl9UkaXpfC1o5SNP3FwuHGjkldZjh879tM2nsHqKzRU%3D&amp;reserved=3D0=
indicates that this option can be safely removed
from the project.

Therefore, remove the deprecated 'Gm' Visual Studio
Compiler option.

Ref: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugzil= la.tianocore.org%2Fshow_bug.cgi%3Fid%3D2660&amp;data=3D02%7C01%7CBret.B= arkelew%40microsoft.com%7C4a4588c4ee79488a3e5e08d7d7f9afc9%7C72f988bf86f141= af91ab2d7cd011db47%7C1%7C0%7C637215339711617971&amp;sdata=3DRi2yVGQs2Jc= NvZU0bMZ6FhZEWhkN8Jj6oR14%2F3oXYow%3D&amp;reserved=3D0

Signed-off-by: Sami Mujawar <sa= mi.mujawar@arm.com>
---

The changes can be seen at:
https://nam06.safelinks.protection.outlook.com/?url= =3Dhttps%3A%2F%2Fgithub.com%2Fsamimujawar%2Fedk2%2Ftree%2F703_vs2017_depre= cated_option_v1&amp;data=3D02%7C01%7CBret.Barkelew%40microsoft.com%7C4a= 4588c4ee79488a3e5e08d7d7f9afc9%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7= C637215339711617971&amp;sdata=3DV%2B9F3QrpY3tX%2B%2BChPK02wOZC0XizIRJI7= 4LLqr9Lw54%3D&amp;reserved=3D0

Notes:
    V1:
    - Remove deprecated VS2017 and VS2019 option  = ;            &n= bsp;     [SAMI]

 BaseTools/Conf/tools_def.template | 18 ++++++= ;+++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.= template
index 2b17d3b2979a83144444b4d543b383af3198cdd0..67368f5013519a2d7397cbc975= 6acb6ff152727a 100755
--- a/BaseTools/Conf/tools_def.template
+++ b/BaseTools/Conf/tools_def.template
@@ -1,7 +1,7 @@
 #
 #  Copyright (c) 2006 - 2018, Intel Corporation. All rights res= erved.<BR>
 #  Portions copyright (c) 2008 - 2009, Apple Inc. All rights re= served.<BR>
-#  Portions copyright (c) 2011 - 2014, ARM Ltd. All rights reserved.= <BR>
+#  Portions copyright (c) 2011 - 2019, ARM Ltd. All rights reser= ved.<BR>
 #  Copyright (c) 2015, Hewlett-Packard Development Company, L.P= .<BR>
 #  (C) Copyright 2016 Hewlett Packard Enterprise Development LP= <BR>
 #  Copyright (c) Microsoft Corporation
@@ -1682,9 +1682,9 @@ NOOPT_VS2017_X64_DLINK_FLAGS    = =3D /NOLOGO /NODEFAULTLIB /IGNORE:4001 /IGNORE:428
 *_VS2017_ARM_ASLDLINK_PATH       = =3D DEF(VS2017_BIN_ARM)\link.exe
 
       *_VS2017_ARM_MAKE_FLAGS  &n= bsp;  =3D /nologo
-  DEBUG_VS2017_ARM_CC_FLAGS       =3D = /nologo /c /WX /GS- /W4 /Gs32768 /D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- = /GR- /GF /Gy /Zi /Gm /Gw /Oi-
+  DEBUG_VS2017_ARM_CC_FLAGS       = = =3D /nologo /c /WX /GS- /W4 /Gs32768 /D UNICODE /O1b2 /GL /FIAutoGen.h /EH= s-c- /GR- /GF /Gy /Zi /Gw /Oi-
 RELEASE_VS2017_ARM_CC_FLAGS       =3D = /nologo /c /WX /GS- /W4 /Gs32768 /D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- = /GR- /GF /Gw /Oi-
-NOOPT_VS2017_ARM_CC_FLAGS        = =3D /nologo /c /WX /GS- /W4 /Gs32768 /D UNICODE /FIAutoGen.h /EHs-c- /GR- = /GF /Gy /Zi /Gm /Od /Oi-
+NOOPT_VS2017_ARM_CC_FLAGS       &n= bsp; =3D /nologo /c /WX /GS- /W4 /Gs32768 /D UNICODE /FIAutoGen.h /EHs-c- /= GR- /GF /Gy /Zi /Od /Oi-
 
   DEBUG_VS2017_ARM_ASM_FLAGS      =3D = /nologo /g
 RELEASE_VS2017_ARM_ASM_FLAGS      =3D /nolo= go
@@ -1709,9 +1709,9 @@ NOOPT_VS2017_ARM_DLINK_FLAGS   &n= bsp;  =3D /NOLOGO /NODEFAULTLIB /IGNORE:4001 /OPT:REF
 *_VS2017_AARCH64_ASLDLINK_PATH     =3D DEF(VS201= 7_BIN_AARCH64)\link.exe
 
       *_VS2017_AARCH64_MAKE_FLAGS  =3D= /nologo
-  DEBUG_VS2017_AARCH64_CC_FLAGS    =3D /nologo /c /WX= /GS- /W4 /Gs32768 /D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gy /= Zi /Gm /Gw /Oi-
+  DEBUG_VS2017_AARCH64_CC_FLAGS    =3D /nologo /c= /WX /GS- /W4 /Gs32768 /D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /= Gy /Zi /Gw /Oi-
 RELEASE_VS2017_AARCH64_CC_FLAGS    =3D /nologo /c /WX= /GS- /W4 /Gs32768 /D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gw /= Oi-
-NOOPT_VS2017_AARCH64_CC_FLAGS      =3D /nologo /= c /WX /GS- /W4 /Gs32768 /D UNICODE /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /G= m /Od /Oi-
+NOOPT_VS2017_AARCH64_CC_FLAGS      =3D /nolo= go /c /WX /GS- /W4 /Gs32768 /D UNICODE /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Z= i /Od /Oi-
 
   DEBUG_VS2017_AARCH64_ASM_FLAGS   =3D /nologo /g
 RELEASE_VS2017_AARCH64_ASM_FLAGS   =3D /nologo
@@ -1845,9 +1845,9 @@ NOOPT_VS2019_X64_DLINK_FLAGS    = =3D /NOLOGO /NODEFAULTLIB /IGNORE:4001 /IGNORE:428
 *_VS2019_ARM_ASLDLINK_PATH       = =3D DEF(VS2019_BIN_ARM)\link.exe
 
       *_VS2019_ARM_MAKE_FLAGS  &n= bsp;  =3D /nologo
-  DEBUG_VS2019_ARM_CC_FLAGS       =3D = /nologo /c /WX /GS- /W4 /Gs32768 /D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- = /GR- /GF /Gy /Zi /Gm /Gw /Oi-
+  DEBUG_VS2019_ARM_CC_FLAGS       = = =3D /nologo /c /WX /GS- /W4 /Gs32768 /D UNICODE /O1b2 /GL /FIAutoGen.h /EH= s-c- /GR- /GF /Gy /Zi /Gw /Oi-
 RELEASE_VS2019_ARM_CC_FLAGS       =3D = /nologo /c /WX /GS- /W4 /Gs32768 /D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- = /GR- /GF /Gw /Oi-
-NOOPT_VS2019_ARM_CC_FLAGS        = =3D /nologo /c /WX /GS- /W4 /Gs32768 /D UNICODE /FIAutoGen.h /EHs-c- /GR- = /GF /Gy /Zi /Gm /Od /Oi-
+NOOPT_VS2019_ARM_CC_FLAGS       &n= bsp; =3D /nologo /c /WX /GS- /W4 /Gs32768 /D UNICODE /FIAutoGen.h /EHs-c- /= GR- /GF /Gy /Zi /Od /Oi-
 
   DEBUG_VS2019_ARM_ASM_FLAGS      =3D = /nologo /g
 RELEASE_VS2019_ARM_ASM_FLAGS      =3D /nolo= go
@@ -1872,9 +1872,9 @@ NOOPT_VS2019_ARM_DLINK_FLAGS   &n= bsp;  =3D /NOLOGO /NODEFAULTLIB /IGNORE:4001 /OPT:REF
 *_VS2019_AARCH64_ASLDLINK_PATH     =3D DEF(VS201= 9_BIN_AARCH64)\link.exe
 
       *_VS2019_AARCH64_MAKE_FLAGS  =3D= /nologo
-  DEBUG_VS2019_AARCH64_CC_FLAGS    =3D /nologo /c /WX= /GS- /W4 /Gs32768 /D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gy /= Zi /Gm /Gw /Oi-
+  DEBUG_VS2019_AARCH64_CC_FLAGS    =3D /nologo /c= /WX /GS- /W4 /Gs32768 /D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /= Gy /Zi /Gw /Oi-
 RELEASE_VS2019_AARCH64_CC_FLAGS    =3D /nologo /c /WX= /GS- /W4 /Gs32768 /D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- /GF /Gw /= Oi-
-NOOPT_VS2019_AARCH64_CC_FLAGS      =3D /nologo /= c /WX /GS- /W4 /Gs32768 /D UNICODE /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Zi /G= m /Od /Oi-
+NOOPT_VS2019_AARCH64_CC_FLAGS      =3D /nolo= go /c /WX /GS- /W4 /Gs32768 /D UNICODE /FIAutoGen.h /EHs-c- /GR- /GF /Gy /Z= i /Od /Oi-
 
   DEBUG_VS2019_AARCH64_ASM_FLAGS   =3D /nologo /g
 RELEASE_VS2019_AARCH64_ASM_FLAGS   =3D /nologo
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'


--_000_DB7PR08MB3097D3BA6CFBE0E2C98B905A84B90DB7PR08MB3097eurp_--