From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.83]) by mx.groups.io with SMTP id smtpd.web10.35245.1606141051977932767 for ; Mon, 23 Nov 2020 06:17:32 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=wkQ4G0vj; spf=pass (domain: arm.com, ip: 40.107.21.83, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mvg86ItUVCpzKG7TdGtYfm73ilu0pNZJc77ffrMH7r8=; b=wkQ4G0vjsvY7ar4W5MiI+qAVaZOuToc3glnhSnCT3FEWTYkb0XlemSvROWw4/tKFk9O9pVUygNKh5vZB0hxpLKdqGgrbpDxnMs8WO0oZPY4c312cDEqUsClHom7TZ7BZadQ6QYIOKmLrUKTNsxYjlm+TnKr8AwjRtzjgMU+AMSI= Received: from DB3PR06CA0009.eurprd06.prod.outlook.com (2603:10a6:8:1::22) by AM6PR08MB4644.eurprd08.prod.outlook.com (2603:10a6:20b:c9::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.30; Mon, 23 Nov 2020 14:17:28 +0000 Received: from DB5EUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:8:1:cafe::15) by DB3PR06CA0009.outlook.office365.com (2603:10a6:8:1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20 via Frontend Transport; Mon, 23 Nov 2020 14:17:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT052.mail.protection.outlook.com (10.152.21.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20 via Frontend Transport; Mon, 23 Nov 2020 14:17:28 +0000 Received: ("Tessian outbound fcd5bc555ddc:v71"); Mon, 23 Nov 2020 14:17:28 +0000 X-CR-MTA-TID: 64aa7808 Received: from 00b1b55711ff.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id AB6E0450-1128-4F6C-A30C-8B2BC0B0B274.1; Mon, 23 Nov 2020 14:17:23 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 00b1b55711ff.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 23 Nov 2020 14:17:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z2ExbIQ6XikEo12ccC4AHGEjy64eGRe/dP2rZB1ZY06RbexSMUE0sQsimbnl3LFMGWllJFiY92zxG4oXaqJXStP+VQrGSKRBYrnDph4/Lwm2Jzyprbc3+AJeLi7psWKchJQAVAcP6GgWwiZs5J7D2P1Zfp8wj3WrvGALd97CEZ1rBg67RYcBWtju8VOwVy2VODxaVa/kQqbi2zTygy+LHvMgwnRQp2vDP+rCRGhySURjIYpc6U182dpsxttpSMhfrDUB4hYAtOs+p1peYSlYqkxMBVyjYTixNKKi5xJtGskF7x6ie+MSdDuwu6jsHXRWdGxrsc3XkQcJ3V3LA+CZyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mvg86ItUVCpzKG7TdGtYfm73ilu0pNZJc77ffrMH7r8=; b=IIll8nd9GpgoZh+O5e5ixNBXGe+jNHRntHti371TC8EEwoK/CVd1lIfFerCqUvOx0pHbGWt5z79hlmeNGPQgvfRH0sUjPWVmljayBRCmKcKSEmOmG9+vbg0gWLhw5DtnOzo1jN82Zxb8ThPcsqsBumGSisVnzRitPbrE0ohfGduxfhBB5OJMIhg3mltahokdVVvfg6PBT/a0icllK12FSd4f2GL6p6THIiUEUiQLBWnaOe10yfQOXYt4BxwgQwQbbxV+iQA6c/K6upN3CbFuzUbdHuexspH7GWjs0qlTVLQ9i7SvowktmZoRm+W9gTVrhUKnedyq4UARZRWTmSSwUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mvg86ItUVCpzKG7TdGtYfm73ilu0pNZJc77ffrMH7r8=; b=wkQ4G0vjsvY7ar4W5MiI+qAVaZOuToc3glnhSnCT3FEWTYkb0XlemSvROWw4/tKFk9O9pVUygNKh5vZB0hxpLKdqGgrbpDxnMs8WO0oZPY4c312cDEqUsClHom7TZ7BZadQ6QYIOKmLrUKTNsxYjlm+TnKr8AwjRtzjgMU+AMSI= Received: from DB7PR08MB3097.eurprd08.prod.outlook.com (2603:10a6:5:1d::27) by DBBPR08MB4460.eurprd08.prod.outlook.com (2603:10a6:10:cc::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20; Mon, 23 Nov 2020 14:17:21 +0000 Received: from DB7PR08MB3097.eurprd08.prod.outlook.com ([fe80::315c:f6c3:2600:bd39]) by DB7PR08MB3097.eurprd08.prod.outlook.com ([fe80::315c:f6c3:2600:bd39%6]) with mapi id 15.20.3589.030; Mon, 23 Nov 2020 14:17:21 +0000 From: "Sami Mujawar" To: Sughosh Ganu , "devel@edk2.groups.io" CC: Ard Biesheuvel , Jiewen Yao , Ilias Apalodimas , nd Subject: Re: [PATCH v1 12/12] StandaloneMmPkg: Allow sending FFA Direct Request message to StandaloneMm Thread-Topic: [PATCH v1 12/12] StandaloneMmPkg: Allow sending FFA Direct Request message to StandaloneMm Thread-Index: AQHWp54OHf6Bpkfk1k2IH0ZEWrkaQqnBj06Q Date: Mon, 23 Nov 2020 14:17:21 +0000 Message-ID: References: <20201021113233.25548-1-sughosh.ganu@linaro.org> <20201021113233.25548-13-sughosh.ganu@linaro.org> In-Reply-To: <20201021113233.25548-13-sughosh.ganu@linaro.org> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 69B565231BB5434A82320C22C7053FDD.0 x-checkrecipientchecked: true Authentication-Results-Original: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [2a00:23c6:548a:4800:e1e2:5e02:5cb9:6f61] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: c8e95703-8ed1-4c88-f222-08d88fba822a x-ms-traffictypediagnostic: DBBPR08MB4460:|AM6PR08MB4644: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 6i1x7g/YrP3tkIJcupgJZcbPJdUtAFzkPa1J4+zWpzvh9qdC2wHTvmb3W/FwAgJ3l9V+gTvdKsc3Xz2moIQzh7J0R+MK5mZ0GIxTnK1OYvCqM/R0ZsWd1IzYPcvxof1aD28IubdchbsWzQ8g+9aqdxW0HJ6QbJE9zdls0oCxiWnx6NC514Id5iimnLyQz2KasLUC6RH6Lfa32E4MtF7f71UBm5bi0tCVNWJ4gLB/+hDHpBEcQ2NrIHZxBRThTDZEUFUyvpKBAKNvxWRvd9I46jjjC6gMNKKpcrfu3NJukXLMO1d3gzS3XhXEERAuKSX4V9ZgvHnO3vVJoY/4IZwUsqA70vlAvut6rSFTEZOfFxBXh/+JAuty81TgjXXT7L9qVKhuSXQmtEL8LoQ/6yn57g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3097.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(376002)(366004)(136003)(39860400002)(346002)(396003)(110136005)(6506007)(5660300002)(55016002)(52536014)(76116006)(53546011)(966005)(9686003)(66946007)(54906003)(64756008)(66446008)(66476007)(2906002)(66556008)(186003)(7696005)(8676002)(15650500001)(4326008)(316002)(8936002)(83380400001)(71200400001)(86362001)(478600001)(33656002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?nimQG0rg4H2Aybh0wjAsJMzaHtl2jLEC04XRMlWdT9pX8hoLhi2bQ5Mk437Z?= =?us-ascii?Q?fAABxH9wUYwYJpot0A3G02bypBzmjV5M6DHEob2EJ/s+vYKXuttbWnWx9QCA?= =?us-ascii?Q?2cEWCnaeNZvyl/tzl/5SaDvzQfy3JVHx85Ur14UTiHJZUaSzqUnq7JZxoPuB?= =?us-ascii?Q?pj0D2JMZC5FfaUAAXisR17jfutybtoKUZ3nj8sP2K1EGJxHRtgltKMWRP3wM?= =?us-ascii?Q?Xi2KPnfohiuPe7ro4hdJfjBmZQMvbivDjgkb1uGNOzjUgQtkr8s5Ei2nJyhH?= =?us-ascii?Q?uPSBJjbM40dj5QBGtPNr3bZtJeIkbrER2MQqqY5cdvGZEIyrcYAjjwHXxEYP?= =?us-ascii?Q?CFwcexgBONogi+5ZAUUg9w7i+3e2oMcleNL2hBc84DPTjMn9Q+eIV3f4Io/I?= =?us-ascii?Q?m0tynNZtSRnzA8Oq5Fr7mtqfI6KaAA4Mjz8E+AzIqUIaONZDRTJXod/nYF1N?= =?us-ascii?Q?ealOA3WlSNxzb0tgLu+MjMBkHtqPb1SwMRnrTQOULvBLijWqpw6LD7uHmhvp?= =?us-ascii?Q?T5Oenbx7ql4NIt+2S59eKg9b7I5Gm6J+WKxkAmawesz+LnURTqZ6GqjeLWdK?= =?us-ascii?Q?uoMo0G5Kv9ZbsGXze9dZKiqv0w6OnnZDzBOrJUx5BMlcPpNY7tcYnQTN3UU2?= =?us-ascii?Q?1ZeqzbNvzF7+xZ3n91u8ND47npMpL7KFveEUEM5poBixJPSj6V8Owh7HYsAi?= =?us-ascii?Q?tEuwBK4+GClzUXPZr2vZl0wJ0xyCPbwVVHg3S1yME+oHVMjIwrl/BCsFCSls?= =?us-ascii?Q?G0eLAJbinjNotRxdapVHn53QLu1beWzw/y4NovRybMU++23g6R+h8+LMv9GT?= =?us-ascii?Q?oYmGZFsqYF5iu+VAkzeoTsTgbTXIfUnuXjkY1AgwGez/Kd/qGW3B35fyOC7v?= =?us-ascii?Q?Pj6+JrXnm4/bZHjyykkVnjn0FeGzgBPHvRy/iTlKVcO3Q3begamlBG0manP+?= =?us-ascii?Q?7YOIfj1xriLlHTOvXVM8nQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4460 Original-Authentication-Results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 0f0ea9a9-39bf-4d74-f2c4-08d88fba7e45 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tqrBoitUoFwjQNIk9SmP2C5ullw7DWzXVdr4ChyMM5ClJd21CXbb3r75K7nAEooDr1EJ7ze0vZughaVSUmrcuN/6cc2dOFxzf4yTiUcZTcuxSCAHV0VlQujnGxYF1aTWJm77YjlrwWAeMf4kVba5hqz7QPPLhkLZDdVgUul4BFkfnGsriXhRV8asyetyutBgRXkzcd6BLb9lUj9NWohCShPidk7JnH0gTD76DMt9rhn89wvClfmhivO1S7/Zj88N9BPbDpV/4A7c4SfXsQcZUJK/siZc8nT9Ef5Z3+AjtRYYruMXfcW/roupzi6s96WPqP5kTURMnaMi/nD3QHZStZxB95zX5pNbmIUjAOkj1vgfD7xhQP5/7bPlSEmE+Nj2emc33eW6tO1+OTl5KssyznxU1D42oAD8YwtT1QvU9q7HGIHTNFRb5mL4daarONC5aPmACkMBAGKfIUsQb1QDkEuADiNwMGlLAd8jGKqgx90= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(6029001)(4636009)(346002)(376002)(136003)(396003)(39860400002)(46966005)(54906003)(966005)(110136005)(9686003)(316002)(478600001)(55016002)(82310400003)(82740400003)(47076004)(81166007)(356005)(86362001)(83380400001)(33656002)(5660300002)(4326008)(15650500001)(52536014)(8936002)(70586007)(70206006)(2906002)(6506007)(53546011)(186003)(7696005)(26005)(8676002)(336012);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2020 14:17:28.3396 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c8e95703-8ed1-4c88-f222-08d88fba822a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4644 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Sughosh, Please find my response inline marked [SAMI]. Regards, Sami Mujawar -----Original Message----- From: Sughosh Ganu =20 Sent: 21 October 2020 12:33 PM To: devel@edk2.groups.io Cc: Ard Biesheuvel ; Sami Mujawar ; Jiewen Yao ; Ilias Apalodimas ; Sughosh Ganu Subject: [PATCH v1 12/12] StandaloneMmPkg: Allow sending FFA Direct Request= message to StandaloneMm From: Ilias Apalodimas Allow passing of a request to StandaloneMm Core through the Firmware Framework(FF-A) using FFA_MSG_SEND_DIRECT_REQ method. This method is used as a mechanism for requesting some service from StandaloneMm. Signed-off-by: Ilias Apalodimas Signed-off-by: Sughosh Ganu --- StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c = b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c index 6a25c4c548..199441f7d2 100644 --- a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c +++ b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c @@ -22,6 +22,7 @@ #include #include =20 +#include #include =20 #include "StandaloneMmCpu.h" @@ -78,7 +79,8 @@ PiMmStandaloneArmTfCpuDriverEntry ( // receipt of a synchronous MM request. Use the Event ID to distinguish // between synchronous and asynchronous events. // - if (ARM_SMC_ID_MM_COMMUNICATE_AARCH64 !=3D EventId) { + if (ARM_SMC_ID_MM_COMMUNICATE_AARCH64 !=3D EventId && + ARM_SVC_ID_FFA_MSG_SEND_DIRECT_REQ_AARCH64 !=3D EventId) { [SAMI] Please use additional parenthesis for clarity.=20 Ref: https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/5= _source_files/52_spacing#5-2-2-10-use-extra-parentheses-rather-than-dependi= ng-on-in-depth-knowledge-of-the-order-of-precedence-of-c [/SAMI] DEBUG ((DEBUG_INFO, "UnRecognized Event - 0x%x\n", EventId)); return EFI_INVALID_PARAMETER; } --=20 2.17.1