From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Bret Barkelew <Bret.Barkelew@microsoft.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Ard Biesheuvel <Ard.Biesheuvel@arm.com>,
"leif@nuviainc.com" <leif@nuviainc.com>,
"lersek@redhat.com" <lersek@redhat.com>,
Matteo Carlini <Matteo.Carlini@arm.com>,
Ben Adderson <Ben.Adderson@arm.com>, nd <nd@arm.com>
Subject: Re: [EXTERNAL] [edk2-devel] [PATCH v5 14/15] .python/SpellCheck: Add 'XIPFLAGS' to "words" section
Date: Tue, 6 Oct 2020 07:58:10 +0000 [thread overview]
Message-ID: <DB7PR08MB3097FCF4A4FECE6AB6C329EE840D0@DB7PR08MB3097.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <MW4PR21MB1857D7FF926ED91D408E059BEF0C0@MW4PR21MB1857.namprd21.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 2853 bytes --]
Hi Bret,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
From: Bret Barkelew <Bret.Barkelew@microsoft.com>
Sent: 05 October 2020 09:51 PM
To: devel@edk2.groups.io; Sami Mujawar <Sami.Mujawar@arm.com>
Cc: Sami Mujawar <Sami.Mujawar@arm.com>; Ard Biesheuvel <Ard.Biesheuvel@arm.com>; leif@nuviainc.com; lersek@redhat.com; Matteo Carlini <Matteo.Carlini@arm.com>; Ben Adderson <Ben.Adderson@arm.com>; nd <nd@arm.com>
Subject: RE: [EXTERNAL] [edk2-devel] [PATCH v5 14/15] .python/SpellCheck: Add 'XIPFLAGS' to "words" section
I'm assuming this is used across multiple packages?
[SAMI] This flag is also used in CryptoPkg\Library\OpensslLib. [/SAMI]
If so,
Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com<mailto:bret.barkelew@microsoft.com>>
- Bret
From: Sami Mujawar via groups.io<mailto:sami.mujawar=arm.com@groups.io>
Sent: Friday, October 2, 2020 2:14 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Sami Mujawar<mailto:sami.mujawar@arm.com>; ard.biesheuvel@arm.com<mailto:ard.biesheuvel@arm.com>; leif@nuviainc.com<mailto:leif@nuviainc.com>; lersek@redhat.com<mailto:lersek@redhat.com>; Matteo.Carlini@arm.com<mailto:Matteo.Carlini@arm.com>; Ben.Adderson@arm.com<mailto:Ben.Adderson@arm.com>; nd@arm.com<mailto:nd@arm.com>
Subject: [EXTERNAL] [edk2-devel] [PATCH v5 14/15] .python/SpellCheck: Add 'XIPFLAGS' to "words" section
The EDKII Core CI reports spelling error for XIPFLAGS. The
XIPFLAGS are typically used to specify XIP options to the
compiler. e.g. GCC:*_*_*_CC_XIPFLAGS = -fno-jump-tables
Add 'XIPFLAGS' to "words" section in cspell.base.yaml file
to avoid spelling check error.
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com<mailto:sami.mujawar@arm.com>>
Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com<mailto:ard.biesheuvel@arm.com>>
---
Notes:
v5:
- No code changes, resending patch with v5 series. [Sami]
Ref: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F62162&data=02%7C01%7CBret.Barkelew%40microsoft.com%7C09b7528fca35489670af08d867182f71%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637372700863446978&sdata=VZm3wyCHnm9oV1HTuripLVGwPxvrLtmuXTDJk68ueCo%3D&reserved=0
.pytool/Plugin/SpellCheck/cspell.base.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/.pytool/Plugin/SpellCheck/cspell.base.yaml b/.pytool/Plugin/SpellCheck/cspell.base.yaml
index 1ce5f6991104b83e41e769299b23cb3fa74c46e9..ad6f7ac06ad18efcd4ab9c2346356dfd6885d827 100644
--- a/.pytool/Plugin/SpellCheck/cspell.base.yaml
+++ b/.pytool/Plugin/SpellCheck/cspell.base.yaml
@@ -178,5 +178,6 @@
"vcruntimed",
"ucrtd",
"msvcrtd",
+ "XIPFLAGS"
]
}
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
[-- Attachment #2: Type: text/html, Size: 7477 bytes --]
next prev parent reply other threads:[~2020-10-06 7:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 21:13 [PATCH v5 00/15] Kvmtool guest firmware support for Arm Sami Mujawar
2020-10-02 21:13 ` [PATCH v5 01/15] PcAtChipsetPkg: Add MMIO Support to RTC driver Sami Mujawar
2020-10-05 10:58 ` Ard Biesheuvel
2020-10-06 10:16 ` Laszlo Ersek
2020-10-15 14:35 ` Ard Biesheuvel
2020-10-02 21:13 ` [PATCH v5 02/15] ArmVirtPkg: Add Kvmtool RTC Fdt Client Library Sami Mujawar
2020-10-02 21:13 ` [PATCH v5 03/15] ArmPlatformPkg: Dynamic flash variable base Sami Mujawar
2020-10-02 21:13 ` [PATCH v5 04/15] ArmVirtPkg: Add kvmtool platform driver Sami Mujawar
2020-10-02 21:13 ` [PATCH v5 05/15] ArmVirtPkg: kvmtool platform memory map Sami Mujawar
2020-10-02 21:14 ` [PATCH v5 06/15] ArmVirtPkg: Add Kvmtool NOR flash lib Sami Mujawar
2020-10-02 21:14 ` [PATCH v5 07/15] MdeModulePkg: Fix constructor invocation ordering Sami Mujawar
2020-10-05 4:35 ` Wu, Hao A
2020-10-02 21:14 ` [PATCH v5 08/15] ArmVirtPkg: GUID Hob for 16550 UART base address Sami Mujawar
2020-10-02 21:14 ` [PATCH v5 09/15] ArmVirtPkg: 16550 UART Platform hook library Sami Mujawar
2020-10-02 21:14 ` [PATCH v5 10/15] ArmVirtPkg: Add Kvmtool Platform Pei Lib Sami Mujawar
2020-10-02 21:14 ` [PATCH v5 11/15] ArmVirtPkg: Support for kvmtool virtual platform Sami Mujawar
2020-10-02 21:14 ` [PATCH v5 12/15] ArmVirtPkg: Package dependency for MC146818 RTC Sami Mujawar
2020-10-02 21:14 ` [PATCH v5 13/15] ArmVirtPkg: Add kvmtool to package dictionary Sami Mujawar
2020-10-02 21:14 ` [PATCH v5 14/15] .python/SpellCheck: Add 'XIPFLAGS' to "words" section Sami Mujawar
2020-10-05 20:51 ` [EXTERNAL] [edk2-devel] " Bret Barkelew
2020-10-06 7:58 ` Sami Mujawar [this message]
2020-10-06 18:18 ` Bret Barkelew
2020-10-02 21:14 ` [PATCH v5 15/15] Maintainer.txt: Add Kvmtool platform reviewer Sami Mujawar
2020-10-16 17:27 ` [PATCH v5 00/15] Kvmtool guest firmware support for Arm Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR08MB3097FCF4A4FECE6AB6C329EE840D0@DB7PR08MB3097.eurprd08.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox