Re: [edk2-devel] [PATCH v3 2/2] BaseTools: Remove caret in NASM_INC macro

["PierreGondois" <pierre.gondois@arm.com>]

[-- Attachment #1: Type: text/plain, Size: 1701 bytes --]

Hello Bob,
If possible, I would prefer it to be committed before the freeze. Without it our builds are failing,

Regards,
Pierre

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Bob Feng via Groups.Io
Sent: 11 February 2020 13:30
To: Pierre Gondois <Pierre.Gondois@arm.com>; devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: Re: [edk2-devel] [PATCH v3 2/2] BaseTools: Remove caret in NASM_INC macro

Hi Pierre,

Thanks for updating the patch. I’ll trigger Intel internal CI to test this patch.

BTW, Since edk2 soft-freeze is coming, do you require this patch to be committed in this stable tag?

Thanks,
Bob

From: PierreGondois [mailto:pierre.gondois@arm.com]
Sent: Monday, February 10, 2020 9:29 PM
To: Feng, Bob C <bob.c.feng@intel.com<mailto:bob.c.feng@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH v3 2/2] BaseTools: Remove caret in NASM_INC macro

Hello Bob,

[From Bob]
This patch cause UefiCpuPkg build fail.
build -p UefiCpuPkg\UefiCpuPkg.dsc -a IA32 -t VS2015x86

As said in the cover letter of the v4 available at the link below, I was not able to reproduce the build fail that you pointed out. In the v4, the only thing that I am modifying is a condition on the makefile type. Hopefully this should only impact the build on Windows platforms using GNU makefiles. Thus there should not be any reason not to build on Windows platform using nmake makefiles. Feel free to modify this patch if you see what needs to be done.
V4 of "BaseTools: Remove caret in NASM_INC": https://edk2.groups.io/g/devel/message/54125

Regards,
Pierre


[-- Attachment #2: Type: text/html, Size: 6656 bytes --]