From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.43]) by mx.groups.io with SMTP id smtpd.web10.18755.1595337493277340270 for ; Tue, 21 Jul 2020 06:18:14 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=4M/8jFzE; spf=pass (domain: arm.com, ip: 40.107.7.43, mailfrom: pierre.gondois@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UwkG4rwlNGV3x9PHgGZ3ftPSUlk75j+yPlytUfX5LmE=; b=4M/8jFzEIvmU25w2NyP/mjGT5h8ozbOe+5moF49kpK2f5WynUGzuYIoQIz2mOkGNktnwJ+sknzrR21OT4DQyjOC4NqY7he+LgvOAsew2P1cn257odQKdiIZVi9TAG0TzGGABFG7ek9cNDNW0OVS3+So9dy4NV8uHmX0ClbCpqEw= Received: from AM5PR1001CA0051.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:15::28) by DBBPR08MB4629.eurprd08.prod.outlook.com (2603:10a6:10:f4::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20; Tue, 21 Jul 2020 13:18:10 +0000 Received: from VE1EUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:15:cafe::6d) by AM5PR1001CA0051.outlook.office365.com (2603:10a6:206:15::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.18 via Frontend Transport; Tue, 21 Jul 2020 13:18:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT032.mail.protection.outlook.com (10.152.18.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.18 via Frontend Transport; Tue, 21 Jul 2020 13:18:10 +0000 Received: ("Tessian outbound 7de93d801f24:v62"); Tue, 21 Jul 2020 13:18:10 +0000 X-CR-MTA-TID: 64aa7808 Received: from d5ee874d54d1.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 42454B3B-0F05-4E2A-920A-45A22CB01074.1; Tue, 21 Jul 2020 13:18:05 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d5ee874d54d1.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 21 Jul 2020 13:18:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HYo6ZupYtVxEYaqRC1CoH7oebM54eD+IKFUgF8UyeOBoyjLZ8mxUmHLhIDSH4zA3hfwzo2w/fTLtFj1/k9Cypp7Yz7Oo+jDvIZImNfn9EP/voVBzg/55DloUp6ipv4Vj4aom4+x6MKaRg59s5Q3gjZLptKHSIazkpQIQOHd2XzoOdZRMbb5KFsZpSbkavKyboSORfwrWBIvkPk4iMNnHfYqhgcSrsGoEZn/HDeBXi+Qd0UhlQHRb7Tqapku1fGagA8xevvwNe0TkWSKfQvuUIYgZqHEx+/WXz5cUvd280Af370lkzqfSfYb0cHFGG9ZBO4IAyVWJeATjsreihY/YYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UwkG4rwlNGV3x9PHgGZ3ftPSUlk75j+yPlytUfX5LmE=; b=L6aRO5hLokXcXs2wD0q485Uj1+CZJ+TNo/TmYSfIKycXNP+Bdg2rRPQsvttKL2Mt8jRsDVm6Gb6MSXn4R7gS96eYe4elEJSw8hLUhU60I1m6TpAXVuwxJrAf2IVJfHRQXMo/Unw8EY9O2So+qAzgdyzRlfrAcADU6T9I5h2XBDhLLmX3TMmJoSodEkSbI9G426Lee0c5Qhiz4CCgTKigDOIBcKSPR5nz6VmYEEsLFhof4HfhDoPEyVqUwfGyJI1sHRG0HSP9MfP5kaBcOipMtkOPYSOxtxnFUFGkcI/JayKoB6ugQLogELZy1iC5Tnei9+Oykhxgyj0gHLMDT7P6GA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UwkG4rwlNGV3x9PHgGZ3ftPSUlk75j+yPlytUfX5LmE=; b=4M/8jFzEIvmU25w2NyP/mjGT5h8ozbOe+5moF49kpK2f5WynUGzuYIoQIz2mOkGNktnwJ+sknzrR21OT4DQyjOC4NqY7he+LgvOAsew2P1cn257odQKdiIZVi9TAG0TzGGABFG7ek9cNDNW0OVS3+So9dy4NV8uHmX0ClbCpqEw= Received: from DB7PR08MB3113.eurprd08.prod.outlook.com (2603:10a6:5:20::21) by DB7PR08MB3835.eurprd08.prod.outlook.com (2603:10a6:10:75::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Tue, 21 Jul 2020 13:18:02 +0000 Received: from DB7PR08MB3113.eurprd08.prod.outlook.com ([fe80::e11b:cdfd:f08f:efde]) by DB7PR08MB3113.eurprd08.prod.outlook.com ([fe80::e11b:cdfd:f08f:efde%6]) with mapi id 15.20.3195.025; Tue, 21 Jul 2020 13:18:02 +0000 From: "PierreGondois" To: Leif Lindholm , "devel@edk2.groups.io" CC: Laszlo Ersek , Bob Feng Subject: Re: [PATCH 1/1] EmbeddedPkg: fix gcc build errors in AndroidBootImgLib Thread-Topic: [PATCH 1/1] EmbeddedPkg: fix gcc build errors in AndroidBootImgLib Thread-Index: AQHWX12dhK8hIx6BvU+0lP3odaEyHqkSAQgg Date: Tue, 21 Jul 2020 13:18:02 +0000 Message-ID: References: <20200721125056.32195-1-leif@nuviainc.com> In-Reply-To: <20200721125056.32195-1-leif@nuviainc.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 17a18a56-0efb-4fc8-b221-d1a906692ea8.1 x-checkrecipientchecked: true Authentication-Results-Original: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.106.52] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: b1dcdcf4-a69f-4e5f-f245-08d82d7883e5 x-ms-traffictypediagnostic: DB7PR08MB3835:|DBBPR08MB4629: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: noNddHy7jPWufA2a2gbNUpqg1dmMWFbm3/a/uh9NBDvPuUtx+T70yfOOoPCzEU0vbMptfqcuLWauBGEZm/66FylnQOaJA90jlL+MHQTlXChG3dxWuIQ690m+b+zewNVAmWdj5ga1Try5T5NlfdkJGynwbev+SU9UIBSDV4I8c32hMQWsM1Yx6GFn70BWpIdL11vYcIKwToYsRWtg0d2lGSQaeWRdJ/vtc/sHe3GbLsHhRo57d5kdGDwN1JaW3ejLmxkxlNT1u0riMrhFN8wDAVTyYEkyvXVAXIFSAR30ZDO/ZAFimVwNJdppnoFwRa95j7IQ8TDo2qaiIu+CrSoQZsE08XCEvpAFHdxEbikgICO8Av8Oc8M2cJtH4PT4L1OqMGhuvdgIF9AZNIYzQefKlA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3113.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(366004)(396003)(376002)(39860400002)(346002)(136003)(53546011)(83380400001)(33656002)(71200400001)(86362001)(19627235002)(6506007)(478600001)(55016002)(316002)(8676002)(26005)(5660300002)(52536014)(54906003)(76116006)(2906002)(7696005)(9686003)(4326008)(186003)(66476007)(64756008)(66446008)(66556008)(966005)(8936002)(66946007)(110136005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: e9J0i4b8MNcjIoyIglsgpOwoLX3g5fOzvUz4jP9VHThXKvd/vatWqyEtD0P1jgSZJsSDA5tQkyQ9FgmRsgbprdPdfccCSRw6ZA8swSXXBH6p5PHq0j5Wwk5UkKzZtjWXq5PfVX/F8HjJtb3/dc1T7hBYNUkFuk54lQnLGlqqkzPw9mxF4vOlBCe5BCAvzKw2Ij7rpoGa0RlE+tQhNxHIfOpp2DBYdvjAf8CKg36edZvX3AKNKdAyP/JGX3t1gwgQb8vy3xJx/uFUH6H+Xp/6cDgvqD52XWuf+e0g5uZ4Wf7nC9igpJ1A2/42K30sXFIq6LgXyVMCVl/mz5FQBmqySFaMa5sVOikPU1SP7MyAFYTDh0q6ays3/+7ZQvF0NAlitphH1pfAeTWeiyPkSyGCY7glHawRppqfjw/gqKtj1FVYMVAguNUtdPKjrurtP7mIgiZPotq8aAnY3gw10cK3KrqLUidbxRkyxzri4NNvcuMpA1XdY8Zm8vxJejgRaf1a x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3835 Original-Authentication-Results: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=arm.com; Return-Path: Pierre.Gondois@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT032.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFTY:;SFS:(4636009)(39860400002)(396003)(376002)(136003)(346002)(46966005)(107886003)(33656002)(36906005)(54906003)(26005)(82310400002)(356005)(110136005)(316002)(8936002)(2906002)(86362001)(5660300002)(4326008)(47076004)(52536014)(82740400003)(966005)(7696005)(53546011)(478600001)(55016002)(8676002)(9686003)(186003)(70586007)(81166007)(19627235002)(6506007)(83380400001)(70206006)(336012);DIR:OUT;SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: fd65ef7c-bc0f-4e1d-18d8-08d82d787f42 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: s6dqLoINwM5p/z7PFIHV0BUY+d7FmQXXf2WgiLqqw48GAatNLY3/vSIRBsaCl5GYtljCEA58oyDdsVHpBcknrTn4iJv9A/9PfvFi0JfvkHAAZQCWC286sGOmxRMz1ZOWlB11AS5rfizQevDr8gTU8dxydLpfYM/nRKy0uumRDko4FuV9rmmmFkLKXJKAdzF3A4ghLhp6FjhZV846JgStAC3j2EgUIeor7sDsAgozw3jaQN5LL/Hy5BZZY/CktRmRIvgOlaGd29YbgAMZGq48z++Id+TBiG+SSlU5EG5yb3wtTxghi2cnuGcQsNgk8XDNMaWxQEbu2sjh+RILxfncLK71nxPuV2ny6sYRspGhG22ocqGzwMAaRjr6zYUfg/lvwAWN+Vn3sd2Nggxf22Ywc1H7VLZvLPmH3WPNkVpn69G3CwbRxDsFQXNH1r72bYtKRIP8AU/JR7WVxUsTLuZcniehSt2ZsmmvMcifVMeP1lk= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2020 13:18:10.3646 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b1dcdcf4-a69f-4e5f-f245-08d82d7883e5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4629 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hello Leif, I actually submitted this modification on the build flags because of the er= ror that you fixed. I submitted a similar modification here https://edk2.gr= oups.io/g/devel/message/61832 . I should have waited before modifying the f= lags, my apologizes. I tried building edk2 top-level packages and this should be the only impact= . Regards, Pierre -----Original Message----- From: Leif Lindholm Sent: 21 July 2020 13:51 To: devel@edk2.groups.io Cc: Pierre Gondois ; Laszlo Ersek ; Bob Feng Subject: [PATCH 1/1] EmbeddedPkg: fix gcc build errors in AndroidBootImgLib Commit dbd546a32d5a ("BaseTools: Add gcc flag to warn on void* pointer arithmetic") does its wo= rk and triggers build errors in this library. Update the affected code to build correctly again. Cc: Pierre Gondois Cc: Laszlo Ersek Cc: Bob Feng Signed-off-by: Leif Lindholm --- Pierre - can you please ensure to CC Arm maintainers when proposing changes= to Arm build flags? (And build test all the top-level edk2 packages *cough= *.) Bob - can you please ensure Arm maintainers have commented on changes to gl= obal build flags? (Would it be possible to break up tools_def.template into separate arch-spe= cific include files so we could have GetMaintainer.py be more helpful for t= his?) Laszlo - you're not formally an EmbeddedPkg reviewer, but Ard is out for an= other couple of weeks. But since the Linaro CI is currently broken and the = fix is trivial, could you have a look please? EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c b/Em= beddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c index e1036954ee58..15b5bf451330 100644 --- a/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c +++ b/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c @@ -97,7 +97,7 @@ AndroidBootImgGetKernelInfo ( ASSERT (IS_VALID_ANDROID_PAGE_SIZE (Header->PageSize)); *KernelSize =3D Header->KernelSize; - *Kernel =3D BootImg + Header->PageSize; + *Kernel =3D (VOID *)((UINTN)BootImg + Header->PageSize); return EFI_SUCCESS; } @@ -341,7 +341,7 @@ AndroidBootImgUpdateFdt ( Status =3D AndroidBootImgSetProperty64 (UpdatedFdtBase, ChosenNode, "linux,initrd-end", - (UINTN)(RamdiskData + RamdiskSize)= ); + ((UINTN)RamdiskData + + RamdiskSize)); if (EFI_ERROR (Status)) { goto Fdt_Exit; } -- 2.20.1 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.