From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (EUR02-HE1-obe.outbound.protection.outlook.com [40.107.1.44]) by mx.groups.io with SMTP id smtpd.web12.6639.1593382336174785204 for ; Sun, 28 Jun 2020 15:12:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=C6JVLfx6; spf=pass (domain: arm.com, ip: 40.107.1.44, mailfrom: pierre.gondois@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lp9WQFsjM5OinN/z4ocH+HRMJueRE0X0ShjOo3uiIRA=; b=C6JVLfx6u6A9UacY/NzytnAeG0nK+qF8bBhBxHQkg47J8CihE9TZ1M7o2wqipWsPp9wacoyfAZ7HdPHzvg1xEBiWdj+zOcsfc4zdsKu9I8ltywnEYlRo2A+/A3JpaIb1KoZWYnMMcK8qTloTzrBtvdSP9lLwm44pJ9SoXUs4Oy8= Received: from AM6PR10CA0083.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::24) by AM6PR08MB3750.eurprd08.prod.outlook.com (2603:10a6:20b:81::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20; Sun, 28 Jun 2020 22:12:13 +0000 Received: from AM5EUR03FT056.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8c:cafe::99) by AM6PR10CA0083.outlook.office365.com (2603:10a6:209:8c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20 via Frontend Transport; Sun, 28 Jun 2020 22:12:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT056.mail.protection.outlook.com (10.152.17.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20 via Frontend Transport; Sun, 28 Jun 2020 22:12:12 +0000 Received: ("Tessian outbound fcfbba629a49:v60"); Sun, 28 Jun 2020 22:12:12 +0000 X-CR-MTA-TID: 64aa7808 Received: from 263b5676309e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E2351F7D-FC92-447E-902F-62BA69DEDBA5.1; Sun, 28 Jun 2020 22:12:07 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 263b5676309e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 28 Jun 2020 22:12:07 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LWZoRnbHotgQifP/twj36Tz+lkNXsxN+c6arr4Al1t4Ie1pC1gnfFDNBWSlLQ/fYs8HJ5fCzJBhz+NimVCFpTOuix+MdRla7G85/rsTyTOigzkkDhDFxP2r2n0ylxin36BCO+MFmb6SS419OFDLplZVO3U6zdbdvK+Vz5zYxWrsHJONzrbYFDBU7czU/ZWUZvgWQZk8Pwiurz8X9TXFcQwYLjM9K8TBx7vclKX/FPjZ8lTGC+hq6h7PrxsWnW8IjIOsk/4awyyKg/POkUoN7xHqJ4aXK/L8dlZJNKVBR1eBdVhmGpwOUPBxnH/Ny28wwlbe33Kfk62CIsMUnFgYWEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lp9WQFsjM5OinN/z4ocH+HRMJueRE0X0ShjOo3uiIRA=; b=dPY1pAj8cqvKntSpwOEU+4BzKuyNKc3PDfORI8EHoWaVUlsVvfifSwqtJGCXd7eajH+/n/fnrkYWdfrt0+t+ZlIwjGMnSv0NG9/bOFXaOow9VqTJstdQ6Ie9ilcAd4eSU3dHA8ovAr/cMlwrgL56hEgG83pKyP6YyRG69mFrXqpLBq2YWUryiSiw/tvw2T0HqyQ051lB+6wZ9j8hCZ1A9rVtD52axbSQ9Sv9u9+m+zy2+ZvsBf7Qf54AIKnoZYap7XXtS1ksM++aSmxJSIS4bDBPulFxOJABFQpO06D+/7Gc08DOtfvAkR2Xg1L4oFsfcGMjwHeIJGP17oHkJGTaAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lp9WQFsjM5OinN/z4ocH+HRMJueRE0X0ShjOo3uiIRA=; b=C6JVLfx6u6A9UacY/NzytnAeG0nK+qF8bBhBxHQkg47J8CihE9TZ1M7o2wqipWsPp9wacoyfAZ7HdPHzvg1xEBiWdj+zOcsfc4zdsKu9I8ltywnEYlRo2A+/A3JpaIb1KoZWYnMMcK8qTloTzrBtvdSP9lLwm44pJ9SoXUs4Oy8= Received: from DB7PR08MB3113.eurprd08.prod.outlook.com (2603:10a6:5:20::21) by DB6PR0802MB2358.eurprd08.prod.outlook.com (2603:10a6:4:89::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.24; Sun, 28 Jun 2020 22:12:05 +0000 Received: from DB7PR08MB3113.eurprd08.prod.outlook.com ([fe80::4178:71bd:a2a4:78bf]) by DB7PR08MB3113.eurprd08.prod.outlook.com ([fe80::4178:71bd:a2a4:78bf%7]) with mapi id 15.20.3131.026; Sun, 28 Jun 2020 22:12:05 +0000 From: "PierreGondois" To: "Feng, Bob C" , "devel@edk2.groups.io" CC: Sami Mujawar , Tomas Pilar , "Gao, Liming" , nd Subject: Re: [edk2-devel] [PATCH v3 0/4] Compile AML bytecode array into OBJ file Thread-Topic: [edk2-devel] [PATCH v3 0/4] Compile AML bytecode array into OBJ file Thread-Index: AQHWSgcbhBvrM/rS80+2kILO/iMwR6jn4K0AgAEs9RCABJtcgIAA9QwA Date: Sun, 28 Jun 2020 22:12:04 +0000 Message-ID: References: <20200624090837.124392-1-pierre.gondois@arm.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: a720bd05-7fe0-4087-8f5d-307c36d9687a.0 x-checkrecipientchecked: true Authentication-Results-Original: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.106.52] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 78472587-8407-4722-4365-08d81bb04f08 x-ms-traffictypediagnostic: DB6PR0802MB2358:|AM6PR08MB3750: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; x-forefront-prvs: 0448A97BF2 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 172BLtMKNxpChAEWzp96jjyFdR84oJP0ieeDaLg2qKe5VB5hyBYBDiWdF3WrUF4Gy8p8T/LUh7gR8cehU07k8QxwRu5n6qgXbf66YwaxdWhqSA8bu9Ygx1/LR82vcfrDDz37bMp0reBORLj/K+vxmDPbMNeFJLu1JR0vGp9ArSFB4u2xDWkoR/ThoW/SFPKBYjSgRxoXUXYCcCqX/HUvlGhxc6hwOfnsQK1yejJIs1dkc+eVXfxdSSAuKkP64aQE+4X8+jKgg1rfZ9vJOV8yVnsbF2SJDyq8lL+/ojfLmut6f3/cgKG65DxdFVOqhwz/1U45aH6lIkvrQEdxd0s6UNs5Ck9XdetqlqfwDxUHAMX1FIPi9lfwCdx+TBOwpZbEwLHvcgNulBL6YPKtDfy8+Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3113.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(396003)(376002)(39850400004)(366004)(346002)(52536014)(186003)(33656002)(26005)(53546011)(4326008)(8676002)(6506007)(7696005)(478600001)(30864003)(55016002)(19627235002)(9686003)(5660300002)(83380400001)(54906003)(76116006)(316002)(110136005)(66946007)(86362001)(71200400001)(966005)(66446008)(2906002)(8936002)(64756008)(66476007)(66556008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: gNgST/bsGU7jLZSO7PydP+BlijFW6qXkaoExYRYrUdJkEoaZEt1QxjJ8urpyeZM6DQPPJGXngyJ8gX5NJir6AASUloC8FGhdR9hNikBrVYYHdQ6BBs6YNY+EtiQ2HW+5N68vQtvISlPTujT7trJCB3Bfl201lJA5ZzZCOajyXXPDUnBBwJ8mw+g8qge9cXmDTCGwGQ2Gd57cVphLM1jROWb2zH7eusOTrFEaqHFJdvNufq+aFwWS2krfI8LsSJWLXrU6hQQr6bKJNU9zIaV4foiHf/eVVkY8YmGQfoynzCtn88uWxffmrynpciNmJgwwaBZfZbGEVEya/FfMjlNb+KriQhs0vjbQerU0yaCJbUiyRkwcRL+W07ZLYdHLPReBjHMF3AhKob+H+PJ4KpCJW4bfFCZMXnT2tJ4jlRS4AKjAM6QU7HIX/fdnKX3HjH26DGslrWcN491LU6ycayj0KrMFDzwvHb5rfiAgZ81ARdKO6A1tWi0dA50PC+2F5xyW MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2358 Original-Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; Return-Path: Pierre.Gondois@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT056.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFTY:;SFS:(4636009)(376002)(346002)(396003)(136003)(39850400004)(46966005)(19627235002)(86362001)(30864003)(5660300002)(26005)(52536014)(4326008)(6506007)(7696005)(83380400001)(53546011)(2906002)(47076004)(33656002)(82740400003)(9686003)(70206006)(110136005)(54906003)(356005)(81166007)(8936002)(36906005)(316002)(55016002)(70586007)(966005)(8676002)(336012)(186003)(82310400002)(478600001);DIR:OUT;SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: 9bf73936-9646-40a1-36ba-08d81bb04a7f X-Forefront-PRVS: 0448A97BF2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: t4RdRtvKIhPYk+4g5ukMiyAm+pkcJ7ZH/3kjouYYykV02ZvATIApSKv5b+cK3xe0WO1NM6906SDby64hSPkH1GoNYZ5bklkTJaiJ7JUBxrsQk1Lq5oc4nqGB+9XijLmMNFGTpFqtjIzkKkJQJT+jBpBrqE1KxGb0L7RC9bpSszhjHnUzv65aI6OXiZ4T5FGJfQ4iAMWvVeUxIy4QIzyX6/OsSg8ZtpVSfj1MqtZZ+zfaCqBcQ5v0T3w987RPmQ7RuHClz0UFTOO5sA9YSFIbtHa44DjR5TJNqN4eBa+uHI/OKGwpSK89CumowAH2xXjyPzxCOjhqZI3k2IC4qNEAtCnoZCmzeW7UnONyGsGNUfPLKvT4696ExmQJ/QLbijFPPI4oUBp6F1U8WYUBGvH6kG0HrSZzyet9FguN3WeqJ5HTlkIi4tt381hcIH7UCDccecLqnuH1naFMOw3Wq+KZsd45rSAXyRmH353JF08s0Ko= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2020 22:12:12.6251 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 78472587-8407-4722-4365-08d81bb04f08 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3750 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hello Bob, The PR729 didn't pass the PatchCheck for the patch adding the LF line endi= ngs to the script in BaseTools/BinWrappers/PosixLike, this is for the patch= named "BaseTools: Rename AmlToHex script to AmlToC" (cf the following link= : https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=3D8860&vie= w=3Dlogs&j=3D12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=3D9c939e41-62c2-5605-5e= 05-fc3554afc9f5&l=3D76). However, I thought it was a normal behaviour. Indeed, PatchCheck.py is tri= ggering an error for any file with LF line endings, except when: - the file has a ".sh" extension - the filename is in .gitmodules (it is coming from another git repo) - the file mode of the file is 160000 (it is coming from another git rep= o) The new AmlToC posix script doesn't match any of these conditions. However= some other files are in the same conditions. I searched the files containi= ng the "#!usr/bin/env" string and which don't have a ".sh" extension. I tri= ed to run the PatchCheck.py script on their respective commit with the vers= ion of PatchCheck.py that existed at that time and the same CRLF error appe= ared. The list of these files is at the end of the mail. Renaming them with= a ".sh" extension would break the build on linux: the extension of the fil= e is important to locate a file. This is not the case on windows (and this = explains why all the scripts in BaseTools\BinWrappers\WindowsLike have a .b= at extension). All the bash scripts not having a ".sh" extension are located in BaseTools= /Bin/CYGWIN_NT-5.1-i686/ or BaseTools/BinWrappers/PosixLike/ . A solution w= ould be to add an exception to the CRLF check for these two folders. A small question: when applying the patch set, did BaseTools\BinWrappers\P= osixLike\AmlToC have CRLF line endings and you had to manually modify them = to linux line endings, or where the line endings already correct (linux LF = line endings)? Regards, Pierre The list of bash scripts without a ".sh" extension: BaseTools/Bin/CYGWIN_NT-5.1-i686/BootSectImage commit 5e407648358d639ed19d228303527133e4c95c25 Date: 2016-01-20T05:12:02+00:00 BaseTools/Bin/CYGWIN_NT-5.1-i686/build commit 7aef7b7cbf16f79fb17c5ace98b1bc7f15bb90fa Date: 2018-12-28T16:25:04+08:00 BaseTools/Bin/CYGWIN_NT-5.1-i686/BuildEnv commit 66a2dc96d3dff90b4243c4ed3e7eaa33abdcdf3c Date: 2012-02-15T08:06:01+00:00 BaseTools/Bin/CYGWIN_NT-5.1-i686/Ecc commit 7aef7b7cbf16f79fb17c5ace98b1bc7f15bb90fa Date: 2018-12-28T16:25:04+08:00 BaseTools/Bin/CYGWIN_NT-5.1-i686/EfiLdrImage commit 5e407648358d639ed19d228303527133e4c95c25 Date: 2016-01-20T05:12:02+00:00 BaseTools/Bin/CYGWIN_NT-5.1-i686/EfiRom commit 5e407648358d639ed19d228303527133e4c95c25 Date: 2016-01-20T05:12:02+00:00 BaseTools/Bin/CYGWIN_NT-5.1-i686/GenCrc32 commit 5e407648358d639ed19d228303527133e4c95c25 Date: 2016-01-20T05:12:02+00:00 BaseTools/Bin/CYGWIN_NT-5.1-i686/GenDepex commit 7aef7b7cbf16f79fb17c5ace98b1bc7f15bb90fa Date: 2018-12-28T16:25:04+08:00 BaseTools/Bin/CYGWIN_NT-5.1-i686/GenFds commit 7aef7b7cbf16f79fb17c5ace98b1bc7f15bb90fa Date: 2018-12-28T16:25:04+08:00 BaseTools/Bin/CYGWIN_NT-5.1-i686/GenFfs commit 5e407648358d639ed19d228303527133e4c95c25 Date: 2016-01-20T05:12:02+00:00 BaseTools/Bin/CYGWIN_NT-5.1-i686/GenFv commit 5e407648358d639ed19d228303527133e4c95c25 Date: 2016-01-20T05:12:02+00:00 BaseTools/Bin/CYGWIN_NT-5.1-i686/GenFw commit 5e407648358d639ed19d228303527133e4c95c25 Date: 2016-01-20T05:12:02+00:00 BaseTools/Bin/CYGWIN_NT-5.1-i686/GenPage commit 5e407648358d639ed19d228303527133e4c95c25 Date: 2016-01-20T05:12:02+00:00 BaseTools/Bin/CYGWIN_NT-5.1-i686/GenSec commit 5e407648358d639ed19d228303527133e4c95c25 Date: 2016-01-20T05:12:02+00:00 BaseTools/Bin/CYGWIN_NT-5.1-i686/GenVtf commit 5e407648358d639ed19d228303527133e4c95c25 Date: 2016-01-20T05:12:02+00:00 BaseTools/Bin/CYGWIN_NT-5.1-i686/GnuGenBootSector commit 5e407648358d639ed19d228303527133e4c95c25 Date: 2016-01-20T05:12:02+00:00 BaseTools/Bin/CYGWIN_NT-5.1-i686/LzmaCompress commit 5e407648358d639ed19d228303527133e4c95c25 Date: 2016-01-20T05:12:02+00:00 BaseTools/Bin/CYGWIN_NT-5.1-i686/LzmaF86Compress commit 2e351cbe8e190271b3716284fc1076551d005472 Date: 2019-04-03T16:03:11-07:00 BaseTools/Bin/CYGWIN_NT-5.1-i686/RunBinToolFromBuildDir commit 66a2dc96d3dff90b4243c4ed3e7eaa33abdcdf3c Date: 2012-02-15T08:06:01+00:00 BaseTools/Bin/CYGWIN_NT-5.1-i686/RunToolFromSource commit 66a2dc96d3dff90b4243c4ed3e7eaa33abdcdf3c Date: 2012-02-15T08:06:01+00:00 BaseTools/Bin/CYGWIN_NT-5.1-i686/Split commit 5e407648358d639ed19d228303527133e4c95c25 Date: 2016-01-20T05:12:02+00:00 BaseTools/Bin/CYGWIN_NT-5.1-i686/TargetTool commit 7aef7b7cbf16f79fb17c5ace98b1bc7f15bb90fa Date: 2018-12-28T16:25:04+08:00 BaseTools/Bin/CYGWIN_NT-5.1-i686/TianoCompress commit 5e407648358d639ed19d228303527133e4c95c25 Date: 2016-01-20T05:12:02+00:00 BaseTools/Bin/CYGWIN_NT-5.1-i686/Trim commit 7aef7b7cbf16f79fb17c5ace98b1bc7f15bb90fa Date: 2018-12-28T16:25:04+08:00 BaseTools/Bin/CYGWIN_NT-5.1-i686/VfrCompile commit 5e407648358d639ed19d228303527133e4c95c25 Date: 2016-01-20T05:12:02+00:00 BaseTools/Bin/CYGWIN_NT-5.1-i686/VolInfo commit 5e407648358d639ed19d228303527133e4c95c25 Date: 2016-01-20T05:12:02+00:00 BaseTools/BinWrappers/PosixLike/AmlToC commit 68fe454598fea8472f65283656c4e9abe06dadb3 (HEAD -> pg/803_Compile_AM= L_bytecode_array_into_OBJ_file) Date: 2020-06-25T13:44:09+01:00 BaseTools/BinWrappers/PosixLike/BPDG commit 7aef7b7cbf16f79fb17c5ace98b1bc7f15bb90fa Date: 2018-12-28T16:25:04+08:00 BaseTools/BinWrappers/PosixLike/Brotli commit de87f23291620d36d69ec55ea53a1c38b8780f0b Date: 2017-03-30T16:23:10+08:00 BaseTools/BinWrappers/PosixLike/BrotliCompress commit 2e351cbe8e190271b3716284fc1076551d005472 Date: 2019-04-03T16:03:11-07:00 BaseTools/BinWrappers/PosixLike/build commit 7aef7b7cbf16f79fb17c5ace98b1bc7f15bb90fa Date: 2018-12-28T16:25:04+08:00 BaseTools/BinWrappers/PosixLike/DevicePath commit 7dbc50bd244d95fdc1741b9cfc561f0bfd724de1 Date: 2017-12-27T14:12:29+08:00 BaseTools/BinWrappers/PosixLike/Ecc commit 7aef7b7cbf16f79fb17c5ace98b1bc7f15bb90fa Date: 2018-12-28T16:25:04+08:00 BaseTools/BinWrappers/PosixLike/EfiRom commit 5e407648358d639ed19d228303527133e4c95c25 Date: 2016-01-20T05:12:02+00:00 BaseTools/BinWrappers/PosixLike/GenCrc32 commit 5e407648358d639ed19d228303527133e4c95c25 Date: 2016-01-20T05:12:02+00:00 BaseTools/BinWrappers/PosixLike/GenDepex commit 7aef7b7cbf16f79fb17c5ace98b1bc7f15bb90fa Date: 2018-12-28T16:25:04+08:00 BaseTools/BinWrappers/PosixLike/GenerateCapsule commit 7aef7b7cbf16f79fb17c5ace98b1bc7f15bb90fa Date: 2018-12-28T16:25:04+08:00 BaseTools/BinWrappers/PosixLike/GenFds commit 7aef7b7cbf16f79fb17c5ace98b1bc7f15bb90fa Date: 2018-12-28T16:25:04+08:00 BaseTools/BinWrappers/PosixLike/GenFfs commit 5e407648358d639ed19d228303527133e4c95c25 Date: 2016-01-20T05:12:02+00:00 BaseTools/BinWrappers/PosixLike/GenFv commit 5e407648358d639ed19d228303527133e4c95c25 Date: 2016-01-20T05:12:02+00:00 BaseTools/BinWrappers/PosixLike/GenFw commit 5e407648358d639ed19d228303527133e4c95c25 Date: 2016-01-20T05:12:02+00:00 BaseTools/BinWrappers/PosixLike/GenPatchPcdTable commit 7aef7b7cbf16f79fb17c5ace98b1bc7f15bb90fa Date: 2018-12-28T16:25:04+08:00 BaseTools/BinWrappers/PosixLike/GenSec commit 5e407648358d639ed19d228303527133e4c95c25 Date: 2016-01-20T05:12:02+00:00 BaseTools/BinWrappers/PosixLike/LzmaCompress commit 5e407648358d639ed19d228303527133e4c95c25 Date: 2016-01-20T05:12:02+00:00 BaseTools/BinWrappers/PosixLike/LzmaF86Compress commit 2e351cbe8e190271b3716284fc1076551d005472 Date: 2019-04-03T16:03:11-07:00 BaseTools/BinWrappers/PosixLike/PatchPcdValue commit 7aef7b7cbf16f79fb17c5ace98b1bc7f15bb90fa Date: 2018-12-28T16:25:04+08:00 BaseTools/BinWrappers/PosixLike/Pkcs7Sign commit 7aef7b7cbf16f79fb17c5ace98b1bc7f15bb90fa Date: 2018-12-28T16:25:04+08:00 BaseTools/BinWrappers/PosixLike/Rsa2048Sha256GenerateKeys commit 7aef7b7cbf16f79fb17c5ace98b1bc7f15bb90fa Date: 2018-12-28T16:25:04+08:00 BaseTools/BinWrappers/PosixLike/Rsa2048Sha256Sign commit 7aef7b7cbf16f79fb17c5ace98b1bc7f15bb90fa Date: 2018-12-28T16:25:04+08:00 BaseTools/BinWrappers/PosixLike/Split commit 5e407648358d639ed19d228303527133e4c95c25 Date: 2016-01-20T05:12:02+00:00 BaseTools/BinWrappers/PosixLike/TargetTool commit 7aef7b7cbf16f79fb17c5ace98b1bc7f15bb90fa Date: 2018-12-28T16:25:04+08:00 BaseTools/BinWrappers/PosixLike/TianoCompress commit 5e407648358d639ed19d228303527133e4c95c25 Date: 2016-01-20T05:12:02+00:00 BaseTools/BinWrappers/PosixLike/Trim commit 7aef7b7cbf16f79fb17c5ace98b1bc7f15bb90fa Date: 2018-12-28T16:25:04+08:00 BaseTools/BinWrappers/PosixLike/UPT commit 7aef7b7cbf16f79fb17c5ace98b1bc7f15bb90fa Date: 2018-12-28T16:25:04+08:00 BaseTools/BinWrappers/PosixLike/VfrCompile commit 5e407648358d639ed19d228303527133e4c95c25 Date: 2016-01-20T05:12:02+00:00 BaseTools/BinWrappers/PosixLike/VolInfo commit 5e407648358d639ed19d228303527133e4c95c25 Date: 2016-01-20T05:12:02+00:00 -----Original Message----- From: Feng, Bob C =20 Sent: 28 June 2020 08:34 To: devel@edk2.groups.io; Pierre Gondois Cc: Sami Mujawar ; Tomas Pilar = ; Gao, Liming ; nd Subject: RE: [edk2-devel] [PATCH v3 0/4] Compile AML bytecode array into O= BJ file Hi Pierre, I met a problem when I push your patch set. If I change the CRLF to a unix format EOL, the patch can't pass PatchCheck= .py. If I don't change the CRLF, The build on Linux will fail. So I can't make the patch set pass the CI. Could you share me how did you do to make your PR 729 pass? Thanks, Bob -----Original Message----- From: devel@edk2.groups.io On Behalf Of PierreGondo= is Sent: Thursday, June 25, 2020 5:31 PM To: devel@edk2.groups.io; Feng, Bob C Cc: Sami Mujawar ; Tomas Pilar = ; Gao, Liming ; nd Subject: Re: [edk2-devel] [PATCH v3 0/4] Compile AML bytecode array into O= BJ file Hello Bob, I believe the line endings of the BaseTools/BinWrappers/PosixLike/AmlToC s= cript have been modified to CRLF when I sent the patch. I created a pull re= quest from the linked github branch noted in the patches. It is available a= t https://github.com/PierreARM/edk2/commits/803_Compile_AML_bytecode_array_= into_OBJ_file_v3 . The pull request is available here (to show the result o= f the CI tests) https://github.com/tianocore/edk2/pull/729 . Do you want a v4 or is it possible to pull the patches from the github rep= ository? Sorry for the inconvenience. Regards, Pierre -----Original Message----- From: devel@edk2.groups.io On Behalf Of Bob Feng vi= a groups.io Sent: 24 June 2020 16:16 To: devel@edk2.groups.io; Pierre Gondois Cc: Sami Mujawar ; Tomas Pilar = ; Gao, Liming ; nd Subject: Re: [edk2-devel] [PATCH v3 0/4] Compile AML bytecode array into O= BJ file Hi Pierre, There are some build failed in OpenCI. Would you please check it? https://github.com/tianocore/edk2/pull/727 Thanks, Bob -----Original Message----- From: devel@edk2.groups.io On Behalf Of PierreGondo= is Sent: Wednesday, June 24, 2020 5:09 PM To: devel@edk2.groups.io Cc: Pierre Gondois ; sami.mujawar@arm.com; tomas.p= ilar@arm.com; Feng, Bob C ; Gao, Liming ; nd@arm.com Subject: [edk2-devel] [PATCH v3 0/4] Compile AML bytecode array into OBJ f= ile Following the BZ at https://bugzilla.tianocore.org/show_bug.cgi?id=3D2425 This patch serie is a another way to solve the dependency of C files over = ASL files. With this new method, the dependency is resolved at the linking = stage. The last method to solve this dependency was to add the possibility to mod= ify INF files to depict such a dependency. This method was not accepted. Th= e discussion is available at https://edk2.groups.io/g/devel/topic/72655342#= 56658 The last patch modifying the INF specification and INF parsing are availab= le at: https://edk2.groups.io/g/devel/topic/72655342#56658 https://edk2.groups.io/g/devel/topic/72656060#56662 Pierre Gondois (4): BaseTools: Generate multiple rules when multiple output files BaseTools: Rename AmlToHex script to AmlToC BaseTools: Compile AML bytecode arrays into .obj file BaseTools: Fix string concatenation BaseTools/BinWrappers/PosixLike/{AmlToHex =3D> AmlToC} | 28= +++---- BaseTools/BinWrappers/WindowsLike/{AmlToHex.bat =3D> AmlToC.bat} | 0 BaseTools/Conf/build_rule.template | 15 += ++- BaseTools/Source/Python/{AmlToHex/AmlToHex.py =3D> AmlToC/AmlToC.py} | 82= ++++++++------------ BaseTools/Source/Python/AutoGen/BuildEngine.py | 2 += - BaseTools/Source/Python/AutoGen/GenMake.py | 6 += + BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 38 += ++++---- 7 files changed, 89 insertions(+), 82 deletions(-) rename BaseTools/BinW= rappers/PosixLike/{AmlToHex =3D> AmlToC} (97%) rename BaseTools/BinWrapper= s/WindowsLike/{AmlToHex.bat =3D> AmlToC.bat} (100%) rename BaseTools/Sourc= e/Python/{AmlToHex/AmlToHex.py =3D> AmlToC/AmlToC.py} (52%) -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'