Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode definitions

["PierreGondois" <pierre.gondois@arm.com>]

Hello everyone,
Just to push the patch forward a bit: the patch has received reviewed-by from Liming Gao, Zhiguang Liu and Sami Mujawar,

Regards,
Pierre

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Liming Gao via groups.io
Sent: Friday, April 10, 2020 4:19 AM
To: Liu, Zhiguang <zhiguang.liu@intel.com>; devel@edk2.groups.io; Pierre Gondois <Pierre.Gondois@arm.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Sami Mujawar <Sami.Mujawar@arm.com>; nd <nd@arm.com>
Subject: Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode definitions

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Liu, Zhiguang <zhiguang.liu@intel.com>
> Sent: Friday, April 10, 2020 9:44 AM
> To: devel@edk2.groups.io; pierre.gondois@arm.com
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming 
> <liming.gao@intel.com>; Sami.Mujawar@arm.com; nd@arm.com
> Subject: RE: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML FieldList 
> OpCode definitions
> 
> Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
> 
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of 
> PierreGondois
> Sent: Monday, March 30, 2020 4:53 PM
> To: devel@edk2.groups.io
> Cc: Pierre Gondois <Pierre.Gondois@arm.com>; Kinney, Michael D 
> <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; 
> Sami.Mujawar@arm.com; nd@arm.com
> Subject: [edk2-devel] [PATCH v1 1/1] MdePkg: Add AML FieldList OpCode 
> definitions
> 
> From: Pierre Gondois <pierre.gondois@arm.com>
> 
> The ACPI specification, version 6.3, January 2019, defines the Named 
> Objects Encoding for FieldElements in section '20.2.5.2 Named Objects 
> Encoding'.
> FieldElements can be one of the following:
> NamedField | ReservedField | AccessField | ExtendedAccessField | 
> ConnectField
> 
> Some of these keywords are starting with an opcode, allowing to 
> identify their type.
> E.g.: ReservedField := 0x00 PkgLength
> 
> This patch adds these FieldElement opcodes definitions to the list of 
> AML Opcode definitions.
> 
> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> ---
> 
> The changes can be seen at 
> https://github.com/PierreARM/edk2/commits/695_Add_FieldElement_OpCode_
> v1
> 
> Notes:
>     v1:
>      - Add AML Field Element OpCodes [Pierre]
> 
>  MdePkg/Include/IndustryStandard/AcpiAml.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/MdePkg/Include/IndustryStandard/AcpiAml.h 
> b/MdePkg/Include/IndustryStandard/AcpiAml.h
> index 
> 3dd5408b359f9192e2fa9cedd0260a0f6bb5603a..74622e912ea42c2a043793628434
> 73cac5ea5856 100644
> --- a/MdePkg/Include/IndustryStandard/AcpiAml.h
> +++ b/MdePkg/Include/IndustryStandard/AcpiAml.h
> @@ -168,4 +168,12 @@
>  #define AML_EXT_BANK_FIELD_OP        0x87
>  #define AML_EXT_DATA_REGION_OP       0x88
> 
> +//
> +// FieldElement OpCode
> +//
> +#define AML_FIELD_RESERVED_OP        0x00
> +#define AML_FIELD_ACCESS_OP          0x01
> +#define AML_FIELD_CONNECTION_OP      0x02
> +#define AML_FIELD_EXT_ACCESS_OP      0x03
> +
>  #endif
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> 
> 
>