From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from FRA01-MR2-obe.outbound.protection.outlook.com (FRA01-MR2-obe.outbound.protection.outlook.com [40.107.9.51]) by mx.groups.io with SMTP id smtpd.web12.15669.1593525365683878141 for ; Tue, 30 Jun 2020 06:56:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=rm6S8K/D; spf=pass (domain: arm.com, ip: 40.107.9.51, mailfrom: pierre.gondois@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8swWcgkyli8WPdp+oRi1TqGIDYEiCr2JX4COyD8kvhY=; b=rm6S8K/Dddeu77/viq8EL6p5MkYwmxEv/FXikKBCZWFvFsoWHjYUi1jgAC3xdDn3WgT2lw5b1Iwa9JiGBEkLeSwWOBXPFIYEVU+8UTaq1q6sdZTJgVxbo2mgvjUIAQS07/+CgFo4RNImxxhKglrOsZ6TMALG0rqbOnfF/tEWjZw= Received: from AM0PR10CA0113.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:e6::30) by PR2PR08MB4764.eurprd08.prod.outlook.com (2603:10a6:101:19::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.21; Tue, 30 Jun 2020 13:56:02 +0000 Received: from AM5EUR03FT009.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:e6:cafe::9f) by AM0PR10CA0113.outlook.office365.com (2603:10a6:208:e6::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.21 via Frontend Transport; Tue, 30 Jun 2020 13:56:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT009.mail.protection.outlook.com (10.152.16.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20 via Frontend Transport; Tue, 30 Jun 2020 13:56:01 +0000 Received: ("Tessian outbound fcfbba629a49:v60"); Tue, 30 Jun 2020 13:56:01 +0000 X-CR-MTA-TID: 64aa7808 Received: from 9a4959e1e45c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5EF33DED-ACD0-4289-8EED-898D8D472DC8.1; Tue, 30 Jun 2020 13:55:56 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9a4959e1e45c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 30 Jun 2020 13:55:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IcGXth3iTe47DLpO0OxwfBM7sAHpb+iJG04YFdPb6gVK3fHzLpKb5DmqAlvQBT/phI4vhtoE5qfDiGpcXApi6xxJ5XXT5j3jedemymc6YicN2YMl9Gkf2Dnb+tQgav9cGzRtFtCV9MHxlPptbYUSNiBgfnSKS64siYWr+RZe0QuqvI+tjpetdVpIzagSNZtMmvq1IUofIGCJIL/O/mGac/OoRD2XfllbGy+5sNeP4CRh9Z6epS4EgvJpnjsUA8zF/pspFQT7ldNoaONetWLGBxrXUbAM+nYwKsFU5LjXF017hASQSDb2NRvuackWEuC7wWy27oudgL9Lofl4xDpU0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8swWcgkyli8WPdp+oRi1TqGIDYEiCr2JX4COyD8kvhY=; b=mqWbxCmjEvxHxEoZm6Pni2Vkvs7bPjH1iAzTnunz1Rd/1srtRntBIHWR+PRClQcd/xW2T2Szn8WmVuQf3R1EEdgpXQ5trWTTSS77QCrloAj4eDtAaITPVh3ir8dswUnRBWhIHs2Oiz7T3orK0W9LCq5E5IgOTlAbN995vPPZ/3RXZGBJnXz48lUz+L9Mjb0gJ1dUHiKH0WuCxwkZyXJzUYSHZ0cKcmPcCIlq1ruc1Ij+M5sRh+vFQ1h95UcpDDg1EIOrINjLSEXYecaRMRkLVunhLLxVMIl8kwNvgt5pRY8Jr3kFoJCH0JlPmpzKztm8crbxUBdFkSLLHnHw+pYrrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8swWcgkyli8WPdp+oRi1TqGIDYEiCr2JX4COyD8kvhY=; b=rm6S8K/Dddeu77/viq8EL6p5MkYwmxEv/FXikKBCZWFvFsoWHjYUi1jgAC3xdDn3WgT2lw5b1Iwa9JiGBEkLeSwWOBXPFIYEVU+8UTaq1q6sdZTJgVxbo2mgvjUIAQS07/+CgFo4RNImxxhKglrOsZ6TMALG0rqbOnfF/tEWjZw= Received: from DB7PR08MB3113.eurprd08.prod.outlook.com (2603:10a6:5:20::21) by DB6PR0801MB1895.eurprd08.prod.outlook.com (2603:10a6:4:74::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.23; Tue, 30 Jun 2020 13:55:55 +0000 Received: from DB7PR08MB3113.eurprd08.prod.outlook.com ([fe80::4178:71bd:a2a4:78bf]) by DB7PR08MB3113.eurprd08.prod.outlook.com ([fe80::4178:71bd:a2a4:78bf%7]) with mapi id 15.20.3153.020; Tue, 30 Jun 2020 13:55:55 +0000 From: "PierreGondois" To: "Feng, Bob C" , "devel@edk2.groups.io" CC: Sami Mujawar , Tomas Pilar , "Gao, Liming" , nd Subject: Re: [edk2-devel] [PATCH v3 0/4] Compile AML bytecode array into OBJ file Thread-Topic: [edk2-devel] [PATCH v3 0/4] Compile AML bytecode array into OBJ file Thread-Index: AQHWSgcbhBvrM/rS80+2kILO/iMwR6jn4K0AgAEs9RCABJtcgIACA8aAgAFaBoCAADDVcA== Date: Tue, 30 Jun 2020 13:55:54 +0000 Message-ID: References: <20200624090837.124392-1-pierre.gondois@arm.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 61c344db-7a0c-4d73-a321-53739d14b431.1 x-checkrecipientchecked: true Authentication-Results-Original: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.106.52] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: ed9552c0-d6e4-44f5-1830-08d81cfd5317 x-ms-traffictypediagnostic: DB6PR0801MB1895:|PR2PR08MB4764: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; x-forefront-prvs: 0450A714CB X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: xX+FuTpY0R9ZOiDietGRabO71oibGWAQy40Kev+j/NmFeGrgk0pyuWi//vODMbIhyHiTFO8Pl3nBV3rn8xN70k35lOu5djT+GHrERwJdLyVKT6xrV7pKAO31Oz8hNBeS6O5D4x5o3F4kGqoOXflbECmnF8RI7INj33Hs1ZOefZiqxBNtLwdeARjUJfEDrTcRghK2rlXObWvvTcrTJVCk/F4YjvSz4GqDuSESUT9O6J7oQMe4QrzJXNgV28WJJVZNXD0MxQyjTbljyJOJNvdcW9YKsttbit4XgEFIIxQcBWZpS1moDVNASxPAcVZ53VDE+rOpzJ1eAbYBMena0WTUfM8vQNfkNLFdiyu/+FtHPlehp285jkwVstgzBwZX990VyIr52mBPeDgY/jd02ov2uQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3113.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(39860400002)(376002)(136003)(346002)(396003)(366004)(316002)(64756008)(2906002)(186003)(66446008)(66476007)(66556008)(66946007)(71200400001)(76116006)(26005)(30864003)(53546011)(52536014)(55016002)(8676002)(5660300002)(9686003)(6506007)(966005)(86362001)(7696005)(33656002)(8936002)(478600001)(54906003)(110136005)(83380400001)(4326008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: kOD9uM4uUMfDg2YoI/ltttCT4cReQ2ejsw2joqpdO99L6Wc7FDT1bfaepmf0KmplAi0kGs1XnusDZJ9/DorebvfbnDtQxPDcjl0muXaK+cUcd0vOarsdqZYu0iu9sDmknGCg7bJApU5jHJBkikoyu73NX6JznioS24U6ApI/lNhqyiP7O0gbV4Gk1XPPLwU0qKhODBO10lpsxGnLI6b0i7SW9ZVabVrBnT3cvOk4q4dTERAojrVaa2fiK1JTKAhKAI95/pO+/RlSMmRZ1Ll9ZlAU5MIhqkjRvttdvLDpJSEIAhLWIJQdHqvxo1eek+WgDOjAC4mABjtyOY7BKvACkyIwSO161ozHwLc4y6LJP1KmCM6elHS/ryhYbu7wKAS4A4U/I2pU44sgvuWJs8bKGI6V7EFurd1L0sZSSKI7v4lSiTrG/5r9wzucKpPG69XoPVrnrm5TyDfv2PL4kI5AfGwtt49CuUaAXfu/RhLIp4hfRLO9Fd3f3EErSWZL9BND MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1895 Original-Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; Return-Path: Pierre.Gondois@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT009.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFTY:;SFS:(4636009)(396003)(39860400002)(136003)(376002)(346002)(46966005)(336012)(316002)(30864003)(356005)(52536014)(54906003)(110136005)(83380400001)(81166007)(7696005)(86362001)(82740400003)(9686003)(4326008)(47076004)(5660300002)(6506007)(53546011)(55016002)(82310400002)(36906005)(33656002)(2906002)(186003)(26005)(70586007)(70206006)(8676002)(478600001)(966005)(8936002);DIR:OUT;SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: 5b19d486-7628-47ee-4989-08d81cfd4f08 X-Forefront-PRVS: 0450A714CB X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dUhpt3K3ms37Nof08heHPP3XUFB0I4on7J+4rOI07/uTjEqvweFVKb5UfWUbO8rtHcR6e8v0Rnzze7ZPYkTewCjJ+IirkfI/WV9jGxNigbx8Z8L5hsAFve52ej7jWvb37Aa3Eeo3zyyFXSUjRld1qbxGBKeyOc+9TdSPpWSXVA4j0KK0sPcnnqlUU7AZRC7/PY58ljMbs2OtLElvrfh5nVMe3J/sBamh0HkxDxprsNqI4sgfdUlOtDUfCwtnvk4O+7rB9Bh3cM+JoO0V/WlTz4nnZ3JU0ie7tuw45nhRs7orS0FzC2VOGlFUkmLs/uTHmqa9utDNHSbfkNpxLTwnxlMOzW4uX7bmVltz15WPhFBxwSZtEy1PpksG/yDBD83hVvQh6HJRqkLF8JwRb/eQ5NEPG+yWY0nAMkMe80oaIXOSTMaladHfkBXdqiLqAIJ3yfz3lXC8GBzl8vlb0jM+fE/J0Ncdd0VS6C5HEQMMEKE= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2020 13:56:01.8401 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ed9552c0-d6e4-44f5-1830-08d81cfd5317 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4764 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I agree that PatchCheck.py needs to be updated. However, this is difficult = for PatchCheck.py to know whether a file should be allowed to have LF line = endings or not. Some files currently in edk2 have LF line endings and: - have a ".sh" extension (EmulatorPkg/build.sh), some other don't (BaseTo= ols/BinWrappers/PosixLike/GenFv); - start with "#!/usr/bin/env bash" (BaseTools/BinWrappers/PosixLike/GenFv= ), some other don't (edksetup.sh); I don't see any criteria that would allow to identify whether a file is su= pposed to have LF line endings or not. This is why I think creating a ".git= attribute" file in edk2 would help. In this file, people could identify fil= es/folders being allowed to have LF line endings. PatchCheck.py would parse= this file to exclude them from the CRLF check. Plus it would enforce the l= ine ending on local copies of edk2, thus preventing mistakes like I did whe= n sending a bash script with CRLF line endings. Do you agree with this solution? Another question: does the CRLF error triggered by PatchCheck.py imply del= aying this current patch set? Indeed I'm scared trying to add a ".gitattrib= ute" file might start long discussions. Regards, Pierre -----Original Message----- From: Feng, Bob C =20 Sent: 30 June 2020 11:59 To: devel@edk2.groups.io; Pierre Gondois Cc: Sami Mujawar ; Tomas Pilar = ; Gao, Liming ; nd Subject: RE: [edk2-devel] [PATCH v3 0/4] Compile AML bytecode array into O= BJ file Hi Pierre, I think we need to update the PatchCheck.py script. The comments says, "Do= not enforce CR/LF line endings for linux shell scripts.", but that only ch= eck the file ext is .sh is not enough. if self.filename.endswith('.sh'): # # Do not enforce CR/LF line endings for linux shell sc= ripts. # self.force_crlf =3D False Thanks, Bob -----Original Message----- From: devel@edk2.groups.io On Behalf Of PierreGondo= is Sent: Monday, June 29, 2020 10:33 PM To: Feng, Bob C ; devel@edk2.groups.io Cc: Sami Mujawar ; Tomas Pilar = ; Gao, Liming ; nd Subject: Re: [edk2-devel] [PATCH v3 0/4] Compile AML bytecode array into O= BJ file Hello Bob, I actually found more files having a LF line ending by running the followi= ng command: for file in `git ls-files`; do if [ "${file##*.}" !=3D bin ] && [ "${file#= #*.}" !=3D bmp ] && [ "${file##*.}" !=3D a ] && [ "${file##*.}" !=3D lib ] = && [ "${file##*.}" !=3D cer ] && [ "${file##*.}" !=3D pyd ] &&[ "${file##*.= }" !=3D pem ] && [ "${file##*.}" !=3D raw ]; then file $file | grep -v "CRL= F" | grep -v ": directory"; fi; done The command list files referenced in g= it, then excludes files with specific extensions, excludes directories, and= excludes files with CRLF line endings. I believe some of them should have CRLF line endings if this is the defaul= t in edk2. I am mainly thinking about the ".rtf", ".py" and ".txt" files. F= or the actual bash scripts, maybe a ".gitattributes" file can be created in= edk2 to explicitly make them use LF line endings. This can be done by sett= ing this attribute: "eol=3Dlf". This ".gitattributes" file would then be parsed by the PatchCHeck.py scrip= t not to trigger an error for files having the later attribute. Regards, Pierre List of files obtained by running the command above, (maybe it needs some = more filters): BaseTools/Bin/CYGWIN_NT-5.1-i686/BootSectImage: Bourne-Again shell script,= ASCII text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/BuildEnv: Bourne-Again shell script, ASCI= I text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/Ecc: Bourne-Again shell script, ASCII tex= t executable BaseTools/Bin/CYGWIN_NT-5.1-i686/EfiLdrImage: Bourne-Again shell script, A= SCII text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/EfiRom: Bourne-Again shell script, ASCII = text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/GenCrc32: Bourne-Again shell script, ASCI= I text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/GenDepex: Bourne-Again shell script, ASCI= I text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/GenFds: Bourne-Again shell script, ASCII = text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/GenFfs: Bourne-Again shell script, ASCII = text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/GenFv: Bourne-Again shell script, ASCII t= ext executable BaseTools/Bin/CYGWIN_NT-5.1-i686/GenFw: Bourne-Again shell script, ASCII t= ext executable BaseTools/Bin/CYGWIN_NT-5.1-i686/GenPage: Bourne-Again shell script, ASCII= text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/GenSec: Bourne-Again shell script, ASCII = text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/GenVtf: Bourne-Again shell script, ASCII = text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/GnuGenBootSector: Bourne-Again shell scri= pt, ASCII text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/LzmaCompress: Bourne-Again shell script, = ASCII text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/LzmaF86Compress: Bourne-Again shell scrip= t, ASCII text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/RunBinToolFromBuildDir: Bourne-Again shel= l script, ASCII text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/RunToolFromSource: Bourne-Again shell scr= ipt, ASCII text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/Split: Bourne-Again shell script, ASCII t= ext executable BaseTools/Bin/CYGWIN_NT-5.1-i686/TargetTool: Bourne-Again shell script, AS= CII text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/TianoCompress: Bourne-Again shell script,= ASCII text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/Trim: Bourne-Again shell script, ASCII te= xt executable BaseTools/Bin/CYGWIN_NT-5.1-i686/VfrCompile: Bourne-Again shell script, AS= CII text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/VolInfo: Bourne-Again shell script, ASCII= text executable BaseTools/Bin/CYGWIN_NT-5.1-i686/build: Bourne-Again shell script, ASCII t= ext executable BaseTools/BinWrappers/PosixLike/BPDG: Bourne-Again shell script, ASCII tex= t executable BaseTools/BinWrappers/PosixLike/Brotli: Bourne-Again shell script, ASCII t= ext executable BaseTools/BinWrappers/PosixLike/BrotliCompress: Bourne-Again shell script,= ASCII text executable BaseTools/BinWrappers/PosixLike/DevicePath: Bourne-Again shell script, ASC= II text executable BaseTools/BinWrappers/PosixLike/Ecc: Bourne-Again shell script, ASCII text= executable BaseTools/BinWrappers/PosixLike/EfiRom: Bourne-Again shell script, ASCII t= ext executable BaseTools/BinWrappers/PosixLike/GenCrc32: Bourne-Again shell script, ASCII= text executable BaseTools/BinWrappers/PosixLike/GenDepex: Bourne-Again shell script, ASCII= text executable BaseTools/BinWrappers/PosixLike/GenFds: Bourne-Again shell script, ASCII t= ext executable BaseTools/BinWrappers/PosixLike/GenFfs: Bourne-Again shell script, ASCII t= ext executable BaseTools/BinWrappers/PosixLike/GenFv: Bourne-Again shell script, ASCII te= xt executable BaseTools/BinWrappers/PosixLike/GenFw: Bourne-Again shell script, ASCII te= xt executable BaseTools/BinWrappers/PosixLike/GenPatchPcdTable: Bourne-Again shell scrip= t, ASCII text executable BaseTools/BinWrappers/PosixLike/GenSec: Bourne-Again shell script, ASCII t= ext executable BaseTools/BinWrappers/PosixLike/GenerateCapsule: Bourne-Again shell script= , ASCII text executable BaseTools/BinWrappers/PosixLike/LzmaCompress: Bourne-Again shell script, A= SCII text executable BaseTools/BinWrappers/PosixLike/LzmaF86Compress: Bourne-Again shell script= , ASCII text executable BaseTools/BinWrappers/PosixLike/PatchPcdValue: Bourne-Again shell script, = ASCII text executable BaseTools/BinWrappers/PosixLike/Pkcs7Sign: Bourne-Again shell script, ASCI= I text executable BaseTools/BinWrappers/PosixLike/Rsa2048Sha256GenerateKeys: Bourne-Again sh= ell script, ASCII text executable BaseTools/BinWrappers/PosixLike/Rsa2048Sha256Sign: Bourne-Again shell scri= pt, ASCII text executable BaseTools/BinWrappers/PosixLike/Split: Bourne-Again shell script, ASCII te= xt executable BaseTools/BinWrappers/PosixLike/TargetTool: Bourne-Again shell script, ASC= II text executable BaseTools/BinWrappers/PosixLike/TianoCompress: Bourne-Again shell script, = ASCII text executable BaseTools/BinWrappers/PosixLike/Trim: Bourne-Again shell script, ASCII tex= t executable BaseTools/BinWrappers/PosixLike/UPT: Bourne-Again shell script, ASCII text= executable BaseTools/BinWrappers/PosixLike/VfrCompile: Bourne-Again shell script, ASC= II text executable BaseTools/BinWrappers/PosixLike/VolInfo: Bourne-Again shell script, ASCII = text executable BaseTools/BinWrappers/PosixLike/build: Bourne-Again shell script, ASCII te= xt executable BaseTools/BuildEnv: ASCII text BaseTools/Source/C/VfrCompile/Pccts/KNOWN_PROBLEMS.txt: data BaseTools/Source/C/VfrCompile/Pccts/history.ps: PostScript document text c= onforming DSC level 3.0 BaseTools/Source/Python/Ecc/CParser3/__init__.py: empty BaseTools/Source/Python/Ecc/CParser4/__init__.py: empty BaseTools/Source/Python/Eot/CParser3/__init__.py: empty BaseTools/Source/Python/Eot/CParser4/__init__.py: empty BaseTools/Source/Python/Pkcs7Sign/TestRoot.cer.gEfiSecurityPkgTokenSpaceGu= id.PcdPkcs7CertBuffer.inc: ASCII text, with very long lines, with no line t= erminators BaseTools/Source/Python/Pkcs7Sign/TestRoot.cer.gFmpDevicePkgTokenSpaceGuid= .PcdFmpDevicePkcs7CertBufferXdr.inc: ASCII text, with very long lines, with= no line terminators BaseTools/UserManuals/Build_Utility_Man_Page.rtf: Rich Text Format data, v= ersion 1, unknown character set BaseTools/UserManuals/EfiRom_Utility_Man_Page.rtf: Rich Text Format data, = version 1, unknown character set BaseTools/UserManuals/GenCrc32_Utility_Man_Page.rtf: Rich Text Format data= , version 1, unknown character set BaseTools/UserManuals/GenDepex_Utility_Man_Page.rtf: Rich Text Format data= , version 1, unknown character set BaseTools/UserManuals/GenFds_Utility_Man_Page.rtf: Rich Text Format data, = version 1, unknown character set BaseTools/UserManuals/GenFfs_Utility_Man_Page.rtf: Rich Text Format data, = version 1, unknown character set BaseTools/UserManuals/GenFv_Utility_Man_Page.rtf: Rich Text Format data, v= ersion 1, unknown character set BaseTools/UserManuals/GenFw_Utility_Man_Page.rtf: Rich Text Format data, v= ersion 1, unknown character set BaseTools/UserManuals/GenPatchPcdTable_Utility_Man_Page.rtf: Rich Text For= mat data, version 1, unknown character set BaseTools/UserManuals/GenSec_Utility_Man_Page.rtf: Rich Text Format data, = version 1, unknown character set BaseTools/UserManuals/Intel_UEFI_Packaging_Tool_Man_Page.rtf: Rich Text Fo= rmat data, version 1, unknown character set BaseTools/UserManuals/LzmaCompress_Utility_Man_Page.rtf: Rich Text Format = data, version 1, unknown character set BaseTools/UserManuals/PatchPcdValue_Utility_Man_Page.rtf: Rich Text Format= data, version 1, unknown character set BaseTools/UserManuals/SplitFile_Utility_Man_Page.rtf: Rich Text Format dat= a, version 1, unknown character set BaseTools/UserManuals/TargetTool_Utility_Man_Page.rtf: Rich Text Format da= ta, version 1, unknown character set BaseTools/UserManuals/TianoCompress_Utility_Man_Page.rtf: Rich Text Format= data, version 1, unknown character set BaseTools/UserManuals/Trim_Utility_Man_Page.rtf: Rich Text Format data, ve= rsion 1, unknown character set BaseTools/UserManuals/UtilityManPage_template.rtf: Rich Text Format data, = version 1, unknown character set BaseTools/UserManuals/VfrCompiler_Utility_Man_Page.rtf: Rich Text Format d= ata, version 1, unknown character set BaseTools/UserManuals/VolInfo_Utility_Man_Page.rtf: Rich Text Format data,= version 1, unknown character set CryptoPkg/Library/Include/internal/dso_conf.h: C source, ASCII text CryptoPkg/Library/OpensslLib/process_files.pl: Perl script text executable EmbeddedPkg/Library/FdtLib/TODO: ASCII text EmbeddedPkg/Library/FdtLib/fdt_overlay.c: C source, ASCII text EmulatorPkg/Unix/.gdbinit: ASCII text EmulatorPkg/Unix/GdbRun.sh: ASCII text EmulatorPkg/Unix/Host/X11IncludeHack: ASCII text, with no line terminators EmulatorPkg/Unix/Xcode/xcode_project32/XcodeBuild.sh: Bourne-Again shell s= cript, ASCII text executable EmulatorPkg/Unix/Xcode/xcode_project32/xcode_project.xcodeproj/default.pbx= user: ASCII text EmulatorPkg/Unix/Xcode/xcode_project32/xcode_project.xcodeproj/project.pbx= proj: ASCII text EmulatorPkg/Unix/Xcode/xcode_project64/XcodeBuild.sh: Bourne-Again shell s= cript, ASCII text executable EmulatorPkg/Unix/Xcode/xcode_project64/xcode_project.xcodeproj/default.pbx= user: ASCII text EmulatorPkg/Unix/Xcode/xcode_project64/xcode_project.xcodeproj/project.pbx= proj: ASCII text EmulatorPkg/Unix/lldbinit: ASCII text EmulatorPkg/build.sh: Bourne-Again shell script, ASCII text executable OvmfPkg/QemuVideoDxe/VbeShim.sh: POSIX shell script, ASCII text executable OvmfPkg/build.sh: Bourne-Again shell script, ASCII text executable edksetup.sh: ASCII text -----Original Message----- From: Feng, Bob C Sent: 28 June 2020 08:34 To: devel@edk2.groups.io; Pierre Gondois Cc: Sami Mujawar ; Tomas Pilar = ; Gao, Liming ; nd Subject: RE: [edk2-devel] [PATCH v3 0/4] Compile AML bytecode array into O= BJ file Hi Pierre, I met a problem when I push your patch set. If I change the CRLF to a unix format EOL, the patch can't pass PatchCheck= .py. If I don't change the CRLF, The build on Linux will fail. So I can't make the patch set pass the CI. Could you share me how did you do to make your PR 729 pass? Thanks, Bob -----Original Message----- From: devel@edk2.groups.io On Behalf Of PierreGondo= is Sent: Thursday, June 25, 2020 5:31 PM To: devel@edk2.groups.io; Feng, Bob C Cc: Sami Mujawar ; Tomas Pilar = ; Gao, Liming ; nd Subject: Re: [edk2-devel] [PATCH v3 0/4] Compile AML bytecode array into O= BJ file Hello Bob, I believe the line endings of the BaseTools/BinWrappers/PosixLike/AmlToC s= cript have been modified to CRLF when I sent the patch. I created a pull re= quest from the linked github branch noted in the patches. It is available a= t https://github.com/PierreARM/edk2/commits/803_Compile_AML_bytecode_array_= into_OBJ_file_v3 . The pull request is available here (to show the result o= f the CI tests) https://github.com/tianocore/edk2/pull/729 . Do you want a v4 or is it possible to pull the patches from the github rep= ository? Sorry for the inconvenience. Regards, Pierre -----Original Message----- From: devel@edk2.groups.io On Behalf Of Bob Feng vi= a groups.io Sent: 24 June 2020 16:16 To: devel@edk2.groups.io; Pierre Gondois Cc: Sami Mujawar ; Tomas Pilar = ; Gao, Liming ; nd Subject: Re: [edk2-devel] [PATCH v3 0/4] Compile AML bytecode array into O= BJ file Hi Pierre, There are some build failed in OpenCI. Would you please check it? https://github.com/tianocore/edk2/pull/727 Thanks, Bob -----Original Message----- From: devel@edk2.groups.io On Behalf Of PierreGondo= is Sent: Wednesday, June 24, 2020 5:09 PM To: devel@edk2.groups.io Cc: Pierre Gondois ; sami.mujawar@arm.com; tomas.p= ilar@arm.com; Feng, Bob C ; Gao, Liming ; nd@arm.com Subject: [edk2-devel] [PATCH v3 0/4] Compile AML bytecode array into OBJ f= ile Following the BZ at https://bugzilla.tianocore.org/show_bug.cgi?id=3D2425 This patch serie is a another way to solve the dependency of C files over = ASL files. With this new method, the dependency is resolved at the linking = stage. The last method to solve this dependency was to add the possibility to mod= ify INF files to depict such a dependency. This method was not accepted. Th= e discussion is available at https://edk2.groups.io/g/devel/topic/72655342#= 56658 The last patch modifying the INF specification and INF parsing are availab= le at: https://edk2.groups.io/g/devel/topic/72655342#56658 https://edk2.groups.io/g/devel/topic/72656060#56662 Pierre Gondois (4): BaseTools: Generate multiple rules when multiple output files BaseTools: Rename AmlToHex script to AmlToC BaseTools: Compile AML bytecode arrays into .obj file BaseTools: Fix string concatenation BaseTools/BinWrappers/PosixLike/{AmlToHex =3D> AmlToC} | 28= +++---- BaseTools/BinWrappers/WindowsLike/{AmlToHex.bat =3D> AmlToC.bat} | 0 BaseTools/Conf/build_rule.template | 15 += ++- BaseTools/Source/Python/{AmlToHex/AmlToHex.py =3D> AmlToC/AmlToC.py} | 82= ++++++++------------ BaseTools/Source/Python/AutoGen/BuildEngine.py | 2 += - BaseTools/Source/Python/AutoGen/GenMake.py | 6 += + BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 38 += ++++---- 7 files changed, 89 insertions(+), 82 deletions(-) rename BaseTools/BinW= rappers/PosixLike/{AmlToHex =3D> AmlToC} (97%) rename BaseTools/BinWrapper= s/WindowsLike/{AmlToHex.bat =3D> AmlToC.bat} (100%) rename BaseTools/Sourc= e/Python/{AmlToHex/AmlToHex.py =3D> AmlToC/AmlToC.py} (52%) -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'