From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.72]) by mx.groups.io with SMTP id smtpd.web08.13908.1613863532099452400 for ; Sat, 20 Feb 2021 15:25:33 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=1N2YMvnl; spf=pass (domain: arm.com, ip: 40.107.21.72, mailfrom: samer.el-haj-mahmoud@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bY1UANsJYRzbQmozvcS6bYfgtrdU37w6peX4RC9FjGE=; b=1N2YMvnlVpCrvwrvmqH2vOTDauHt5gKCh1dbpLVOKcMHHtKLX1JQCtuL7VTgDs39PIBSgUJBpagg5x1mcY1nyE5IFJxk+frbAlnY64IuZIGZNe/eeInqQqi3DP4s0EeahKOUM1klvI/d4jz+Cgwf/XqAPPPtLWNH5oX/yPOIrWY= Received: from AS8PR04CA0059.eurprd04.prod.outlook.com (2603:10a6:20b:312::34) by VI1PR0801MB1663.eurprd08.prod.outlook.com (2603:10a6:800:4f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.28; Sat, 20 Feb 2021 23:25:29 +0000 Received: from AM5EUR03FT012.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:312:cafe::fa) by AS8PR04CA0059.outlook.office365.com (2603:10a6:20b:312::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.28 via Frontend Transport; Sat, 20 Feb 2021 23:25:29 +0000 X-MS-Exchange-Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT012.mail.protection.outlook.com (10.152.16.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.27 via Frontend Transport; Sat, 20 Feb 2021 23:25:28 +0000 Received: ("Tessian outbound e7cb4a6f0881:v71"); Sat, 20 Feb 2021 23:25:27 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: f5c5c63dc5ad2e54 X-CR-MTA-TID: 64aa7808 Received: from c2eb385ad474.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1E691CF1-FCB4-4810-9F6E-D91729107969.1; Sat, 20 Feb 2021 23:25:22 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c2eb385ad474.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sat, 20 Feb 2021 23:25:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NTE58ZeKvKAw98l8JvWn/ai/kk/4PWEC8jIRJsTnRTX5V71tHblXedXM9Go6YC+x4SGF7gUkrbCAY4eLRKyESLVCi4UtNOrCCljg9SJpit7Lq6qOFTW8eN8I4PFr1vloNSrYWBVi+5XwYPc3f5znpD+8S6N4+T5EfyfBUj4EeqGbUbiJ1XmLONRAZArwI+/L+ILZWJv38+aGWnoQJnjUAdOSxYaZUmlrNqdPK7laExgWaovgJQIXKGu0rl6RQHbHIqnZvjfnoWt22MsSn752+wVNQmw8/+GctD6a6fT1miQt+CpDXmyQF13hRSb+Q6hD2aFnmW38elAy/GXuLvkJkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bY1UANsJYRzbQmozvcS6bYfgtrdU37w6peX4RC9FjGE=; b=b6h76rITO5vSNnIcVsdgmte1GD9ID9UHsR1WzriI4mu2trXJ57VKj9bz9uiizUYsEoVBtixOQ24Rspcusohf9rzUUGMfdCFOsd3IrIIJJ7FEss8WNkTq8CMDJ/NHbqb8rox8Iay4Ve23MAYCJxAJkkfTcoElhB6dB+j9obOaSm3grfGOGcfv/CS2zao2Cl8PK+wYCEnNVhywJAxw0RgrHSi+EypcLhTis1nU/AjODJqrvekBwU0/8zVy43VidX6HSP0wKVcGl+oMl6dyKuWTqBzIEZeaNtbjVEWr5n/PcvypAjD6FYa9AwA5JD8jCP6vZIeCdtxFX95CjbRBOsgYQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bY1UANsJYRzbQmozvcS6bYfgtrdU37w6peX4RC9FjGE=; b=1N2YMvnlVpCrvwrvmqH2vOTDauHt5gKCh1dbpLVOKcMHHtKLX1JQCtuL7VTgDs39PIBSgUJBpagg5x1mcY1nyE5IFJxk+frbAlnY64IuZIGZNe/eeInqQqi3DP4s0EeahKOUM1klvI/d4jz+Cgwf/XqAPPPtLWNH5oX/yPOIrWY= Received: from DB7PR08MB3260.eurprd08.prod.outlook.com (2603:10a6:5:21::23) by DBAPR08MB5558.eurprd08.prod.outlook.com (2603:10a6:10:1b3::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.29; Sat, 20 Feb 2021 23:25:21 +0000 Received: from DB7PR08MB3260.eurprd08.prod.outlook.com ([fe80::a15d:ad7f:98a0:23f9]) by DB7PR08MB3260.eurprd08.prod.outlook.com ([fe80::a15d:ad7f:98a0:23f9%5]) with mapi id 15.20.3846.043; Sat, 20 Feb 2021 23:25:20 +0000 From: "Samer El-Haj-Mahmoud" To: Leif Lindholm , Ard Biesheuvel CC: "devel@edk2.groups.io" , Ard Biesheuvel , Pete Batard , Samer El-Haj-Mahmoud Subject: Re: [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity Thread-Topic: [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity Thread-Index: AQHXB9HZlgTkPwi5mUOCF1Pz+/DiLaphrF+Q Date: Sat, 20 Feb 2021 23:25:20 +0000 Message-ID: References: <20210220164133.21746-1-Samer.El-Haj-Mahmoud@arm.com> <20210220214614.GL1664@vanye> In-Reply-To: <20210220214614.GL1664@vanye> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [107.207.147.147] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 24540631-f5c6-43dc-d194-08d8d5f6cec3 x-ms-traffictypediagnostic: DBAPR08MB5558:|VI1PR0801MB1663: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 6yK4zY8TYrrtOv4o0s/3Ckdde5lFmKwb4dz6S8Llm4N7WXEPLikdvNV7qTMWayj5liW5TZ7Kayc91ppiE0580kYPKlfCWXiftpciTzN3+uGP0iGfP95tof+TRLcslqyw0vw/TnycJvxKjqnEne9NN9lcJWOkVqlGqQjIvvEo/x9KAPmok6Tf2DzytnLYidGH9bGhayCyI5MQ4X59tLrSumSWSTaaNlVYDG4s0Q+JffXi+tc+wP3zcqE+E6G98mNNsJhcWtGcYJ80S4cVoTk0w2QRXnEp7oInD3hHyFCPTuW0mMoyIOnPiwI5/NDjyaiKgiTsPDwZ4iGgbkFbsbA6TIyKOfqmn098cTQmCGHPC2Tn2ypJ4uNlp52TWdsYiVh5JDEG4LlYqer69idFyaeQqYr47rnlEKQvNe93hCF9loQIF49hSDzm7iBCSO2cZnHu6dpx8jP/9ej13psUtPq6iqGYh6tYeRf7zXLguiLDbiD6EnjyBy6BSG7VwQXEP/Tjm3Y1xO3nrC9vKVVh83Df6iykICw7OxUoN3eh2HQ1kDPnKnrJPxXLUTYCOiFvhHQqCGWVieymcdG2mDiBalw8yQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3260.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(39860400002)(396003)(366004)(346002)(136003)(76116006)(83380400001)(110136005)(66446008)(2906002)(86362001)(4326008)(15650500001)(8936002)(8676002)(9686003)(5660300002)(7696005)(478600001)(55016002)(71200400001)(52536014)(33656002)(6506007)(66476007)(53546011)(186003)(66556008)(66946007)(54906003)(64756008)(316002)(26005)(213903007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?pBUfmJYBQ1BoKsA7K3nJ4jEuW2ZGctoZxs9+zVApQSxeIn4Asrfrow3IdIID?= =?us-ascii?Q?yvY0Rk5NjRkgH2I9pKgeTWB8m0yWBGbjGMTW1SoBleSEcCLuu8gT4OLsWOr6?= =?us-ascii?Q?S0/bb6vYKv6XXV8JKPlqTATnCdIopoQrQc+T+8yAtGuDIm0PvgZJWdwfUg2r?= =?us-ascii?Q?z54Cx6pgJ9hwxDKmzlySOdLSf3F15sSxbjDwj85+7omlfxyu2Ja5zo4OeWu7?= =?us-ascii?Q?Knhn+reNXR+6L7y+Rwwl/dg48odNfp/z8aWnqeJs1RrgmOBFEMES5Jo72+GW?= =?us-ascii?Q?5DYugRx6mLMK4oXMs56mdVShCaxDCSvyGmb/IpNa3tsqXm5w6DDTCtRul2Ap?= =?us-ascii?Q?i5OeIxU4AVOJuzKwoQDwk4NuCwgKf9aMoAsJWtARhSiwo7hxgbs+lf9ngUFs?= =?us-ascii?Q?Iq2IDqOVDjYG6EyfkurdwZa3NldTOsoDIOzPxBWBMi1drXzlp/Q5OpoE4HoJ?= =?us-ascii?Q?HMhnbLUBRYUmzhYbYCqGL7Cn6bigZqFiJhhfq7NGxNSSfFmKNwe3xCUPTvQ3?= =?us-ascii?Q?xlx+zlFpMpsGc09qxIGK3MSyy3gF15umqhtseo9M8tB+23yFI//m2z+vAkFT?= =?us-ascii?Q?gMW6DLMSFpRQDvGOWGIGzXMbCqHvnLRaecNBrSTrdD2GkxUfS3Hb4rFSjRD6?= =?us-ascii?Q?KKXTVcrGOjF6U2aIiEUCP9lYrLhDxiLKKJBKX29WQPySL5zIwBsCA5cPYtZr?= =?us-ascii?Q?YiGcu5zz30xVbAUGHC0ijN3xvJuVCS1LhYPpIvSINDPWv6hgLKDqHUWjiQka?= =?us-ascii?Q?JZt0cJDOC/sltenyGEZCVDuDMAFvAeBgT3fqZPMfDg/JAud58sKxrv0sbjxW?= =?us-ascii?Q?fACIt6fRloL6o8K6I+zwXExFsBc5toWFrhUEWQg2PKsae53K6nUQPL7fefYn?= =?us-ascii?Q?J8Ql4dCVxRJRrHaowCuSGcFa/MeSZc3cs2e80FS8iyi6iavz/uzcWFfmCg+0?= =?us-ascii?Q?he7oCPL8lYMKDJ89FUXUci3Kjs4rMcWcoD3Myyd52cDKOSVWo7a9SfSo0B0S?= =?us-ascii?Q?DsJjTkFHhj0kKLh/Gp9U30J4a0WunMY5tCk7z15I6F8vntgSOhlEysfj7jnE?= =?us-ascii?Q?0yT+CCEY+9Q9Ov5pmvCufuraNPHUbS09KAnYPTnoaBMdhmh9VRSQXOIjw4gw?= =?us-ascii?Q?YQn2mL8ut7jB9bsmfsq/P5ar5Ya0gRMCKfFZAulhdGOw8lVN9YJaIXptdx5N?= =?us-ascii?Q?z55GLUGHkqJPDkQuEtktSHUc4M+nM+CV/4xlkvbu3gzbB1IWMMPjpv4uyXqA?= =?us-ascii?Q?+8eKtscsY3aNNU/k5/nLBPkHT6uhcWY7sHYrvOdIXzLISLjriS/783jlfS/9?= =?us-ascii?Q?MkUKFAtigAHHh+PDKV/VlK4a?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5558 Original-Authentication-Results: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=arm.com; Return-Path: Samer.El-Haj-Mahmoud@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 74ac68cb-c0ba-4569-4af4-08d8d5f6ca7a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S0r0JnEfXwKtwGYC+arJGVJ/ldUK8WXT9d+E16tKUuxNojPwS42+j4YBw79koyp1t+IYjoiXJvUqmrbnF8CV+TTbBTluTzeNCM9Mq8lgmzeEzVzGJDkYTI5e8xi+6uKmgwxZf7+JIj3Adw3oaJWeEIdwCNMbtVmLbYfPxTAylKD+jfxHOf5ciCvKfQ1DwHZJNYgSs/iy7HpKhz8cqcMbc1RTN5o/4JAuD8/CEpbV7DpCeiI1VtyVEt+VueMlwFLKOODlbkZlFjmt1keRcItgdfg1RWG8sDEfo4U3KfW72l+qLNfCknTF+q6uYD/gN7Wu1E91Yfp9Izizsy74xeZQTI1DLCdxmT3nrBPKtGe6dzdoegzrYFZ9U0XWxSGt2MQ5fZr7MBk03WKy0Rw94o9JnBnw/+A4+reLbzXQzp0KWedgAv8WUM0viyyOo+odWnKjuI1yI5bP8Vw00r+8QJAkFNGsd6uur2MTYl4ava5vXBiJE9cepWX0eMLw/i/yqV66JwgSCMKS1Nk3pWXeG279Cd17GdPSrUzELFKUQxGSzG63FeSFWv0qlxcZib9+lbeGJ5iBoKrJWmkPor6aZLvSfgsOvGJE8EbPsobL4hX/eFMmT4OjZun5926Wt6rK4qBD0kDznIEvK97R7g35qNNYinoHNx68ts9o2ePaZfMJzw3soFnWd7fII0YqVddIh5Jx X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39860400002)(346002)(136003)(376002)(396003)(36840700001)(46966006)(81166007)(110136005)(4326008)(47076005)(9686003)(33656002)(63370400001)(52536014)(2906002)(36860700001)(55016002)(82740400003)(86362001)(15650500001)(8676002)(54906003)(70586007)(6506007)(63350400001)(478600001)(8936002)(5660300002)(70206006)(316002)(53546011)(336012)(82310400003)(186003)(356005)(83380400001)(7696005)(26005)(213903007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2021 23:25:28.0006 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 24540631-f5c6-43dc-d194-08d8d5f6cec3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1663 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Leif, I admit, this is not *super* annoying on a normal DEBUG build boot. On the = RPi4 for instance, this shows up between 25-50 times until the OS boots (de= pending on the boot source). On a test run (such as running SCT), this message is *EXTREMLY* annoying. I= see ~6600 instances on one run, accounting for ~60% of the entire debug ou= tput during the test. I agree we should not be optimizing for a test run, b= ut this is just beyond being reasonable.. How useful is this message in non-verbose DEBUG output? Does it need to be = repeated for every call to LibGetTime() ? I am open for suggestions on rate= limiting the output. --Samer > -----Original Message----- > From: Leif Lindholm > Sent: Saturday, February 20, 2021 4:46 PM > To: Ard Biesheuvel > Cc: Samer El-Haj-Mahmoud ; > devel@edk2.groups.io; Ard Biesheuvel ; Pete > Batard > Subject: Re: [edk2-platform][PATCH v1 1/1] > EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity > > *How* annoying was this? > > This is kind of useful information, well at the "would be good to see in = a > regular DEBUG build" level. > > This change will have suddenly effectively hidden a message that was alre= ady > present in many platforms, where they were not (very) annoyingly repetiti= ve > during a normal boot. > > It feels the test suite is not the thing that we need to optimise debug o= utput > for. > > Is there some alternative way we can rate limit this? > > / > Leif > > On Sat, Feb 20, 2021 at 17:50:43 +0100, Ard Biesheuvel wrote: > > On Sat, 20 Feb 2021 at 17:41, Samer El-Haj-Mahmoud > > wrote: > > > > > > the DEBUG message for using compilation time epoch is appearing very > > > frequently on DEBUG firmware builds, for example during UEFI SCT runs= . > > > Reduce verbosity to avoid the annoying repetitive message. > > > > > > Cc: Ard Biesheuvel > > > Cc: Leif Lindholm > > > Cc: Pete Batard > > > Signed-off-by: Samer El-Haj-Mahmoud Mahmoud@arm.com> > > > > > > Reviewed-by: Ard Biesheuvel > > > > Merged as #1434 into master. > > > > > --- > > > > > > EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib. > > > c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git > > > a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLi > > > b.c > > > b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLi > > > b.c index 5c13ed4cf190..4210708cff36 100644 > > > --- > > > a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLi > > > b.c > > > +++ b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClo > > > +++ ckLib.c > > > @@ -88,7 +88,7 @@ LibGetTime ( > > > // > > > EpochSeconds =3D BUILD_EPOCH; > > > DEBUG (( > > > - DEBUG_INFO, > > > + DEBUG_VERBOSE, > > > "LibGetTime: %s non volatile variable was not found - Using > compilation time epoch.\n", > > > mEpochVariableName > > > )); > > > -- > > > 2.25.1 > > > IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.